From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 06:49:27 2025 Received: (at submit) by debbugs.gnu.org; 14 Feb 2025 11:49:27 +0000 Received: from localhost ([127.0.0.1]:47383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tiuCF-0001sF-4H for submit@debbugs.gnu.org; Fri, 14 Feb 2025 06:49:27 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39524) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tiuCC-0001rv-1c for submit@debbugs.gnu.org; Fri, 14 Feb 2025 06:49:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tiuBx-0004Dh-OW for guix-patches@gnu.org; Fri, 14 Feb 2025 06:49:11 -0500 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tiuBr-0005bq-Hj for guix-patches@gnu.org; Fri, 14 Feb 2025 06:49:06 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6A4CF25EB0; Fri, 14 Feb 2025 12:48:58 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id b_txjKFAVWZ4; Fri, 14 Feb 2025 12:48:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1739533737; bh=iWdDRzj2MTFBsTv5WLtdsthLJngS3LFwwK4T2w3cLeo=; h=From:To:Cc:Subject:Date; b=RhoQRmghUMW7bL0D4qm7ryGxA4mCLIoXNi0ofTlvLRIK2JpbdUn5LdrNuXfH09O9G zMbxegbmD/AGRZUMp7YSl6WAbqrbp7ZArRZIyB1nfImxvdTf0b0Vx4kWb04WulRCxn NTqzj1/bINM4n0q4ZR9NkSEC4ssFXBeWHgRR4aqtmHB9hHRWEy02a8HTsWslv8Jcmj qTkGbAISHzYEWf7pvXKqGo5/vJvgsaZF/9DDoiBUhBvljPTEoz+8JYNaBOs0yPL5lh Mgvbi5OJfevUZYzHoA7CkAo9+kvw5r06oSc1lXb4ZJv6yoBElqx7O9EnvG7LLl+8z1 nc5dEr+kTIJnw== From: Murilo To: guix-patches@gnu.org Subject: [PATCH] services: greetd: Use user default login shell. Date: Fri, 14 Feb 2025 08:40:46 -0300 Message-ID: <8ef844a7fca5464f621b6fd9b8bae73385df462d.1739533246.git.murilo@disroot.org> MIME-Version: 1.0 X-Debbugs-Cc: Ludovic Courtès , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=murilo@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Murilo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/services/base.scm ()[command]: Use user's expected login shell. * doc/guix.texi (Base Services): Change default value for 'greetd-user-session-command' to reflect the newer default command. Change-Id: Iae702312000d5bc3cc16d40af205ee2c1e5bc4be --- This patch changes 'greetd-user-session-command' to use the user's actual login shell by default, rather than bash. doc/guix.texi | 5 +++-- gnu/services/base.scm | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index bd66adf326..ab1598e181 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -20630,8 +20630,9 @@ Base Services of Bash. @table @asis -@item @code{command} (default: @code{(file-append bash "/bin/bash")}) -Command to be started by @command{agreety} on successful login. +@item @code{command} (default: @code{#~(passwd:shell (getpwnam (getenv "USER")))}) +Command to be started by @command{agreety} on successful login. Defaults to the +user login shell. @item @code{command-args} (default: @code{'("-l")}) Command arguments to pass to command. diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 4bc0433def..848b1bd276 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -3398,7 +3398,8 @@ (define %qemu-static-networking (define-record-type* greetd-user-session make-greetd-user-session greetd-user-session? - (command greetd-user-session-command (default (file-append bash "/bin/bash"))) + (command greetd-user-session-command + (default #~(passwd:shell (getpwnam (getenv "USER"))))) (command-args greetd-user-session-command-args (default '("-l"))) (extra-env greetd-user-session-extra-env (default '())) (xdg-session-type greetd-user-session-xdg-session-type (default "tty")) base-commit: 3a916935311568b742d734cf76be8a45737f9382 -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 09:11:38 2025 Received: (at 76286) by debbugs.gnu.org; 21 Feb 2025 14:11:38 +0000 Received: from localhost ([127.0.0.1]:57710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlTkf-0004eQ-IL for submit@debbugs.gnu.org; Fri, 21 Feb 2025 09:11:37 -0500 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:47133) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tlTkb-0004d1-Uf for 76286@debbugs.gnu.org; Fri, 21 Feb 2025 09:11:35 -0500 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2fcc99efe9bso3403523a91.2 for <76286@debbugs.gnu.org>; Fri, 21 Feb 2025 06:11:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740147087; x=1740751887; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vg5qEzRL2isaEl2cSaey7QaZzanUweAdOPT0syfRcXY=; b=FfbIOUlVGNqyLbFVw8YJ3/fY50gKiZ9shXEb0AnxCym8Sd1xf6/afqdTdg36aXlUd/ cpYZyzQFTck6XIWGuxHBC47BQ0ye4HPtUH8cprlN3xBbZknvFVYV+rvZUyJNi4GUoCMv h5EXiHWMBlg/24Uc8pXlCh0kmQXLj7YMfTVwecPGiXEJ+JZutKnP8YVfLVeaQhg4eWQ8 tMAn+zROvaBUdJYYOnOBA0EWzs1XatuY4eusryQXdXv9ldre/dCjUVlwkm8aWtTWl0WE Wv77oGZJpK/x6WMpSpeZtGzbfRNr+anqLGWNdZZhg9y6oVymEFpNv5U0QQvxLbihbu2H TD8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740147087; x=1740751887; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Vg5qEzRL2isaEl2cSaey7QaZzanUweAdOPT0syfRcXY=; b=VEyV2mVyTui0HKZ0qJf9YNL7aLeMxIjhwcynqb6JFUB28kkiG249dvl6TSxs4+leLI fNwvxwTqjfcTTpjxoC1L7LHsIj5m9kttIgOwMAtfqk4UTVRq5K+434AZBjmKe8RAzwp/ CmrvaWOlz3QK7w+/EYdQqUGMJua6gRCQ/fb+B9edhO3oykqnvJh478avK6vR8srwQ+nr HwFHZ0ybGBbncHuFNvph3wmZ9BexSDPTS6y8Q15UKLbJh0y4kaUkXXF3Zmm+YU0+PiXj 19v1CXAE2zh4Jp2/3zvHhq31Te0oXMDXtoeXXLzUeUXoFTvX66C/PBx6zelEz50wKVgS 8u7g== X-Gm-Message-State: AOJu0YycMD2De8JXH8uGkp0uFj+UATIcn2ZnJtCBQV2/CLRhhw1SA9oZ ufnDoLhEZR7m5TQ2GF7l64udB4+Is26xiFd1iMrK7Tky2dh5kN/7 X-Gm-Gg: ASbGnctK5PbM9gGD18nW2de2we0IYxKtZtwXKXSy/bBtV/8Ixpj/03fRWLyYRhARNKI VL3rf4cGTJHqDT1vkH1MfjhkFzts4ATdx/835Wus68zDrirxfW6aQDZf2mgXtb5Ev/IMdwzsfDL /v00FVhts6WT+n97iM4UtAvOPRN0g5N5CsPY6A/QJx/Gv4VkQ17hSrJUQL/4Ro5uiu8K+KtKB8V Pw3tALd0MzNzsqYouZ46bvaks0MUcS6SErtyhcHB0FNnbCmXOd+pdyXQXJmJIc6LcYFv5e1ji4k AeDOB57VdpzZjc0ouoChzpxS X-Google-Smtp-Source: AGHT+IGWQkJmZ7fAH3D7MKzBgCMc50dT1Lgh+Ndp8wzvl1VKvS68ayCR4PuIFVKCRISfuWv6uaLOBA== X-Received: by 2002:a17:90a:e7cb:b0:2ee:cd83:8fe7 with SMTP id 98e67ed59e1d1-2fce875d6aemr4946933a91.35.1740147087073; Fri, 21 Feb 2025 06:11:27 -0800 (PST) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fceae302e7sm1422456a91.0.2025.02.21.06.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 06:11:26 -0800 (PST) From: Maxim Cournoyer To: Murilo Subject: Re: [bug#76286] [PATCH] services: greetd: Use user default login shell. In-Reply-To: <8ef844a7fca5464f621b6fd9b8bae73385df462d.1739533246.git.murilo@disroot.org> (murilo@disroot.org's message of "Fri, 14 Feb 2025 08:40:46 -0300") References: <8ef844a7fca5464f621b6fd9b8bae73385df462d.1739533246.git.murilo@disroot.org> Date: Fri, 21 Feb 2025 23:11:12 +0900 Message-ID: <8734g7wfpb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76286 Cc: 76286@debbugs.gnu.org, muradm , Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Murilo writes: > * gnu/services/base.scm ()[command]: Use user's > expected login shell. > * doc/guix.texi (Base Services): Change default value for > 'greetd-user-session-command' to reflect the newer default command. > > Change-Id: Iae702312000d5bc3cc16d40af205ee2c1e5bc4be LGTM. CC'=C3=ACng muradm, just to be sure. They worked on the recent gree= td changes. Reviewed-by: Maxim Cournoyer --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 12:42:27 2025 Received: (at 76286) by debbugs.gnu.org; 21 Feb 2025 17:42:27 +0000 Received: from localhost ([127.0.0.1]:34768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlX2e-00072G-In for submit@debbugs.gnu.org; Fri, 21 Feb 2025 12:42:26 -0500 Received: from nomad-cl1.muradm.net ([139.162.159.157]:58338) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tlX2a-00070m-Kq for 76286@debbugs.gnu.org; Fri, 21 Feb 2025 12:42:22 -0500 Received: from localhost ([127.0.0.1]:49370) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1tlX1k-000000002Qr-0b74; Fri, 21 Feb 2025 17:41:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fU/Zm58gb58slZspTGwLo9vE0nMoq8fWZwvSgi4Q2mo=; b=Rr6pW6qxvsOSXbc5Z4G/yTXvGu WGtTaSEkilKm1nU1M3fyi/VoXPQpyDrx8P6EWzmdxHzG4g1mw37ZnwZQpOWRdTICoO7z+OUnVDSZy elMvFqvdNp7iEjX27toYZOYUcmFetzQiXTARU9gSmmlvbtF0Emwuu8c9zz9F9hOgrhLVBcbbuUu20 5InTrhP/P23HjRCFhtiBCvgAVU/8y386WJcfVGIM8QsAPt0WqC09vkSVk9iKieisMw6Gqzh3q+WHQ l1+SHOQfO+puEhP9WthpNe4ocTQV9/nMTBH1UELWef5Jm2ivPSf4v1EBK2cMf6vbQB0srD25KO3+a xm3ztn2c2FKzQ08iIGR2zU4d3Iw4XhGQzTupicakWVd6V+yD2L/+JS6sruiYbMzseYlDc5czI6UZJ w4rGqST/Q6GobTv2JQr3W+9pw88mUe5eWPiqL0yp8kkb7W4cLWEtMltqokox2me+VOA2NMXVRzf8u D0JRjz5bYR4gbr8Cm51L7H+I; Received: from muradm by localhost with local (Exim 4.98) (envelope-from ) id 1tlX2R-000000001av-1YV3; Fri, 21 Feb 2025 20:42:11 +0300 From: muradm To: Maxim Cournoyer , Murilo Subject: Re: [bug#76286] [PATCH] services: greetd: Use user default login shell. In-Reply-To: <8734g7wfpb.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 21 Feb 2025 23:11:12 +0900") References: <8ef844a7fca5464f621b6fd9b8bae73385df462d.1739533246.git.murilo@disroot.org> <8734g7wfpb.fsf@gmail.com> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Fri, 21 Feb 2025 20:42:11 +0300 Message-ID: <871pvrjito.fsf@muradm.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76286 Cc: 76286@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi! Techincally looks fine, however... Initially, I intentionally didn't go with login shell. The problem=20 is, you can't write 'bash -l` in passwd database. Having shell command configured in passwd, and its arguments in=20 guix configuration may intiated unwanted inconsistency. For instance, user puts some fancy command as shell in passwd, and=20 greetd sticks '-l' flag to it that nukes the hard drive -=20 exaggeration to illustrate the problem :) Personally, I didn't feel comfortable in spreading configuration=20 of one command in two unrelated places. As far as I understand, whoever uses shell configured in passwd=20 should known how to invoke it. However, for instance, in my passwd shell is=20 '/gnu/store/cdwviyfnsfv7k57qrwmym0mrynjixc1i-bash-5.1.16/bin/bash',=20 if I would not use 'greetd' who would run 'bash -l'? With Guix, this situation can be handled purely with passwd=20 (either command if no args needed or command-with-args wrapping=20 script), then for the sake of consistency I would deprecate=20 'command' and 'command-args' and rely on passwd only. Otherwise, I'm afraid that adding complexity in=20 'greetd-user-session-command' program to match known shell=20 commands, and probably warning/failing for unknown ones will be=20 necessary. IMHO. Maxim Cournoyer writes: > Hi! > > Murilo writes: > >> * gnu/services/base.scm ()[command]: Use=20 >> user's >> expected login shell. >> * doc/guix.texi (Base Services): Change default value for >> 'greetd-user-session-command' to reflect the newer default=20 >> command. >> >> Change-Id: Iae702312000d5bc3cc16d40af205ee2c1e5bc4be > > LGTM. CC'=C3=ACng muradm, just to be sure. They worked on the=20 > recent greetd > changes. > > Reviewed-by: Maxim Cournoyer --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEESPY5lma9A9l5HGLP6M7O0mLOBeIFAme4uvMACgkQ6M7O0mLO BeLSuw//Uy7Fgn+SKWJSYGdIEOXBWbVgtKTRevKs9ZLYMvOy53LxXZ6uF6WXWrEu OTNVET5mxPU0eYmfiCunvyZuncF1OeXXMrynLArhyWNpzk2ddmnskRlB2lrzh9CB VptCspK2dq/3t6gUlzJq7tEqMaa3u9ha5AjGGzM0PMul97WukxIs9D/gHDIUeQeS 52O+njVUoP2oiI1J/8w0PG7t/igCGe/S3CCfwCMNZnK0LODFF9NjlRDNxgjxoDCD 4A9gLs3Xgd0btg/G6m0JISFrpFFWsJeM0jhk/ZI56dc8d/J0KB0aTksk2sgDkoaN mAjanEvDOp0OXkXZr+q0/hTs3zkOI1e+nlkwIPJPPM7B8eXLh8lz6IRU1NZQYhuP XYHNL3/fojMlCxcAN/c9M1BeEUCwakJ7+JoxblVT7mAo2r9b56csX9W5ZknggUeX x4+IUy6PDFbtoe9k3cWO5VYHEeBAQuNlestdsoXKknaj9b3gpxa/ILO/OgfvfKIf Dt/KUXiib05fVHVXQLjpZdqjIUOXI7mbgU0hpJC+DULKqHygtLzzAxGlh9EY/6dK wrKJe7OuBQIDIVCYPVdsp4vwYVxWquPuHGAmhe2b/JDjvSZCnbiykALmuicXMWiV k0ShZ7Rg2tvk7xai0DOHdqoPfL6Pzj/vlVA8msSAcK+u69RO6XM= =GbLj -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 08:13:58 2025 Received: (at 76286) by debbugs.gnu.org; 22 Feb 2025 13:13:58 +0000 Received: from localhost ([127.0.0.1]:51096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlpKP-0002gC-J0 for submit@debbugs.gnu.org; Sat, 22 Feb 2025 08:13:58 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:59534) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tlpKM-0002ez-QN for 76286@debbugs.gnu.org; Sat, 22 Feb 2025 08:13:55 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-220bfdfb3f4so68586395ad.2 for <76286@debbugs.gnu.org>; Sat, 22 Feb 2025 05:13:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740230028; x=1740834828; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=cVk4igDCPoyrpdODzZbI+LZAEc9LD568oHDIRh42evM=; b=IF/XohCrbVG4iO5q4h+SWiLnDSh8YinqkBnkqX0MOEsbrf2ciKjzRIIPlud3yBpuhA VmJefW2Zo1wR+Jlb3QGvN765pz9fnL7NADwA+NH/eyn1q1wp31QXhViN6eOGiOwKqfow u6pTwoLB6/dtC2HReeBCmKh2TWIHmQktGfvj+82bWelwlh69SJXKxO1dH0mt4uKzlx4X 4CoHYW9tQNaNP7VbU/7A8d3UEv5XcEy8/iByOozhPNWNH3WemkRLwgDEQAvJybWLbO8q 5B3RalMtxpCknKBb5vZO3q+K/b8xWRu1MtNHjzII2N4a0xL4Le5s2NxPcyj4oiSpA36j EZQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740230028; x=1740834828; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cVk4igDCPoyrpdODzZbI+LZAEc9LD568oHDIRh42evM=; b=hP48UGocbrzApU6qzpZ6z74r3CMps0fZeSGamRmvrL2LYeZS8Rdzr03/oN3QErncMW EhWzl0Gj4x5P6Ncfa4wsL8ifGr+iHUxdk8XftN7Tzavg699Yk680pV1BL8UxSGQ5/1do HN2w7sF9M4I4Ic0sfpWye4AyoHLuAU7HUNy+hOJEQqBhuAQ028nbePRlvnuk71k1hnJi yE+e9qL1eudNED9PvIAeXqHIRLA6c87Okd6p7iWR6RuJC9oeOasc13Au/BujGWRtv04F LN21knOA1lIiBs2TZyPJsGY5w8+zocdbPzDTmii6MQGyA8+g6f0WHCZaWDtY6kaGjgE1 B/TA== X-Forwarded-Encrypted: i=1; AJvYcCUcxlV7fW2eA+nbjUlOxjXhybNSsucW/G52FZqfbWeVMBd3iWMXLPDQOYuAZGhqNWZy/6yVVw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyXNcukuhtt6no35XzHEzMc8Drl57iMSMZIFzv9Ie9dmK3Sy0O/ +PEO7X/XQi45CoB0KCkE4KJB2sOWt2WCJuuSydl5FMt1L38hPwva X-Gm-Gg: ASbGncuZf1hMkgzzK21nCoUf2wMxYkzEiiKe3aEYew9CyEpKsWe5paOZMtgsG7GkDUU /zUiaozQvTurFx+ejlD683lmcx3u/407QYnZjw8X4Jx13rf+KEtHUDB7jjNFTmcWMOAmJRB7YZs yItbVZUM+fha++ll9KV9WHDypmNcpZtlahdhxu384BrN1bezgxblJSZ3dD0K8uLfZKjRswI7iKG 6m/9IUi+TKBe1c1DZZyhpAXeIyZ9WzAT/QIIX3wj5OscNpQjOIofzIxr48WT29l77Fcab+MKjN8 VkNHcQcIYnT/Jad+a6lOE+uq X-Google-Smtp-Source: AGHT+IE1NbR8cQXSW206q/kqfjMqHoOJ1EHd7m6JNR1UKilmz9nxp/PpJ8jpO+1sUi3xdwxGOyVM3A== X-Received: by 2002:a05:6a20:2585:b0:1e1:afa9:d397 with SMTP id adf61e73a8af0-1eef3c9ab9dmr13213449637.15.1740230028348; Sat, 22 Feb 2025 05:13:48 -0800 (PST) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-add3f326b31sm13537094a12.64.2025.02.22.05.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2025 05:13:47 -0800 (PST) From: Maxim Cournoyer To: muradm Subject: Re: bug#76286: [PATCH] services: greetd: Use user default login shell. In-Reply-To: <871pvrjito.fsf@muradm.net> (muradm's message of "Fri, 21 Feb 2025 20:42:11 +0300") References: <8ef844a7fca5464f621b6fd9b8bae73385df462d.1739533246.git.murilo@disroot.org> <8734g7wfpb.fsf@gmail.com> <871pvrjito.fsf@muradm.net> Date: Sat, 22 Feb 2025 22:13:34 +0900 Message-ID: <87o6yut94x.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76286 Cc: Murilo , 76286@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Muradm, muradm writes: > Hi! > > Techincally looks fine, however... > > Initially, I intentionally didn't go with login shell. The problem is, > you can't write 'bash -l` in passwd database. > Having shell command configured in passwd, and its arguments in guix > configuration may intiated unwanted inconsistency. > For instance, user puts some fancy command as shell in passwd, and > greetd sticks '-l' flag to it that nukes the hard drive - exaggeration > to illustrate the problem :) > Personally, I didn't feel comfortable in spreading configuration of > one command in two unrelated places. > > As far as I understand, whoever uses shell configured in passwd should > known how to invoke it. I see, thanks for bringing my attention to the fact that greetd provides '-l' itself. It seems it could be awkard to honor the default user shell and have a default '-l' added to it, which may or may not be supported (I guess most shells do, but...) Murilo, what do you think? Can we close this, preserving the fully declarative status quo? -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 10:32:12 2025 Received: (at 76286-done) by debbugs.gnu.org; 22 Feb 2025 15:32:14 +0000 Received: from localhost ([127.0.0.1]:52810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tlrUA-0007Cc-D0 for submit@debbugs.gnu.org; Sat, 22 Feb 2025 10:32:12 -0500 Received: from layka.disroot.org ([178.21.23.139]:58542) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tlrU2-0007Au-53 for 76286-done@debbugs.gnu.org; Sat, 22 Feb 2025 10:32:04 -0500 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 40BF925215; Sat, 22 Feb 2025 16:32:00 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 85XSqIAszOLv; Sat, 22 Feb 2025 16:31:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1740238315; bh=DCworQ3N2sHzlchCrvYiV7xL1OzBMaXKysoQG94ZhrM=; h=Date:Cc:Subject:From:To:References:In-Reply-To; b=VBw4U7h4LfKnLoD+ilyn6OwCP0UICIzeSDKwJFSvVLBpIhEFo1d/A8ZBSpbnkMV5o 5IdDxghjofCude0WJWaBPDjkhEsNNRZFDXgtrHQk/vm97Yh74fuLUlQusCy2eVzq++ ESzKy8yJiKrpyfI/CbarpjaoWsUHtdsc2VnpKL3Qza3pgaHCnX867WLNzU6EWH/G77 cbm+U3CZ9fEBkEJm1ieKa4myb4jGRajWbILWhp/RmUhk70AbGbZifpmG71u54ErXiD x8ZGJno5+WdAWjFIdYkemYZov7Hjcu7Oo6C2Qkucgm/An/olUm8sG557Rdpkn+n8me D7DxRsQ+t57Iw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 22 Feb 2025 12:31:51 -0300 Message-Id: Subject: Re: bug#76286: [PATCH] services: greetd: Use user default login shell. From: "Murilo" To: "Maxim Cournoyer" , "muradm" References: <8ef844a7fca5464f621b6fd9b8bae73385df462d.1739533246.git.murilo@disroot.org> <8734g7wfpb.fsf@gmail.com> <871pvrjito.fsf@muradm.net> <87o6yut94x.fsf_-_@gmail.com> In-Reply-To: <87o6yut94x.fsf_-_@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76286-done Cc: 76286-done@debbugs.gnu.org, =?utf-8?q?Ludovic_Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim and muradm, > muradm writes: >> For instance, user puts some fancy command as shell in passwd, and >> greetd sticks '-l' flag to it that nukes the hard drive - exaggeration >> to illustrate the problem :) I see, I haven't thought of this issue, thanks for your input, muradm. On Sat Feb 22, 2025 at 10:13 AM -03, Maxim Cournoyer wrote: > Murilo, what do you think? Can we close this, preserving the fully > declarative status quo? Yes, I'm closing this, thanks for reviewing anyways Maxim, really appreciat= e it. From unknown Tue Jun 17 01:26:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Mar 2025 11:24:54 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator