GNU bug report logs - #76274
[PATCH] gnu: Add chatterino

Previous Next

Package: guix-patches;

Reported by: Vitor Hugo <vitorhugonunes <at> proton.me>

Date: Thu, 13 Feb 2025 23:50:03 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 76274 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#76274; Package guix-patches. (Thu, 13 Feb 2025 23:50:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vitor Hugo <vitorhugonunes <at> proton.me>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 13 Feb 2025 23:50:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vitor Hugo <vitorhugonunes <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add chatterino
Date: Thu, 13 Feb 2025 20:59:29 +0000
* gnu/packages/messaging.scm (chatterino): New variable.

Change-Id: I32d2cd4898a1ed234d5b9496a79ff4e30f74430b
---
 gnu/packages/messaging.scm | 50 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index f6ac865512..ce7b4d2fa3 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -221,6 +221,54 @@ (define-public biboumi
 users take part in IRC discussions, using their favourite XMPP client.")
    (license license:zlib)))
 
+(define-public chatterino
+  (package
+    (name "chatterino")
+    (version "2.5.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Chatterino/chatterino2")
+             (commit (string-append "v" version))
+             (recursive? #t)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1v1nd3pzghsx9fm1x2im0wmi01anfzm0pk4mdp6g736h1rskig4y"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:configure-flags #~(list "-DCMAKE_BUILD_TYPE=Release")
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'check)
+                   (add-before 'configure 'setvars
+                     (lambda _
+                       (setenv "GIT_HASH" "f53d92c7")))
+                   (add-after 'install 'wrap-executable
+                     (lambda* _
+                       (let ((plugin-path (getenv "QT_PLUGIN_PATH")))
+                         (wrap-program (string-append #$output
+                                                      "/bin/chatterino")
+                           `("QT_PLUGIN_PATH" ":" prefix
+                             (,plugin-path)))))))))
+    (inputs (list qtbase
+                  qtsvg
+                  qttools
+                  qt5compat
+                  boost
+                  openssl
+                  libsecret
+                  qtwayland
+                  qtimageformats
+                  bash-minimal))
+    (native-inputs (list pkg-config))
+    (synopsis "Chat client for Twitch")
+    (description
+     "Chatterino is a chat client for Twitch chat.
+It aims to be an improved/extended version of the Twitch web chat.")
+    (home-page "https://chatterino.com")
+    (license license:expat)))
+
 (define-public omemo-wget
   (package
     (name "omemo-wget")
@@ -3882,4 +3930,6 @@ (define-public ejabberd
     (home-page "https://www.ejabberd.im")
     (license license:gpl2+)))
 
+
+
 ;;; messaging.scm ends here
-- 
2.46.0




Information forwarded to guix-patches <at> gnu.org:
bug#76274; Package guix-patches. (Sun, 13 Apr 2025 20:32:02 GMT) Full text and rfc822 format available.

Message #8 received at 76274 <at> debbugs.gnu.org (full text, mbox):

From: Vitor Hugo <vitorhugonunes <at> proton.me>
To: "76274 <at> debbugs.gnu.org" <76274 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: Add chatterino
Date: Sun, 13 Apr 2025 20:31:33 +0000
Below follows a reworked version of the package/patch.
I reached out on IRC and had some feedback on it.
I'd very much appreciate a response on if the patch has something wonky.
From my testing both linter and style checks passed with no complaints.


* gnu/packages/messaging.scm (chatterino): New variable.

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 26db072b4a..60cfa22d8c 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -220,6 +220,56 @@ (define-public biboumi
 users take part in IRC discussions, using their favourite XMPP client.")
    (license license:zlib)))
 
+(define-public chatterino
+  (package
+    (name "chatterino")
+    (version "2.5.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Chatterino/chatterino2")
+             (commit (string-append "v" version))
+             (recursive? #t)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1fs13vdxbq2dbxr21wp9mvn33bhvnmg17rqdd6yawsgslab2lssv"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list "-DCMAKE_BUILD_TYPE=Release" "-DCHATTERINO_UPDATER=OFF")
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'check)
+          (add-before 'configure 'setvars
+            (lambda _
+              (setenv "GIT_HASH" "3f3a31db")))
+          (add-after 'install 'wrap-executable
+            (lambda* _
+              (let ((plugin-path (getenv "QT_PLUGIN_PATH")))
+                (wrap-program (string-append #$output "/bin/chatterino")
+                  `("QT_PLUGIN_PATH" ":" prefix
+                    (,plugin-path)))))))))
+    (native-inputs (list pkg-config))
+    (inputs (list qtbase
+                  qtsvg
+                  qttools
+                  qt5compat
+                  boost
+                  bash-minimal
+                  openssl
+                  libsecret
+                  libnotify
+                  qtwayland
+                  qtimageformats))
+    (synopsis "Chat client for Twitch")
+    (description
+     "Chatterino is a chat client for Twitch chat.
+It aims to be an improved/extended version of the Twitch web chat.")
+    (home-page "https://chatterino.com")
+    (license expat)))
+
 (define-public omemo-wget
   (package
     (name "omemo-wget")





Information forwarded to guix-patches <at> gnu.org:
bug#76274; Package guix-patches. (Sun, 13 Apr 2025 20:33:01 GMT) Full text and rfc822 format available.

Message #11 received at 76274 <at> debbugs.gnu.org (full text, mbox):

From: Vitor Hugo <vitorhugonunes <at> proton.me>
To: "76274 <at> debbugs.gnu.org" <76274 <at> debbugs.gnu.org>
Subject: (No Subject)
Date: Sun, 13 Apr 2025 20:32:23 +0000
Forgot to mention that the patch above also
includes a newer version of the package.




Information forwarded to guix-patches <at> gnu.org:
bug#76274; Package guix-patches. (Sun, 13 Apr 2025 21:54:02 GMT) Full text and rfc822 format available.

Message #14 received at 76274 <at> debbugs.gnu.org (full text, mbox):

From: Vitor Hugo <vitorhugonunes <at> proton.me>
To: "76274 <at> debbugs.gnu.org" <76274 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: Add chatterino
Date: Sun, 13 Apr 2025 21:53:25 +0000
One last patch *crosses-fingers*.
I realized I was missing the proper namespace for the license module.
Should all be good now.


* gnu/packages/messaging.scm (chatterino): New variable.

Change-Id: I0c2dd4863c9953159f059d18fb9b554da36e087a
---
 gnu/packages/messaging.scm | 50 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 26db072b4a..bc2ce4d199 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -220,6 +220,56 @@ (define-public biboumi
 users take part in IRC discussions, using their favourite XMPP client.")
    (license license:zlib)))
 
+(define-public chatterino
+  (package
+    (name "chatterino")
+    (version "2.5.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Chatterino/chatterino2")
+             (commit (string-append "v" version))
+             (recursive? #t)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1fs13vdxbq2dbxr21wp9mvn33bhvnmg17rqdd6yawsgslab2lssv"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list "-DCMAKE_BUILD_TYPE=Release" "-DCHATTERINO_UPDATER=OFF")
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'check)
+          (add-before 'configure 'setvars
+            (lambda _
+              (setenv "GIT_HASH" "3f3a31db")))
+          (add-after 'install 'wrap-executable
+            (lambda* _
+              (let ((plugin-path (getenv "QT_PLUGIN_PATH")))
+                (wrap-program (string-append #$output "/bin/chatterino")
+                  `("QT_PLUGIN_PATH" ":" prefix
+                    (,plugin-path)))))))))
+    (native-inputs (list pkg-config))
+    (inputs (list qtbase
+                  qtsvg
+                  qttools
+                  qt5compat
+                  boost
+                  bash-minimal
+                  openssl
+                  libsecret
+                  libnotify
+                  qtwayland
+                  qtimageformats))
+    (synopsis "Chat client for Twitch")
+    (description
+     "Chatterino is a chat client for Twitch chat.
+It aims to be an improved/extended version of the Twitch web chat.")
+    (home-page "https://chatterino.com")
+    (license license:expat)))
+
 (define-public omemo-wget
   (package
     (name "omemo-wget")

base-commit: 7f0ec135d1bf6fd8b7bff84bc176b6c61fdee75d
-- 
2.49.0





Information forwarded to guix-patches <at> gnu.org:
bug#76274; Package guix-patches. (Mon, 05 May 2025 07:50:02 GMT) Full text and rfc822 format available.

Message #17 received at 76274 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 76274 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add chatterino
Date: Mon, 05 May 2025 09:49:27 +0200
Hi Vitor!

Congrats, most of the patch is correct.

There's one rule you didn't try to fix IMHO : unbundling system
libraries when possible.

I've reworked on your patch to try and unbundle the following libraries:
googletest, lua, magic-enum, libcommuni, miniaudio, qtkeychain, rapidjson, sol2.

I'm still in the process of fixing the last lua-related error, and will
submit a new revision after that!

-- 
Best regards,
Nicolas Graves




Information forwarded to guix-patches <at> gnu.org:
bug#76274; Package guix-patches. (Wed, 28 May 2025 21:20:02 GMT) Full text and rfc822 format available.

Message #20 received at 76274 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 76274 <at> debbugs.gnu.org
Subject: Re: [bug#76274] [PATCH] gnu: Add chatterino
Date: Wed, 28 May 2025 19:42:02 +0200
Hi Nicolas,

Nicolas Graves <ngraves <at> ngraves.fr> writes:

> I've reworked on your patch to try and unbundle the following libraries:
> googletest, lua, magic-enum, libcommuni, miniaudio, qtkeychain, rapidjson, sol2.
>
> I'm still in the process of fixing the last lua-related error, and will
> submit a new revision after that!

Did you eventually achieve success and satisfaction? :-)

Thanks,
Ludo’.




This bug report was last modified 21 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.