Subject: Re: [bug#76269] [PATCH] gnu: vtk: Update to 9.4.1

From: Lars Bilke <[email-masked]>
Date: Mon, 24 Feb 2025 09:48:15 +0100

Dear Ludovic,

thanks for your comments. I have uploaded a patch for freecad, this one:

https://github.com/FreeCAD/FreeCAD/commit/fafff3a08b7a6212ce3417e08b18cb2fc8e7e868

I hope this is fine.

Sincerely,
Lars

On 18 Feb 2025, at 18:19, Ludovic Courtès wrote:

> Hi Lars,
>
> Lars Bilke <[email-masked]> skribis:
>
>> * gnu/packages/image-processing.scm (vtk): Update to 9.4.1.
>>
>> Change-Id: Ife39df610c4487683a5c8d72b60eb750530c1358
>
> Apparently this breaks at least freecad:
>
> --8<---------------cut here---------------start------------->8---
> cd /tmp/guix-build-freecad-1.0.0.drv-0/build/src/Mod/CAM && 
> /gnu/store/2lxfijiqqljxdxr2ppqqrn5czkh4r1rq-cmake-minimal-3.24.2/bin/cmake 
> -E copy 
> /tmp/guix-build-freecad-1.0.0.drv-0/source/src/Mod/CAM/Path/Op/Util.py 
> /tmp/guix-build-freecad-1.0.0.drv-0/build/Mod/CAM/Path/Op/Util.py
> /tmp/guix-build-freecad-1.0.0.drv-0/source/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp: 
> In member function ‘void SMDS_UnstructuredGrid::BuildLinks()’:
> /tmp/guix-build-freecad-1.0.0.drv-0/source/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:1030:25: 
> error: no matching function for call to 
> ‘vtkCellLinks::BuildLinks(SMDS_UnstructuredGrid*)’
>  1030 |   GetLinks()->BuildLinks(this);
>       |   ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> In file included from 
> /tmp/guix-build-freecad-1.0.0.drv-0/source/src/3rdParty/salomesmesh/inc/SMDS_UnstructuredGrid.hxx:30,
>                  from 
> /tmp/guix-build-freecad-1.0.0.drv-0/source/src/3rdParty/salomesmesh/src/SMDS/SMDS_UnstructuredGrid.cpp:20:
> /gnu/store/gr8mwbl3zlx9hc4x9k5s9sgcy2kp4sr9-vtk-9.4.1/include/vtk-9.4/vtkCellLinks.h:64:8: 
> note: candidate: ‘virtual void vtkCellLinks::BuildLinks()’
>    64 |   void BuildLinks() override;
>       |        ^~~~~~~~~~
> /gnu/store/gr8mwbl3zlx9hc4x9k5s9sgcy2kp4sr9-vtk-9.4.1/include/vtk-9.4/vtkCellLinks.h:64:8: 
> note:   candidate expects 0 arguments, 1 provided
> --8<---------------cut here---------------end--------------->8---
>
> Could you take a look?  (Perhaps the solution will be to retain the
> previous version of VTK for use in packages like this one.)
>
> More generally, could you test with:
>
>   guix build -P1 [email-masked] -P1 vtk@7
>
> ?
>
> Dependent packages like ‘python-fenics-fiat’ are already broken, 
> so it’s
> “okay” to keep them broken.
>
> Thanks,
> Ludo’.