GNU bug report logs - #76264
[GNU ELPA] Use lisp-data-mode in generated *-pkg.el files

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76264: closed ([GNU ELPA] Use lisp-data-mode in generated
 *-pkg.el files)
Date: Thu, 13 Feb 2025 15:45:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 13 Feb 2025 07:44:11 -0800
with message-id <CADwFkm=HBaddeBk6KgKmZFNV215tZPv5C867T=UKe3HgMctTww <at> mail.gmail.com>
and subject line Re: [GNU ELPA] Use lisp-data-mode in generated *-pkg.el files
has caused the debbugs.gnu.org bug report #76264,
regarding [GNU ELPA] Use lisp-data-mode in generated *-pkg.el files
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76264: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76264
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Philip Kaludercic <philipk <at> posteo.net>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: [GNU ELPA] Use lisp-data-mode in generated *-pkg.el files
Date: Thu, 13 Feb 2025 04:24:21 -0800

Severity: wishlist

The *-pkg.el files are not source files that should be executed, but
Lisp data files.  This has been the source of much confusion.

For example, it is currently completely confused in the lispref manual,
which talks about `define-package' as a function, despite the fact that
it has never been working like that and is now obsolete.  (I'm working
on a patch.)

I think we should install the following to start clearing up some of the
confusion.

Thoughts?

diff --git a/elpa-admin.el b/elpa-admin.el
index c127f50dcc..2ccfe35f81 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1516,7 +1516,7 @@ Rename DIR/ to PKG-VERS/, and return the descriptor."
 	(print-length nil))
     (elpaa--temp-file pkg-file)
     (write-region
-     (concat (format ";; Generated package description from %s.el
-*- no-byte-compile: t -*-\n"
+     (concat (format ";; Generated package description from %s.el
-*- mode: lisp-data; no-byte-compile: t -*-\n"
 		     name)
 	     (prin1-to-string
               (pcase-let ((`(,version ,desc ,requires ,extras)

[Message part 3 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 76264-done <at> debbugs.gnu.org
Subject: Re: [GNU ELPA] Use lisp-data-mode in generated *-pkg.el files
Date: Thu, 13 Feb 2025 07:44:11 -0800

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> I think we should install the following to start clearing up some of the
>> confusion.
>
> LGTM,

Thanks, pushed, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.