GNU bug report logs - #76259
[PATCH 0/3] Add python-triangle, python-pandamesh and update gmsh to 4.13.1.

Previous Next

Full log

Message #17 received at 76259 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76259 <at> debbugs.gnu.org
Subject: [PATCH 0/3] Add python-triangle, python-pandamesh and update gmsh
 to 4.13.1.
Date: Thu, 13 Feb 2025 10:19:10 +0000

[Message part 1 (text/plain, inline)]

Hi Lars,

Thank you for the patches.

I've got some simplification review comments.

--8<---------------cut here---------------start------------->8---
+    (native-inputs (list python-setuptools python-wheel python-pytest))
--8<---------------cut here---------------end--------------->8---
Please sort alphabetically.

--8<---------------cut here---------------start------------->8---
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (replace 'check
+                     (lambda* (#:key tests? #:allow-other-keys)
+                       (when tests?
+                         (invoke "pytest" "-v")))))))
--8<---------------cut here---------------end--------------->8---
This may be removed as pyproject-build-system tries to detect available
test runner e.g. pytest in your case and does all setup within build
system flow.

--8<---------------cut here---------------start------------->8---
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (replace 'check
+                     (lambda* (#:key tests? #:allow-other-keys)
+                       (when tests?
+                         ;; tests requiring network disabled
+                         (invoke "pytest" "-v" "--ignore=tests/test_data.py")))))))
--8<---------------cut here---------------end--------------->8---
Likewise, you may utiize #:test-flags instead of adding custom phase.

--8<---------------cut here---------------start------------->8---
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/drufat/triangle")
+             (commit (string-append "v" version))
+             (recursive? #t)))
--8<---------------cut here---------------end--------------->8---
I guess the project contains git submodules, may you double check if may
replace them with our own?

gmsh is save to be refreshed on master:

--8<---------------cut here---------------start------------->8---
guix refresh --list-dependent gmsh
Building the following 3 packages
would ensure 4 dependent packages are rebuilt: python-pygmsh <at> 7.1.17
openfoam-com <at> 2212 openfoam-org <at> 10.20230119
--8<---------------cut here---------------end--------------->8---

Waiting for v2!

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.