GNU bug report logs - #76251
[PATCH] .dir-locals.el: Have Magit recognize Change-Id git trailers.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76251 in the body.
You can then email your comments to 76251 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH] .dir-locals.el: Have Magit recognize Change-Id git trailers.
Date: Thu, 13 Feb 2025 16:08:35 +0900

* .dir-locals.el: Register the 'Change-Id' git trailer to the
GIT-COMMIT-TRAILERS Magit variable.

Change-Id: I45deafae39163c63d559e0d50e39ee0691533955
---
 .dir-locals.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.dir-locals.el b/.dir-locals.el
index 211f5d9afb..d629b51c8a 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -18,6 +18,9 @@
      (eval . (setq-local guix-directory
                          (locate-dominating-file default-directory
                                                  ".dir-locals.el")))
+     ;; Magit
+     (eval . (with-eval-after-load 'git-commit
+               (add-to-list 'git-commit-trailers "Change-Id")))
 
      ;; TempEl
      (eval . (with-eval-after-load

base-commit: d994b9b6461318384fdc5820ea9c94dec128f7e9
-- 
2.48.1

Message #8 received at 76251 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76251 <at> debbugs.gnu.org
Subject: Re: [bug#76251] [PATCH] .dir-locals.el: Have Magit recognize
 Change-Id git trailers.
Date: Fri, 21 Feb 2025 15:17:13 +0100

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> * .dir-locals.el: Register the 'Change-Id' git trailer to the
> GIT-COMMIT-TRAILERS Magit variable.
>
> Change-Id: I45deafae39163c63d559e0d50e39ee0691533955

LGTM!

Message #13 received at 76251-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 76251-done <at> debbugs.gnu.org
Subject: Re: [bug#76251] [PATCH] .dir-locals.el: Have Magit recognize
 Change-Id git trailers.
Date: Sun, 23 Feb 2025 00:43:50 +0900

Hi,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> * .dir-locals.el: Register the 'Change-Id' git trailer to the
>> GIT-COMMIT-TRAILERS Magit variable.
>>
>> Change-Id: I45deafae39163c63d559e0d50e39ee0691533955
>
> LGTM!

Thanks, pushed!

-- 
Thanks,
Maxim

Message #16 received at 76251 <at> debbugs.gnu.org (full text, mbox):

From: Erwan Jahier <erwan.jahier <at> univ-grenoble-alpes.fr>
To: 76251 <at> debbugs.gnu.org
Subject: magit is broken
Date: Fri, 28 Feb 2025 11:23:35 +0100

Hello,

This change broke magit for me:

  Symbol’s value as variable is void: git-commit-trailers

Regards
-- 
R1.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.