Subject: bug#76249: closed (Re: bug#76249: [PATCH] Avoid cl-caaar etc. compatibility aliases in Tramp)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 13 Feb 2025 08:53:02 +0000

Your bug report

#76249: [PATCH] Avoid cl-caaar etc. compatibility aliases in Tramp

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
76249: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76249
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#76249: [PATCH] Avoid cl-caaar etc. compatibility aliases in Tramp
From: Stefan Kangas <[email-masked]>
To: Michael Albinus <[email-masked]>
Cc: [email-masked]
Date: Thu, 13 Feb 2025 00:52:18 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 31.1

Michael Albinus <[email-masked]> writes:

> Stefan Kangas <[email-masked]> writes:
>
>> Hi Michael,
>
> Hi Stefan,
>
>> IIUC, Tramp now requires Emacs 28.1 to run (based on the check in
>> trampver.el).
>
> Yes.
>
>> If that is correct, could we stop relying on the compatibility aliases
>> cl-cXXXXr now?  These functions are built-in since Emacs 26.1.  Please
>> see the attached.
>
> Of course, feel free to apply the patch.

Thanks, done in commit d06606ff42b.

BTW, not that I know anything about the specifics of how Tramp is
distributed, but should tramp.el have a "Package-Requires" header,
perhaps?

Subject: [PATCH] Avoid cl-caaar etc. compatibility aliases in Tramp
From: Stefan Kangas <[email-masked]>
To: [email-masked]
Date: Wed, 12 Feb 2025 22:52:48 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Severity: wishlist

Hi Michael,

IIUC, Tramp now requires Emacs 28.1 to run (based on the check in
trampver.el).  If that is correct, could we stop relying on the
compatibility aliases cl-cXXXXr now?  These functions are built-in
since Emacs 26.1.  Please see the attached.
From 97ae005b83eef6f9ac6aa69747516668f3820194 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <[email-masked]>
Date: Thu, 13 Feb 2025 07:48:07 +0100
Subject: [PATCH] Avoid cl-caaar etc. compatibility aliases in Tramp

* lisp/net/tramp-gvfs.el (tramp-gvfs-handler-askquestion):
(tramp-gvfs-handler-mounted-unmounted):
(tramp-gvfs-connection-mounted-p):
* lisp/net/tramp-sh.el (tramp-sh-gio-monitor-process-filter):
(tramp-sh-inotifywait-process-filter): Don't use cl-caaar
etc. compatibility aliases.
---
 lisp/net/tramp-gvfs.el | 10 +++++-----
 lisp/net/tramp-sh.el   |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/lisp/net/tramp-gvfs.el b/lisp/net/tramp-gvfs.el
index 53a6ffc48aa..2f0593b0a93 100644
--- a/lisp/net/tramp-gvfs.el
+++ b/lisp/net/tramp-gvfs.el
@@ -1891,7 +1891,7 @@ tramp-gvfs-handler-askquestion
 
 	;; When the choice is "no", we set a dummy fuse-mountpoint in
 	;; order to leave the timeout.
-	(unless (zerop (cl-caddr result))
+	(unless (zerop (caddr result))
 	  (tramp-set-file-property v "/" "fuse-mountpoint" "/"))
 
 	result))))
@@ -1908,10 +1908,10 @@ tramp-gvfs-handler-mounted-unmounted
       ;; elements.
       (while (stringp (car elt)) (setq elt (cdr elt)))
       (let* ((fuse-mountpoint (tramp-gvfs-dbus-byte-array-to-string (cadr elt)))
-	     (mount-spec (cl-caddr elt))
+	     (mount-spec (caddr elt))
 	     (prefix (tramp-gvfs-dbus-byte-array-to-string (car mount-spec)))
 	     (default-location (tramp-gvfs-dbus-byte-array-to-string
-				(cl-cadddr elt)))
+				(cadddr elt)))
 	     (method (tramp-gvfs-dbus-byte-array-to-string
 		      (cadr (assoc "type" (cadr mount-spec)))))
 	     (user (tramp-gvfs-dbus-byte-array-to-string
@@ -2004,10 +2004,10 @@ tramp-gvfs-connection-mounted-p
        (while (stringp (car elt)) (setq elt (cdr elt)))
        (let* ((fuse-mountpoint (tramp-gvfs-dbus-byte-array-to-string
 				(cadr elt)))
-	      (mount-spec (cl-caddr elt))
+	      (mount-spec (caddr elt))
 	      (prefix (tramp-gvfs-dbus-byte-array-to-string (car mount-spec)))
 	      (default-location (tramp-gvfs-dbus-byte-array-to-string
-				 (cl-cadddr elt)))
+				 (cadddr elt)))
 	      (method (tramp-gvfs-dbus-byte-array-to-string
 		       (cadr (assoc "type" (cadr mount-spec)))))
 	      (user (tramp-gvfs-dbus-byte-array-to-string
diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el
index e268489b7c8..a21af990e0e 100644
--- a/lisp/net/tramp-sh.el
+++ b/lisp/net/tramp-sh.el
@@ -3900,7 +3900,7 @@ tramp-sh-gio-monitor-process-filter
 	  (setq string (replace-match "" nil nil string))
           ;; Add an Emacs event now.
 	  ;; `insert-special-event' exists since Emacs 31.
-	  (when (member (cl-caadr object) events)
+	  (when (member (caadr object) events)
 	    (tramp-compat-funcall
                 (if (fboundp 'insert-special-event)
                     'insert-special-event
@@ -3937,7 +3937,7 @@ tramp-sh-inotifywait-process-filter
 		   (process-get proc 'tramp-watch-name))))))
         ;; Add an Emacs event now.
 	;; `insert-special-event' exists since Emacs 31.
-	(when (member (cl-caadr object) events)
+	(when (member (caadr object) events)
 	  (tramp-compat-funcall
               (if (fboundp 'insert-special-event)
                   'insert-special-event
-- 
2.48.1