GNU bug report logs - #76235
[PATCH] Improve prompt for 'project-switch-project'

Previous Next

Full log

Message #17 received at 76235 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 76235 <at> debbugs.gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#76235: [PATCH] Improve prompt for 'project-switch-project'
Date: Wed, 12 Feb 2025 15:34:08 -0500

[Message part 1 (text/plain, inline)]

That looks nice. Revised patch attached.

On Wed, Feb 12, 2025 at 3:28 PM Dmitry Gutov <dmitry <at> gutov.dev> wrote:

> On 12/02/2025 22:13, Ship Mints wrote:
> > Sounds good. I'll update the patch now maybe with "Command in" or
> > "Command for" after I see how it looks on the screen.
>
> Thanks.
>
> > Dealing with text stability in the little one-line minibuffer prompt is
> > indeed a challenge. Perhaps we can propertize the prefix to be bold or
> > the menu option list to be bolded so that at least it stands out?
>
> Hm, I think bold might, conversely, call too much attention. It also
> depends on the individual system and font configuration.
>
> Perhaps orthogonally, we could use the string face for the directory
> name. It helps a little, it seems?
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index ff707437e95..a429c1d2c42 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -2211,7 +2211,7 @@ project--menu-prompt
>      project-switch-commands
>      "  "))
>
> -(defun project--switch-project-command ()
> +(defun project--switch-project-command (&optional dir)
>     (let* ((commands-menu
>             (mapcar
>              (lambda (row)
> @@ -2241,7 +2241,14 @@ project--switch-project-command
>                                          (propertize "Unrecognized input"
>                                                      'face 'warning)
>                                          (help-key-description choice
> nil)))))
> -        (setq choice (read-key-sequence (concat "Choose: " prompt)))
> +        (setq choice (read-key-sequence (concat
> +                                         (if dir
> +                                             (format-message "Command
> in `%s': "
> +                                                             (propertize
> +                                                              dir 'face
> +
> 'font-lock-string-face))
> +                                           "Command: ")
> +                                         prompt)))
>           (when (setq command (lookup-key commands-map choice))
>             (when (numberp command) (setq command nil))
>             (unless (or project-switch-use-entire-map
> @@ -2266,7 +2273,7 @@ project-switch-project
>     (project--remember-dir dir)
>     (let ((command (if (symbolp project-switch-commands)
>                        project-switch-commands
> -                   (project--switch-project-command)))
> +                   (project--switch-project-command dir)))
>           (buffer (current-buffer)))
>       (unwind-protect
>           (progn
>
>

[Message part 2 (text/html, inline)]

[0001-Improve-prompt-for-project-switch-project.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.