Subject: Re: [bug#76225] [PATCH v2] gnu: Add emacs-age.

From: Nicolas Goaziou <[email-masked]>
Date: Wed, 12 Feb 2025 20:43:40 +0100

Hello,

Nicolas Graves via Guix-patches via <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-age): New variable.

Thanks.

> +(define-public emacs-age
> +  (let ((commit "890c467ebc27538507c54a03afd2f7260630d7f5")
> +        (revision "0"))
> +    (package
> +      (name "emacs-age")
> +      ;; 0.1.4 in the code but 0.1.5 on github
> +      (version (git-version "0.1.5" revision commit))

Please use the "v0.1.5" tag instead of a raw commit.

> +      (description
> +       "This package provides transparent Age file encryption and decryption
> +in Emacs.  It is based on the Emacs @code{EasyPG} code and offers similar

Nitpick: I think EasyPG is better than @code{EasyPG}. See below.

> +Emacs file handling for Age encrypted files: maintain @code{.org.age}
> +encrypted Org files, provide Age encrypted authentication information out of
> +@code{.authinfo.age},

@code -> @file (x2)

> + open/edit/save Age encrypted files via @code{tramp}...")

Nitpick: I prefer Tramp over @code{tramp} as you’re referring to
a project, not to some piece of code. It is also coherent with Age and
Emacs in the same description.

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou