From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 09:42:36 2010 Received: (at submit) by debbugs.gnu.org; 12 Dec 2010 14:42:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PRn8F-0001aN-GB for submit@debbugs.gnu.org; Sun, 12 Dec 2010 09:42:35 -0500 Received: from emh05.mail.saunalahti.fi ([62.142.5.111]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PRn8C-0001a6-9o for submit@debbugs.gnu.org; Sun, 12 Dec 2010 09:42:34 -0500 Received: from saunalahti-vams (vs3-10.mail.saunalahti.fi [62.142.5.94]) by emh05-2.mail.saunalahti.fi (Postfix) with SMTP id 706A68BE63 for ; Sun, 12 Dec 2010 16:48:39 +0200 (EET) Received: from emh04.mail.saunalahti.fi ([62.142.5.110]) by vs3-10.mail.saunalahti.fi ([62.142.5.94]) with SMTP (gateway) id A06F496A45D; Sun, 12 Dec 2010 16:48:39 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh04.mail.saunalahti.fi (Postfix) with ESMTP id 4F6A541BE7 for ; Sun, 12 Dec 2010 16:48:37 +0200 (EET) From: Jari Aalto To: submit@debbugs.gnu.org Subject: [PATCH] lib-src/emacsclient.c: Change -H to -h. Order options alphabetically Mail-Copies-To: poster Date: Sun, 12 Dec 2010 16:48:37 +0200 Message-ID: <87r5dn59oa.fsf@picasso.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Antivirus: VAMS X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) --=-=-= Content-Type: text/plain Package: emacs Version: 23.2+1-5.1 Severity: wishlist Tags: patch The patch changes help option to lowercase -h like found e.g. in GNU cp(1). The option help is also presented alphabetically. The patch is against Git: 74bd01f 2010-12-12 Merge branch 'master' of git://git.sv.gnu.org/emacs [ lib-src/ChangeLog ] 2010-12-12 Jari Aalto * emacsclient.c (decode_options): Change help option from -H to -h. (print_help_and_exit): Order options alphabetically. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-emacsclient.c-decode_options-Change-help-option-from.patch >From f9c51ef32df48c3a01cb32e9b67aa5694794ccef Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Sun, 12 Dec 2010 16:41:47 +0200 Subject: [PATCH] * emacsclient.c (decode_options): Change help option from -H to -h. (print_help_and_exit): Order options alphabetically. Organization: Private Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Signed-off-by: Jari Aalto --- lib-src/emacsclient.c | 36 +++++++++++++++++++----------------- 1 files changed, 19 insertions(+), 17 deletions(-) diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c index 48ea3d2..9759898 100644 --- a/lib-src/emacsclient.c +++ b/lib-src/emacsclient.c @@ -516,9 +516,9 @@ decode_options (int argc, char **argv) { int opt = getopt_long_only (argc, argv, #ifndef NO_SOCKETS_IN_FILE_SYSTEM - "VHnea:s:f:d:tc", + "Vhnea:s:f:d:tc", #else - "VHnea:f:d:tc", + "Vhnea:f:d:tc", #endif longopts, 0); @@ -581,7 +581,7 @@ decode_options (int argc, char **argv) current_frame = 0; break; - case 'H': + case 'h': print_help_and_exit (); break; @@ -646,29 +646,31 @@ Tell the Emacs server to visit the specified files.\n\ Every FILE can be either just a FILENAME or [+LINE[:COLUMN]] FILENAME.\n\ \n\ The following OPTIONS are accepted:\n\ --V, --version Just print version info and return\n\ --H, --help Print this usage information message\n\ --nw, -t, --tty Open a new Emacs frame on the current terminal\n\ +-a EDITOR, --alternate-editor=EDITOR\n\ + Editor to fallback to if the server is not running\n" +#ifndef WINDOWSNT +" If EDITOR is the empty string, start Emacs in daemon\n\ + mode and try connecting again\n" +#endif /* not WINDOWSNT */ +"\ -c, --create-frame Create a new frame instead of trying to\n\ use the current Emacs frame\n\ --e, --eval Evaluate the FILE arguments as ELisp expressions\n\ --n, --no-wait Don't wait for the server to return\n\ -d DISPLAY, --display=DISPLAY\n\ Visit the file in the given display\n\ +-e, --eval Evaluate the FILE arguments as ELisp expressions\n\ +-f SERVER, --server-file=SERVER\n\ + Set filename of the TCP authentication file\n\ +-n, --no-wait Don't wait for the server to return\n\ +-nw, -t, --tty Open a new Emacs frame on the current terminal\n\ --parent-id=ID Open in parent window ID, via XEmbed\n" #ifndef NO_SOCKETS_IN_FILE_SYSTEM "-s SOCKET, --socket-name=SOCKET\n\ Set filename of the UNIX socket for communication\n" #endif -"-f SERVER, --server-file=SERVER\n\ - Set filename of the TCP authentication file\n\ --a EDITOR, --alternate-editor=EDITOR\n\ - Editor to fallback to if the server is not running\n" -#ifndef WINDOWSNT -" If EDITOR is the empty string, start Emacs in daemon\n\ - mode and try connecting again\n" -#endif /* not WINDOWSNT */ -"\n\ +"\ +-h, --help Print this usage information message\n\ +-V, --version Just print version info and return\n\ +\n\ Report bugs with M-x report-emacs-bug.\n", progname); exit (EXIT_SUCCESS); } -- 1.7.2.3 --=-=-= Content-Type: text/plain -- System Information Debian Release: squeeze/sid APT Prefers testing APT policy: (990, testing) (500, unstable) (1, experimental) Architecture: amd64 Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux Locale: LANG=en_DK.UTF-8 -- Versions of packages `emacs depends on'. Depends: emacs23 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-lucid 23.2+1-5.1 GNU Emacs is the extensible self-documenting emacs23-nox 23.2+1-5.1 GNU Emacs is the extensible self-documenting --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 10 19:49:19 2012 Received: (at 7622-close) by debbugs.gnu.org; 10 Apr 2012 23:49:19 +0000 Received: from localhost ([127.0.0.1]:49572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHkoJ-0006ed-3G for submit@debbugs.gnu.org; Tue, 10 Apr 2012 19:49:19 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:35838) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHkoH-0006eX-7P for 7622-close@debbugs.gnu.org; Tue, 10 Apr 2012 19:49:18 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SHkn8-0002gu-H8; Wed, 11 Apr 2012 01:48:06 +0200 From: Lars Magne Ingebrigtsen To: Jari Aalto Subject: Re: bug#7622: [PATCH] lib-src/emacsclient.c: Change -H to -h. Order options alphabetically References: <87r5dn59oa.fsf@picasso.cante.net> X-Now-Playing: Lichens's _Time & Light (version)_: "(untitled)" Date: Wed, 11 Apr 2012 01:48:05 +0200 In-Reply-To: <87r5dn59oa.fsf@picasso.cante.net> (Jari Aalto's message of "Sun, 12 Dec 2010 16:48:37 +0200") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SHkn8-0002gu-H8 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334706487.01603@ADeDU3RTYF8KlJQOYrs89Q X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7622-close Cc: 7622-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Jari Aalto writes: > The patch changes help option to lowercase -h like found e.g. in GNU > cp(1). The option help is also presented alphabetically. [larsi@stories ~/src/emacs/trunk]$ cp -h cp: invalid option -- 'h' So I don't think this change would be correct. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 11 01:23:12 2012 Received: (at 7622) by debbugs.gnu.org; 11 Apr 2012 05:23:12 +0000 Received: from localhost ([127.0.0.1]:50054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHq1P-00079V-GS for submit@debbugs.gnu.org; Wed, 11 Apr 2012 01:23:12 -0400 Received: from emh01.mail.saunalahti.fi ([62.142.5.107]:46855) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHq1J-00079H-Ao for 7622@debbugs.gnu.org; Wed, 11 Apr 2012 01:23:10 -0400 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh01-2.mail.saunalahti.fi (Postfix) with SMTP id 9A1A68C97F; Wed, 11 Apr 2012 08:21:58 +0300 (EEST) Received: from emh06.mail.saunalahti.fi ([62.142.5.116]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A01B0C6753D; Wed, 11 Apr 2012 08:21:58 +0300 Received: from bongo.cante.net (a91-155-176-245.elisa-laajakaista.fi [91.155.176.245]) by emh06.mail.saunalahti.fi (Postfix) with ESMTP id 3EC78E51A2; Wed, 11 Apr 2012 08:21:55 +0300 (EEST) Received: from test20.cante.net ([192.168.1.20]) by bongo.cante.net with esmtp (Exim 4.77) (envelope-from ) id 1SHpwR-0003K1-J3; Wed, 11 Apr 2012 08:18:03 +0300 Received: from jaalto by test20.cante.net with local (Exim 4.77) (envelope-from ) id 1SHq09-0005tS-5A; Wed, 11 Apr 2012 08:21:53 +0300 Date: Wed, 11 Apr 2012 08:21:52 +0300 From: jaalto To: Lars Magne Ingebrigtsen Subject: Re: bug#7622: [PATCH] lib-src/emacsclient.c: Change -H to -h. Order options alphabetically Message-ID: <20120411052152.GO13747@taiko.cante.net> References: <87r5dn59oa.fsf@picasso.cante.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Gpg-Key-Id: 0xD189E680 X-Gpg-Key-Info: http://key-server.de:11371/pks/lookup?search=0xD189E680&op=vindex X-Gpg-Key-Get: ttp://key-server.de:11371/pks/lookup?search=0xD189E680&op=get User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: jaalto@taiko.cante.net X-SA-Exim-Scanned: No (on test20.cante.net); SAEximRunCond expanded to false X-Antivirus: VAMS X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 7622 Cc: 7622@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 2012-04-11 01:48, Lars Magne Ingebrigtsen wrote: | Jari Aalto writes: | | > The patch changes help option to lowercase -h like found e.g. in GNU | > cp(1). The option help is also presented alphabetically. | | [larsi@stories ~/src/emacs/trunk]$ cp -h | cp: invalid option -- 'h' | | So I don't think this change would be correct. I remembered wrong. GNU uses --long options for cp(1) and mv(1); I assume because it wanted to reserve all short options. But almot universally lowercase -h, is understood as a synonym for --help. At least for emacsclient that would work well as there are no conflicting options[*]. The patch would also make the listing a little easier; alphabetical as in GNU programs in general. Jari [*] -H and -h could have been taken to mean something else for historical reasons in other programs. From unknown Sat Sep 20 05:02:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 May 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator