Subject: [bug#76207] [PATCH] gnu: Add uhdm.

From: Sharlatan Hellseher <[email-masked]>
Date: Wed, 19 Feb 2025 09:44:05 +0000

Hi,

Thank you for the patch.

Please check my review points:
--8<---------------cut here---------------start------------->8---
+    (inputs (list python-orderedmultidict
+                  python
+                  cmake-minimal
+                  openssl
+                  zlib
+                  googletest
+                  capnproto))
--8<---------------cut here---------------end--------------->8---
I contains build and runtime dependencies, let's split them out e.g.

- native-inputs:
  + cmake-minimal
  + googletest
  + python-wrapper
- inputs:
  + capnproto
  + openssl
  + python-orderedmultidict
  + zlib

--8<---------------cut here---------------start------------->8---
+       (uri (git-reference
+             (url "https://github.com/chipsalliance/UHDM/")
+             (commit (string-append "v" version))
+             (recursive? #f)))
--8<---------------cut here---------------end--------------->8---
Does it pull any extra dependencies? May you check if they may be
replaced by available in Guix, if not provide some notes why it's not
possible for now.

Ok I see <https://github.com/chipsalliance/UHDM/tree/master/third_party>
--8<---------------cut here---------------start------------->8---
capnproto @ 8c7e0fd
decompile vpiHandle
2 years ago
googletest @ 58d77fa
Switch to current googletest release.
3 years ago
Verilog_Object_Model.pdf
--8<---------------cut here---------------end--------------->8---
Let's remove them as you already provided in inputs.

--8<---------------cut here---------------start------------->8---
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure))
--8<---------------cut here---------------end--------------->8---
Please, provide some notes for the future package maintainer describing
why you did this.

License looks correct:
--8<---------------cut here---------------start------------->8---
licensecheck -r UHDM | awk -F: '{print $2}' | sort | uniq -c | sort -rn
    305  Apache License (v2.0)
     63  *No copyright* UNKNOWN
     19  Apache License (v2.0) GENERATED FILE
      4  *No copyright* GENERATED FILE
      2  UNKNOWN
      1  *No copyright* Apache License (v2.0)
--8<---------------cut here---------------end--------------->8---

Looking forward for v2!

---
Oleg