GNU bug report logs - #76207
[PATCH] gnu: Add uhdm.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76207 in the body.
You can then email your comments to 76207 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: Add uhdm.
Date: Tue, 11 Feb 2025 17:25:49 +0100

* gnu/packages/electronics.scm (uhdm): New variable.

Change-Id: I581fa4de57c377f6b2c99aa439fdfb98e2e472a9
---
 gnu/packages/electronics.scm | 43 ++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index df0238c348..868bfb0571 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
@@ -52,10 +53,13 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages sdl)
+  #:use-module (gnu packages serialization)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages stb)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits))
 
 (define-public libserialport
@@ -522,3 +526,42 @@ (define-public minipro
 Additionally your user must be member of the @code{plugdev} group.")
       (home-page "https://gitlab.com/DavidGriffith/minipro")
       (license license:gpl3+))))
+
+(define-public uhdm
+  (package
+    (name "uhdm")
+    (version "1.84")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/chipsalliance/UHDM/")
+             (commit (string-append "v" version))
+             (recursive? #f)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1364kv8fg4nh76qs7j1h7sqfhsfav6bda9hcxkqhcgzsiysnxqwy"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure)
+                   (replace 'check
+                     (lambda* (#:key tests? #:allow-other-keys)
+                       (when tests?
+                         (invoke "make" "test")))))
+      #:make-flags #~(list (string-append "PREFIX="
+                                          #$output))))
+    (inputs (list python-orderedmultidict
+                  python
+                  cmake-minimal
+                  openssl
+                  zlib
+                  googletest
+                  capnproto))
+    (home-page "https://github.com/chipsalliance/UHDM/")
+    (synopsis "Universal Hardware Data Model")
+    (description
+     "UHDM is a complete modeling of the IEEE SystemVerilog Object Model with
+VPI Interface, Elaborator, Serialization, Visitor and Listener.")
+    (license license:asl2.0)))

base-commit: e72b988cfb36f48ec8f43700fe0ad132acb98ca1
--
2.48.1

Message #8 received at 76207 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 76207 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v1] gnu: Add uhdm.
Date: Wed, 12 Feb 2025 11:01:04 +0100

* gnu/packages/electronics.scm (uhdm): New variable.

Change-Id: I85438daefa41fae999500f19b6d0c2e4035d57a9
Signed-off-by: Cayetano Santos <csantosb <at> inventati.org>
---
 gnu/packages/electronics.scm | 44 ++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index df0238c348..9d6fbea936 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
@@ -52,6 +53,10 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages serialization)
+  #:use-module (gnu packages swig)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages sqlite)
@@ -522,3 +527,42 @@ (define-public minipro
 Additionally your user must be member of the @code{plugdev} group.")
       (home-page "https://gitlab.com/DavidGriffith/minipro")
       (license license:gpl3+))))
+
+(define-public uhdm
+  (package
+    (name "uhdm")
+    (version "1.84")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/chipsalliance/UHDM/")
+             (commit (string-append "v" version))
+             (recursive? #f)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "06i06wfyymhvmpnw79lgb84l9w9cyydvnr7n3bgmgf8a77jbxk2y"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure))
+      #:test-target "test"
+      #:make-flags #~(list
+                      "ADDITIONAL_CMAKE_OPTIONS=-DUHDM_USE_HOST_CAPNP=On -DUHDM_USE_HOST_GTEST=On"
+                      (string-append "PREFIX="
+                                     #$output))))
+    (native-inputs (list pkg-config swig))
+    (inputs (list capnproto
+                  cmake-minimal
+                  googletest
+                  openssl
+                  python
+                  python-orderedmultidict
+                  zlib))
+    (home-page "https://github.com/chipsalliance/UHDM/")
+    (synopsis "Universal Hardware Data Model")
+    (description
+     "UHDM is a complete modeling of the IEEE SystemVerilog Object Model with
+VPI Interface, Elaborator, Serialization, Visitor and Listener.")
+    (license license:asl2.0)))

base-commit: d59a13b6401e7494d8d5c9c9f66df3318451be79
-- 
2.48.1

Message #11 received at 76207 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 76207 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add uhdm.
Date: Wed, 19 Feb 2025 09:44:05 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patch.

Please check my review points:
--8<---------------cut here---------------start------------->8---
+    (inputs (list python-orderedmultidict
+                  python
+                  cmake-minimal
+                  openssl
+                  zlib
+                  googletest
+                  capnproto))
--8<---------------cut here---------------end--------------->8---
I contains build and runtime dependencies, let's split them out e.g.

- native-inputs:
  + cmake-minimal
  + googletest
  + python-wrapper
- inputs:
  + capnproto
  + openssl
  + python-orderedmultidict
  + zlib

--8<---------------cut here---------------start------------->8---
+       (uri (git-reference
+             (url "https://github.com/chipsalliance/UHDM/")
+             (commit (string-append "v" version))
+             (recursive? #f)))
--8<---------------cut here---------------end--------------->8---
Does it pull any extra dependencies? May you check if they may be
replaced by available in Guix, if not provide some notes why it's not
possible for now.

Ok I see <https://github.com/chipsalliance/UHDM/tree/master/third_party>
--8<---------------cut here---------------start------------->8---
capnproto @ 8c7e0fd
decompile vpiHandle
2 years ago
googletest @ 58d77fa
Switch to current googletest release.
3 years ago
Verilog_Object_Model.pdf
--8<---------------cut here---------------end--------------->8---
Let's remove them as you already provided in inputs.

--8<---------------cut here---------------start------------->8---
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (delete 'configure))
--8<---------------cut here---------------end--------------->8---
Please, provide some notes for the future package maintainer describing
why you did this.

License looks correct:
--8<---------------cut here---------------start------------->8---
licensecheck -r UHDM | awk -F: '{print $2}' | sort | uniq -c | sort -rn
    305  Apache License (v2.0)
     63  *No copyright* UNKNOWN
     19  Apache License (v2.0) GENERATED FILE
      4  *No copyright* GENERATED FILE
      2  UNKNOWN
      1  *No copyright* Apache License (v2.0)
--8<---------------cut here---------------end--------------->8---

Looking forward for v2!

---
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 76207 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 76207 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: Add uhdm.
Date: Mon, 24 Feb 2025 12:13:38 +0100

* gnu/packages/electronics.scm (uhdm): New variable.

Change-Id: I85438daefa41fae999500f19b6d0c2e4035d57a9
---
 gnu/packages/electronics.scm | 44 ++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index df0238c348..93e37cf9ee 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
@@ -52,6 +53,10 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages serialization)
+  #:use-module (gnu packages swig)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages sdl)
   #:use-module (gnu packages sqlite)
@@ -522,3 +527,42 @@ (define-public minipro
 Additionally your user must be member of the @code{plugdev} group.")
       (home-page "https://gitlab.com/DavidGriffith/minipro")
       (license license:gpl3+))))
+
+(define-public uhdm
+  (package
+    (name "uhdm")
+    (version "1.84")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/chipsalliance/UHDM/")
+             (commit (string-append "v" version))
+             ;; avoid submodules, and use guix packages capnproto and
+             ;; googletest instead
+             (recursive? #f)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "06i06wfyymhvmpnw79lgb84l9w9cyydvnr7n3bgmgf8a77jbxk2y"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          ;; there is no configure stage, as for INSTALL.md
+          (delete 'configure))
+      #:test-target "test"
+      #:make-flags
+      #~(list
+         "ADDITIONAL_CMAKE_OPTIONS=-DUHDM_USE_HOST_CAPNP=On -DUHDM_USE_HOST_GTEST=On"
+         (string-append "PREFIX="
+                        #$output))))
+    (native-inputs (list cmake-minimal googletest pkg-config python-wrapper
+                         swig))
+    (inputs (list capnproto openssl python-orderedmultidict zlib))
+    (home-page "https://github.com/chipsalliance/UHDM/")
+    (synopsis "Universal Hardware Data Model")
+    (description
+     "UHDM is a complete modeling of the IEEE SystemVerilog Object Model with
+VPI Interface, Elaborator, Serialization, Visitor and Listener.")
+    (license license:asl2.0)))

base-commit: c4fcf8fb627c9ea54a4a639a81766e5df3973fdc
--
2.48.1

Message #19 received at 76207-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 76207-done <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#76207] [PATCH v2] gnu: Add uhdm.
Date: Wed, 05 Mar 2025 20:19:20 +0100

Cayetano Santos <csantosb <at> inventati.org> skribis:

> * gnu/packages/electronics.scm (uhdm): New variable.
>
> Change-Id: I85438daefa41fae999500f19b6d0c2e4035d57a9

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.