GNU bug report logs - #7619
23.2.91; [PATCH] Mark outline-heading-end-regexp safe local

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7619 in the body.
You can then email your comments to 7619 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local
Date: Sun, 12 Dec 2010 10:36:09 +0000

There is a missing autoload to mark outline-heading-end-regexp safe
local while its doc string recommends setting it file locally. The
attached patch fixes this.

From 32fb65f511efab56e2ec926cbc49d2e324832909 Mon Sep 17 00:00:00 2001
Date: Sun, 12 Dec 2010 10:33:19 +0000
Subject: [PATCH] Mark outline-heading-end-regexp safe local

with predicate string-or-null-p.
---
 lisp/outline.el |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lisp/outline.el b/lisp/outline.el
index b5d3d79..37adb1e 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -62,6 +62,7 @@ The recommended way to set this is with a `Local Variables:' list
 in the file it applies to."
   :type 'regexp
   :group 'outlines)
+;;;###autoload(put 'outline-heading-end-regexp 'safe-local-variable 'string-or-null-p)
 
 (defvar outline-mode-prefix-map
   (let ((map (make-sparse-keymap)))
-- 
1.7.3

Message #8 received at 7619 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 7619 <at> debbugs.gnu.org
Subject: Re: bug#7619: 23.2.91;
	[PATCH] Mark outline-heading-end-regexp safe local
Date: Mon, 13 Dec 2010 12:10:34 -0500

> There is a missing autoload to mark outline-heading-end-regexp safe
> local while its doc string recommends setting it file locally. The
> attached patch fixes this.

Looks good, please apply it.


        Stefan

Message #11 received at 7619 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 7619 <at> debbugs.gnu.org
Subject: Re: bug#7619: 23.2.91;
	[PATCH] Mark outline-heading-end-regexp safe local
Date: Sun, 19 Dec 2010 07:26:28 +0000

On 2010-12-13 17:10 +0000, Stefan Monnier wrote:
>> There is a missing autoload to mark outline-heading-end-regexp safe
>> local while its doc string recommends setting it file locally. The
>> attached patch fixes this.
>
> Looks good, please apply it.
>
>
>         Stefan

I don't have commit access. Could someone help install it?

Thanks.

Leo

Message #14 received at 7619 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Leo <sdl.web <at> gmail.com>, 7619 <at> debbugs.gnu.org
Subject: Re: bug#7619: 23.2.91;
	[PATCH] Mark outline-heading-end-regexp safe local
Date: Thu, 03 Mar 2011 23:56:02 -0500

I was going to apply this, but then I noticed that nil is not an allowed
:type for outline-heading-end-regexp, so I don't see that
string-or-null-p is correct. But I also don't see why outline-regexp
does allow nil as a :type, when that is undocumented and will in fact
break several places in the code that assume it is a string.

Message #17 received at 7619 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 7619 <at> debbugs.gnu.org
Subject: Re: bug#7619: 23.2.91;
	[PATCH] Mark outline-heading-end-regexp safe local
Date: Fri, 04 Mar 2011 13:32:08 +0800

On 2011-03-04 12:56 +0800, Glenn Morris wrote:
> I was going to apply this, but then I noticed that nil is not an allowed
> :type for outline-heading-end-regexp, so I don't see that
> string-or-null-p is correct. But I also don't see why outline-regexp
> does allow nil as a :type, when that is undocumented and will in fact
> break several places in the code that assume it is a string.

I think both cases should be changed to stringp.

Leo

Message #22 received at 7619-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 7619-done <at> debbugs.gnu.org
Subject: Re: bug#7619: 23.2.91;
	[PATCH] Mark outline-heading-end-regexp safe local
Date: Fri, 4 Mar 2011 03:40:09 -0500

Version: 24.1

I figured out why nil was there. It's no longer relevant, so I removed
it and added the other safety predicate.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.