GNU bug report logs - #76187
vc-git-test-dir-branch-headers failure on Fedora

Previous Next

Full log

View this message in rfc822 format

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 76187 <at> debbugs.gnu.org, Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#76187: vc-git-test-dir-branch-headers failure on Fedora
Date: Sat, 15 Feb 2025 23:17:45 +0100

[Message part 1 (text/plain, inline)]

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> On 2025-02-15 02:42, Kévin Le Gouguec wrote:
>> waiting for vc-dir-busy*after* invoking vc-dir seems to work fine,
>> which makes complete sense
>
> Makes sense to me too. I didn't look at the patch in detail, but did notice a "TODO" comment.

One of these "finishing touches" I mentioned, yup.

Attaching for your consideration:

1. a patch that fixes the vc-dir synchronization,
2. a patch that ditches vc-dir entirely.

Either fixes the issue, as far as I can validate.  I still have a slight
preference for the second one¹.  FWIW, here the test takes ≈330ms with
patch 1, and ≈68ms with patch 2².

Happy to install whichever.


¹ tl;dr vc-dir is a middleman with no added value for the purposes of
this test.

² Which is only worth consideration if you happen to need run that test
repeatedly to reproduce a weird race condition 🥲

[0001-Fix-race-condition-in-vc-git-tests.el-bug-76187.patch (text/x-patch, attachment)]

[0001-Test-vc-git-dir-extra-headers-directly-bug-76187.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.