GNU bug report logs - #76187
vc-git-test-dir-branch-headers failure on Fedora

Previous Next

Full log

Message #62 received at 76187 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76187 <at> debbugs.gnu.org, Dmitry Gutov <dmitry <at> gutov.dev>, eggert <at> cs.ucla.edu
Subject: Re: bug#76187: vc-git-test-dir-branch-headers failure on Fedora
Date: Sat, 15 Feb 2025 11:42:33 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
>> Cc: 76187 <at> debbugs.gnu.org,  eggert <at> cs.ucla.edu
>> Date: Thu, 13 Feb 2025 23:58:21 +0100
>> 
>> Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:
>> 
>> > FWIW, with that last patch I posted, the test has been passing on repeat
>> > for 3h (47k iterations) and counting.  Maybe we have a winner?
>> 
>> 4h10min, 66k iterations, no failures.  Stopping the count because this
>> brain needs zzz's.
>> 
>> > Let me know if it looks acceptable, I'll add commentary & a changelog
>> > entry.
>> 
>> Done; attached for your consideration.
>
> I'm okay with this if Dmitry agrees.

For the sake of intellectual honesty (and to prove, if need be, that I
am a clown), while I do still prefer getting vc-dir out of the equation
for the purpose of testing vc-git-dir-extra-headers (and so, applying
the patch to which you reply),

I should note that with the alternative attached patch, the test has
been passing 7k times for 1h, with reassuring traces such as:

    Running in foreground: git --no-pager clone /tmp/emacs-test-Aoc9gk-vc-git/ /tmp/emacs-test-qRZ6nt-vc-git/ .
    Done (status=0): git --no-pager clone /tmp/emacs-test-Aoc9gk-vc-git/ /tmp/emacs-test-qRZ6nt-vc-git/ .
    Running in foreground: git --no-pager config --get remote.origin.url
    Done (status=0): git --no-pager config --get remote.origin.url
    Running in background: git --no-pager update-index --refresh .
    Done in background: git --no-pager update-index --refresh .
    Running in background: git --no-pager diff-index --relative -z -M HEAD -- .
    Done in background: git --no-pager diff-index --relative -z -M HEAD -- .
    Running in background: git --no-pager ls-files -z -u -- .
    Done in background: git --no-pager ls-files -z -u -- .
    Running in background: git --no-pager ls-files -z -o --exclude-standard -- .
    Done in background: git --no-pager ls-files -z -o --exclude-standard -- .
    Paused 50 ms waiting for vc-dir-busy
    Running in foreground: git --no-pager checkout -b feature/foo master .

IOW waiting for vc-dir-busy *after* invoking vc-dir seems to work fine,
which makes complete sense, and I am not sure why I never thought about
this in the first place?

Let me know if we favor this approach, in which case I'll add the
finishing touches on that patch (docstring, changelog).

[wait-AFTER-dir-🤦.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.