GNU bug report logs - #76172
31.0.50; C-h f menu-bar-open-mouse signals error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76172 in the body.
You can then email your comments to 76172 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; C-h f menu-bar-open-mouse signals error
Date: Mon, 10 Feb 2025 06:10:30 +0100

1. emacs -Q -nw
2. C-h f menu-bar-open-mouse RET

=> Wrong type argument: listp, menu-bar-open-mouse


In GNU Emacs 31.0.50 (build 5, aarch64-apple-darwin24.3.0) of 2025-02-10
 built on pro2
Repository revision: e9d17e41971c887675d52e1dcee21978d4247130
Repository branch: master
System Description:  macOS 15.3

Configured using:
 'configure --without-ns --cache-file
 /var/folders/1d/k_6t25f94sl83szqbf8gpkrh0000gn/T//config.cache.master
 --with-native-compilation=no CC=clang 'CFLAGS=-Wgnu-imaginary-constant
 -Wunused-result -g -F
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks
 -Wno-ignored-attributes -Wno-flag-enum -Wno-missing-method-return-type
 -Wno-variadic-macros -Wno-strict-prototypes -Wno-availability
 -Wno-nullability-completeness' --prefix=/Users/gerd/.local'

Message #8 received at 76172 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>, 
 76172 <at> debbugs.gnu.org
Subject: Re: bug#76172: 31.0.50; C-h f menu-bar-open-mouse signals error
Date: Mon, 10 Feb 2025 07:19:38 -0600

tags 76172 + patch
thanks

Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:

> 1. emacs -Q -nw
> 2. C-h f menu-bar-open-mouse RET
>
> => Wrong type argument: listp, menu-bar-open-mouse

It looks like this special case is just not covered.  Evaluating

    (car (cdr (cdr (assq 'menu-bar global-map))))

leads to

    (mouse-1 . menu-bar-open-mouse)

but that has a different form than all other menu bar entries, and the
`(nth 1 ...)` call will obviously not work.

This should fix it:

diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 9324cf85454..6112df99850 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -649,7 +649,8 @@ help-fns--insert-menu-bindings
          (lambda (entry level)
            (when (symbolp map)
              (setq map (symbol-function map)))
-           (when-let* ((elem (assq entry (cdr map))))
+           (when-let* ((elem (assq entry (cdr map)))
+                       (_ (proper-list-p elem)))
              (when (> level 0)
                (push sep string))
              (if (eq (nth 1 elem) 'menu-item)

Message #11 received at 76172 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 76172 <at> debbugs.gnu.org
Subject: Re: bug#76172: 31.0.50; C-h f menu-bar-open-mouse signals error
Date: Mon, 10 Feb 2025 14:51:58 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

> This should fix it:

Thanks, works!

                          

Message #16 received at 76172-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 76172-done <at> debbugs.gnu.org
Subject: Re: bug#76172: 31.0.50; C-h f menu-bar-open-mouse signals error
Date: Mon, 10 Feb 2025 06:18:35 -0800

Version: 31.1

Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> This should fix it:
>
> Thanks, works!

Thanks for testing!

Installed as commit 6a31cbc67fc, and thus closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.