GNU bug report logs - #76153
[PATCH] gnu: icewm: iAdd icewm.desktop file.

Previous Next

Full log

Message #14 received at 76153 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andy Tai <atai <at> atai.org>
Cc: 76153 <at> debbugs.gnu.org
Subject: Re: [bug#76153] [PATCH v2] gnu: icewm: Add icewm.desktop file.
Date: Sat, 01 Mar 2025 21:33:09 +0000

[Message part 1 (text/plain, inline)]

Andy Tai <atai <at> atai.org> writes:

> patch originally written here:
> https://lists.nongnu.org/archive/html/help-guix/2022-05/msg00114.html
>
> by
>
> 白い熊
> ShiroiKuma

I think it would be good to mention this in the commit message, I also
think it's missing why this change is being made, it's unclear to me at
least what this .desktop file enables?

Second thing, re-indenting parts of the package definition is fine, but
it's best to do that in a separate commit, that way the diff will be
clearer.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.