GNU bug report logs - #76142
[PATCH] Eglot: do not activate unsupported menu items

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Felician Nemeth <felician.nemeth <at> gmail.com>
Subject: bug#76142: closed (Re: bug#76142: [PATCH] Eglot: do not activate
 unsupported menu items)
Date: Sat, 08 Feb 2025 13:33:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#76142: [PATCH] Eglot: do not activate unsupported menu items

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 76142 <at> debbugs.gnu.org.

-- 
76142: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76142
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: João Távora <joaotavora <at> gmail.com>
To: Felician Nemeth <felician.nemeth <at> gmail.com>
Cc: 76142-done <at> debbugs.gnu.org
Subject: Re: bug#76142: [PATCH] Eglot: do not activate unsupported menu items
Date: Sat, 8 Feb 2025 13:31:34 +0000

On Sat, Feb 8, 2025 at 11:45 AM Felician Nemeth
<felician.nemeth <at> gmail.com> wrote:
>
> > Thanks, felicián.  Feel free to push and close this issue.
>
> I don't have access rights to push.

Ok, I pushed it for you.  I'll close the bug, but we can keep talking.

>
> > Re outline mode, I'm not sure it would help.  You can already use tab
> > to navigate buttons.
>
> I have not used call hierarchies long enough to have a strong opinion,
> but maybe starting with fully open hierarchy is more useful than the
> current closed one.

Opening the first node is feasible (and logical, since why else would
you invoke the hierarchy commands?) but expanding the whole tree
is impossible.  In general, especially when both directions are considered,
the tree is infinite.

> For example:
>
> [-]  ∘ funcb
>  |-[-]  ← funca
>  |  `-   ← main
>  `-   ← main
>
> vs:
>
> [+]  ∘ funcb
>
> And in the former case, 'Up' and 'Next Same Level' commands can be
> useful.

indeed.

> I don't know.  If Eglot just relies on the tree-widget library, then
> maybe that library should be enhanced with more navigation commands
> instead.

Yes.  tree-widget.el could come with some kind of tree-widget-mode with such
commands.  outline-mode is not a good choice, it's meant for plain text
with some markup.

I also don't know what other LSP extensions do with this graph.  If you have
more ideas to make it more interactive, pretty, etc, feel free to let me know
or push patches.  I think you should have commit rights to push to Eglot
directly.

João

[Message part 3 (message/rfc822, inline)]

From: Felician Nemeth <felician.nemeth <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Eglot: do not activate unsupported menu items
Date: Sat, 08 Feb 2025 12:13:37 +0100

[Message part 4 (text/plain, inline)]

Hi João,

This small patch follows the current tradition of disabling menu items
that are known not to work with the current server.

By the way, the new eglot-hierarchy-mode looks really nice.  I wonder
if outline-minor-mode cloud somehow be enabled here.  Or if
eglot-hierarchy-mode cloud be derived from outline-mode.  Their
navigation commands are quite useful.

Thanks.

[0001-Eglot-do-not-activate-unsupported-menu-items.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.