From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 06:13:54 2025 Received: (at submit) by debbugs.gnu.org; 8 Feb 2025 11:13:54 +0000 Received: from localhost ([127.0.0.1]:38829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgimX-0002TM-Tr for submit@debbugs.gnu.org; Sat, 08 Feb 2025 06:13:54 -0500 Received: from lists.gnu.org ([2001:470:142::17]:47768) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tgimU-0002T5-Fg for submit@debbugs.gnu.org; Sat, 08 Feb 2025 06:13:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgimN-00081Q-VX for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2025 06:13:44 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tgimM-000683-5v for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2025 06:13:43 -0500 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5de5e3729ecso857771a12.0 for ; Sat, 08 Feb 2025 03:13:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739013219; x=1739618019; darn=gnu.org; h=mime-version:face:user-agent:message-id:date:subject:to:from:from :to:cc:subject:date:message-id:reply-to; bh=3/cMQvAcxAE9FzQ7dZe0vZyxAjxSy+LWUo6Mqb8wNXo=; b=BIL0uEEDDdb9XE9LFiHbt4uQG/+0+W4PWUUwRMb8EL1ILGtgLnkef85AMQ9Lvkt2Lt R+jX0R1ew31j2aAUnltOwz6+csajRelT6vS4v3VVuH4beV241ujKgL8itbRLIkxAaam2 iHR15UbcAs9egsKgAn0vwSwoa0g35U8v71dvRFAK8TICCK5ZH6j+zZM3HmFy1JoLDUpg /tF85dX06MarhqTS8wkxvNV72gKaCPAWJSWjjNwrj2DQeHH5W07lRw0BIduyDJ91c30S GDElR39N3/zY0tjx4kAvmtKlXOUZlgejryDt530+hTe9lzMm5QYp4Ug8pCUWFBPrJgZG Pd2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739013219; x=1739618019; h=mime-version:face:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3/cMQvAcxAE9FzQ7dZe0vZyxAjxSy+LWUo6Mqb8wNXo=; b=JvKg0PVJ21wb8OEErn5KdQsvBrbSQI7kcDqX8wb7GucdG4TGjHEzXoHzybjZPFibYj wkgLp4XubdYSHsrWtuej6pZaEf5bHgpT5k1bwayXgUBI8OMRqvhqFqeg/5tvn8urWNlh pYQSFVNjvPZeuu5U4RWRbMjUMjGlpsQCGvXEGydZSwUycmB6S72/qPnjLDeezJEsRe0H 3GXKKzmV4K3NianJc4NvV/6u3W5F+mf2/ZikEXkCogp7LNAdNIY5Bbqssx5QAfJukwxB 60bC9y4IKZK1RNxib9su6VgqsO3+cszHlZtKqtJz7mM52xzhFjS5dhhsGpyaZm7yJd0I AUqA== X-Gm-Message-State: AOJu0Yz5ZNFAf9P/lGE3j57nKlenpkigK6WmIgrmgEyCoKNXTDmqOPgo i41JhHHj4xahHcc3PgG9vQeBNjcl+uIDmCtn9Km20MEvx1WG3Fvc/UXoMA== X-Gm-Gg: ASbGncshEkmhgsHAOVB0ZRRj5Xmd8W6wx6x9XFhts5ODqAPvrxTFxJ9K5so3lYZAufJ /aGwOuRvNhIcAgpSIkSb9RNDxVUtACcKDTmWNxD7i/xXvU14fMOU+VbfjWGeZxbbIH1oUC1hjOt /CY/YbhwgPg2vvzUh3J+gIPewlwuiAsHU1ZY7r468+GtCHU2mkssyBgpo/LLlQ9E0YhK0nACpGu +Ws1tWM3vWSeXJGrVBnvKgJGu4W2WPymuP74ozJtnRE4YKgFZ0EE4FK2M8yyH2R6kUE1QJVFKnD IQL8Ieh9dv0gR6xfqSwogce7UIbfXwMIHQ0GTP2hTpIVy0zr/bSmBzhSn0U7+xgzAXZm8zSf X-Google-Smtp-Source: AGHT+IHqCBP1KGh0PwnOLAbdS/Wh1HXPYBXqcAyJ11bCInAWBTUi5P8QLjjDSnJFnOfIYPVC2zuu6g== X-Received: by 2002:a17:907:9803:b0:ab6:d7c5:123 with SMTP id a640c23a62f3a-ab789c50a85mr707764866b.51.1739013219321; Sat, 08 Feb 2025 03:13:39 -0800 (PST) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.one.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab781453f04sm370920866b.161.2025.02.08.03.13.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 03:13:38 -0800 (PST) From: Felician Nemeth To: bug-gnu-emacs@gnu.org Subject: [PATCH] Eglot: do not activate unsupported menu items X-Debbugs-Cc: joaotavora@gmail.com Date: Sat, 08 Feb 2025 12:13:37 +0100 Message-ID: <874j14665a.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=felician.nemeth@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jo=C3=A3o, This small patch follows the current tradition of disabling menu items that are known not to work with the current server. By the way, the new eglot-hierarchy-mode looks really nice. I wonder if outline-minor-mode cloud somehow be enabled here. Or if eglot-hierarchy-mode cloud be derived from outline-mode. Their navigation commands are quite useful. Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Eglot-do-not-activate-unsupported-menu-items.patch >From d5e02a79061394ccda7ee08137921ba7dfd75569 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felici=C3=A1n=20N=C3=A9meth?= Date: Sat, 8 Feb 2025 11:53:31 +0100 Subject: [PATCH] Eglot: do not activate unsupported menu items * lisp/progmodes/eglot.el (eglot-menu): Do not activate items that the server does not support. --- lisp/progmodes/eglot.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 728227f0e9a..a69d239214f 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2311,8 +2311,10 @@ eglot-menu ["Quickfix" eglot-code-action-quickfix :visible (eglot-server-capable :codeActionProvider)] "--" - ["Show type hierarchy" eglot-show-type-hierarchy] - ["Show call hierarchy" eglot-show-call-hierarchy] + ["Show type hierarchy" eglot-show-type-hierarchy + :active (eglot-server-capable :typeHierarchyProvider)] + ["Show call hierarchy" eglot-show-call-hierarchy + :active (eglot-server-capable :callHierarchyProvider)] "--")) (easy-menu-define eglot-server-menu nil "Manage server communication" -- 2.39.5 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 06:18:56 2025 Received: (at 76142) by debbugs.gnu.org; 8 Feb 2025 11:18:57 +0000 Received: from localhost ([127.0.0.1]:38846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgirQ-0002j9-Mz for submit@debbugs.gnu.org; Sat, 08 Feb 2025 06:18:56 -0500 Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]:59745) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tgirO-0002iu-JP for 76142@debbugs.gnu.org; Sat, 08 Feb 2025 06:18:55 -0500 Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-5f4ce54feb8so1602427eaf.3 for <76142@debbugs.gnu.org>; Sat, 08 Feb 2025 03:18:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739013528; x=1739618328; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OtFOc7YkLqYF74nzJO6fK/AvARPyR3r/W0zIFw3X8kE=; b=IxOJibbHUNsZafGaBdsx9Eai1kfUqyRbjY0YGTAg8xaGdBr5BIF/S3cqHKyQRIQqT7 LsY6JbAklG6miQ3xO743gGCq5BxH6Lu0UGtg3QAVHhIkhNT16aE9HkAWOfMXheKQjGe0 4jpCBB3jEbd7o0OIVQlD5pkO6ZS0XsTDKeqNsFn+46EAeaijY4TzV90duPtRVfCr+2Vq n9DFZUzzdg4py3MtRcFYfQKgwe4Ld/xeWHfk5E0G6oqrsVefs0pEm54Cy+GeTwynR+8b xWgzkOD3bjwgAginQu53DAwUc6tDqX7JLOW+v7i//57JLRhJxMAYaOGc2ki3tmMPxIQs XngQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739013528; x=1739618328; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OtFOc7YkLqYF74nzJO6fK/AvARPyR3r/W0zIFw3X8kE=; b=YRFLmT87CWqDycQicZSieQltivCpU9ycX96rUQJNy/+HkGZfek0+hkQxnslWDq9CNA USOWWc8z4/DClS4MZHWM9k8B/ijI0tFFo971Es4s7dkhKAJOPh6x0DWnQjufSBncg1wL Zk8m2t6ScCUzuZ8RujMkYcFJal2uko87IVmgPimJe2tOhPvdCnNeGQMIk55BcVbOEiEJ G3xT3Vn/DUVkey8PA5FAcp/h23ehVeX9/DEmJMjAJsd0HdYB8SXDwe17074NLfxtDZV9 tBdLQE/PPkMLADl/qtybiYLwpyRWqDeSV6gU3Iyrd/7TmaPHfuRsB+3+AnEOSOFqh9vM NhAQ== X-Gm-Message-State: AOJu0Yz2FYAr7sQ05XlBIBK7GyxYZdSyzf0PaYUE7vIq31Q4HSpFmOSN ygpRTysWRkAdyflcZ/Wh6Ke0LwgxTwqexvK4IwqnK6pdHzTPa/7tAJbgz7/RgTrswJHl6Sd3cNP vazrA1n3eddcl4thxRRGvKGdsOWg= X-Gm-Gg: ASbGnctoQgPFXUa6IFjiC90D0Os8XdXAUU9s4MDIL2BSfE6DQ06AFIlKf7ggEX7vRVm /nwYmzyT8Nfofp5kUo1QqcRoqN/wT+D1PYDyqgEyAZtkfiFym+3gfXW9qoskCO6xmdjnlu7w= X-Google-Smtp-Source: AGHT+IH3LWxtEwHcxMaezzpbBEWUXQfCcdso8wFoOKkhy78miVKsmOhGbe+GBvm7B/6FXIEgASXuiBTKbP1KKoV+Vy0= X-Received: by 2002:a05:6870:46a5:b0:29e:69d9:8847 with SMTP id 586e51a60fabf-2b83e7ad1f0mr4071805fac.0.1739013528513; Sat, 08 Feb 2025 03:18:48 -0800 (PST) MIME-Version: 1.0 References: <874j14665a.fsf@betli.tmit.bme.hu> In-Reply-To: <874j14665a.fsf@betli.tmit.bme.hu> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 8 Feb 2025 11:18:49 +0000 X-Gm-Features: AWEUYZnnK1_iYrjEgCMggJrvIMo9OL1RjV5m61XWGGRlJT9rxsm47k9WuvV0hqA Message-ID: Subject: Re: bug#76142: [PATCH] Eglot: do not activate unsupported menu items To: Felician Nemeth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76142 Cc: 76142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks, felici=C3=A1n. Feel free to push and close this issue. Re outline mode, I'm not sure it would help. You can already use tab to navigate buttons. What do other modes that display tree widgets from tree-widget.el do? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 06:45:55 2025 Received: (at 76142) by debbugs.gnu.org; 8 Feb 2025 11:45:55 +0000 Received: from localhost ([127.0.0.1]:38895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgjHX-000441-CG for submit@debbugs.gnu.org; Sat, 08 Feb 2025 06:45:55 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:61949) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tgjHU-00043d-Fv for 76142@debbugs.gnu.org; Sat, 08 Feb 2025 06:45:53 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-ab7483b9bf7so421349466b.3 for <76142@debbugs.gnu.org>; Sat, 08 Feb 2025 03:45:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739015146; x=1739619946; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=MidiIVjOU95nTmnuw3ztDUlIHD4qwDs/HX9gHaNQ/c4=; b=lE8EYqy/ii1X+K1gd3VUGffANbaCHYSyxi3RnqemmIlE8F5WzFBxPCLFpzjwzho4BU 7sRuUtbHo90FNx9EZbHFrsrWEqVEDerHOO9tPh4c9a8oIyd5Ulvbx1u7E+GLgqlFkFlK rhQE05fKq2ton0Y+g/O0Nk2TcTzP7vp5qaLaHtVOTSVNToVQdDJYg3Knnp2HlEnXGNm3 P/MtWcoEaWbtBi2GAk7GxxW7FJ420RCIZP3Hy5qkASLnh2IntWNL3XyaxquczFINkbEE MrP7eqkpRy3Eq80ueuz22R7le5cHiBIp1gDAiXVmxD0cZowuYs8ZEU1f0YXSLIdYJg1g XVqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739015146; x=1739619946; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MidiIVjOU95nTmnuw3ztDUlIHD4qwDs/HX9gHaNQ/c4=; b=uPNgKjY6Tt5x6f1o0YKr/c186iCtTv/TeTvmTVv2VKCzjpc4//JMSvDRUA0VIkZhw6 VRXKEoFsgjjRPdx467nlergdad+hOWbZNpyW18zu8LT3ADPxXzShyXtfHZcrTTuJhFHE yiTLHKZGvQ94gF7O8yozolgDQSIzDVV7+Kazya55+zwpV0FOZDLMupijfNUpCiI23fjt NrsL+WWthtqTgv+30cyC8mzqx3yuAOy/U5f0FbtymyKTvg9jb2M2Cf0TAIZan9xsx2MF uIiuoswjJf64bu4XtA9bs00KC66MWuIazyJTwATv69FFumc2JQx7YVWS+wl6QRyH4RCY kMvw== X-Gm-Message-State: AOJu0YwHzlTDiqvO+GZaGfkXsVfqT+zS2YM50n78nrj5G/7t2jhfv3IY IkrmeFn71+TwfSopaigY+g16fsfGAngboZG9EgLHiZAOCzMnq6o7OF2rwQ== X-Gm-Gg: ASbGncsS2GSugdBV7qoiXinaXsQSSz8pz3yN1jlinmpwLZXLgtoQUDC2bPql07c8iNj ii5LGyplpsm3ASCK8gVn9bF6fjjY3aiyLM0pl+C/m4Z1kXJxG2XFsu47CVN8MoBgv+FO5lb+N1m hLmt3/rsIkecQJ8aQlciOMbcF6QcRh317HcBt7342G91tOfcxmzpAAKyWXG+rPyboyhW/PmAsSK ZW+LpXgjrcGi3n+GeScGQ4YzqGS/wp0wTyY/ifFKK8SOCvfCsmUAVaY3fxG+0HrnKh5tdcXFhIO Soa1roNtxL8zyYJvOcs2ttIVpzQPdz6ISq7CK1VNFLPSDcCDTmUfY1U0jo3NnA8gyq59eVJj X-Google-Smtp-Source: AGHT+IEgxEQsgE9v06YpZfWju9SRHz36I6IfTzaHVI1DQ1nuy0ft9o5He8fpdmNnutvAODu9ramEyQ== X-Received: by 2002:a17:907:6094:b0:ab6:fd30:f2ea with SMTP id a640c23a62f3a-ab789bfbf45mr847792166b.37.1739015145498; Sat, 08 Feb 2025 03:45:45 -0800 (PST) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.one.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dcf9f6fa21sm4206127a12.68.2025.02.08.03.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 03:45:45 -0800 (PST) From: Felician Nemeth To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#76142: [PATCH] Eglot: do not activate unsupported menu items References: <874j14665a.fsf@betli.tmit.bme.hu> Date: Sat, 08 Feb 2025 12:45:44 +0100 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Sat, 8 Feb 2025 11:18:49 +0000") Message-ID: <87wme04q3b.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76142 Cc: 76142@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks, felici=C3=A1n. Feel free to push and close this issue. I don't have access rights to push. > Re outline mode, I'm not sure it would help. You can already use tab > to navigate buttons. I have not used call hierarchies long enough to have a strong opinion, but maybe starting with fully open hierarchy is more useful than the current closed one. For example: [-] =E2=88=98 funcb |-[-] =E2=86=90 funca | `- =E2=86=90 main `- =E2=86=90 main vs: [+] =E2=88=98 funcb And in the former case, 'Up' and 'Next Same Level' commands can be useful. > What do other modes that display tree widgets from tree-widget.el do? I don't know. If Eglot just relies on the tree-widget library, then maybe that library should be enhanced with more navigation commands instead. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 08:32:50 2025 Received: (at 76142-done) by debbugs.gnu.org; 8 Feb 2025 13:32:50 +0000 Received: from localhost ([127.0.0.1]:39174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgkx0-0004Mu-05 for submit@debbugs.gnu.org; Sat, 08 Feb 2025 08:32:50 -0500 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:60886) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tgkwx-0004Mb-FC for 76142-done@debbugs.gnu.org; Sat, 08 Feb 2025 08:32:48 -0500 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-2b85131e68dso770888fac.1 for <76142-done@debbugs.gnu.org>; Sat, 08 Feb 2025 05:32:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739021561; x=1739626361; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TyTTWz6HkkdQZioeOGugMbKFFZSrD/D7KWSa5SPd8oo=; b=huf2kO9s/F7yQfYgqs93Bf0Y/ydp8WFO79pQh71j/9y+fFJtmSsUwW5N4/rBxPBJ9g cjacaF0hEZgeuAHla1XKYzJyg5JU6cXJk3G0q5YUC6p+SFKgFENgcX07jH0GLEaXeRwm 6j94OkFDcR6dlnuMFeWs9gZGsVAp8dOYMBaww+Q7z3qlm0kwjhV/M0mDEIKnKF5Tqz+P QfbouimafvT77+F3vYSmGR3anyM1ZooIkyyzNGvP0fP4WpqIi5U8/SCiplrvlgDIwaxj 7837/44RJbFyKdUtB0qnjLZzoeZ35UrOSEIjMbO13TuDtOUH3gAfd1FR/i8sXJXp11BY ViWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739021561; x=1739626361; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TyTTWz6HkkdQZioeOGugMbKFFZSrD/D7KWSa5SPd8oo=; b=JfLMoNu+DYUk2FbAKiMTT7v7ePgnSdi/Vq4j3BQ7FO62HZ7eWViEd93JmwRmEd9C5N JZST+ZnSks/3N18yHGtOzOeEh5Pt99d8gcZ0crKPKL24PVZ0y2byM6ME+ghMgI+WvnkX ReCaYV1R992zqxl/0QuhII5TSi98dYKCPPQf4EkPTSEhWGZ8FVeCDSjAmHa6vrVMT9RZ iQpVB+7sOXA9esHdooxckDSFjFkjqdf1zHiymU/TRkN+shnz5ZPk1sQMS2fAbUCOEoWV CQTKRrARiosOWbeTU/q4nHcl4AR6UD/JjTJZu3oD+zBCc4SxYYVltzapODm8iGFLuSPH a++w== X-Gm-Message-State: AOJu0Yz+eNX7T2PausGW8PM3UhfTiVRIF/bTa2+SW9A8eDZOcnJwurni gZG5CbDYA8jj3vRNTyvQVkH2+5eZxesirNRx/70f9f51+9EuoBQ2judybkbFZtLu88eaB3dsscj gRrZPvD/nTnxjw1el121GqG0xSMo= X-Gm-Gg: ASbGncvfT0kGKBE0zd/NQpGxMPsWYq+gtrjIvrBbwSfaMcEX30FT7dz0MWhsU675yUB I7r4PFnykwOyOZGobeKVNV6zOqb+LT2HTTe6+5UJitrzUW81mUzJQ4kpCSzOiH7svb95xhv8= X-Google-Smtp-Source: AGHT+IFcikreurcXZNBKd9g00t759ReCJTKFTd4C9xcvKmiFpVLVhb3xZHzeObA43CmKMpIEdF3vyXZ510etPtcBShw= X-Received: by 2002:a05:6870:4512:b0:2a7:d856:94a with SMTP id 586e51a60fabf-2b83ed0905dmr3887360fac.22.1739021561274; Sat, 08 Feb 2025 05:32:41 -0800 (PST) MIME-Version: 1.0 References: <874j14665a.fsf@betli.tmit.bme.hu> <87wme04q3b.fsf@betli.tmit.bme.hu> In-Reply-To: <87wme04q3b.fsf@betli.tmit.bme.hu> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 8 Feb 2025 13:31:34 +0000 X-Gm-Features: AWEUYZluFjYctj0ksqEY3dPVsjvlpvYY6LbQG6kQIYoDPn5euvnl9yocWfynAM4 Message-ID: Subject: Re: bug#76142: [PATCH] Eglot: do not activate unsupported menu items To: Felician Nemeth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76142-done Cc: 76142-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Feb 8, 2025 at 11:45=E2=80=AFAM Felician Nemeth wrote: > > > Thanks, felici=C3=A1n. Feel free to push and close this issue. > > I don't have access rights to push. Ok, I pushed it for you. I'll close the bug, but we can keep talking. > > > Re outline mode, I'm not sure it would help. You can already use tab > > to navigate buttons. > > I have not used call hierarchies long enough to have a strong opinion, > but maybe starting with fully open hierarchy is more useful than the > current closed one. Opening the first node is feasible (and logical, since why else would you invoke the hierarchy commands?) but expanding the whole tree is impossible. In general, especially when both directions are considered, the tree is infinite. > For example: > > [-] =E2=88=98 funcb > |-[-] =E2=86=90 funca > | `- =E2=86=90 main > `- =E2=86=90 main > > vs: > > [+] =E2=88=98 funcb > > And in the former case, 'Up' and 'Next Same Level' commands can be > useful. indeed. > I don't know. If Eglot just relies on the tree-widget library, then > maybe that library should be enhanced with more navigation commands > instead. Yes. tree-widget.el could come with some kind of tree-widget-mode with suc= h commands. outline-mode is not a good choice, it's meant for plain text with some markup. I also don't know what other LSP extensions do with this graph. If you hav= e more ideas to make it more interactive, pretty, etc, feel free to let me kn= ow or push patches. I think you should have commit rights to push to Eglot directly. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 15:01:18 2025 Received: (at 76142-done) by debbugs.gnu.org; 8 Feb 2025 20:01:18 +0000 Received: from localhost ([127.0.0.1]:41610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgr0w-0001qE-8H for submit@debbugs.gnu.org; Sat, 08 Feb 2025 15:01:18 -0500 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]:56677) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tgr0u-0001px-Lr for 76142-done@debbugs.gnu.org; Sat, 08 Feb 2025 15:01:17 -0500 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-ab7a5dbe96dso71451666b.1 for <76142-done@debbugs.gnu.org>; Sat, 08 Feb 2025 12:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739044870; x=1739649670; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EYZSg6T49Ap6JulfC+OCKjX0YI9xtzUcIecKlI2bECw=; b=PZarU8VNtpkybTBe8u3M/17bJGwkMprcqa1q1PwcDhYBLH93SHND3nON3EppOrcGIS O4Hy7X3Ot6z5V3krq4XfL3LzkXCIx2hsNHGyT6BWZoqgCjTrtsyL5O8OM5k6Q/6cCR4e KqSBElVuoLsGdHvCgomeP1JT1kUN/rH8jJ/qhr5aZxTdZDUn6s3vp7BOglGRUrMNHsEa QzueQFkZyF7TLPSZeIFFzUwKiZD9i9Y9o3aJY0xSMAWNwLmN27ShIyuYmPrNFTk7KLy7 3YpezxDjioTvEK6ZRwE/G84SJ2++HiJPFt/G5Ha3LLdH64Ph6xBvqYI7DJcEAujPX8GU GIsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739044870; x=1739649670; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EYZSg6T49Ap6JulfC+OCKjX0YI9xtzUcIecKlI2bECw=; b=BaPQ8TlOeQkOBeOAk0sWTApRQEXzg0JZ5Mqn0ZUe2ymcYT6gxPe4BNBqTIf7tu2aYn YSuz0ixpdGp6i6r07aEqp8WCKpv8D8kXbfBKEkZDQooFHUk5sNrVxjWWeUbsHrxNTKWu PzKMVNspv1xnteiF0Qld/lIUcf594hg9inR7hx+vydhf87N7bSpiJCXo9exVADHbErho CuZVdPGRyVajnvytIR4s/JC5IZlP1Tbmo40qEd2jAd9H8H55VEsJqqDGb45QSYBh6ToJ 6npKaNBF1qsBnoFudsYEqDFy9ABuQjp7pZCfyznwIDAyIzE11xZfsAQHsABb3tKPtQTE HgfQ== X-Gm-Message-State: AOJu0YxyhQkIyCrgTIwbut+tq4v/qPfhnSBuuCs1FIU5WBFjidtNfihB yUnT9pxolfdr4UX2xMh0k/aLp26GJHSlk58Li2x2CesVwLBUagxjcSTASw== X-Gm-Gg: ASbGnctNu/2stPxDc8deneAFKTfC5lbGtLQsaAk8hGK5tIwUAz2h/ye3cB048puOcBK 3p3k6MOlk4lQkYMOCjhCR7I5UjSXMLsQHFZAe5G74cvsdJuO5ShUsNwYGGt9R9i6WnF5Yf76Hve Y9jzVNQWVmiZIlitDCnSIDMzEY8sKuysOkZCIkY8eb1nRpRvRII9BOjomVVFQ3JWqaM0PtRirw/ F/FVfhRXWY1M/NXE0LU/9RSQ7pLJoNoYLJDUvtio9ZGyTzswbyGoviiY5lGFhHnFOhxImPFHTqB mHXsg1rJwdhlUnMPZmKERbEC9sJyUzS4rtjjVx6ilxdxFCaLpCG0B22EIR3AcPAbI9ACCFx5 X-Google-Smtp-Source: AGHT+IGiVEpSG0qtNyKlQxOavYeievUoqUCJc51j2nySMR8m86TJ+dnEKdX9ICCh3dGkkE9RsfXUxg== X-Received: by 2002:a17:906:4fd1:b0:ab7:6369:83fc with SMTP id a640c23a62f3a-ab789c3dcd0mr929236166b.38.1739044869592; Sat, 08 Feb 2025 12:01:09 -0800 (PST) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.one.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7a58abd76sm168976366b.26.2025.02.08.12.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:01:09 -0800 (PST) From: Felician Nemeth To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#76142: [PATCH] Eglot: do not activate unsupported menu items References: <874j14665a.fsf@betli.tmit.bme.hu> <87wme04q3b.fsf@betli.tmit.bme.hu> Date: Sat, 08 Feb 2025 21:01:08 +0100 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Sat, 8 Feb 2025 13:31:34 +0000") Message-ID: <87seoo435n.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76142-done Cc: 76142-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I also don't know what other LSP extensions do with this graph. If you have > more ideas to make it more interactive, pretty, etc, feel free to let me know > or push patches. It seems the current implementation ignores the tags, the detail, and the data fields of a CallHierarchyItem. The detail is probably useful to show. I don't like the language of the LSP specification, but the way I understand it, the client MUST return the data field to the server. Another approach to handle hierarchies is not to show the hierarchy itself, but to provide xref-like commands based on it: eglot-find-incoming-calls, eglot-find-outgoing-calls. Eglot-x has a command named eglot-x-find-refs that dispatches additional reference-finding commands based on eglot-x--extra-refs-alist. The alist is defined here: https://github.com/nemethf/eglot-x/blob/82c315c052e5a08c5307df4a4624049ee0e219e8/eglot-x.el#L564 Since Eglot currently has five xref commands, maybe it is a good idea to provide a single-key dispatcher similar to eglot-x-find-refs in Eglot itself. > I think you should have commit rights to push to Eglot directly. Thanks. I asked for commit rights at the savannah site. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 19:22:25 2025 Received: (at 76142-done) by debbugs.gnu.org; 9 Feb 2025 00:22:25 +0000 Received: from localhost ([127.0.0.1]:41914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgv5d-0005ee-95 for submit@debbugs.gnu.org; Sat, 08 Feb 2025 19:22:25 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:56509) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tgv5Z-0005e9-KS for 76142-done@debbugs.gnu.org; Sat, 08 Feb 2025 19:22:22 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4361b0ec57aso31674695e9.0 for <76142-done@debbugs.gnu.org>; Sat, 08 Feb 2025 16:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739060534; x=1739665334; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+tqvp/eWfD2+hHF8ULc3Gli1+9hUmURplDblyAKezPQ=; b=hnh4l+UlTdFPgH46LFD6M8zy6EbAMLj1Nohy69oDLbM0P0ZV9RrSY/RyqbDOU9YcdS Z+TeXQrSkQrQ2tqHvRbgbYR8GtDGrLkRL4xCWX7uX5ePd5a05hATXX5nD9VrTSqng1io KtXyW4zkjNlYkVwiENm3bM3MCZaM6noJ4pqM8c/vU/Om7EIlxR8LKh6H/Moqr1cHteAh i1cCZ6CiS+WRZ90bKebYxWnqIoquzOBRXZInqcpZryDtuF2rLfPAP7ASBO6PgQ8Pg69z 4LhH/iNHnBJtWavOJOexe1saGfbhvDRXweAMhCngWVLWLuE+ReGUPFx3GjWys/CYSLd4 s0VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739060534; x=1739665334; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+tqvp/eWfD2+hHF8ULc3Gli1+9hUmURplDblyAKezPQ=; b=T6Feczrl1HxIBTO6SqGoFT+sbtC4KYpPvJX3WOHllh9GxYFbkjdidE8F7qUp4gZIZK sjipAcymcVsFtzz1at9i/4tk9T9rI8nZlB9ybet6Yq60nKaXhQphFAbc1ICEuyOKJWcB wVqizHW0mT0feFbWNioh5rn/VlzL7tCInICAqpTbN3jdM2JqXIx1k2kadwwySlVaiSsQ 2s1YqUyqTZcyql/QaNUmV+0dzKLLhI3/afVuZR1iI+13L6b7yycxOPkeOYuk9QRmxY6r b2UX9wnsqjAyaPlQGMDIE528LH0DlCbB/7dDGS674lRc1KYgXyOKxUeClqmlp1QvDtfF 4PZA== X-Gm-Message-State: AOJu0YwSJD+9nRTeKpVIYH/OngPYQh/R1OP25sdCyw/RqyR5gCkKXEtM 55ud1l6WyBrlKi303Fbe393gaWAb6ky3DnrXrlJPw0MFsqVlJiYSQfjInA== X-Gm-Gg: ASbGncuHZ/h/G01M1DSUZVkxyn1ixGJJJcJc0V8of11lD+rP2T9b+z1kXnzEB5aLi6p wvFlztxrMWpfYMWfa4MohHNNMBXnwGUhRV/dWfLTOUEMw2rXveabT3o8nikVjqdZsintw79yb47 A56V17lI7uvTdMOA+tDZILWkg8w2AiDkWuAtXQHqI0TvHY6sCuiF6azLYWCCAuZLl5CmmFSkYIp ROyL+8AHxg1UfOhjT0h1x33gDVj/8rgk8AXyTztdwtNkopT06uv6xj9n2fFeLtHW/MMnHhgdaDL niG1 X-Google-Smtp-Source: AGHT+IG5WWLH7QOVWpMDWeqW5tzkq/wNNlIOrb35IjP0bhXw3OWFohgPUH7FLUTcT4vT/Cr3UP1FdA== X-Received: by 2002:a05:600c:4f50:b0:434:ffd7:6fd2 with SMTP id 5b1f17b1804b1-43924987431mr62799055e9.7.1739060534070; Sat, 08 Feb 2025 16:22:14 -0800 (PST) Received: from krug ([87.196.73.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4390daf3c70sm134256465e9.26.2025.02.08.16.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 16:22:13 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Felician Nemeth Subject: Re: bug#76142: [PATCH] Eglot: do not activate unsupported menu items In-Reply-To: <87seoo435n.fsf@betli.tmit.bme.hu> References: <874j14665a.fsf@betli.tmit.bme.hu> <87wme04q3b.fsf@betli.tmit.bme.hu> <87seoo435n.fsf@betli.tmit.bme.hu> Date: Sun, 09 Feb 2025 00:22:25 +0000 Message-ID: <87zfiwezlq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76142-done Cc: 76142-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Felician Nemeth writes: >> I also don't know what other LSP extensions do with this graph. If you = have >> more ideas to make it more interactive, pretty, etc, feel free to let me= know >> or push patches.=20=20 > > It seems the current implementation ignores the tags, the detail, and > the data fields of a CallHierarchyItem. What would you do with the tags and detail? For example, graphically, where would you put it? > The detail is probably useful to show. I don't like the language of > the LSP specification, but the way I understand it, the client MUST > return the data field to the server. It does that -- else it wouldn't work -- check the logs. > Another approach to handle hierarchies is not to show the hierarchy > itself, but to provide xref-like commands based on it: > eglot-find-incoming-calls, eglot-find-outgoing-calls. Eglot-x has a > command named eglot-x-find-refs that dispatches additional > reference-finding commands based on eglot-x--extra-refs-alist. The > alist is defined here: > https://github.com/nemethf/eglot-x/blob/82c315c052e5a08c5307df4a4624049ee= 0e219e8/eglot-x.el#L564 > > Since Eglot currently has five xref commands, maybe it is a good idea to > provide a single-key dispatcher similar to eglot-x-find-refs in Eglot > itself. Maybe, but anything that interacts with xref is usually more complexity and UI to think about. I don't personally see a lot of use in this though, iow, the hierarchy API is really good for showing the hierarchy. And M-? for incoming calls is already sufficient, IMO. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 12:11:10 2025 Received: (at 76142-done) by debbugs.gnu.org; 10 Feb 2025 17:11:10 +0000 Received: from localhost ([127.0.0.1]:52251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1thXJO-0005mx-61 for submit@debbugs.gnu.org; Mon, 10 Feb 2025 12:11:10 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:52332) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1thXJL-0005mf-V5 for 76142-done@debbugs.gnu.org; Mon, 10 Feb 2025 12:11:08 -0500 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-38dc660b56cso3550761f8f.0 for <76142-done@debbugs.gnu.org>; Mon, 10 Feb 2025 09:11:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739207461; x=1739812261; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=C8FHlBY6vY1PKKc5omZ31UdeHMOVmI+VxQZp2aGjM6U=; b=mKtpSr+X+qQfIXc9e+fANFzDHT5fDJ/8TRnMeRtV2feN8QIeM/X1Nz+HDkmhLD8FQo mgkqwyz9IRIc0eqQLzdV2NufOU5YxtZ4UMCZfZ5Yvviyb0CA9vM+ChvGZFqvLStPRrR/ kh02Cr/VS9B7IhtJ9hudXbE3r7Z/TSHE+RrQzlPIe3mLldWH/sH1ik1RwPPoQdYD72Ks Q3RAmlNrqV1H+XtwKOD++bL50n+Clf2mfwcT1ba0qlwDsaON+X8C6Q64vI9kHayZQVff x3ZsGlkislsikfWO3DQ9w5KPd+GemSwA5J/gj1ESJI44vE02GjgDdF0lohbHaMsmtgjt zhCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739207461; x=1739812261; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C8FHlBY6vY1PKKc5omZ31UdeHMOVmI+VxQZp2aGjM6U=; b=By/Pg0HJCdBFzB4uD5/xQOSeDSSvZGDTivExUNQFfCQ+De86Mxdly52xUZMS8tuIJz e4PvP0WJohl6uxCnFntPVpToO9MisOKrVq/QDG/UU750//r3ECYkLMy9J2UYKMi9lk4V Io1My5w3x7GMuz0ghpik49i7uD2IWD9OJBebx36hWUEfglUGIJE5Li63NbY2J9j+Idki HSUy/XnqxRrBX+4Bv23bcorXoGzlA3Nc1fCfhf/I0rFpW9cpNxzKl1pdwBBEIXZIdcQ3 kkyEvJ5JDufXNW38r5WrQ+NzhECS7nG9stnAOXiqp12ErFDUuMWZatVQhf53zLfmOTBJ P+kA== X-Gm-Message-State: AOJu0Yywr6leeOfo9gIjN2PV+gNZEvkMSNDdpYMI64LBvX4yW240uWcB U1SdS51KagrlSYzsjmF8q+nyDAnnyvDaCninJwQl+1hWqOPKWQn4qs672g== X-Gm-Gg: ASbGnctW80et9KcTLykn7B8HTwMS8cSsgX8D+a5s4XBSC69F7ohTQkZBPg1VHhAsmjR S0uCyWlHan6+ZGbSb5V+1OvQv9FFGMiuoO6XYdE29hsmiqRtAL8UXRUsLnAhPQt75aRR8dkMiw7 4cjC/sdC5k+fcbhgv8e33y9Ov5UEAAm/lqofPAGDwBj3eW6RLnfTLf3lDI2Faoh/b7c58ehld4U Uj/Ydy7Kp9gtsfUXKilvfr5cdQ5VZshZNvFNR+rCvLTy6qaOVQb/yKrGX52wB6IhddPUhm/8jGD uz9j2qr+bwwr8MCKhK/breW+Q0KHjcj3+l/Qywj+qoDJjq3gJZW0pXkZzDr4wq0do2JyDYrW X-Google-Smtp-Source: AGHT+IHhQwG8pFOmE+feB3/M0lQCtwUJS2DdUPqA63A60MDYK1yvRiuR7xxv066o02eAOochGuGhKA== X-Received: by 2002:adf:f70b:0:b0:385:d7f9:f157 with SMTP id ffacd0b85a97d-38dc9135d53mr9670749f8f.36.1739207460843; Mon, 10 Feb 2025 09:11:00 -0800 (PST) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.one.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7d101ed7dsm103179566b.106.2025.02.10.09.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 09:11:00 -0800 (PST) From: Felician Nemeth To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#76142: [PATCH] Eglot: do not activate unsupported menu items References: <874j14665a.fsf@betli.tmit.bme.hu> <87wme04q3b.fsf@betli.tmit.bme.hu> <87seoo435n.fsf@betli.tmit.bme.hu> <87zfiwezlq.fsf@gmail.com> Date: Mon, 10 Feb 2025 18:10:59 +0100 In-Reply-To: <87zfiwezlq.fsf@gmail.com> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Sun, 09 Feb 2025 00:22:25 +0000") Message-ID: <875xlh209o.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76142-done Cc: 76142-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > What would you do with the tags and detail? For example, graphically, > where would you put it? If the detail is just the signature of a function as in the exaple of the specification, then it can follow the name with a less important face. However, I think displaying the detail in the echo area with eldoc would be better. Currently a tag can only be "Deprecated", so the tag as a string can go after the name. Or the name can be printed with a warning face. But an eldoc message can also display the warning. I personally do not need this, but I think people usually like to see the "kind" field as an icon before the name. company-box is an example for this, but it is not in GNU ELPA. Eglot cloud show icons if the svg-lib package and a suitable icon collection were installed. svg-lib is in GNU ELPA. Or Eglot cloud provide easy customizability for users to implement this for themselves. Would you be interested in any of these? From unknown Fri Jun 20 07:17:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 11 Mar 2025 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator