GNU bug report logs - #76123
[PATCH] Eliminate savehist duplicated symbols

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76123: closed ([PATCH] Eliminate savehist duplicated symbols)
Date: Sat, 08 Feb 2025 12:09:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 08 Feb 2025 14:07:58 +0200
with message-id <861pw83aht.fsf <at> gnu.org>
and subject line Re: bug#76123: [PATCH] Eliminate savehist duplicated symbols
has caused the debbugs.gnu.org bug report #76123,
regarding [PATCH] Eliminate savehist duplicated symbols
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76123: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76123
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Eliminate savehist duplicated symbols
Date: Fri, 7 Feb 2025 15:05:40 -0500

[Message part 3 (text/plain, inline)]

This patch avoids savehist saving symbols duplicated between
'savehist-minibuffer-history-variables' and
'savehist-additional-variables'. I've accumulated symbols on
'savehist-additional-variables' that wind up, over time, in the master
minibuffer list documented as being dynamic.

  The contents of this variable is built while Emacs is running,
  and saved along with minibuffer history.

savehist had no defensive mechanism until now. The patch should do no harm
to users and will transparently save some resources.

TIA,

-Stephane

[Message part 4 (text/html, inline)]

[0001-Eliminate-savehist-duplicated-symbols.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76123-done <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#76123: [PATCH] Eliminate savehist duplicated symbols
Date: Sat, 08 Feb 2025 14:07:58 +0200

> From: Ship Mints <shipmints <at> gmail.com>
> Date: Sat, 8 Feb 2025 05:38:47 -0500
> Cc: stefankangas <at> gmail.com, 76123 <at> debbugs.gnu.org
> 
> Surely. Revised patch attached with a NEWS entry.

Thanks, installed on master, and closing the bug.

> I did not yet combine the two tests (the code is nearly duplicated) if that's what you think should be done so
> if you want me to do that, I can today.

I see no need.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.