GNU bug report logs - #76123
[PATCH] Eliminate savehist duplicated symbols

Previous Next

Package: emacs;

Reported by: Ship Mints <shipmints <at> gmail.com>

Date: Fri, 7 Feb 2025 20:07:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #29 received at 76123 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76123 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#76123: [PATCH] Eliminate savehist duplicated symbols
Date: Sat, 8 Feb 2025 05:38:47 -0500
[Message part 1 (text/plain, inline)]
Surely. Revised patch attached with a NEWS entry.

I did not yet combine the two tests (the code is nearly duplicated) if
that's what you think should be done so if you want me to do that, I can
today.

On Sat, Feb 8, 2025 at 3:35 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: 76123 <at> debbugs.gnu.org
> > From: Ship Mints <shipmints <at> gmail.com>
> > Date: Fri, 7 Feb 2025 19:04:27 -0500
> >
> > Revised patch attached with two tests to get savehist tests started. One
> is a basic functions test and the
> > other a duplicate test. They probably could be combined into one test,
> tbh, but not precisely sure what the
> > Emacs Core testing regime is for functionality.
> >
> > I tested on both Emacs 29 with the duplicate issue and with the
> duplicate avoidance patch applied.
>
> Thanks.  There's one more nit: I think this change needs to be called
> out in NEWS.  It changes user-facing behavior, so users should be
> informed about that.
>
[Message part 2 (text/html, inline)]
[0001-Eliminate-savehist-duplicated-symbols.patch (application/octet-stream, attachment)]

This bug report was last modified 98 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.