GNU bug report logs - #76123
[PATCH] Eliminate savehist duplicated symbols

Previous Next

Full log

View this message in rfc822 format

From: Ship Mints <shipmints <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 76123 <at> debbugs.gnu.org
Subject: bug#76123: [PATCH] Eliminate savehist duplicated symbols
Date: Fri, 7 Feb 2025 15:57:55 -0500

[Message part 1 (text/plain, inline)]

I kinda doubt it is worth it. There are currently no savehist tests at all
that I can see. But if you really, really want one, I'll start a test jig.

On Fri, Feb 7, 2025 at 3:45 PM Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Ship Mints <shipmints <at> gmail.com> writes:
>
> > This patch avoids savehist saving symbols duplicated between
> > 'savehist-minibuffer-history-variables' and
> > 'savehist-additional-variables'. I've accumulated symbols on
> > 'savehist-additional-variables' that wind up, over time, in the master
> > minibuffer list documented as being dynamic.
> >
> >   The contents of this variable is built while Emacs is running,
> >   and saved along with minibuffer history.
> >
> > savehist had no defensive mechanism until now. The patch should do no
> harm
> > to users and will transparently save some resources.
>
> Would it be worth adding a test for this?
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.