Subject: Re: bug#76120: This feature is not about "sharing", or a "native" anything.

From: Alvaro Ramirez <[email-masked]>
Date: Wed, 26 Feb 2025 10:51:09 +0000

Rudolf Adamkovič <[email-masked]> writes:

> Alvaro Ramirez <[email-masked]> writes:
>
>> Attaching the latest iteration of the patch (renamed
>> 0004-Add-Send-to-context-menu-item-to-mouse-el.patch)..
>
> Below are a couple of comments, if you are interested in 
> feedback.

Thank you Rudolf! I shall apply these in the next patch iteration.

>
>> * lisp/send-to.el: New package implements sending to apps or 
>> services.
>
> The verb sending needs an object, i.e. sending what?
>
>> +(non-Emacs) apps or services. See send-to.el for 
>> customisations.
>
> Two spaces should separate sentences.
>
>> + "Send item (region, buffer file, or dired files) to app or 
>> service")))
>
> Dired is a proper noun and so should be capitalized.
>
>> +(defgroup send-to nil
>> +  "Send files or text to external applications or services."
>> +  :group 'external
>> +  :version "31.1")
>
> Inconsistent terminology: the patch says "apps" everywhere else.
>
> (Personally, I am for saying "applications" everywhere.)
>
>> + (error "Don't know how to sende %s (adjust 
>> `send-to-handler-function')"
>
> A typo in the word send.
>
> Thank you for your work on the patch!
>
> Rudy