GNU bug report logs - #76112
gnupg-verify* crashes when stdin is not /dev/tty

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>, 76112 <at> debbugs.gnu.org, Christopher Baines <guix <at> cbaines.net>
Subject: bug#76112: [PATCH] gnupg: Automatically fallback to 'always policy when non-interactive.
Date: Thu, 27 Feb 2025 15:18:18 +0100

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Previously to this change, the 'guix refresh' download
> policy (--key-download)would default to 'interactive', which would throw a
> backtrace when guix was invoked with its stdin not connected to a peusdo
> terminal (tty).  This change makes the new default value 'auto' use
> interactive only in an interactive environment, with 'always' used as
> fallback.
>
> * doc/guix.texi (Invoking guix refresh): Adjust doc.
> * etc/completion/fish/guix.fish: Adjust accordingly.
> * etc/completion/zsh/_guix (_guix_list_installed_packages): Likewise.
> * guix/gnupg.scm (gnupg-verify*): Change default #:key-download argument value
> to 'auto.  Update doc.  Validate argument.  Raise an error in case read-line
> returns #<eof>.
> * guix/import/gnu.scm (gnu-package->sexp): <#:key-download>: Change default
> value to 'auto.
> * guix/import/gnu.scm (gnu->guix-package): <#:key-download>: Likewise.
> * guix/scripts/import/gnu.scm (%options): Add "auto" to accepted
> --key-download values.
> (%default-options): Set default key-download option to the 'auto value.
> (show-help): Update doc.
> * guix/scripts/refresh.scm (show-help): Update doc.
> (update-package) <#:key-download>: Change default value to 'auto.  Update doc.
> * guix/upstream.scm (download-tarball): <#:key-download>: Likewise.
> (package-update): Likewise.
>
> Fixes: https://issues.guix.gnu.org/76112
> Change-Id: Id1ca8fd6d453ca4bc5b372534445e3beab9133a8

LGTM, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.