GNU bug report logs - #76110
Broken i686 package on x86_64 since commit 28e4018e59

Previous Next

Full log

Message #11 received at 76110 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: David Elsing <david.elsing <at> posteo.net>
Cc: 76110 <at> debbugs.gnu.org, Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
Subject: Re: Broken i686 package on x86_64 since commit 28e4018e59
Date: Thu, 27 Feb 2025 15:43:12 +0100

Hi David,

David Elsing <david.elsing <at> posteo.net> skribis:

> diff --git a/guix/packages.scm b/guix/packages.scm
> index 78726b089ae..43125bac61a 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -1824,7 +1824,9 @@ (define (input-graft system)
>                          (return (graft
>                                    (origin orig)
>                                    (origin-output output)
> -                                  (replacement replacement)
> +                                  (replacement
> +                                   (with-parameters ((%current-system system))
> +                                     replacement))
>                                    (replacement-output output))))
>                        package output system)
>               (return #f))))
> @@ -1846,7 +1848,10 @@ (define (input-cross-graft target system)
>                 (return (graft
>                           (origin orig)
>                           (origin-output output)
> -                         (replacement replacement)
> +                         (replacement
> +                          (with-parameters ((%current-system system)
> +                                            (%current-target-system target))
> +                            replacement))
>                           (replacement-output output))))

I think we should apply this patch, it makes perfect sense.

And yes, passing #:system in the ‘arguments’ field is valid: it’s used
in a handful of packages.

David, would you be willing/able to send it as a proper patch to
guix-patches, ideally with a test?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.