From unknown Thu Jun 19 13:53:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#76110 <76110@debbugs.gnu.org> To: bug#76110 <76110@debbugs.gnu.org> Subject: Status: Broken i686 package on x86_64 since commit 28e4018e59 Reply-To: bug#76110 <76110@debbugs.gnu.org> Date: Thu, 19 Jun 2025 20:53:11 +0000 retitle 76110 Broken i686 package on x86_64 since commit 28e4018e59 reassign 76110 guix submitter 76110 Denis 'GNUtoo' Carikli severity 76110 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 19:17:45 2025 Received: (at submit) by debbugs.gnu.org; 7 Feb 2025 00:17:45 +0000 Received: from localhost ([127.0.0.1]:59910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgC40-0006ry-IR for submit@debbugs.gnu.org; Thu, 06 Feb 2025 19:17:44 -0500 Received: from lists.gnu.org ([2001:470:142::17]:41246) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tgC3x-0006rd-V9 for submit@debbugs.gnu.org; Thu, 06 Feb 2025 19:17:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgC3o-0006NY-Qw for bug-guix@gnu.org; Thu, 06 Feb 2025 19:17:33 -0500 Received: from cyberdimension.org ([2001:678:938:3ff::36] helo=rockpro64.cyberdimension.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1tgC3l-0005oq-GU; Thu, 06 Feb 2025 19:17:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=dkim; bh=TQ2mTKj2vx63/J6 5s72BCedo1YOmsXG9aydi4eLTE7Q=; h=subject:to:from:date; d=cyberdimension.org; b=MxLbOFfNk32r/6SArTWrg0Z7pcrCtXB1LVMLjhm8M5/krg uD2QooTlF6Q/Yn+YMplZudXYeEjVvDQmo4gRI0QMwVn2b2l9AodHIKaih5BTuMxleqJq4u OU/zj3TI7YY6NMP5g8PLDOoHUzbAgnFFxSnuLhyY5XO982p3xYJfUXY/fp5Wh2r85hJ8SB 9hq24pIN35qKkP+qkx8L7A3qSCXCQooDdBPx9djzYG8q55jzLhbu3pQBHPhFuigP8Av04T uI/8+31Tm5XLPm5/tSsjvM9sI8StMy51wJfRly9KZWHoghhu+1a62tJxbHEor3aoO3+FVD lR3SPJjNQG+EblhA== Received: from primary_laptop (localhost [127.0.0.1]) by rockpro64.cyberdimension.org (OpenSMTPD) with ESMTP id ffcb98fe; Fri, 7 Feb 2025 00:17:22 +0000 (UTC) Date: Fri, 7 Feb 2025 01:15:41 +0100 From: Denis 'GNUtoo' Carikli To: bug-guix@gnu.org, Ludovic =?UTF-8?B?Q291cnTDqHM=?= , David Elsing Subject: Broken i686 package on x86_64 since commit 28e4018e59 Message-ID: <20250207011541.4eecdd7a@primary_laptop> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/QsFdsRY9eaP9grgCu_taVoJ"; protocol="application/pgp-signature"; micalg=pgp-sha256 Received-SPF: pass client-ip=2001:678:938:3ff::36; envelope-from=GNUtoo@cyberdimension.org; helo=rockpro64.cyberdimension.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --Sig_/QsFdsRY9eaP9grgCu_taVoJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, I run a 32bit version of PostgreSQL that I compile with the package definition below: > ;; Copyright (C) 2024 Denis 'GNUtoo' Carikli > ;; > ;; This file is free software; you can redistribute it and/or modify > ;; it under the terms of the GNU General Public License as > ;; published by the Free Software Foundation; either version 3 of the > ;; License, or (at your option) any later version. > ;; > ;; This file is distributed in the hope that it will be useful, but > ;; WITHOUT ANY WARRANTY; without even the implied warranty of > ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > ;; GNU General Public License for more details. > ;; > ;; You should have received a copy of the GNU General Public License > ;; along with GNU Guix. If not, see . >=20 > (define-module (postgresql-i686-linux) > #:use-module (gnu packages databases) > #:use-module (guix packages) > #:use-module (guix utils)) >=20 > (define-public postgresql-14-i686-linux > (package > (inherit postgresql-14) > (name "postgresql-14-i686-linux") > (arguments > (ensure-keyword-arguments > (package-arguments postgresql-14) > '(#:system "i686-linux"))))) >=20 > (list postgresql-14-i686-linux) Here's why it is broken: > $ guix build -f postgresql-i686-linux.scm > [...] > /gnu/store/[...]-postgresql-14-i686-linux-14.13 > $ file /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql > /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql: > ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically > linked, interpreter > /gnu/store/[...]-glibc-2.39/lib/ld-linux.so.2, > $ ls -l /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql > -r-xr-xr-x 2 root root 674532 Jan 1 1970 > /gnu/store/jb8jdcyf8q4whlczhp76kdgpqs007jz9-postgresql-14-i686-linux-14.1= 3/bin/psql > $ /gnu/store/[...]-postgresql-14-i686-linux-14.13/bin/psql --help > bash: > /gnu/store/jb8jdcyf8q4whlczhp76kdgpqs007jz9-postgresql-14-i686-linux-14.1= 3/bin/psql: > No such file or directory Before the commit 28e4018e59d30efb3d52aa950ce2261f11b69b33, the same command printed the help of the psql program. So I bisected with the script below (ran manually, not with git bisect run): > #!/usr/bin/env bash > $(guix time-machine \ > --commit=3D$(git show HEAD --no-patch --pretty=3D"%H") -- \ > build -f \ > ~/work/setup/configs/packages/postgresql-i686-linux.scm )/bin/psql > --help And the process gave the commit 28e4018e59d30efb3d52aa950ce2261f11b69b33 ("grafts: Allow file-like objects in the =E2=80=98replacement=E2=80=99 fiel= d of ."). However I didn't look into how to repair the behavior above as I'm not familiar at all with the code that the 28e4018e59 patch touches. Denis. --Sig_/QsFdsRY9eaP9grgCu_taVoJ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmelUK0ACgkQX138wUF3 4mMikQ/+OLpxC82KSSMxjpy5cCdaumN3fYkJ8T1fmrHgtWjNcREPj6SMPH+icWBz V844jwfOGWZ+F2H5xbLpXlRzx1R0WKyPASwZF8v/OCDH9M1+2BgzUNj630iXyhdL FraUw7SB7+XA9bryvpG4iIkDRyzb5eGC5GpFtu3byhYI3Bi+Ma0/Pnfw11Rn6woB 9nTvchwsqQXYO1imBKbILtXgPJVDZFWze0ghpQSVqD9D0Jp0vJLpRIFtFMlcvFmN c1mLa9YXt3a36EKaeTMXG+WHnsZsD9D0wIieoiLgQCqxJQp0Xz45i+S6qFGgZ7cB Mk74HRDQxbiyxUXm7naloE1RCMJZH+YJQY5TZdl8pM/zSRfNiXT4wBfc7U7IbAZt rP3zRcDjZi8sAbpuikZeE+g8CrGwSQ1j6bHZh+mayUxMVngs0SX/4SpZ0Ron0Cgg 02yB6VqjndDp2/wJTS+FxZzq3FBieFvqzKRLpVoAlF/s7D9D5dTBaqhzRmb0d0YF +1pUgKqRAAa0szfTb/JCWmYJRRKWaHxooZaTB0wvCDEcpzQZUUfhweQm2Q++M/HE pj2766ofZvLGf5+Jp/RTau+SD6LC+Yrqa2JtkXpm0PYqgmp6t7zFx+bNQ8HtjqF4 K5JkAjHBye2lbuVgf7RnsCBVclD6nMICYzl7iNQ87FWnwneHYxc= =w0bJ -----END PGP SIGNATURE----- --Sig_/QsFdsRY9eaP9grgCu_taVoJ-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 08:01:40 2025 Received: (at 76110) by debbugs.gnu.org; 8 Feb 2025 13:01:40 +0000 Received: from localhost ([127.0.0.1]:39091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tgkSp-0008Ha-O8 for submit@debbugs.gnu.org; Sat, 08 Feb 2025 08:01:40 -0500 Received: from mout01.posteo.de ([185.67.36.65]:34359) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tgkSm-0008HJ-LI for 76110@debbugs.gnu.org; Sat, 08 Feb 2025 08:01:38 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9F0ED240028 for <76110@debbugs.gnu.org>; Sat, 8 Feb 2025 14:01:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1739019689; bh=fQmPVoPYNbxoAApP3Rxv7W/AumeCPCz24/uuQEDap3o=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=KSk7I2/LdDSc4A62zsk0oFWJSegUo7fM+Y5Cm89U7d0Wr4O1kUK/aYyGMjxSkEevY d9voL3KUo0aMhtooClo+KoTEgR5PKSk64lVnztpQR+kBVxOHVy6M9LRtl7tPyDSvVf 0BqH2ov0hJkk7aRUFCa7r6xQZ1i4mQcUtr3rrJeVBuOA7X/L51r6TwDY4NaNbybh0j PE5ZnL/uqh2Wngebtwz8fSC3cGzj6cGX+jeJRBgwOWVak0RC/vfB/8XHj5pDGNGTcd s24jjir05djGD1GYjs1xnmwoOV9KiBHOT+70cvLyaKvS2wzTVtseQhXGiLYdRq7pNJ 988jQ9ktWO+4A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YqrZJ5N0tz9rxK; Sat, 8 Feb 2025 14:01:28 +0100 (CET) From: David Elsing To: Denis 'GNUtoo' Carikli , 76110@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Broken i686 package on x86_64 since commit 28e4018e59 In-Reply-To: <20250207011541.4eecdd7a@primary_laptop> References: <20250207011541.4eecdd7a@primary_laptop> Date: Sat, 08 Feb 2025 13:01:26 +0000 Message-ID: <7y1pw8bnfd.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76110 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Denis 'GNUtoo' Carikli writes: > And the process gave the commit 28e4018e59d30efb3d52aa950ce2261f11b69b33 > ("grafts: Allow file-like objects in the =E2=80=98replacement=E2=80=99 fi= eld of > ."). > > However I didn't look into how to repair the behavior above as I'm not > familiar at all with the code that the 28e4018e59 patch touches. The problematic change with commit 28e4018e59 is that the 'system' argument in `input-graft' (and `system' and `target' in `input-cross-graft') is no longer respected for the replacement, such that the 'origin' and 'replacement' fields are built for a different system. Therefore, I would suggest to indeed add another wrapping by `with-parameters' to `input-graft' and `input-cross-graft' (but keeping the `with-parameters' wrapping which sets %grafts in `graft-derivation/shallow', even if it doesn't do anything yet [2]). Attached is a patch with the change. Unlike other parameters, for which `with-parameters' currently does not work with packages [2], `%current-system' and `%current-target-system' are treated specially and are working correctly. However, this still does not really solve the issue for your package: It still (correctly) calls `package->derivation' with the 'system' argument set to "x86_64-linux", which is then overridden by the #:system argument in the system package in `bag->derivation'. The same is not the case however for grafts, and `graft-derivation*' is still called with "x86_64-linux", which is arguably correct, but inconsistent with the #:system package argument. IIUC, this leads to grafts being missed, as some are calculated for "x86_64-linux" (which are not applicable) and some for "i686-linux". For reference, is setting #:system in a package even intended? It seems more coincidental to me that it works, as the #:system argument of a package overrides the previous #:system argument in `bag->derivation'. I think it makes more sense to use `with-parameters', which works correctly in this case (also without the new patch): --8<---------------cut here---------------start------------->8--- (with-parameters ((%current-system "i686-linux")) postgresql-14) --8<---------------cut here---------------end--------------->8--- Cheers, David [1] https://issues.guix.gnu.org/70895 [2] https://issues.guix.gnu.org/75879 --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=graft-replacement-system.patch diff --git a/guix/packages.scm b/guix/packages.scm index 78726b089ae..43125bac61a 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -1824,7 +1824,9 @@ (define (input-graft system) (return (graft (origin orig) (origin-output output) - (replacement replacement) + (replacement + (with-parameters ((%current-system system)) + replacement)) (replacement-output output)))) package output system) (return #f)))) @@ -1846,7 +1848,10 @@ (define (input-cross-graft target system) (return (graft (origin orig) (origin-output output) - (replacement replacement) + (replacement + (with-parameters ((%current-system system) + (%current-target-system target)) + replacement)) (replacement-output output)))) (return #f)))) (_ --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 09:43:25 2025 Received: (at 76110) by debbugs.gnu.org; 27 Feb 2025 14:43:25 +0000 Received: from localhost ([127.0.0.1]:33001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tnf6i-0002Ae-Tw for submit@debbugs.gnu.org; Thu, 27 Feb 2025 09:43:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47984) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tnf6g-00029z-QU for 76110@debbugs.gnu.org; Thu, 27 Feb 2025 09:43:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnf6Z-00006s-Ob; Thu, 27 Feb 2025 09:43:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=2vkyB8rp0lPrV88LqAlF7pXwoHvCSO/GDzh9G0zHQaY=; b=pYBrb9eG3HkCEyEgkOPS ejJiGRZCKnXG0QXM4LcQmfREttW1FdOsmM+r04Q5IZc7Y48vOM6zwsMaRbB7wdJLHEpJi6qviJkCY 0oPQkKL7es5QoH0sxPdh7WQ2JA6DEuLjxFM2AJsBeTnS7y5vHgvkUYQl3YFdwEo9LBGN2ntZMLge2 305d7A7PwwKTzgwtfTFdXDUCttAEi9nmbXoEYtdFk65VGbJiwiz/YUjmtfuRCa00v9RVak/h66D9k 0PXBIUIKAFdw9BZ1aY9+eLXnF0pfcZTG/XLRrIpVE6JsmAKTDG0xeRsarL2daL1Xg9hViE5buLvNO B8HAZQ2G4IcIGw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: David Elsing Subject: Re: Broken i686 package on x86_64 since commit 28e4018e59 In-Reply-To: <7y1pw8bnfd.fsf@posteo.net> (David Elsing's message of "Sat, 08 Feb 2025 13:01:26 +0000") References: <20250207011541.4eecdd7a@primary_laptop> <7y1pw8bnfd.fsf@posteo.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 =?utf-8?Q?Vent=C3=B4se?= an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Marsault X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 27 Feb 2025 15:43:12 +0100 Message-ID: <871pvjxxbz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76110 Cc: 76110@debbugs.gnu.org, Denis 'GNUtoo' Carikli X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi David, David Elsing skribis: > diff --git a/guix/packages.scm b/guix/packages.scm > index 78726b089ae..43125bac61a 100644 > --- a/guix/packages.scm > +++ b/guix/packages.scm > @@ -1824,7 +1824,9 @@ (define (input-graft system) > (return (graft > (origin orig) > (origin-output output) > - (replacement replacement) > + (replacement > + (with-parameters ((%current-system sy= stem)) > + replacement)) > (replacement-output output)))) > package output system) > (return #f)))) > @@ -1846,7 +1848,10 @@ (define (input-cross-graft target system) > (return (graft > (origin orig) > (origin-output output) > - (replacement replacement) > + (replacement > + (with-parameters ((%current-system system) > + (%current-target-system targ= et)) > + replacement)) > (replacement-output output)))) I think we should apply this patch, it makes perfect sense. And yes, passing #:system in the =E2=80=98arguments=E2=80=99 field is valid= : it=E2=80=99s used in a handful of packages. David, would you be willing/able to send it as a proper patch to guix-patches, ideally with a test? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 17:52:24 2025 Received: (at 76110) by debbugs.gnu.org; 2 Mar 2025 22:52:24 +0000 Received: from localhost ([127.0.0.1]:38481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tosAZ-0001Co-4v for submit@debbugs.gnu.org; Sun, 02 Mar 2025 17:52:23 -0500 Received: from mout02.posteo.de ([185.67.36.66]:45187) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tosAV-0001Bu-Ar for 76110@debbugs.gnu.org; Sun, 02 Mar 2025 17:52:20 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EA283240101 for <76110@debbugs.gnu.org>; Sun, 2 Mar 2025 23:52:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1740955932; bh=39sqNNmZ9Ea+QU8b8NO7p5jyXdT9RlVIs8tgLZOAtk4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=f0LJ+YlEbFQNlmWQvJyEvuRz+e6v3oQTaB1mbxShWqCMKACgU33OhDe5vqg7GHkpE sc2VvqjRQGNQs+h52b9XPhrcGlNPj8+kVrUYMTRaS8XjEWyc/2ebCxXd/BPRnohWPo LmEFVrSX7kNbbRyZDvCK0MKvaz62orZZWvwssrY4tVu0zK/Xq3s7ZWZ47nGpJlB1HS kPuXaNZQ+bK9QHIUUbzEamynBFtlhfuU2PVNSF2Q8j8NmK7dgyfJKzCs0BLEDc/yJV w0xZbF3SbkBbdbOHhyTaSBvQNmlJPq5WznHCL8CIMTwXCvUXd9ZKCekcLaAIzjOVFW rzptLkA4YnJ4g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Z5cdl0Lppz6twM; Sun, 2 Mar 2025 23:52:10 +0100 (CET) From: David Elsing To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Broken i686 package on x86_64 since commit 28e4018e59 In-Reply-To: <871pvjxxbz.fsf@gnu.org> References: <20250207011541.4eecdd7a@primary_laptop> <7y1pw8bnfd.fsf@posteo.net> <871pvjxxbz.fsf@gnu.org> Date: Sun, 02 Mar 2025 22:52:08 +0000 Message-ID: <86bjujxcyv.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76110 Cc: 76110@debbugs.gnu.org, Denis 'GNUtoo' Carikli X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Ludovic Court=C3=A8s writes: > David, would you be willing/able to send it as a proper patch to > guix-patches, ideally with a test? The patch is here: https://issues.guix.gnu.org/76694 I had to adjust other tests as well, because the replacement can now only be compared by lowering it to a derivation first. Best, David From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 10:18:38 2025 Received: (at 76110-done) by debbugs.gnu.org; 8 Mar 2025 15:18:38 +0000 Received: from localhost ([127.0.0.1]:56140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqvwj-0003Z4-23 for submit@debbugs.gnu.org; Sat, 08 Mar 2025 10:18:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44404) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqvwf-0003Yl-S4; Sat, 08 Mar 2025 10:18:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqvwY-0008Sg-Jf; Sat, 08 Mar 2025 10:18:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=j7g/TByDBJyZol2GIjhZklm7iKTNFhOubsotgz2SMY0=; b=AvtoHhX0/2kNthF3qSLT br/g61R7Ml+zlUEqVes+uYJs5r/1k6tYhjsnfO++1pBEsgRwkl2uvcA2n69RyfQOrozhHfMso0wFH 32miWqF1zd5vwn/kCG+RyiKROUekGM+pPrKsckPvDBkJreXpMYgylNt9gRhR2mcGUykOrfzvkR0h5 c7myocT4RWgct1wfcpsQaLZQpsWOEeLKiDdttrcucl3yeYMCKueGiQI8UvY9Tj0LFK/Io+eeBKPkL zXRWAeMJTmaYoo+yuMTqF5H1L6NersygsjN4bA6MXRqOTPdWnqj/fH9WBNKOCigMWQqBTCCnmTHYJ NG5oX4qpERlVuw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: David Elsing Subject: Re: [bug#76694] [PATCH] packages: Honor system and target system for graft replacements. In-Reply-To: <20250302224357.23572-1-david.elsing@posteo.net> (David Elsing's message of "Sun, 2 Mar 2025 22:43:30 +0000") References: <20250302224357.23572-1-david.elsing@posteo.net> Date: Sat, 08 Mar 2025 16:18:23 +0100 Message-ID: <8734fnv9ds.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 76110-done Cc: 76694-done@debbugs.gnu.org, 76110-done@debbugs.gnu.org, Denis 'GNUtoo' Carikli X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi David, David Elsing skribis: > * guix/packages.scm (input-graft, input-cross-graft): Wrap graft replacem= ent > in =E2=80=98with-parameters=E2=80=99. > * tests/packages.scm ("package-grafts, indirect grafts") > ("package-grafts, indirect grafts, propagated inputs") > ("package-grafts, same replacement twice") > ("package-grafts, dependency on several outputs") > ("replacement also grafted"): Adjust accordingly by comparing the replace= ment > after lowering to a derivation. > ("package-grafts, indirect grafts, #:system argument"): New test. > --- > The modified tests are now more expensive, because comparing the > replacements now needs to be done by comparing the resulting derivations > due to the wrapping in . This requires building the > original package. Applied, thanks for fixing it! I tweaked the commit log to include a reference to the bug report and to the reporter. Ludo=E2=80=99. From unknown Thu Jun 19 13:53:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 06 Apr 2025 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator