GNU bug report logs - #76107
Consider image specs when scanning for a column

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76107: closed (Consider image specs when scanning for a column)
Date: Sat, 05 Apr 2025 10:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 05 Apr 2025 13:30:32 +0300
with message-id <86o6xax5mf.fsf <at> gnu.org>
and subject line Re: bug#76107: Consider image specs when scanning for a column
has caused the debbugs.gnu.org bug report #76107,
regarding Consider image specs when scanning for a column
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76107: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76107
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Thuna <thuna.cing <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Consider image specs when scanning for a column
Date: Fri, 07 Feb 2025 00:29:38 +0100

[Message part 3 (text/plain, inline)]

This patch handles display specs within `scan_for_column', which mainly
works to handle it in `current-column' and `move-to-column', which then
effects the filling functions and commands, and visual-fill-column, and
so on.

The patch seems to be working, as far as I can tell, but it would be
nice if someone could take a look.  Specifically, I copied the code to
convert the Lisp_Object holding the width into an integer from the code
above handling the space display properties, so that needs
double-checking.

I decided to use `Fcar_safe' instead of `XCAR' when taking the `car' of
`Fimage_size' just to be safe but it doesn't look to be necessary?  If
that's fine, then feel free to make the change.

[0001-Consider-image-specs-when-scanning-for-a-column.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Thuna <thuna.cing <at> gmail.com>
Cc: 76107-done <at> debbugs.gnu.org
Subject: Re: bug#76107: Consider image specs when scanning for a column
Date: Sat, 05 Apr 2025 13:30:32 +0300

> From: Thuna <thuna.cing <at> gmail.com>
> Cc: 76107 <at> debbugs.gnu.org
> Date: Sat, 05 Apr 2025 10:38:01 +0200
> 
> > Did you have an opportunity to test the fixed code?  If there are no
> > problems with it you could report, I'd like to install the change.
> 
> Yes, I have been using it without any visible issues so far, so it
> should hopefully be good to go.

Thanks, now installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.