GNU bug report logs - #76081
OCI provisioning service

Previous Next

Full log

Message #203 received at 76081 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Giacomo Leidi <goodoldpaul <at> autistici.org>
Cc: Tanguy Le Carrour <tanguy <at> bioneland.org>,
 Ludovic Courtès <ludo <at> gnu.org>,
 Gabriel Wicki <gabriel <at> erlikon.ch>, Andrew Tropin <andrew <at> trop.in>,
 Hilton Chain <hako <at> ultrarare.space>, 76081 <at> debbugs.gnu.org,
 Janneke Nieuwenhuizen <janneke <at> gnu.org>
Subject: Re: [bug#76081] [PATCH v10 7/7] home: Add home-oci-service-type.
Date: Fri, 16 May 2025 11:07:46 +0900

Hi,

Giacomo Leidi <goodoldpaul <at> autistici.org> writes:

> * gnu/home/service/containers.scm: New file;
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (OCI backed services): Document it.

LGTM, but please break long lines so they fit in 80 columns.  This
shouldn't be merged until 6/7 has been understood; if it can be
eliminated this will need to be adjusted like:

--8<---------------cut here---------------start------------->8---
modified   gnu/home/services/containers.scm
@@ -32,16 +32,14 @@ (define home-oci-service-type
                 (extensions
                  (list
                   (service-extension home-profile-service-type
-                                     (oci-service-extension-wrap-validate
-                                      (lambda (config)
-                                        (let ((runtime-cli
-                                               (oci-configuration-runtime-cli config))
-                                              (runtime
-                                               (oci-configuration-runtime config)))
-                                          (oci-service-profile runtime runtime-cli)))))
+                                     (lambda (config)
+                                       (let ((runtime-cli
+                                              (oci-configuration-runtime-cli config))
+                                             (runtime
+                                              (oci-configuration-runtime config)))
+                                         (oci-service-profile runtime runtime-cli))))
                   (service-extension home-shepherd-service-type
-                                     (oci-service-extension-wrap-validate
-                                      oci-configuration->shepherd-services))))
+                                     oci-configuration->shepherd-services)))
                 (extend
                  (lambda (config extension)
                    (for-home
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.