GNU bug report logs - #76063
[PATCH 0/3] Switch to the Shepherd's system log

Previous Next

Full log

Message #44 received at 76063 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76063 <at> debbugs.gnu.org
Subject: Re: [bug#76063] [PATCH 1/3] services: Add ‘system-log’ Shepherd service.
Date: Fri, 14 Feb 2025 00:14:33 +0100

Hi!

I’ve sent v2, which addresses all the points you raised, with one
exception:

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

>> +                             ;; XXX: As of Shepherd 1.0.1,
>> +                             ;; 'default-message-destination-procedure' is not
>> +                             ;; exported, hence this conditional.
>
> Perhaps check if we have shepherd >= 1.0.2 (?) and put the
> forward-looking code in this case, with the other code path ready to be
> removed after some time, if it's easy to check for the shepherd version.
>
>> +                             #$@(match (system-log-configuration-message-destination
>> +                                        config)
>> +                                  (#f #~())
>> +                                  (value #~(#:message-destination #$value)))

I kept it as is because we cannot really do what you describe: the
conditional would need to go in the default value of
‘message-destination’, like:

  #~(if (defined? 'default-message-destination-procedure)
        (default-message-destination-procedure)
        #f)

But if we did that it’d be hard to not pass #:message-destination in the
#f case.

(Not sure if I’m being clear, I hope you get the idea. :-))

Thanks for looking at it!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.