GNU bug report logs - #76028
31; completing-read-multiple: Add prompt indicator

Previous Next

Full log

Message #56 received at 76028 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 76028 <at> debbugs.gnu.org, stefankangas <at> gmail.com, juri <at> linkov.net
Subject: Re: bug#76028: 31; completing-read-multiple: Add prompt indicator
Date: Fri, 07 Feb 2025 13:52:17 +0200

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Cc: Juri Linkov <juri <at> linkov.net>,  76028 <at> debbugs.gnu.org,
>   stefankangas <at> gmail.com
> Date: Fri, 07 Feb 2025 10:44:49 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I think this does have to be called out in NEWS, including the new
> > user option.  In a sense, this is an incompatible behavior change, so
> > we cannot introduce it silently.
> 
> Agree. I have attached an updated patch to this mail, where the change
> is announced in the NEWS.

Thanks, I have a few minor comments below.

> ++++

The "+++" marker means the manuals weer updated with this information,
which is not true in this case.  If you think this should be described
in the ELisp manual, please include a patch for that.  If you think
this is too minor to be in the manual, please mark the NEWS entry with
"---" instead.

> +*** New user option 'crm-prompt'.
> +This option configures the prompt of 'completing-read-multiple'. By
> +default the prompt indicates to the user that the completion accepts a
> +comma-separated list.

Two spaces between sentences, please.

More importantly, it sounds like you tried to describe both the
changes to 'completing-read-multiple' and the new option.  I think it
would be better to describe them in two separate entries.  In any
case, the entry for 'crm-prompt' should describe the default value.

>                         The variable 'crm-separator' carries the prompt
> +description and the separator string as text properties.

I didn't understand this sentence: what do you mean by "carries" here?
I guess a more detailed description is needed for this part.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.