Subject: [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 03 Feb 2025 22:08:10 +0900

Hello!

[email-masked] writes:

> From: 宋文武 <[email-masked]>
>
> Fixes <https://issues.guix.gnu.org/39126>.
>
> The cogl GStreamer sink has been broken:
>   <https://gitlab.gnome.org/Archive/cogl/-/issues/15>
>
> * gnu/packages/gnome.scm (cogl)[inputs]: Remove gstreamer and
> gst-plugins-base.
> [arguments]: Pass "--enable-cogl-gst=no" to configure-flags.

Awesome, you are fixing a 5 years old bug :-).  Nitpick, I'd used

--8<---------------cut here---------------start------------->8---
Fixes: <https://issues.guix.gnu.org/39126>
--8<---------------cut here---------------end--------------->8---

at the bottom of your git commit message, next to the Change-Id (these
are git trailers, must be placed at the bottom of the git message, see
'man git-interpret-trailers').

> Change-Id: I644da53effb52c6b6d8b1f9b6df293545fab963c
> ---
>  gnu/packages/gnome.scm | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 1225570c3c..1e8d813682 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -6308,12 +6308,10 @@ (define-public cogl
>       (list mesa
>             cairo
>             pango
> -           gstreamer
> -           gst-plugins-base
>             wayland))
>      (arguments
>       `(#:disallowed-references (,xorg-server-for-tests)
> -       #:configure-flags (list "--enable-cogl-gst"
> +       #:configure-flags (list "--enable-cogl-gst=no" ;broken and unmaintained
>                                 "--enable-wayland-egl-platform"
>                                 "--enable-wayland-egl-server"

That looks good to me, but reading
https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems
we should instead be removing cogl from the distribution, or at least
never propagating it, in which case the above flag would become
unnecessary.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

-- 
Thanks,
Maxim