GNU bug report logs - #76026
[PATCH] gnu: cogl: Disable gstreamer plugin.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76026 in the body.
You can then email your comments to 76026 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: cogl: Disable gstreamer plugin.
Date: Mon,  3 Feb 2025 14:32:52 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

Fixes <https://issues.guix.gnu.org/39126>.

The cogl GStreamer sink has been broken:
  <https://gitlab.gnome.org/Archive/cogl/-/issues/15>

* gnu/packages/gnome.scm (cogl)[inputs]: Remove gstreamer and
gst-plugins-base.
[arguments]: Pass "--enable-cogl-gst=no" to configure-flags.

Change-Id: I644da53effb52c6b6d8b1f9b6df293545fab963c
---
 gnu/packages/gnome.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1225570c3c..1e8d813682 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -6308,12 +6308,10 @@ (define-public cogl
      (list mesa
            cairo
            pango
-           gstreamer
-           gst-plugins-base
            wayland))
     (arguments
      `(#:disallowed-references (,xorg-server-for-tests)
-       #:configure-flags (list "--enable-cogl-gst"
+       #:configure-flags (list "--enable-cogl-gst=no" ;broken and unmaintained
                                "--enable-wayland-egl-platform"
                                "--enable-wayland-egl-server"
 

base-commit: 12619742365b4bc138853ff7d79053e2089ffe1e
-- 
2.48.1

Message #8 received at 76026 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: iyzsong <at> envs.net
Cc: 76026 <at> debbugs.gnu.org, Vivien Kraus <vivien <at> planete-kraus.eu>,
 宋文武 <iyzsong <at> member.fsf.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
Date: Mon, 03 Feb 2025 22:08:10 +0900

Hello!

iyzsong <at> envs.net writes:

> From: 宋文武 <iyzsong <at> member.fsf.org>
>
> Fixes <https://issues.guix.gnu.org/39126>.
>
> The cogl GStreamer sink has been broken:
>   <https://gitlab.gnome.org/Archive/cogl/-/issues/15>
>
> * gnu/packages/gnome.scm (cogl)[inputs]: Remove gstreamer and
> gst-plugins-base.
> [arguments]: Pass "--enable-cogl-gst=no" to configure-flags.

Awesome, you are fixing a 5 years old bug :-).  Nitpick, I'd used

--8<---------------cut here---------------start------------->8---
Fixes: <https://issues.guix.gnu.org/39126>
--8<---------------cut here---------------end--------------->8---

at the bottom of your git commit message, next to the Change-Id (these
are git trailers, must be placed at the bottom of the git message, see
'man git-interpret-trailers').

> Change-Id: I644da53effb52c6b6d8b1f9b6df293545fab963c
> ---
>  gnu/packages/gnome.scm | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 1225570c3c..1e8d813682 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -6308,12 +6308,10 @@ (define-public cogl
>       (list mesa
>             cairo
>             pango
> -           gstreamer
> -           gst-plugins-base
>             wayland))
>      (arguments
>       `(#:disallowed-references (,xorg-server-for-tests)
> -       #:configure-flags (list "--enable-cogl-gst"
> +       #:configure-flags (list "--enable-cogl-gst=no" ;broken and unmaintained
>                                 "--enable-wayland-egl-platform"
>                                 "--enable-wayland-egl-server"

That looks good to me, but reading
https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems
we should instead be removing cogl from the distribution, or at least
never propagating it, in which case the above flag would become
unnecessary.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #13 received at 76026-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 76026-done <at> debbugs.gnu.org, Vivien Kraus <vivien <at> planete-kraus.eu>,
 宋文武 <iyzsong <at> member.fsf.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
Date: Mon, 03 Feb 2025 22:09:26 +0800

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Awesome, you are fixing a 5 years old bug :-).  Nitpick, I'd used
>
> Fixes: <https://issues.guix.gnu.org/39126>

Done, thank you!

> [...]
> That looks good to me, but reading
> https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems
> we should instead be removing cogl from the distribution, or at least
> never propagating it, in which case the above flag would become
> unnecessary.

Yes, It's propagated and needed by clutter, which still required by 22
packages.  GNOME propagated it by cheese, where cheese.pc does requires
cluster.  So I think remove the cogl gst plugin is right thing to do
here.

Message #16 received at 76026-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 宋文武 <iyzsong <at> envs.net>
Cc: 76026-done <at> debbugs.gnu.org, Vivien Kraus <vivien <at> planete-kraus.eu>,
 宋文武 <iyzsong <at> member.fsf.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
Date: Tue, 04 Feb 2025 11:21:00 +0900

Hi,

宋文武 <iyzsong <at> envs.net> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> Awesome, you are fixing a 5 years old bug :-).  Nitpick, I'd used
>>
>> Fixes: <https://issues.guix.gnu.org/39126>
>
> Done, thank you!
>
>> [...]
>> That looks good to me, but reading
>> https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems
>> we should instead be removing cogl from the distribution, or at least
>> never propagating it, in which case the above flag would become
>> unnecessary.
>
> Yes, It's propagated and needed by clutter, which still required by 22
> packages.  GNOME propagated it by cheese, where cheese.pc does requires
> cluster.  So I think remove the cogl gst plugin is right thing to do
> here.

cheese has been replaced by snapshot, so we should remove it from the
gnome core applications [0]

[0]  https://gitlab.gnome.org/Teams/Releng/AppOrganization/-/issues/8#note_1820268

-- 
Thanks,
Maxim

Message #19 received at 76026-done <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 
 宋文武 <iyzsong <at> envs.net>
Cc: 76026-done <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> member.fsf.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
Date: Tue, 04 Feb 2025 06:46:58 +0100

Hello,

Le mardi 04 février 2025 à 11:21 +0900, Maxim Cournoyer a écrit :
> cheese has been replaced by snapshot,

As far as I understand, snapshot is Rust, so I understand why we would
want to keep cheese around also.

Best regards,

Vivien

Message #22 received at 76026-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 76026-done <at> debbugs.gnu.org,
 宋文武 <iyzsong <at> member.fsf.org>,
 宋文武 <iyzsong <at> envs.net>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
Date: Wed, 05 Feb 2025 10:58:45 +0900

Hi,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> Hello,
>
> Le mardi 04 février 2025 à 11:21 +0900, Maxim Cournoyer a écrit :
>> cheese has been replaced by snapshot,
>
> As far as I understand, snapshot is Rust, so I understand why we would
> want to keep cheese around also.

GNOME already pulls librsvg, which is rust-written as well, so it's not
that big of deal; especially since it can be conditionally added via
(supported-package? snapshot).  The bigger deal is getting it packaged
:-).

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.