GNU bug report logs - #76016
[PATCH] Correct project-remember/forget-projects-under message grammar

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#76016: closed ([PATCH] Correct project-remember/forget-projects-under
 message grammar)
Date: Tue, 11 Feb 2025 07:53:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 10 Feb 2025 23:52:05 -0800
with message-id <CADwFkmnnwgOx9QWbDpxd2cBKYyLuoQZavfLYQFM=nMZa3zvRFA <at> mail.gmail.com>
and subject line Re: bug#76016: [PATCH] Correct project-remember/forget-projects-under message grammar
has caused the debbugs.gnu.org bug report #76016,
regarding [PATCH] Correct project-remember/forget-projects-under message grammar
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
76016: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76016
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Correct project-remember/forget-projects-under message grammar
Date: Sun, 2 Feb 2025 12:02:17 -0500

[Message part 3 (text/plain, inline)]

Correct grammar for the singular case. Rather than "1 projects were found",
say "1 project was found". Ditto for forgotten.

-Stephane

[Message part 4 (text/html, inline)]

[0001-Correct-project-remember-forget-projects-under-messa.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 76016-done <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#76016: [PATCH] Correct project-remember/forget-projects-under
 message grammar
Date: Mon, 10 Feb 2025 23:52:05 -0800

Version: 31.1

Ship Mints <shipmints <at> gmail.com> writes:

> In any case, here's a revised patch with ngettext.
>
> On Sun, Feb 2, 2025 at 12:44 PM Ship Mints <shipmints <at> gmail.com> wrote:
>
>  Alright. Does ngettext accommodate the zero case or just singular and plural? It seems to
>  respect only two choices.
>
>      (if (zerop count)
>          (message "No projects were found")
>        (project--write-project-list)
>        (message (ngettext "%d project was found"
>                           "%d projects were found"
>                           count) count))
>
>  vs. which could be a useful variant:
>
>      (when (> count 0)
>        (project--write-project-list))
>      (message (ngettext "No projects were found"
>                         "%d project was found"
>                         "%d projects were found"
>                         count) count)
>
>  On Sun, Feb 2, 2025 at 12:29 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>  > From: Ship Mints <shipmints <at> gmail.com>
>  > Date: Sun, 2 Feb 2025 12:02:17 -0500
>  >
>  > Correct grammar for the singular case. Rather than "1 projects were found", say "1
>  project was found". Ditto
>  > for forgotten.
>
>  Neither is correct, because they hard-code English grammar.  We should
>  use ngettext instead.

Thanks, installed on master as commit b2d2ad58ea4.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.