Subject: Re: bug#76016: [PATCH] Correct project-remember/forget-projects-under message grammar

From: Stefan Kangas <[email-masked]>
Date: Mon, 10 Feb 2025 23:52:05 -0800

Version: 31.1

Ship Mints <[email-masked]> writes:

> In any case, here's a revised patch with ngettext.
>
> On Sun, Feb 2, 2025 at 12:44 PM Ship Mints <[email-masked]> wrote:
>
>  Alright. Does ngettext accommodate the zero case or just singular and plural? It seems to
>  respect only two choices.
>
>      (if (zerop count)
>          (message "No projects were found")
>        (project--write-project-list)
>        (message (ngettext "%d project was found"
>                           "%d projects were found"
>                           count) count))
>
>  vs. which could be a useful variant:
>
>      (when (> count 0)
>        (project--write-project-list))
>      (message (ngettext "No projects were found"
>                         "%d project was found"
>                         "%d projects were found"
>                         count) count)
>
>  On Sun, Feb 2, 2025 at 12:29 PM Eli Zaretskii <[email-masked]> wrote:
>
>  > From: Ship Mints <[email-masked]>
>  > Date: Sun, 2 Feb 2025 12:02:17 -0500
>  >
>  > Correct grammar for the singular case. Rather than "1 projects were found", say "1
>  project was found". Ditto
>  > for forgotten.
>
>  Neither is correct, because they hard-code English grammar.  We should
>  use ngettext instead.

Thanks, installed on master as commit b2d2ad58ea4.  Closing.