GNU bug report logs - #76014
31.0.50; Wrong highlighting of "All" in mode-line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 76014 in the body.
You can then email your comments to 76014 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 31.0.50; Wrong highlighting of "All" in mode-line
Date: Sun, 02 Feb 2025 17:03:14 +0100

With master, emacs -Q. Move the mouse to the "All" displayed in the
mode-line. The last 'l' is not highlighted.

This seems to be the case for a longer time.
cb0b6a405706f6367d9adfb3ee447590c2a0876f from around 4 months ago
already shows this. Emacs 30 works as expected.

Sorry, I can't bisect this at the moment.

Message #8 received at 76014 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 76014 <at> debbugs.gnu.org
Subject: Re: bug#76014: 31.0.50; Wrong highlighting of "All" in mode-line
Date: Sun, 02 Feb 2025 18:51:17 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Date: Sun, 02 Feb 2025 17:03:14 +0100
> 
> With master, emacs -Q. Move the mouse to the "All" displayed in the
> mode-line. The last 'l' is not highlighted.
> 
> This seems to be the case for a longer time.
> cb0b6a405706f6367d9adfb3ee447590c2a0876f from around 4 months ago
> already shows this. Emacs 30 works as expected.
> 
> Sorry, I can't bisect this at the moment.

It happened sometime in August last year, so my prime suspect is
71505b723c9fb9de20f6d38be7c73d595e9be3ce, since that part of the mode
line uses 'min-width' display property.

Message #11 received at 76014 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76014 <at> debbugs.gnu.org
Subject: Re: bug#76014: 31.0.50; Wrong highlighting of "All" in mode-line
Date: Mon, 03 Feb 2025 06:53:00 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
>> Date: Sun, 02 Feb 2025 17:03:14 +0100
>> 
>> With master, emacs -Q. Move the mouse to the "All" displayed in the
>> mode-line. The last 'l' is not highlighted.
>> 
>> This seems to be the case for a longer time.
>> cb0b6a405706f6367d9adfb3ee447590c2a0876f from around 4 months ago
>> already shows this. Emacs 30 works as expected.
>> 
>> Sorry, I can't bisect this at the moment.
>
> It happened sometime in August last year, so my prime suspect is
> 71505b723c9fb9de20f6d38be7c73d595e9be3ce, since that part of the mode
> line uses 'min-width' display property.

Confirmed, 71505b723c9fb9de20f6d38be7c73d595e9be3ce it is.

Message #14 received at 76014 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76014 <at> debbugs.gnu.org
Subject: Re: bug#76014: 31.0.50; Wrong highlighting of "All" in mode-line
Date: Mon, 03 Feb 2025 07:40:33 +0100

Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:

> Confirmed, 71505b723c9fb9de20f6d38be7c73d595e9be3ce it is.

Don't know if this is directly related, but playing with

  (defun foo ()
    (interactive)
    (with-current-buffer (get-buffer-create "*foo*")
      (erase-buffer)
      (insert "12345")
      (put-text-property (point-min) (point)
                         'display '(min-width (5)))
      (put-text-property (point-min) (point)
                         'mouse-face 'highlight)
      (insert "abc")
      (display-buffer (current-buffer))))

shows that if the text, in this case "12345", is longer than min-width, a
space is added, and if it's equal to min-width, no space is added.

Message #17 received at 76014 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76014 <at> debbugs.gnu.org
Subject: Re: bug#76014: 31.0.50; Wrong highlighting of "All" in mode-line
Date: Tue, 04 Feb 2025 06:12:57 +0100

[Message part 1 (text/plain, inline)]

Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:

> Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
>
>> Confirmed, 71505b723c9fb9de20f6d38be7c73d595e9be3ce it is.
>
> Don't know if this is directly related, but playing with
>
>   (defun foo ()
>     (interactive)
>     (with-current-buffer (get-buffer-create "*foo*")
>       (erase-buffer)
>       (insert "12345")
>       (put-text-property (point-min) (point)
>                          'display '(min-width (5)))
>       (put-text-property (point-min) (point)
>                          'mouse-face 'highlight)
>       (insert "abc")
>       (display-buffer (current-buffer))))
>
> shows that if the text, in this case "12345", is longer than min-width, a
> space is added, and if it's equal to min-width, no space is added.

That attached patch fixes both the above problem and the the one in the
mode-line.

[0001-Fix-min-width-display-spec-handling-bug-76014.patch (text/x-patch, attachment)]

Message #20 received at 76014 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gerd Möllmann <gerd.moellmann <at> gmail.com>
Cc: 76014 <at> debbugs.gnu.org
Subject: Re: bug#76014: 31.0.50; Wrong highlighting of "All" in mode-line
Date: Tue, 04 Feb 2025 15:46:42 +0200

> From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
> Cc: 76014 <at> debbugs.gnu.org
> Date: Tue, 04 Feb 2025 06:12:57 +0100
> 
> Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
> 
> > Gerd Möllmann <gerd.moellmann <at> gmail.com> writes:
> >
> >> Confirmed, 71505b723c9fb9de20f6d38be7c73d595e9be3ce it is.
> >
> > Don't know if this is directly related, but playing with
> >
> >   (defun foo ()
> >     (interactive)
> >     (with-current-buffer (get-buffer-create "*foo*")
> >       (erase-buffer)
> >       (insert "12345")
> >       (put-text-property (point-min) (point)
> >                          'display '(min-width (5)))
> >       (put-text-property (point-min) (point)
> >                          'mouse-face 'highlight)
> >       (insert "abc")
> >       (display-buffer (current-buffer))))
> >
> > shows that if the text, in this case "12345", is longer than min-width, a
> > space is added, and if it's equal to min-width, no space is added.
> 
> That attached patch fixes both the above problem and the the one in the
> mode-line.

Thanks, feel free to install.

Message #23 received at 76014 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 76014 <at> debbugs.gnu.org
Subject: Re: bug#76014: 31.0.50; Wrong highlighting of "All" in mode-line
Date: Tue, 04 Feb 2025 15:45:14 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks, feel free to install.

Pushed and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.