Subject: Re: [bug#76001] [PATCH] gnu: Add jool.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 12 Feb 2025 10:54:40 +0100

Ashish SHUKLA <[email-masked]> skribis:

> * gnu/packages/networking.scm (jool): Add jool.
>
> Change-Id: Ic517fc8c4afbb964363ec68b3d89ce9fcd00c7d8

[...]

> +                    (out (assoc-ref outputs "out"))
> +                    (module-dir (string-append
> +                                 (assoc-ref outputs "module")
> +                                 "/lib/modules")))

I’d suggest using #$output and #$output:module throughout.

> +    (home-page "https://nicmx.github.io/Jool/")
> +    (synopsis "SIIT and NAT64 implementation for Linux")
> +    (description "Jool implements SIIT and NAT64 for Linux.")

Could you expand the description as per
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>?
You should probably make it clear that the package provides a kernel
module.

Thanks in advance,
Ludo’.