GNU bug report logs - #75966
[PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess.

Previous Next

Package: guix-patches;

Reported by: iyzsong <at> envs.net

Date: Fri, 31 Jan 2025 10:32:01 UTC

Severity: normal

Tags: patch

Full log


Message #71 received at 75966 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: iyzsong <at> envs.net
Cc: 宋文武 <iyzsong <at> member.fsf.org>, 75966 <at> debbugs.gnu.org
Subject: Re: [bug#75966] [PATCH v3 10/10] gnu: qutebrowser: Do not wrap with
 QTWEBENGINEPROCESS_PATH.
Date: Tue, 04 Feb 2025 00:19:27 +0900
Hi,

iyzsong <at> envs.net writes:

> From: 宋文武 <iyzsong <at> member.fsf.org>
>
> * gnu/packages/web-browsers.scm (qutebrowser): [arguments]: Remove
> QTWEBENGINEPROCESS_PATH from the 'wrap-qt-process-path phase.
>

[...]

This one and the other before LGTM, with the same nitpicks about the GNU
change log style. 

--8<---------------cut here---------------start------------->8---
Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
--8<---------------cut here---------------end--------------->8---

By the way, I notice that sending the cover letter on each submission is
useful, as I could then put my reviewed-by trailer on the 0/N commit
(the cover letter) to mean 'whole series LGTM', at least per 'b4 shazam'
semantic, which will add the trailer for you if you use it to apply the
patches.

--
Thanks,
Maxim




This bug report was last modified 136 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.