From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 05:31:44 2025 Received: (at submit) by debbugs.gnu.org; 31 Jan 2025 10:31:45 +0000 Received: from localhost ([127.0.0.1]:50121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdoJG-0001ie-VH for submit@debbugs.gnu.org; Fri, 31 Jan 2025 05:31:44 -0500 Received: from lists.gnu.org ([2001:470:142::17]:53412) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdoJB-0001iG-U5 for submit@debbugs.gnu.org; Fri, 31 Jan 2025 05:31:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdoJ6-0008ME-9m for guix-patches@gnu.org; Fri, 31 Jan 2025 05:31:28 -0500 Received: from mail.envs.net ([5.199.136.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdoJ3-0006P1-FS for guix-patches@gnu.org; Fri, 31 Jan 2025 05:31:27 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 89C6338A3E59; Fri, 31 Jan 2025 10:31:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1OSb__qVpCtB; Fri, 31 Jan 2025 10:31:16 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Fri, 31 Jan 2025 10:31:16 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 51220bde; Fri, 31 Jan 2025 10:34:54 +0000 (UTC) From: iyzsong@envs.net To: guix-patches@gnu.org Subject: [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. Date: Fri, 31 Jan 2025 18:34:50 +0800 Message-ID: X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Debbugs-Cc: Maxim Cournoyer , 宋文武 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=5.199.136.28; envelope-from=iyzsong@envs.net; helo=mail.envs.net X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URI_NOVOWEL=0.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: 宋文武 * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source phase. [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. * g [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom;id=iyzsong%40envs.net;ip=2001%3A470%3A142%3A%3A17;r=debbugs.gnu.org] 0.5 URI_NOVOWEL URI: URI hostname has long non-vowel sequence X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) From: 宋文武 * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source phase. [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. * gnu/packages/ebook.scm (calibre) * gnu/packages/education.scm (anki) * gnu/packages/kde-internet.scm (falkon) * gnu/packages/kde-systemtools.scm (khelpcenter) * gnu/packages/kde.scm (akregator) * gnu/packages/video.scm (openshot) * gnu/packages/vpn.scm (openconnect-sso) * gnu/packages/web-browsers.scm (qutebrowser) * gnu/packages/web.scm (kiwix-desktop): Remove wrapper for QTWEBENGINEPROCESS_PATH. Change-Id: I43745969ce80daa0f077da37671d1b44a468c953 --- gnu/packages/ebook.scm | 21 +-------------------- gnu/packages/education.scm | 13 +++---------- gnu/packages/kde-internet.scm | 13 ------------- gnu/packages/kde-systemtools.scm | 10 +--------- gnu/packages/kde.scm | 13 +------------ gnu/packages/qt.scm | 22 ++++++++-------------- gnu/packages/video.scm | 14 +------------- gnu/packages/vpn.scm | 12 +----------- gnu/packages/web-browsers.scm | 10 ++-------- gnu/packages/web.scm | 10 +--------- 10 files changed, 19 insertions(+), 119 deletions(-) diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm index 0cd2b31724..73fea2f66a 100644 --- a/gnu/packages/ebook.scm +++ b/gnu/packages/ebook.scm @@ -320,26 +320,7 @@ (define-public calibre (string-append #$(this-package-input "font-liberation") "/share/fonts/truetype"))) (delete-file-recursively font-dest) - (symlink font-src font-dest)))) - ;; Make run-time dependencies available to the binaries. - (add-after 'wrap 'wrap-program - (lambda* (#:key inputs #:allow-other-keys) - (with-directory-excursion (string-append #$output "/bin") - (for-each - (lambda (binary) - (wrap-program binary - ;; Make QtWebEngineProcess available. - `("QTWEBENGINEPROCESS_PATH" = - ,(list - (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))))) - ;; Wrap all the binaries shipping with the package, except - ;; for the wrappings created during the 'wrap standard - ;; phase. This extends existing .calibre-real wrappers - ;; rather than create ..calibre-real-real-s. For more - ;; information see: https://issues.guix.gnu.org/43249. - (find-files "." (lambda (file stat) - (not (wrapped-program? file))))))))))) + (symlink font-src font-dest))))))) (home-page "https://calibre-ebook.com/") (synopsis "E-book library management software") (description "Calibre is an e-book library manager. It can view, convert diff --git a/gnu/packages/education.scm b/gnu/packages/education.scm index f42a216972..f0c0e931bf 100644 --- a/gnu/packages/education.scm +++ b/gnu/packages/education.scm @@ -836,18 +836,11 @@ (define-public anki (filter (match-lambda ((label . _) (string-prefix? "python-" label))) - inputs))) - (qtwebengineprocess - (search-input-file inputs - "lib/qt5/libexec/QtWebEngineProcess"))) - ;; The program fails to find the QtWebEngineProcess program, so - ;; we set QTWEBENGINEPROCESS_PATH to help it. PYTHONPATH is - ;; wrapped to avoid declaring Python libraries as propagated - ;; inputs. + inputs)))) + ;; PYTHONPATH is wrapped to avoid declaring Python libraries as + ;; propagated inputs. (for-each (lambda (program) (wrap-program program - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengineprocess)) `("PATH" prefix (,(string-append (assoc-ref inputs "mpv") "/bin"))) diff --git a/gnu/packages/kde-internet.scm b/gnu/packages/kde-internet.scm index 4bf40afe88..d54126ed12 100644 --- a/gnu/packages/kde-internet.scm +++ b/gnu/packages/kde-internet.scm @@ -130,19 +130,6 @@ (define-public falkon (base32 "0j930i2nvg71p05z881inbk59c54gx8dzhyjb8iaqkw8i5s5r983")))) (build-system qt-build-system) - (arguments - (list #:phases - #~(modify-phases %standard-phases - (add-after 'install 'wrap - (lambda* (#:key inputs outputs #:allow-other-keys) - (let ((qtwebengineprocess - (search-input-file inputs - "lib/qt6/libexec/QtWebEngineProcess"))) - ;; The program fails to find the QtWebEngineProcess program, so - ;; we set QTWEBENGINEPROCESS_PATH to help it. - (wrap-program (string-append #$output "/bin/falkon") - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengineprocess))))))))) (native-inputs (list extra-cmake-modules pkg-config qttools)) (inputs diff --git a/gnu/packages/kde-systemtools.scm b/gnu/packages/kde-systemtools.scm index 4923854a7c..a86b550a7f 100644 --- a/gnu/packages/kde-systemtools.scm +++ b/gnu/packages/kde-systemtools.scm @@ -178,15 +178,7 @@ (define-public khelpcenter PrintSupport") (("Qt6::WebEngineWidgets") "Qt6::PrintSupport - Qt6::WebEngineWidgets")))) - (add-after 'install 'wrap-executable - (lambda* (#:key inputs #:allow-other-keys) - (wrap-program (string-append #$output - "/bin/khelpcenter") - `("QTWEBENGINEPROCESS_PATH" = - (,(search-input-file - inputs - "lib/qt6/libexec/QtWebEngineProcess"))))))))) + Qt6::WebEngineWidgets"))))))) (home-page "https://apps.kde.org/khelpcenter/") (synopsis "KDE documentation viewer") (description "KHelpCenter uses meta data files which describe the diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm index 765176f42b..9a4115eda6 100644 --- a/gnu/packages/kde.scm +++ b/gnu/packages/kde.scm @@ -205,18 +205,7 @@ (define-public akregator (base32 "07flc3617px9w1c729p0lsixf1g0h297hkbip259ykkbwxizn71q")))) (build-system qt-build-system) (arguments - (list #:qtbase qtbase - #:phases - #~(modify-phases %standard-phases - (add-after 'install 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/akregator")) - (qt-process-path - (search-input-file - inputs "/lib/qt6/libexec/QtWebEngineProcess"))) - (wrap-program bin - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + (list #:qtbase qtbase)) (native-inputs (list extra-cmake-modules kdoctools)) (inputs diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 76c11af543..c29f8e14e7 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -3415,7 +3415,10 @@ (define-public qtwebengine-5 "/share/qt5/translations\")")) (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") (string-append "QLatin1String(\"" #$output - "/share/qt5\")"))) + "/share/qt5\")")) + (("QLibraryInfo::location\\(QLibraryInfo::LibraryExecutablesPath)") + (string-append "QLatin1String(\"" #$output + "/lib/qt5/libexec\")"))) ;; Substitute full dynamic library path for nss. (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") @@ -3453,12 +3456,6 @@ (define-public qtwebengine-5 ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH ;; before running tests. ((#:tests? _ #f) #f))) - (native-search-paths - (list (search-path-specification - (file-type 'regular) - (separator #f) - (variable "QTWEBENGINEPROCESS_PATH") - (files '("lib/qt5/libexec/QtWebEngineProcess"))))) (home-page "https://wiki.qt.io/QtWebEngine") (synopsis "Qt WebEngine module") (description "The Qt5WebEngine module provides support for web applications @@ -3824,7 +3821,10 @@ (define-public qtwebengine "/share/qt6/translations\")")) (("QLibraryInfo::path\\(QLibraryInfo::DataPath)") (string-append "QLatin1String(\"" #$output - "/share/qt6\")"))) + "/share/qt6\")")) + (("QLibraryInfo::path\\(QLibraryInfo::LibraryExecutablesPath)") + (string-append "QLatin1String(\"" #$output + "/lib/qt6/libexec\")"))) ;; Substitute full dynamic library path for nss. (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") @@ -3884,12 +3884,6 @@ (define-public qtwebengine (replace "qtbase" qtbase) (replace "qtdeclarative" qtdeclarative) (replace "qtwebchannel" qtwebchannel))) - (native-search-paths - (list (search-path-specification - (file-type 'regular) - (separator #f) - (variable "QTWEBENGINEPROCESS_PATH") - (files '("lib/qt6/libexec/QtWebEngineProcess"))))) (home-page "https://wiki.qt.io/QtWebEngine") (synopsis "Qt WebEngine module") (description "The Qt WebEngine module provides support for web diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index d0b5907bdd..4881f6ba64 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -6049,19 +6049,7 @@ (define-public openshot (lambda _ ;; src/classes/info.py "needs" to create several ;; directories in $HOME when loaded during build - (setenv "HOME" "/tmp"))) - (add-after 'install 'wrap-program - (lambda* (#:key outputs inputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out")) - (qtwebengine-process-path - (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-qt-program "openshot-qt" - #:output out #:inputs inputs) - ;; Help the program discover QtWebEngine at runtime. - (wrap-program (string-append out "/bin/openshot-qt") - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengine-process-path))))))))) + (setenv "HOME" "/tmp")))))) (home-page "https://www.openshot.org/") (synopsis "Video editor") (description "OpenShot takes your videos, photos, and music files and diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 0b62e8c7cf..b64617c5df 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -800,17 +800,7 @@ (define-public openconnect-sso (("\"openconnect\"") (string-append "\"" (search-input-file inputs "/sbin/openconnect") - "\""))))) - (add-after 'check 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/openconnect-sso")) - (qt-process-path - (search-input-file inputs - "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-program bin - #:sh (search-input-file inputs "bin/bash") - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + "\"")))))))) (inputs (list openconnect poetry diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm index c0138eea17..5159a3b76d 100644 --- a/gnu/packages/web-browsers.scm +++ b/gnu/packages/web-browsers.scm @@ -490,10 +490,7 @@ (define-public qutebrowser python-pyyaml python-pyqt-6 python-pyqtwebengine-6 - python-tldextract - ;; While qtwebengine is provided by python-pyqtwebengine-6, it's - ;; included here so we can wrap QTWEBENGINEPROCESS_PATH. - qtwebengine)) + python-tldextract)) (arguments `(;; FIXME: With the existence of qtwebengine, tests can now run. But ;; they are still disabled because test phase hangs. It's not readily @@ -547,10 +544,7 @@ (define-public qutebrowser (wrap-program (search-input-file outputs "bin/qutebrowser") `("QTWEBENGINE_RESOURCES_PATH" = (,(search-input-directory - inputs "/share/qt6/resources"))) - `("QTWEBENGINEPROCESS_PATH" = - (,(search-input-file - inputs "/lib/qt6/libexec/QtWebEngineProcess"))))))))) + inputs "/share/qt6/resources"))))))))) (home-page "https://qutebrowser.org/") (synopsis "Minimal, keyboard-focused, vim-like web browser") (description "qutebrowser is a keyboard-focused browser with a minimal diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index a23a0f3dcd..0cf1c18a56 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -9404,15 +9404,7 @@ (define-public kiwix-desktop (lambda* (#:key outputs #:allow-other-keys) (invoke "qmake" (string-append "PREFIX=" - (assoc-ref outputs "out"))))) - (add-after 'install 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/kiwix-desktop")) - (qt-process-path (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-program bin - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + (assoc-ref outputs "out")))))))) (inputs (list bash-minimal curl base-commit: bdd6760b8c46e59f86415d67981acb6f77e9ed22 -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 05:35:34 2025 Received: (at 75966) by debbugs.gnu.org; 31 Jan 2025 10:35:35 +0000 Received: from localhost ([127.0.0.1]:50133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdoN4-0001vw-II for submit@debbugs.gnu.org; Fri, 31 Jan 2025 05:35:34 -0500 Received: from mail.envs.net ([5.199.136.28]:41042) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdoN2-0001vj-9v for 75966@debbugs.gnu.org; Fri, 31 Jan 2025 05:35:32 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 72CA738A3E53; Fri, 31 Jan 2025 10:35:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3G4CE3hx_nIa; Fri, 31 Jan 2025 10:35:27 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Fri, 31 Jan 2025 10:35:26 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 602f7d80; Fri, 31 Jan 2025 10:39:07 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: 75966@debbugs.gnu.org Subject: Re: [bug#75966] [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: (iyzsong@envs.net's message of "Fri, 31 Jan 2025 18:34:50 +0800") References: Date: Fri, 31 Jan 2025 18:39:07 +0800 Message-ID: <87wmebz2r8.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) iyzsong@envs.net writes: > * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: > Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source phase. > [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. Haven't build qtwebengine, so not tested, but I think it should work.. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 08:24:48 2025 Received: (at 75966) by debbugs.gnu.org; 31 Jan 2025 13:24:48 +0000 Received: from localhost ([127.0.0.1]:50506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdr0q-0004av-37 for submit@debbugs.gnu.org; Fri, 31 Jan 2025 08:24:48 -0500 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:42034) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tdr0m-0004af-NH for 75966@debbugs.gnu.org; Fri, 31 Jan 2025 08:24:45 -0500 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-216395e151bso24242745ad.0 for <75966@debbugs.gnu.org>; Fri, 31 Jan 2025 05:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738329878; x=1738934678; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ogkgzjtWHbCJsAbhsFm/psDmx9AAhxm5Ru/y31w9lBI=; b=LN5LNQTvymPiV+COp0l4oFshDLgm8Dcxh3NHLyPOUxjIbJhgMbX1FE7MrhY9G2UBA2 +08eodhiPtC7PLlvGmpdHYa3d4KrjCh4+PJRt3DI2fgcL0enxwDgPA2kZ0f+jS2FHSXk iLPkg8D0NjC+LoqqK2nhurEi2j1exLF6KShv3rdBkXzqH92UXJLIZUVCKnGBd9BE0xGC R2q8AOYi2Zchvfc7RyUfdnNzkwHtQlvqMGPD90yuzcdbV5cidqhPAlpvgD5qv5Vj97ZF kNBQeRogF6Q42/AZjEJ9hkrVfkcl6T4m8zIJp51IIC3t2cfe8RqW/wJvAnZQzD8rM3tj 9pqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738329878; x=1738934678; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ogkgzjtWHbCJsAbhsFm/psDmx9AAhxm5Ru/y31w9lBI=; b=QCObG9M24QrvpQ7dd4BplDWK/6gVsvUH/iE0v2JPg5AM6D4sUUZT2ZjBjeU1OMO7/x rDACXBEQdr65wV3eaMKIp4b2SVsrGlRO5jf8Fpd80JUO58X6l/z4pYLNsbB8GNjzt41e jO4/CCXlFth2o5DIevLxrQr7sRUiqyZaHxX6MH6pWEIscOfGtynpLtWr7TYGOPS1qnIt BYH3eIR7IP9o9aaJbBnrdHeyy/of3KIis50khT7arniwxh+lzy8Ph/dZv51edc6rtxlM ndTbibF6gbuIV4E69rPhFeA6ap6AfEnB2lr2sn3p0zvLC0BwhFIGQFt2tiyoPeWGAdp8 HilA== X-Gm-Message-State: AOJu0Yx3xcOcP8yAvKo/wG6ptlM9NT0KN8MYYFTNYruIh7SKGyeuCQ1C tZ6XjS9eSh3S2wA8r1EmX6r1+R/vvUT2GNqLf3iiXHvqXg0iir1Ueiw2kA== X-Gm-Gg: ASbGncte6LarXu/ddds9032500IzC321UJt/pdsfDDvMPHG4s2PcXIaIhqg25Ihzu2q pDjTj+M1BwrGrAePoO1/GuC1o1lZygkaOYFX5s4XPIvNTfEOhW7xyyXmCTr2QQkCbLySr55KHJS R7YTvl/jaezuHxmVkm3HUANdAFBEy23jukicBA6gPvsHKzeip4CTHfUZPIYZWseVbBWG2L02/fY kxmf5TUL01kJrE3n4QDhhHKmzLoRmdEwNuGhPyTH4R9Zf5lU4xu9oaiSzcDyWxlhZsyoafeQAKh lcMFCAcif2/r X-Google-Smtp-Source: AGHT+IHx1azY5+FDWfafYqnGBqzKZVaW8Ly0Kz20eGV8vzx7b0gDZlcPhnNqk0bWuxy9o0DWyiUpLA== X-Received: by 2002:a17:903:2f89:b0:216:1079:82bb with SMTP id d9443c01a7336-21edd84e33bmr62538425ad.19.1738329878400; Fri, 31 Jan 2025 05:24:38 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de331f0d6sm29727655ad.219.2025.01.31.05.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jan 2025 05:24:37 -0800 (PST) From: Maxim Cournoyer To: iyzsong@envs.net Subject: Re: [bug#75966] [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: (iyzsong@envs.net's message of "Fri, 31 Jan 2025 18:34:50 +0800") References: Date: Fri, 31 Jan 2025 22:24:26 +0900 Message-ID: <87bjvnnmk5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, iyzsong@envs.net writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: > Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source p= hase. > [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. > * gnu/packages/ebook.scm (calibre) > * gnu/packages/education.scm (anki) > * gnu/packages/kde-internet.scm (falkon) > * gnu/packages/kde-systemtools.scm (khelpcenter) > * gnu/packages/kde.scm (akregator) > * gnu/packages/video.scm (openshot) > * gnu/packages/vpn.scm (openconnect-sso) > * gnu/packages/web-browsers.scm (qutebrowser) > * gnu/packages/web.scm (kiwix-desktop): Remove wrapper for QTWEBENGINEPRO= CESS_PATH. Could you mention what is the rationale in the commit message? Is the QTWEBENGINEPROCESS_PATH environment variable problematic is some ways (perhaps mixing Qt5 and Qt6 qtwebengine?). Shouldn't we keep the native-search-path for it? Perhaps not all software are patched yet, and it shouldn't hurt? Or would it defeat the aim of this series? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 22:55:12 2025 Received: (at 75966) by debbugs.gnu.org; 1 Feb 2025 03:55:12 +0000 Received: from localhost ([127.0.0.1]:55789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1te4b8-0006sU-PB for submit@debbugs.gnu.org; Fri, 31 Jan 2025 22:55:11 -0500 Received: from mail.envs.net ([5.199.136.28]:35904) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1te4b4-0006oA-PV for 75966@debbugs.gnu.org; Fri, 31 Jan 2025 22:55:08 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 0D0DE38A3E40; Sat, 1 Feb 2025 03:55:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id A3Ub9XkRxszi; Sat, 1 Feb 2025 03:55:01 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 1 Feb 2025 03:55:01 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ca8994a1; Sat, 1 Feb 2025 03:58:37 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: qtwebengine: Fix default path for QtWebEngineProcess. Date: Sat, 1 Feb 2025 11:58:31 +0800 Message-ID: <64b2f94cf05195646d5076df6bd67a8538001e00.1738382284.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-Debbugs-Cc: Maxim Cournoyer , 宋文武 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) From: 宋文武 Since qtwebengine and qtbase are not installed into the same prefix, the default path for QtWebEngineProcess won't work. Fix it so that we no longer need to set QTWEBENGINEPROCESS_PATH anymore. * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source phase. [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. * gnu/packages/ebook.scm (calibre) * gnu/packages/education.scm (anki) * gnu/packages/kde-internet.scm (falkon) * gnu/packages/kde-systemtools.scm (khelpcenter) * gnu/packages/kde.scm (akregator) * gnu/packages/video.scm (openshot) * gnu/packages/vpn.scm (openconnect-sso) * gnu/packages/web-browsers.scm (qutebrowser) * gnu/packages/web.scm (kiwix-desktop): Remove wrapper for QTWEBENGINEPROCESS_PATH. Change-Id: I43745969ce80daa0f077da37671d1b44a468c953 --- gnu/packages/ebook.scm | 21 +-------------------- gnu/packages/education.scm | 13 +++---------- gnu/packages/kde-internet.scm | 13 ------------- gnu/packages/kde-systemtools.scm | 10 +--------- gnu/packages/kde.scm | 13 +------------ gnu/packages/qt.scm | 22 ++++++++-------------- gnu/packages/video.scm | 14 +------------- gnu/packages/vpn.scm | 12 +----------- gnu/packages/web-browsers.scm | 10 ++-------- gnu/packages/web.scm | 10 +--------- 10 files changed, 19 insertions(+), 119 deletions(-) diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm index 0cd2b31724..73fea2f66a 100644 --- a/gnu/packages/ebook.scm +++ b/gnu/packages/ebook.scm @@ -320,26 +320,7 @@ (define-public calibre (string-append #$(this-package-input "font-liberation") "/share/fonts/truetype"))) (delete-file-recursively font-dest) - (symlink font-src font-dest)))) - ;; Make run-time dependencies available to the binaries. - (add-after 'wrap 'wrap-program - (lambda* (#:key inputs #:allow-other-keys) - (with-directory-excursion (string-append #$output "/bin") - (for-each - (lambda (binary) - (wrap-program binary - ;; Make QtWebEngineProcess available. - `("QTWEBENGINEPROCESS_PATH" = - ,(list - (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))))) - ;; Wrap all the binaries shipping with the package, except - ;; for the wrappings created during the 'wrap standard - ;; phase. This extends existing .calibre-real wrappers - ;; rather than create ..calibre-real-real-s. For more - ;; information see: https://issues.guix.gnu.org/43249. - (find-files "." (lambda (file stat) - (not (wrapped-program? file))))))))))) + (symlink font-src font-dest))))))) (home-page "https://calibre-ebook.com/") (synopsis "E-book library management software") (description "Calibre is an e-book library manager. It can view, convert diff --git a/gnu/packages/education.scm b/gnu/packages/education.scm index f42a216972..f0c0e931bf 100644 --- a/gnu/packages/education.scm +++ b/gnu/packages/education.scm @@ -836,18 +836,11 @@ (define-public anki (filter (match-lambda ((label . _) (string-prefix? "python-" label))) - inputs))) - (qtwebengineprocess - (search-input-file inputs - "lib/qt5/libexec/QtWebEngineProcess"))) - ;; The program fails to find the QtWebEngineProcess program, so - ;; we set QTWEBENGINEPROCESS_PATH to help it. PYTHONPATH is - ;; wrapped to avoid declaring Python libraries as propagated - ;; inputs. + inputs)))) + ;; PYTHONPATH is wrapped to avoid declaring Python libraries as + ;; propagated inputs. (for-each (lambda (program) (wrap-program program - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengineprocess)) `("PATH" prefix (,(string-append (assoc-ref inputs "mpv") "/bin"))) diff --git a/gnu/packages/kde-internet.scm b/gnu/packages/kde-internet.scm index 4bf40afe88..d54126ed12 100644 --- a/gnu/packages/kde-internet.scm +++ b/gnu/packages/kde-internet.scm @@ -130,19 +130,6 @@ (define-public falkon (base32 "0j930i2nvg71p05z881inbk59c54gx8dzhyjb8iaqkw8i5s5r983")))) (build-system qt-build-system) - (arguments - (list #:phases - #~(modify-phases %standard-phases - (add-after 'install 'wrap - (lambda* (#:key inputs outputs #:allow-other-keys) - (let ((qtwebengineprocess - (search-input-file inputs - "lib/qt6/libexec/QtWebEngineProcess"))) - ;; The program fails to find the QtWebEngineProcess program, so - ;; we set QTWEBENGINEPROCESS_PATH to help it. - (wrap-program (string-append #$output "/bin/falkon") - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengineprocess))))))))) (native-inputs (list extra-cmake-modules pkg-config qttools)) (inputs diff --git a/gnu/packages/kde-systemtools.scm b/gnu/packages/kde-systemtools.scm index 4923854a7c..a86b550a7f 100644 --- a/gnu/packages/kde-systemtools.scm +++ b/gnu/packages/kde-systemtools.scm @@ -178,15 +178,7 @@ (define-public khelpcenter PrintSupport") (("Qt6::WebEngineWidgets") "Qt6::PrintSupport - Qt6::WebEngineWidgets")))) - (add-after 'install 'wrap-executable - (lambda* (#:key inputs #:allow-other-keys) - (wrap-program (string-append #$output - "/bin/khelpcenter") - `("QTWEBENGINEPROCESS_PATH" = - (,(search-input-file - inputs - "lib/qt6/libexec/QtWebEngineProcess"))))))))) + Qt6::WebEngineWidgets"))))))) (home-page "https://apps.kde.org/khelpcenter/") (synopsis "KDE documentation viewer") (description "KHelpCenter uses meta data files which describe the diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm index 765176f42b..9a4115eda6 100644 --- a/gnu/packages/kde.scm +++ b/gnu/packages/kde.scm @@ -205,18 +205,7 @@ (define-public akregator (base32 "07flc3617px9w1c729p0lsixf1g0h297hkbip259ykkbwxizn71q")))) (build-system qt-build-system) (arguments - (list #:qtbase qtbase - #:phases - #~(modify-phases %standard-phases - (add-after 'install 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/akregator")) - (qt-process-path - (search-input-file - inputs "/lib/qt6/libexec/QtWebEngineProcess"))) - (wrap-program bin - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + (list #:qtbase qtbase)) (native-inputs (list extra-cmake-modules kdoctools)) (inputs diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 76c11af543..c29f8e14e7 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -3415,7 +3415,10 @@ (define-public qtwebengine-5 "/share/qt5/translations\")")) (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") (string-append "QLatin1String(\"" #$output - "/share/qt5\")"))) + "/share/qt5\")")) + (("QLibraryInfo::location\\(QLibraryInfo::LibraryExecutablesPath)") + (string-append "QLatin1String(\"" #$output + "/lib/qt5/libexec\")"))) ;; Substitute full dynamic library path for nss. (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") @@ -3453,12 +3456,6 @@ (define-public qtwebengine-5 ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH ;; before running tests. ((#:tests? _ #f) #f))) - (native-search-paths - (list (search-path-specification - (file-type 'regular) - (separator #f) - (variable "QTWEBENGINEPROCESS_PATH") - (files '("lib/qt5/libexec/QtWebEngineProcess"))))) (home-page "https://wiki.qt.io/QtWebEngine") (synopsis "Qt WebEngine module") (description "The Qt5WebEngine module provides support for web applications @@ -3824,7 +3821,10 @@ (define-public qtwebengine "/share/qt6/translations\")")) (("QLibraryInfo::path\\(QLibraryInfo::DataPath)") (string-append "QLatin1String(\"" #$output - "/share/qt6\")"))) + "/share/qt6\")")) + (("QLibraryInfo::path\\(QLibraryInfo::LibraryExecutablesPath)") + (string-append "QLatin1String(\"" #$output + "/lib/qt6/libexec\")"))) ;; Substitute full dynamic library path for nss. (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") @@ -3884,12 +3884,6 @@ (define-public qtwebengine (replace "qtbase" qtbase) (replace "qtdeclarative" qtdeclarative) (replace "qtwebchannel" qtwebchannel))) - (native-search-paths - (list (search-path-specification - (file-type 'regular) - (separator #f) - (variable "QTWEBENGINEPROCESS_PATH") - (files '("lib/qt6/libexec/QtWebEngineProcess"))))) (home-page "https://wiki.qt.io/QtWebEngine") (synopsis "Qt WebEngine module") (description "The Qt WebEngine module provides support for web diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index d0b5907bdd..4881f6ba64 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -6049,19 +6049,7 @@ (define-public openshot (lambda _ ;; src/classes/info.py "needs" to create several ;; directories in $HOME when loaded during build - (setenv "HOME" "/tmp"))) - (add-after 'install 'wrap-program - (lambda* (#:key outputs inputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out")) - (qtwebengine-process-path - (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-qt-program "openshot-qt" - #:output out #:inputs inputs) - ;; Help the program discover QtWebEngine at runtime. - (wrap-program (string-append out "/bin/openshot-qt") - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengine-process-path))))))))) + (setenv "HOME" "/tmp")))))) (home-page "https://www.openshot.org/") (synopsis "Video editor") (description "OpenShot takes your videos, photos, and music files and diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 0b62e8c7cf..b64617c5df 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -800,17 +800,7 @@ (define-public openconnect-sso (("\"openconnect\"") (string-append "\"" (search-input-file inputs "/sbin/openconnect") - "\""))))) - (add-after 'check 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/openconnect-sso")) - (qt-process-path - (search-input-file inputs - "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-program bin - #:sh (search-input-file inputs "bin/bash") - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + "\"")))))))) (inputs (list openconnect poetry diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm index c0138eea17..5159a3b76d 100644 --- a/gnu/packages/web-browsers.scm +++ b/gnu/packages/web-browsers.scm @@ -490,10 +490,7 @@ (define-public qutebrowser python-pyyaml python-pyqt-6 python-pyqtwebengine-6 - python-tldextract - ;; While qtwebengine is provided by python-pyqtwebengine-6, it's - ;; included here so we can wrap QTWEBENGINEPROCESS_PATH. - qtwebengine)) + python-tldextract)) (arguments `(;; FIXME: With the existence of qtwebengine, tests can now run. But ;; they are still disabled because test phase hangs. It's not readily @@ -547,10 +544,7 @@ (define-public qutebrowser (wrap-program (search-input-file outputs "bin/qutebrowser") `("QTWEBENGINE_RESOURCES_PATH" = (,(search-input-directory - inputs "/share/qt6/resources"))) - `("QTWEBENGINEPROCESS_PATH" = - (,(search-input-file - inputs "/lib/qt6/libexec/QtWebEngineProcess"))))))))) + inputs "/share/qt6/resources"))))))))) (home-page "https://qutebrowser.org/") (synopsis "Minimal, keyboard-focused, vim-like web browser") (description "qutebrowser is a keyboard-focused browser with a minimal diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index a23a0f3dcd..0cf1c18a56 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -9404,15 +9404,7 @@ (define-public kiwix-desktop (lambda* (#:key outputs #:allow-other-keys) (invoke "qmake" (string-append "PREFIX=" - (assoc-ref outputs "out"))))) - (add-after 'install 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/kiwix-desktop")) - (qt-process-path (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-program bin - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + (assoc-ref outputs "out")))))))) (inputs (list bash-minimal curl base-commit: d48da2d21610f9cf5f76cd846703b12beedb1fd5 -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 22:55:12 2025 Received: (at 75966) by debbugs.gnu.org; 1 Feb 2025 03:55:12 +0000 Received: from localhost ([127.0.0.1]:55791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1te4bA-0006t4-4A for submit@debbugs.gnu.org; Fri, 31 Jan 2025 22:55:12 -0500 Received: from mail.envs.net ([5.199.136.28]:59070) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1te4b5-0006q7-PE for 75966@debbugs.gnu.org; Fri, 31 Jan 2025 22:55:10 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id F152E38A3E44; Sat, 1 Feb 2025 03:55:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Iethe90Iv41O; Sat, 1 Feb 2025 03:55:04 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 1 Feb 2025 03:55:03 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id dfef2f2b; Sat, 1 Feb 2025 03:58:37 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v2 2/2] build: qt-utils: Remove wrapping for 'QTWEBENGINEPROCESS_PATH'. Date: Sat, 1 Feb 2025 11:58:32 +0800 Message-ID: <9dac26b1691456f8a54d6ae6a0e10880909c7976.1738382284.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <64b2f94cf05195646d5076df6bd67a8538001e00.1738382284.git.iyzsong@member.fsf.org> References: <64b2f94cf05195646d5076df6bd67a8538001e00.1738382284.git.iyzsong@member.fsf.org> MIME-Version: 1.0 X-Debbugs-Cc: Maxim Cournoyer , 宋文武 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * guix/build/qt-utils.scm (variables-for-wrapping): Remove 'QTWEBENGINEPROCESS_PATH'. Change-Id: I834da403d750fe1b20e369ecee9ae081a6d57c25 --- guix/build/qt-utils.scm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/guix/build/qt-utils.scm b/guix/build/qt-utils.scm index d7609b9f21..65592757e6 100644 --- a/guix/build/qt-utils.scm +++ b/guix/build/qt-utils.scm @@ -93,11 +93,7 @@ (define* (variables-for-wrapping base-directories output-directory `(,(if (>= (string->number qt-major-version) 6) "QML_IMPORT_PATH" "QML2_IMPORT_PATH") - prefix directory ,(format #f "/lib/qt~a/qml" qt-major-version)) - ;; QTWEBENGINEPROCESS_PATH accepts a single value, which makes 'exact the - ;; most suitable environment variable type for it. - `("QTWEBENGINEPROCESS_PATH" = regular - ,(format #f "/lib/qt~a/libexec/QtWebEngineProcess" qt-major-version))))) + prefix directory ,(format #f "/lib/qt~a/qml" qt-major-version))))) (define* (wrap-qt-program* program #:key sh inputs output-dir qt-wrap-excluded-inputs -- 2.47.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 31 23:03:17 2025 Received: (at 75966) by debbugs.gnu.org; 1 Feb 2025 04:03:17 +0000 Received: from localhost ([127.0.0.1]:55808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1te4iy-0007DH-Q2 for submit@debbugs.gnu.org; Fri, 31 Jan 2025 23:03:17 -0500 Received: from mail.envs.net ([5.199.136.28]:45748) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1te4iw-0007D8-M6 for 75966@debbugs.gnu.org; Fri, 31 Jan 2025 23:03:15 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id ACA7F38A3E40; Sat, 1 Feb 2025 04:03:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RQPtlNbW6aKN; Sat, 1 Feb 2025 04:03:09 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 1 Feb 2025 04:03:09 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 3a1da2f4; Sat, 1 Feb 2025 04:06:49 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Maxim Cournoyer Subject: Re: [bug#75966] [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: <87bjvnnmk5.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 31 Jan 2025 22:24:26 +0900") References: <87bjvnnmk5.fsf@gmail.com> Date: Sat, 01 Feb 2025 12:06:49 +0800 Message-ID: <878qqqfgva.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > Could you mention what is the rationale in the commit message? Is the > QTWEBENGINEPROCESS_PATH environment variable problematic is some ways > (perhaps mixing Qt5 and Qt6 qtwebengine?). It seems fine to mixing QtWebEngineProcess from Qt5 and Qt6, but the default path is wrong due to we have different install prefixes, normally there is no need to set QTWEBENGINEPROCESS_PATH ourself. > > Shouldn't we keep the native-search-path for it? Perhaps not all > software are patched yet, and it shouldn't hurt? Or would it defeat the > aim of this series? The rationale is to drop the wrapping for QTWEBENGINEPROCESS_PATH, as there is no need to use it if the default path is working from the beginning. v2 patches send, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 09:38:30 2025 Received: (at 75966) by debbugs.gnu.org; 1 Feb 2025 14:38:30 +0000 Received: from localhost ([127.0.0.1]:57137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teEdg-0007uW-HJ for submit@debbugs.gnu.org; Sat, 01 Feb 2025 09:38:30 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:53407) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1teEdd-0007uF-Lg for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 09:38:26 -0500 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-215770613dbso39675445ad.2 for <75966@debbugs.gnu.org>; Sat, 01 Feb 2025 06:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738420699; x=1739025499; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6yjgK8Gm6ooz7atEILa0w892ES1m9iRhlA8VDTdqyv4=; b=iJkct7OWM5OeqR7sEUUe35gLtPKLlS5GvRmn4+rVBXkHW3VV561PpCyAIw+NLiwWqR LNmJcvKDaXxl4I4bcIJCdhKguJD9XzUjDb1+JDtJ+xYD60q/7Nt2SeDmUH08qIChQ64Z sdDviCvNLIBFHJwyb7g2CF/c5yOrHDe+RmXyWPz+uL0Fc7WGrsa6da7rOfBBb+Kqhr7W chW6xx154nlaTYpVOBzk9pmJUpOoZT0Y+ZSGDrvk1kyT+Md3hnO6Jq07YEHMakEPISI1 UDhJpTcNVSVyDMl4CvZi/n0YOedoF8eI9ZcPqanh3d0Rux63c3y2P+QYztIKT/nkx8aY RBVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738420699; x=1739025499; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6yjgK8Gm6ooz7atEILa0w892ES1m9iRhlA8VDTdqyv4=; b=cN7klyw52mGxLzSDpcFh9kXw+VPQ1fFjPAPkkOIIdB8YuODJST9Mt05J/cSzQ/sAko W5gGb7OWYOk5tIa34tDb7p97qUZdDuHl1Ro02YonHqLJ7vf6iR43PxHSHoUHdEDD+Kzt QNarlcieGPw9d6jLbZiOhkIMjnLQuQhUgqV7wyYusEGBhtqmWccVLW2dneGWire9lIna d0YV0RagBImbgohmolYMqlSa8RCybmBIsMAirkVPbohT6UtHWjXLhBC9B2rpyDiInc4t UuwL18AqX39vtXwkA1cxpnMkzPMvBdB1bHt+nMLBKlmwsLhAf2FphanHEI6JKPcm5W0E TrxA== X-Forwarded-Encrypted: i=1; AJvYcCURWHX6VfOWrIIz+Rq22RxQnxpmP0MfWyKP7hyoikxYKpZp5ZXoJ2t/Yv6DPgGANP+mQarvvQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxovlH/2H6irmJ5tOlfEaaWQQisrkVzmIQ7UkU2BrM5hIE2V5pt QPJzY5GN/NisUl/32LYIgIGRSMKHxDh5AvYDL7HaQxLiVhY8ehslMsJpig== X-Gm-Gg: ASbGncsBC6ktWI6odydi80kWcV2lzbpSLtEe5H3wVwWMiQzBZ16R1QYghBbxNMJb1pg y9UkfUbdt4KGKNi/CbOBR/D0tk6INJAr1PW2M6itaHh2AdNzNrGtrIOKdx4RoOx0mYq8ebF1c3F EXaYPHpnqFSkQF0jrqFSRnNehk+5mV6/S8rjfp2MgRsVZKQd61r84AUIZjPrAvSeWmLxQyr/VYi 66m0eseV18Jh+yUTjYx4NFhdbblNCtn3zhIc0fyd8463Z8uiFqjK67peO8xcnxU3ZM3Ls8/6HrM 6HOHXbLzlkfc X-Google-Smtp-Source: AGHT+IGGVw0JMir6N13jbFv+99u29lFIRm2rcBSp3ocQhh/1+YAP11mwJZ1o/hRZ1+96SzB1HJ9kpw== X-Received: by 2002:a05:6300:8a07:b0:1ed:aca6:826 with SMTP id adf61e73a8af0-1edaca60924mr2953005637.35.1738420698899; Sat, 01 Feb 2025 06:38:18 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-acebddbb0besm4818356a12.16.2025.02.01.06.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Feb 2025 06:38:18 -0800 (PST) From: Maxim Cournoyer To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: bug#75966: [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: <878qqqfgva.fsf@envs.net> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Sat, 01 Feb 2025 12:06:49 +0800") References: <87bjvnnmk5.fsf@gmail.com> <878qqqfgva.fsf@envs.net> Date: Sat, 01 Feb 2025 23:38:06 +0900 Message-ID: <87tt9dlohd.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > Maxim Cournoyer writes: > >> Could you mention what is the rationale in the commit message? Is the >> QTWEBENGINEPROCESS_PATH environment variable problematic is some ways >> (perhaps mixing Qt5 and Qt6 qtwebengine?). > > It seems fine to mixing QtWebEngineProcess from Qt5 and Qt6, but the > default path is wrong due to we have different install prefixes, > normally there is no need to set QTWEBENGINEPROCESS_PATH ourself. > >> >> Shouldn't we keep the native-search-path for it? Perhaps not all >> software are patched yet, and it shouldn't hurt? Or would it defeat the >> aim of this series? > > The rationale is to drop the wrapping for QTWEBENGINEPROCESS_PATH, as > there is no need to use it if the default path is working from the beginn= ing. > > v2 patches send, thanks. Makes sense now, thank your for the explanation. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 09:44:31 2025 Received: (at 75966) by debbugs.gnu.org; 1 Feb 2025 14:44:31 +0000 Received: from localhost ([127.0.0.1]:57149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teEjX-0008BC-A9 for submit@debbugs.gnu.org; Sat, 01 Feb 2025 09:44:31 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:54576) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1teEjU-0008As-A9 for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 09:44:30 -0500 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-21670dce0a7so61848615ad.1 for <75966@debbugs.gnu.org>; Sat, 01 Feb 2025 06:44:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738421062; x=1739025862; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V17XUXxKwFOSy4h9DkAXOrWnpdNBMxFkVqohpW6n4MA=; b=QUEuboFsCyg8WF+2HJNPBZR1BdKQo6PqTzDPkLwMFZnOtXhDzNitxBHCN3tdCYJ1K0 mGeWFUMwuhK3G75yI9N4Mb86NS9dD0Mb8BMet5LIq/pSSfXRr9hjhskNhMAl5IZJy8jU hCs2fwr3X59hsu1Lo9NnEKj0v0X1yphsplnFeTTDm/+j9CSYKpXFK11PcySfF9z0NPDp afPS/IpWrYJyQeqsaqQoDP3dRo0WgsrSTytD8ws+um7t0Voq/tq020oO8U6jsNKcTr75 +tklhIQnRocZrlUZYo0d9YY37EX7C6VxNWX6FhOwfrdENgrbfceWAQZQdxkf9nIqrS9u F8jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738421062; x=1739025862; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=V17XUXxKwFOSy4h9DkAXOrWnpdNBMxFkVqohpW6n4MA=; b=jjGL5X2Im3iMctUfffy1JHVF/q6cAnS3jtTWMAJXyO39leaO6Q7FsT1Qx9HgA+uD7s WjBnK3fncz2AGU3IbY7W7qshZDB0KwIxQCdCw6CVzPQIhmIqifO9I8hfyIsy1h/tiQUi /grtBIULFrFYURLQx8QjHPYdCbox6scduRgSLlKAIa/sXZ5p2FUwOMbbEIztywagOLZ4 s6wlGrW+p3KIfK+Fphm1TQ7njg/MC7ZI+M/Ah+YGFZwyBK7nBOpfnJO/oY8T0WM34SDW 206JD7i+/UDjEfOkN+b4JO2j88kYFDZcNWs5nZ4O6ZmOFLxCAeyamMURlSlsL8tFmJo9 s3Ag== X-Gm-Message-State: AOJu0YyV4nAVzbg0FSL/02q18jSXAzTdcyFQQjJJaHIY83APZVoGJ9nb Uzeo0s2KUUZaWjAv+zaK1oJT9lj2ON1lj25CyFjF4kZcWuSAY8hQGVy+1w== X-Gm-Gg: ASbGncsImi1pn+aBSA4ZnhyncT+rbuTmZAR8Ezw5oTruTZu6+cQ521hRdYueWIx6sFB FFTDJfbuGjIck0ZtwFoPjfDaAurS+egaT44QJJMgFIuDV4IlY5ojVszLWIB+5iBxWZNGjR2/jaf Hn7JmvklH+qqD2xLUuQ79FAod9/YEZA2TEJLC+CczWwRIqYBTupGnd+dOCe8CfrCpG/ldFeZugb PbbFJAykMFqICdhlTlIQ4yWPTfl7u+vD+1EQQxPCUDk3PDOdruc1Xxc6Za8jnmUeJeJydMHeBh+ N1Ow3MVbdBUs X-Google-Smtp-Source: AGHT+IEyVbe3d+/5rnZ0ffky9SemH9BBUqg5aSb9kldvgTTW43oHtF+Th76jOXiUIolGbf4pKWWOMg== X-Received: by 2002:a17:903:244b:b0:216:4a8a:2665 with SMTP id d9443c01a7336-21dd7df43c7mr239263765ad.50.1738421062330; Sat, 01 Feb 2025 06:44:22 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-acebe856890sm4852925a12.42.2025.02.01.06.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Feb 2025 06:44:21 -0800 (PST) From: Maxim Cournoyer To: iyzsong@envs.net Subject: Re: bug#75966: [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: <64b2f94cf05195646d5076df6bd67a8538001e00.1738382284.git.iyzsong@member.fsf.org> (iyzsong@envs.net's message of "Sat, 1 Feb 2025 11:58:31 +0800") References: <64b2f94cf05195646d5076df6bd67a8538001e00.1738382284.git.iyzsong@member.fsf.org> Date: Sat, 01 Feb 2025 23:44:09 +0900 Message-ID: <87jza9lo7a.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, iyzsong@envs.net writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > Since qtwebengine and qtbase are not installed into the same prefix, > the default path for QtWebEngineProcess won't work. Fix it so that > we no longer need to set QTWEBENGINEPROCESS_PATH anymore. > > * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: > Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source p= hase. > [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. > * gnu/packages/ebook.scm (calibre) > * gnu/packages/education.scm (anki) > * gnu/packages/kde-internet.scm (falkon) > * gnu/packages/kde-systemtools.scm (khelpcenter) > * gnu/packages/kde.scm (akregator) > * gnu/packages/video.scm (openshot) > * gnu/packages/vpn.scm (openconnect-sso) > * gnu/packages/web-browsers.scm (qutebrowser) > * gnu/packages/web.scm (kiwix-desktop): Remove wrapper for QTWEBENGINEPRO= CESS_PATH. I think it'd be a bit clearer to introduce the change to qt/qt-utils in a same commit, and then proceed to remove the wrappers in one commit per package, since it doesn't break anything to do it this way and it matches our usual 1 package per commit change convention. Would you mind to split you series this way? Or if it's too much work, at least extract the core qt change as a prerequisite commit, and the adjustment of the packages as a 2nd commit on top of it. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:31:48 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:31:48 +0000 Received: from localhost ([127.0.0.1]:60782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teRe7-00007f-GC for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:47 -0500 Received: from mail.envs.net ([5.199.136.28]:59716) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teRe2-00007H-Jl for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:45 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 9C25238A2C06; Sun, 2 Feb 2025 04:31:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bQ3wInPR9s9e; Sun, 2 Feb 2025 04:31:37 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:36 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 52018ba6; Sun, 2 Feb 2025 04:35:14 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 01/10] gnu: qtwebengine: Fix default path for QtWebEngineProcess. Date: Sun, 2 Feb 2025 12:34:50 +0800 Message-ID: X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-Debbugs-Cc: Maxim Cournoyer , 宋文武 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) From: 宋文武 Since qtwebengine and qtbase are not installed into the same prefix, the default path for QtWebEngineProcess won't work. Fix it so that we no longer need to set QTWEBENGINEPROCESS_PATH anymore. * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source phase. [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. * guix/build/qt-utils.scm (variables-for-wrapping): Remove QTWEBENGINEPROCESS_PATH. Change-Id: Ie0dfaf8c2355a679e2a3ddeacf09654830f9ab2f --- gnu/packages/qt.scm | 22 ++++++++-------------- guix/build/qt-utils.scm | 6 +----- 2 files changed, 9 insertions(+), 19 deletions(-) diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm index 432282f9cf..430f0bb96d 100644 --- a/gnu/packages/qt.scm +++ b/gnu/packages/qt.scm @@ -3415,7 +3415,10 @@ (define-public qtwebengine-5 "/share/qt5/translations\")")) (("QLibraryInfo::location\\(QLibraryInfo::DataPath\\)") (string-append "QLatin1String(\"" #$output - "/share/qt5\")"))) + "/share/qt5\")")) + (("QLibraryInfo::location\\(QLibraryInfo::LibraryExecutablesPath)") + (string-append "QLatin1String(\"" #$output + "/lib/qt5/libexec\")"))) ;; Substitute full dynamic library path for nss. (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") @@ -3453,12 +3456,6 @@ (define-public qtwebengine-5 ;; It's possible this can be fixed by setting QTWEBENGINEPROCESS_PATH ;; before running tests. ((#:tests? _ #f) #f))) - (native-search-paths - (list (search-path-specification - (file-type 'regular) - (separator #f) - (variable "QTWEBENGINEPROCESS_PATH") - (files '("lib/qt5/libexec/QtWebEngineProcess"))))) (home-page "https://wiki.qt.io/QtWebEngine") (synopsis "Qt WebEngine module") (description "The Qt5WebEngine module provides support for web applications @@ -3824,7 +3821,10 @@ (define-public qtwebengine "/share/qt6/translations\")")) (("QLibraryInfo::path\\(QLibraryInfo::DataPath)") (string-append "QLatin1String(\"" #$output - "/share/qt6\")"))) + "/share/qt6\")")) + (("QLibraryInfo::path\\(QLibraryInfo::LibraryExecutablesPath)") + (string-append "QLatin1String(\"" #$output + "/lib/qt6/libexec\")"))) ;; Substitute full dynamic library path for nss. (substitute* "src/3rdparty/chromium/crypto/nss_util.cc" (("libnssckbi.so") @@ -3884,12 +3884,6 @@ (define-public qtwebengine (replace "qtbase" qtbase) (replace "qtdeclarative" qtdeclarative) (replace "qtwebchannel" qtwebchannel))) - (native-search-paths - (list (search-path-specification - (file-type 'regular) - (separator #f) - (variable "QTWEBENGINEPROCESS_PATH") - (files '("lib/qt6/libexec/QtWebEngineProcess"))))) (home-page "https://wiki.qt.io/QtWebEngine") (synopsis "Qt WebEngine module") (description "The Qt WebEngine module provides support for web diff --git a/guix/build/qt-utils.scm b/guix/build/qt-utils.scm index d7609b9f21..65592757e6 100644 --- a/guix/build/qt-utils.scm +++ b/guix/build/qt-utils.scm @@ -93,11 +93,7 @@ (define* (variables-for-wrapping base-directories output-directory `(,(if (>= (string->number qt-major-version) 6) "QML_IMPORT_PATH" "QML2_IMPORT_PATH") - prefix directory ,(format #f "/lib/qt~a/qml" qt-major-version)) - ;; QTWEBENGINEPROCESS_PATH accepts a single value, which makes 'exact the - ;; most suitable environment variable type for it. - `("QTWEBENGINEPROCESS_PATH" = regular - ,(format #f "/lib/qt~a/libexec/QtWebEngineProcess" qt-major-version))))) + prefix directory ,(format #f "/lib/qt~a/qml" qt-major-version))))) (define* (wrap-qt-program* program #:key sh inputs output-dir qt-wrap-excluded-inputs base-commit: 070c073d508d3197f0235adc424aec287e7dd916 -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:31:50 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:31:50 +0000 Received: from localhost ([127.0.0.1]:60785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReA-00007w-4h for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:50 -0500 Received: from mail.envs.net ([5.199.136.28]:59738) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teRe6-00007R-4t for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:46 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 1A59838A3E90; Sun, 2 Feb 2025 04:31:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KuMLMfo3yIis; Sun, 2 Feb 2025 04:31:42 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:40 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 7bbe4e8d; Sun, 2 Feb 2025 04:35:14 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 03/10] gnu: anki: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:52 +0800 Message-ID: <3ab14499f91127ac45500e86ce6a4d71772e60a8.1738470835.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/education.scm (anki):[arguments]: Remove QTWEBENGINEPROCESS_PATH from the 'wrap phase. Change-Id: If8b2cd5bcb0624033b6f7a29c9b865b70943032d --- gnu/packages/education.scm | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/gnu/packages/education.scm b/gnu/packages/education.scm index f42a216972..f0c0e931bf 100644 --- a/gnu/packages/education.scm +++ b/gnu/packages/education.scm @@ -836,18 +836,11 @@ (define-public anki (filter (match-lambda ((label . _) (string-prefix? "python-" label))) - inputs))) - (qtwebengineprocess - (search-input-file inputs - "lib/qt5/libexec/QtWebEngineProcess"))) - ;; The program fails to find the QtWebEngineProcess program, so - ;; we set QTWEBENGINEPROCESS_PATH to help it. PYTHONPATH is - ;; wrapped to avoid declaring Python libraries as propagated - ;; inputs. + inputs)))) + ;; PYTHONPATH is wrapped to avoid declaring Python libraries as + ;; propagated inputs. (for-each (lambda (program) (wrap-program program - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengineprocess)) `("PATH" prefix (,(string-append (assoc-ref inputs "mpv") "/bin"))) -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:31:51 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:31:51 +0000 Received: from localhost ([127.0.0.1]:60787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReA-000083-K3 for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:51 -0500 Received: from mail.envs.net ([5.199.136.28]:59724) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teRe4-00007K-9T for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:46 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 7E99538A2C32; Sun, 2 Feb 2025 04:31:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id B66naCWNaqVX; Sun, 2 Feb 2025 04:31:40 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:39 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id de8a2f80; Sun, 2 Feb 2025 04:35:14 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 02/10] gnu: calibre: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:51 +0800 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/ebook.scm (calibre)[arguments]: Remove 'wrap-program phase. Change-Id: If289d6d5bcd1582134bbb02a179425a4f9c6a4d0 --- gnu/packages/ebook.scm | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm index 0cd2b31724..73fea2f66a 100644 --- a/gnu/packages/ebook.scm +++ b/gnu/packages/ebook.scm @@ -320,26 +320,7 @@ (define-public calibre (string-append #$(this-package-input "font-liberation") "/share/fonts/truetype"))) (delete-file-recursively font-dest) - (symlink font-src font-dest)))) - ;; Make run-time dependencies available to the binaries. - (add-after 'wrap 'wrap-program - (lambda* (#:key inputs #:allow-other-keys) - (with-directory-excursion (string-append #$output "/bin") - (for-each - (lambda (binary) - (wrap-program binary - ;; Make QtWebEngineProcess available. - `("QTWEBENGINEPROCESS_PATH" = - ,(list - (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))))) - ;; Wrap all the binaries shipping with the package, except - ;; for the wrappings created during the 'wrap standard - ;; phase. This extends existing .calibre-real wrappers - ;; rather than create ..calibre-real-real-s. For more - ;; information see: https://issues.guix.gnu.org/43249. - (find-files "." (lambda (file stat) - (not (wrapped-program? file))))))))))) + (symlink font-src font-dest))))))) (home-page "https://calibre-ebook.com/") (synopsis "E-book library management software") (description "Calibre is an e-book library manager. It can view, convert -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:31:54 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:31:54 +0000 Received: from localhost ([127.0.0.1]:60790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReC-00008I-EB for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:54 -0500 Received: from mail.envs.net ([5.199.136.28]:36390) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teRe8-00007o-Sm for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:49 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 1C74B38A2C06; Sun, 2 Feb 2025 04:31:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CM223cJTxKiQ; Sun, 2 Feb 2025 04:31:45 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:43 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 5105b7ed; Sun, 2 Feb 2025 04:35:15 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 04/10] gnu: falkon: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:53 +0800 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/kde-internet.scm (falkon)[arguments]: Remove 'wrap phase. Change-Id: Iad27eace218b15e847d5918170e68427176cc3ff --- gnu/packages/kde-internet.scm | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/gnu/packages/kde-internet.scm b/gnu/packages/kde-internet.scm index 4bf40afe88..d54126ed12 100644 --- a/gnu/packages/kde-internet.scm +++ b/gnu/packages/kde-internet.scm @@ -130,19 +130,6 @@ (define-public falkon (base32 "0j930i2nvg71p05z881inbk59c54gx8dzhyjb8iaqkw8i5s5r983")))) (build-system qt-build-system) - (arguments - (list #:phases - #~(modify-phases %standard-phases - (add-after 'install 'wrap - (lambda* (#:key inputs outputs #:allow-other-keys) - (let ((qtwebengineprocess - (search-input-file inputs - "lib/qt6/libexec/QtWebEngineProcess"))) - ;; The program fails to find the QtWebEngineProcess program, so - ;; we set QTWEBENGINEPROCESS_PATH to help it. - (wrap-program (string-append #$output "/bin/falkon") - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengineprocess))))))))) (native-inputs (list extra-cmake-modules pkg-config qttools)) (inputs -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:31:54 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:31:54 +0000 Received: from localhost ([127.0.0.1]:60793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReE-00008W-9O for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:54 -0500 Received: from mail.envs.net ([5.199.136.28]:36402) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teReA-00007v-KQ for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:51 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id D615138A3EBB; Sun, 2 Feb 2025 04:31:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JgvnzmmUdrcm; Sun, 2 Feb 2025 04:31:46 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:45 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 9decb1b1; Sun, 2 Feb 2025 04:35:15 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 05/10] gnu: khelpcenter: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:54 +0800 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/kde-systemtools.scm (khelpcenter):[arguments]: Remove 'wrap-executable phase. Change-Id: I6e1ab2c41638a60d5ab1942f101f3ff34b8d1a86 --- gnu/packages/kde-systemtools.scm | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/gnu/packages/kde-systemtools.scm b/gnu/packages/kde-systemtools.scm index 4923854a7c..a86b550a7f 100644 --- a/gnu/packages/kde-systemtools.scm +++ b/gnu/packages/kde-systemtools.scm @@ -178,15 +178,7 @@ (define-public khelpcenter PrintSupport") (("Qt6::WebEngineWidgets") "Qt6::PrintSupport - Qt6::WebEngineWidgets")))) - (add-after 'install 'wrap-executable - (lambda* (#:key inputs #:allow-other-keys) - (wrap-program (string-append #$output - "/bin/khelpcenter") - `("QTWEBENGINEPROCESS_PATH" = - (,(search-input-file - inputs - "lib/qt6/libexec/QtWebEngineProcess"))))))))) + Qt6::WebEngineWidgets"))))))) (home-page "https://apps.kde.org/khelpcenter/") (synopsis "KDE documentation viewer") (description "KHelpCenter uses meta data files which describe the -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:31:56 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:31:56 +0000 Received: from localhost ([127.0.0.1]:60796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReG-00008i-0E for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:56 -0500 Received: from mail.envs.net ([5.199.136.28]:36410) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teReD-00008K-Ls for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:54 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id DE7A538A2C06; Sun, 2 Feb 2025 04:31:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FflvXJqcsB5m; Sun, 2 Feb 2025 04:31:49 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:48 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ed0fc8f5; Sun, 2 Feb 2025 04:35:15 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 06/10] gnu: akregator: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:55 +0800 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/kde.scm (akregator):[arguments]: Remove 'wrap-qt-process-path phase. Change-Id: I827e8375186492064c934c35196790af6e999e0d --- gnu/packages/kde.scm | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm index 765176f42b..9a4115eda6 100644 --- a/gnu/packages/kde.scm +++ b/gnu/packages/kde.scm @@ -205,18 +205,7 @@ (define-public akregator (base32 "07flc3617px9w1c729p0lsixf1g0h297hkbip259ykkbwxizn71q")))) (build-system qt-build-system) (arguments - (list #:qtbase qtbase - #:phases - #~(modify-phases %standard-phases - (add-after 'install 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/akregator")) - (qt-process-path - (search-input-file - inputs "/lib/qt6/libexec/QtWebEngineProcess"))) - (wrap-program bin - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + (list #:qtbase qtbase)) (native-inputs (list extra-cmake-modules kdoctools)) (inputs -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:31:59 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:32:00 +0000 Received: from localhost ([127.0.0.1]:60800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReJ-00009A-I0 for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:59 -0500 Received: from mail.envs.net ([5.199.136.28]:36412) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teReF-00008f-HH for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:55 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id BACB238A3EBB; Sun, 2 Feb 2025 04:31:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id r7K7FvgwejmH; Sun, 2 Feb 2025 04:31:51 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:50 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 79172604; Sun, 2 Feb 2025 04:35:16 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 08/10] gnu: openconnect-sso: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:57 +0800 Message-ID: <7e8cec7bc3ed4d2e39332b648ef462bdca5885ba.1738470835.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/vpn.scm (openconnect-sso):[arguments]: Remove 'wrap-qt-process-path phase. Change-Id: I10332aac3d482c991cccd583c12489a9291c89bf --- gnu/packages/vpn.scm | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm index 0b62e8c7cf..b64617c5df 100644 --- a/gnu/packages/vpn.scm +++ b/gnu/packages/vpn.scm @@ -800,17 +800,7 @@ (define-public openconnect-sso (("\"openconnect\"") (string-append "\"" (search-input-file inputs "/sbin/openconnect") - "\""))))) - (add-after 'check 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/openconnect-sso")) - (qt-process-path - (search-input-file inputs - "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-program bin - #:sh (search-input-file inputs "bin/bash") - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + "\"")))))))) (inputs (list openconnect poetry -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:32:01 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:32:01 +0000 Received: from localhost ([127.0.0.1]:60802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReL-00009S-87 for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:32:01 -0500 Received: from mail.envs.net ([5.199.136.28]:47780) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teReI-00008x-U0 for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:59 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 23BCF38A3EBB; Sun, 2 Feb 2025 04:31:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Qv_qfik5kjTV; Sun, 2 Feb 2025 04:31:55 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:53 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 2df5ffc5; Sun, 2 Feb 2025 04:35:16 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 09/10] gnu: kiwix-desktop: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:58 +0800 Message-ID: <87fc24ae32b650b129f1fe714bf400a17fcfa1c1.1738470835.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/web.scm (kiwix-desktop):[arguments]: Remove 'wrap-qt-process-path phase. Change-Id: Iaf33c180268358a3b1bf1695b37313f20b410f9d --- gnu/packages/web.scm | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index a23a0f3dcd..0cf1c18a56 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -9404,15 +9404,7 @@ (define-public kiwix-desktop (lambda* (#:key outputs #:allow-other-keys) (invoke "qmake" (string-append "PREFIX=" - (assoc-ref outputs "out"))))) - (add-after 'install 'wrap-qt-process-path - (lambda* (#:key inputs outputs #:allow-other-keys) - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin/kiwix-desktop")) - (qt-process-path (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-program bin - `("QTWEBENGINEPROCESS_PATH" = (,qt-process-path))))))))) + (assoc-ref outputs "out")))))))) (inputs (list bash-minimal curl -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:32:02 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:32:02 +0000 Received: from localhost ([127.0.0.1]:60804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReL-00009k-Lx for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:32:02 -0500 Received: from mail.envs.net ([5.199.136.28]:47774) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teReI-00008w-O8 for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:31:59 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id EAAF538A2C06; Sun, 2 Feb 2025 04:31:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ogoTr1y7_rS5; Sun, 2 Feb 2025 04:31:54 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:50 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 950fc115; Sun, 2 Feb 2025 04:35:15 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 07/10] gnu: openshot: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:56 +0800 Message-ID: <06ea53b41d3dce61ff0b6e5e669016568d5bd516.1738470835.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/video.scm (openshot)[arguments]: Remove 'wrap-program phase. Change-Id: Id09d18cb0f2f9e6542cdeeaa3026a0ff71164121 --- gnu/packages/video.scm | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index d0b5907bdd..4881f6ba64 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -6049,19 +6049,7 @@ (define-public openshot (lambda _ ;; src/classes/info.py "needs" to create several ;; directories in $HOME when loaded during build - (setenv "HOME" "/tmp"))) - (add-after 'install 'wrap-program - (lambda* (#:key outputs inputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out")) - (qtwebengine-process-path - (search-input-file - inputs "/lib/qt5/libexec/QtWebEngineProcess"))) - (wrap-qt-program "openshot-qt" - #:output out #:inputs inputs) - ;; Help the program discover QtWebEngine at runtime. - (wrap-program (string-append out "/bin/openshot-qt") - `("QTWEBENGINEPROCESS_PATH" = - (,qtwebengine-process-path))))))))) + (setenv "HOME" "/tmp")))))) (home-page "https://www.openshot.org/") (synopsis "Video editor") (description "OpenShot takes your videos, photos, and music files and -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:32:08 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:32:08 +0000 Received: from localhost ([127.0.0.1]:60818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teReS-0000BN-3t for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:32:08 -0500 Received: from mail.envs.net ([5.199.136.28]:47788) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teReM-00009m-C4 for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:32:06 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 95C5338A2C06; Sun, 2 Feb 2025 04:32:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id UoShqinoNEl0; Sun, 2 Feb 2025 04:31:58 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:31:55 +0000 (UTC) Received: from localhost.localdomain (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id c422eaa2; Sun, 2 Feb 2025 04:35:16 +0000 (UTC) From: iyzsong@envs.net To: 75966@debbugs.gnu.org Subject: [PATCH v3 10/10] gnu: qutebrowser: Do not wrap with QTWEBENGINEPROCESS_PATH. Date: Sun, 2 Feb 2025 12:34:59 +0800 Message-ID: <01b9a27f0667f70e1370265f28045136460edc1a.1738470835.git.iyzsong@member.fsf.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: 宋文武 * gnu/packages/web-browsers.scm (qutebrowser): [arguments]: Remove QTWEBENGINEPROCESS_PATH from the 'wrap-qt-process-path phase. Change-Id: I7227e1f5abd9e9db98d603ca74ece6ea268b7eaa --- gnu/packages/web-browsers.scm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm index c0138eea17..2bc79de3b5 100644 --- a/gnu/packages/web-browsers.scm +++ b/gnu/packages/web-browsers.scm @@ -492,7 +492,7 @@ (define-public qutebrowser python-pyqtwebengine-6 python-tldextract ;; While qtwebengine is provided by python-pyqtwebengine-6, it's - ;; included here so we can wrap QTWEBENGINEPROCESS_PATH. + ;; included here so we can wrap QTWEBENGINE_RESOURCES_PATH. qtwebengine)) (arguments `(;; FIXME: With the existence of qtwebengine, tests can now run. But @@ -547,10 +547,7 @@ (define-public qutebrowser (wrap-program (search-input-file outputs "bin/qutebrowser") `("QTWEBENGINE_RESOURCES_PATH" = (,(search-input-directory - inputs "/share/qt6/resources"))) - `("QTWEBENGINEPROCESS_PATH" = - (,(search-input-file - inputs "/lib/qt6/libexec/QtWebEngineProcess"))))))))) + inputs "/share/qt6/resources"))))))))) (home-page "https://qutebrowser.org/") (synopsis "Minimal, keyboard-focused, vim-like web browser") (description "qutebrowser is a keyboard-focused browser with a minimal -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 23:33:22 2025 Received: (at 75966) by debbugs.gnu.org; 2 Feb 2025 04:33:22 +0000 Received: from localhost ([127.0.0.1]:60822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teRfd-0000DY-Nv for submit@debbugs.gnu.org; Sat, 01 Feb 2025 23:33:21 -0500 Received: from mail.envs.net ([5.199.136.28]:50842) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1teRfb-0000DP-4q for 75966@debbugs.gnu.org; Sat, 01 Feb 2025 23:33:19 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 58F1E38A2C06; Sun, 2 Feb 2025 04:33:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Q-dIwwfrz8IR; Sun, 2 Feb 2025 04:33:13 +0000 (UTC) Received: from localhost (unknown [112.44.100.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 2 Feb 2025 04:33:13 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 55e704b4; Sun, 2 Feb 2025 04:36:56 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Maxim Cournoyer Subject: Re: bug#75966: [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: <87jza9lo7a.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Sat, 01 Feb 2025 23:44:09 +0900") References: <64b2f94cf05195646d5076df6bd67a8538001e00.1738382284.git.iyzsong@member.fsf.org> <87jza9lo7a.fsf_-_@gmail.com> Date: Sun, 02 Feb 2025 12:36:56 +0800 Message-ID: <87cyg1t11z.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > I think it'd be a bit clearer to introduce the change to qt/qt-utils in > a same commit, and then proceed to remove the wrappers in one commit per > package. Done and sent as v3, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 09:37:38 2025 Received: (at 75966) by debbugs.gnu.org; 3 Feb 2025 14:37:38 +0000 Received: from localhost ([127.0.0.1]:38477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1texZx-0002aO-Vt for submit@debbugs.gnu.org; Mon, 03 Feb 2025 09:37:38 -0500 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:56618) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1texZv-0002a8-Tj for 75966@debbugs.gnu.org; Mon, 03 Feb 2025 09:37:36 -0500 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2166360285dso73220025ad.1 for <75966@debbugs.gnu.org>; Mon, 03 Feb 2025 06:37:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738593450; x=1739198250; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0YTHPWfSMDrtr7/mXVcJznv4DZ4NIWi+VNmntJ1j81g=; b=bu6fBKXhdjvKsKBogyudBIHB0l7EBQgmj2AstRoi17V8sC+AaUxSxseaxIbANlbdMi JNHLdXdjcOnlLDBnIvFx/rbD6XqOgQMRjIbfqSNNdXc+pepojmXNhFwdj8ZaTfpz58/a /ioPMUruiZtYGlY3D25Vp+nOC4pvL021bYZC5DInw5CH6H4fNryTjwXSbV2OxgO9A6l9 79o9PN4OBfbeD026RXbA83CCd1J25pZA63KAAwh4At2lxF9fBdV/D4yTe5yweLtDFtGz oCLWb3mo+AAg04taKRIcPYMOmfAd7UKesupSnzJzOuoj124eNdDarEPrq01JdPjmyPf9 wPMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738593450; x=1739198250; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0YTHPWfSMDrtr7/mXVcJznv4DZ4NIWi+VNmntJ1j81g=; b=ONJ2XxFPsoo29Zg8BfqIn6rHIHZjYzkKdqu+pA/x1CRxACeLECTfoJS01oLg21xfEg Uyu4S3zFFU918a80Sqh3s9We6M2LJdUDcAtg8mMfsArXgJYjT+OclHS+1+asRV9tv0CY 68JKrLE3p7E1edwX4chRGNhhvZhju0QvUijtlDmtgl8SDKWCjzt+EPDUzbdWH4GZXZfm Bqwq9dnuux4DAPt1aMhMVrtDFW9r0WqoVtbapTcu90l24s/f+8pg5eC/6KBISOhlf1Ie tev3avXSXW+gqRIpAurk/7UiEGGLXSVzsBnNOCVf/mDztsaaLywnWKgC/cAAKl0n1NgU w6Mg== X-Gm-Message-State: AOJu0Yz4pysKimSrsRix/RQH1zQukcRBZ/xtiSqOd1EbI0eu1RsvdQmK vp8zKn+ZxkkAM7oFZk5k3PppgMKD+TXrRJRV2ugiN2vfp+/OFIbNihERJ0pF X-Gm-Gg: ASbGncvwiik0mKzVAZigxbFS+XBOhhbPyxb+eBB82PUoRgIi4eEYtMxoP5Kp+qbafOv guqC1aXdnMmjrqF4aWELqOMnAm+i6OPVjtApURrjfnqtOxnc4SX39KubppO5rk+0OqM/AKyp3xH N4ZQxJ5iENn+8haxCeEBxyfaR9o5DhNet/tI86S9LTyYNsFY3DHum6saWjgecQPIGvNWgNAiynq 9pxwzOiurmU8PMhRJRFVeEjwKOUAUjdxt7ZC57AQxYNRrwWDmxFFxNOSTpoKuzAp6jiSPvF63Yz JAPCvm55JOUV X-Google-Smtp-Source: AGHT+IF47ccHc6DotUbOHn2SM56ja5cv8qxwa1A7GK+ju8KjHTRA97YTNhjMfegsobQbTRKSf9Omng== X-Received: by 2002:a17:902:f651:b0:216:2dc5:2310 with SMTP id d9443c01a7336-21dd7dfc60fmr396884765ad.48.1738593449749; Mon, 03 Feb 2025 06:37:29 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de330342asm76357925ad.193.2025.02.03.06.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 06:37:29 -0800 (PST) From: Maxim Cournoyer To: iyzsong@envs.net Subject: Re: bug#75966: [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: (iyzsong@envs.net's message of "Sun, 2 Feb 2025 12:34:50 +0800") References: Date: Mon, 03 Feb 2025 23:37:17 +0900 Message-ID: <87ed0fdrhe.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, iyzsong@envs.net writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > Since qtwebengine and qtbase are not installed into the same prefix, > the default path for QtWebEngineProcess won't work. Fix it so that > we no longer need to set QTWEBENGINEPROCESS_PATH anymore. > > * gnu/packages/qt.scm (qtwebengine-5, qtwebengine)[arguments]: > Substitute 'QLibraryInfo::LibraryExecutablesPath' in 'substitute-source p= hase. > [native-search-paths]: Remove QTWEBENGINEPROCESS_PATH. > * guix/build/qt-utils.scm (variables-for-wrapping): Remove > QTWEBENGINEPROCESS_PATH. > > Change-Id: Ie0dfaf8c2355a679e2a3ddeacf09654830f9ab2f Reviewed-by: Maxim Cournoyer I note that given then change to qt-utils, that's a Qt world rebuild change, and should go to a qt-team branch. Perhaps we could bunch a qt upgrade on top if time permits; we have a manifest that makes this rather simple (unless there are new test failures...). See etc/teams/qt-team/qt-manifest.scm for example, and the comment inside. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 09:40:34 2025 Received: (at 75966) by debbugs.gnu.org; 3 Feb 2025 14:40:34 +0000 Received: from localhost ([127.0.0.1]:38486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1texco-0002lJ-1A for submit@debbugs.gnu.org; Mon, 03 Feb 2025 09:40:34 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:42026) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1texcl-0002l0-5F for 75966@debbugs.gnu.org; Mon, 03 Feb 2025 09:40:31 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-216395e151bso53367865ad.0 for <75966@debbugs.gnu.org>; Mon, 03 Feb 2025 06:40:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738593625; x=1739198425; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M1P/0H/D9klPUhjq49v35crEE43SDdTOEADPhl4W5RE=; b=hvBJfnWTR01lsAgoN28OLE3QY7BtTJKmRVpbU/DozwRDNIKfcmVG+IkgPVwSG7ajpQ RbW2aF7GawphBU39Gfre+kc6xq37sD/gonLMvMbMVTubWDC7mo1oNjanMz1Y9iYKJEfj KzGpvLg8tWh+g/3c7+2A031cgbcQhG0TBdZEYYFttTMxReZ0mG7yprXm3ro4mC8VXX7d +kGEHYnleSnBjCsl6J2g1J0tigMiL5EFawd3/mGfJVAsccmDctmta4WJi+/Or5i0lLOS iS7Ra/9dKDnSAv3hzBzl+1sZXGQX290SnSRypUwaJk4PIhKKsVoo41lNX9GMyWxtS2xT 2mgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738593625; x=1739198425; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M1P/0H/D9klPUhjq49v35crEE43SDdTOEADPhl4W5RE=; b=PT14UKGNVzT+me/3BGHhcILcN2tRoYDC4lufS8tzt0kBY76Ffv8dvk9xfoDRfSiq+B ZtIhiNpPlv7AOg0Bce1g0uQbhSzeV7fgFReOkfDX4YwYQAax8acIFiRdH7KHKjnIKXV5 BaeWC3HxoIR2KPvFJ0WtyptLpDP8l/zbdNouEYU5b8cEVnBtixs9g7pC1mYVr6CmeEir oYva9SaHeH2zvr2j2fQXqI6BZE4Psp/Tmc+ajQymfed96I1WDr6QdriUYZ/JAKpAkekv gKPyHWoajcvMBveL6K/BMWWMwOQcTnd/nlysZ7NVKcW0371eoNDVYVZIoNJAkr0bemyJ IxkA== X-Gm-Message-State: AOJu0YzkkFXHbk2uIKkZnDik2u0vgHMRFg4G/h1GR4tZEeQHKGf6Tw5X 67+xpfmg9tKSDT2AnKBh9EAbh0M5PpUeiSRoxUvKD2DT0JuWujT3XaWN0Kh5 X-Gm-Gg: ASbGncuPA9q92Pfgf0ppAcEZ7mPGoUQ1BjxRBcjXjkVBYRD5q7z4dsVnehmNgIUpxMM WuEFblzcFfCdkhDhgOWd0mR8YXNX5/zCCtI5Ov+hRm6SMGVFgzvhoIyKAF7dtd5L3bp9YzImsJg wk6dzB6JyNHOFYYqPhZFkKNsv28SwwVRylD6lz1eoVaCDG+sfW3VBZefX6wsxlolXcSuhbBFigD X8/eiFFZ9+zYuIMk2Er0Q+ixxdwURHFeeipQ8GrpVk2I7fteP4RMwZpLQlz7n3yD4tv1rBLsv/J Fo92RsShjn6p X-Google-Smtp-Source: AGHT+IHRt/xxZOP1nZw8gXz2GQD83yN8/q6BHMNsAhLym4mQp+yYR/6IPNjKoy+/bXUfceXk6ZjlkA== X-Received: by 2002:a17:903:1ce:b0:215:7287:67bb with SMTP id d9443c01a7336-21de182c719mr321379745ad.0.1738593625249; Mon, 03 Feb 2025 06:40:25 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de33205b4sm77357315ad.245.2025.02.03.06.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 06:40:24 -0800 (PST) From: Maxim Cournoyer To: iyzsong@envs.net Subject: Re: bug#75966: [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: (iyzsong@envs.net's message of "Sun, 2 Feb 2025 12:34:51 +0800") References: Date: Mon, 03 Feb 2025 23:40:12 +0900 Message-ID: <874j1bdrcj.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) iyzsong@envs.net writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > * gnu/packages/ebook.scm (calibre)[arguments]: Remove 'wrap-program phase. > > Change-Id: If289d6d5bcd1582134bbb02a179425a4f9c6a4d0 Reviewed-by: Maxim Cournoyer --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 09:42:36 2025 Received: (at 75966) by debbugs.gnu.org; 3 Feb 2025 14:42:36 +0000 Received: from localhost ([127.0.0.1]:38490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1texel-0002p0-NR for submit@debbugs.gnu.org; Mon, 03 Feb 2025 09:42:35 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:56721) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1texek-0002oi-HV for 75966@debbugs.gnu.org; Mon, 03 Feb 2025 09:42:35 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2166360285dso73423295ad.1 for <75966@debbugs.gnu.org>; Mon, 03 Feb 2025 06:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738593748; x=1739198548; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LwEJQ/MWEMYlJmrxcqjcO6bPjkztp5rWb1+62SNbJHw=; b=VXMv7o1nofpjkumq7ThON4fgcWTybQDEtrwF7PzMiPxiUTbVaPuA9WdF5uu+cW4lnG gvRICP+drjbVDKzFCrzWcXzUMrn4S/yLQzzN0Y7JrhFgoa6ksMpnbXqYHx0EgG2vJCBq ZaPOtEyaRVe8pyKmZydB5HXc/56i6eKwmNixI0pJnEOUJf76YtsmmENGsF8ocaXOXm0q pXSUEqq1jKID8PhMwvql2ZUXCW0vOXpRvhUXP1q0l+g25ljB2CG6TRikZz/cxSnSdvvj WmGjItv8QvoF58VYs9k9o+bK1SFBfxBn99Po4p558gEMGx2mYCkIAd/cg6eJyG7s0Afy nVEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738593748; x=1739198548; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LwEJQ/MWEMYlJmrxcqjcO6bPjkztp5rWb1+62SNbJHw=; b=sSSYgR2i7dQo3cqrjyKWqAo5XuZOehVr5ckQ7//sLneQdjpzPe9S7XWiDR39rXmpFD 6Y3Pn7dEidi8c/+snA8xrOyTu5MPh0heyTcQjxA9MQaJw8OcQLTCuqeM53b82zUmU+LU F8W5/A+QC+tVv4jka2qWkgYO5O9AGqXEFCvvz/1vnS8xljb/o/w4WBERwNtq/IKH1R5x NMXHnV2QdMVkZhVoB2L7KUESn1exq6NpSIYljOyslLNGV1qHDiWlZovPKRSbfVSgy8iS lXAB8JUXLqFzVkTTahcjJSseay+6KWQelZHcoHJ5fB8fYPrO3EyQGD1Z9ok26OBli1VV DHJw== X-Gm-Message-State: AOJu0YxtGvoXP0tjbUL6SZFzYcEP3yp/r2WsyqZiRuMu0JY1hJux8oub zzaLwN/N7OJq1RF8I27XeuvMGgNUDiH9zp4f5Hulr2jK/kM2Kpls X-Gm-Gg: ASbGncv5vgDBkNCBdtfonI1mtuOJaCv2Jwfk8U44FSFuCyFIoaYPAuhI43/hL+GcZGW aBwVbe4dl/i0lPaggeooe8KIOC+E+GQCwWWwyuQvuD2lXVEQij7n4W1x/H4gKurKlMHeqQcVMJt MMeEVfY2foldXcniIZPg/dZuGIXiXW8mhEUoOW2OIB+yU8HL2dX4deRxcHiWUnOJ/PyH9l90duR o9Yb4xKXJKrIfGZHo52nMDIMfl3Mft9ikytZzMZ70vq2Y8/eILC1xdOApEjifNd0g52hVr8VJHd Dmey5DTmof+4 X-Google-Smtp-Source: AGHT+IEGHSHjt4m3nDbmsAwvj2EtxttKABsNic3IEol35lEpgNWrZnZogyTnnChzFOrpS0gsXf4ZAw== X-Received: by 2002:a17:903:124b:b0:20b:8a71:b5c1 with SMTP id d9443c01a7336-21dd7c4641cmr330972865ad.1.1738593748501; Mon, 03 Feb 2025 06:42:28 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de31ee66dsm76513525ad.50.2025.02.03.06.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 06:42:27 -0800 (PST) From: Maxim Cournoyer To: iyzsong@envs.net Subject: Re: bug#75966: [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: <3ab14499f91127ac45500e86ce6a4d71772e60a8.1738470835.git.iyzsong@member.fsf.org> (iyzsong@envs.net's message of "Sun, 2 Feb 2025 12:34:52 +0800") References: <3ab14499f91127ac45500e86ce6a4d71772e60a8.1738470835.git.iyzsong@member.fsf.org> Date: Mon, 03 Feb 2025 23:42:15 +0900 Message-ID: <87zfj3ccoo.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, iyzsong@envs.net writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > * gnu/packages/education.scm (anki):[arguments]: Remove > QTWEBENGINEPROCESS_PATH from the 'wrap phase. nitpick: You can omit single quotes for phase names in the change log, and there shouldn't be a colon between (anki) and [arguments] (there should be a space according to (info '(standards) Style of Change Logs') which is a manual provided the autoconf package.). Reviewed-by: Maxim Cournoyer --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 10:19:50 2025 Received: (at 75966) by debbugs.gnu.org; 3 Feb 2025 15:19:50 +0000 Received: from localhost ([127.0.0.1]:40761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1teyEo-00054I-1g for submit@debbugs.gnu.org; Mon, 03 Feb 2025 10:19:50 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:56658) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1teyEk-000541-S0 for 75966@debbugs.gnu.org; Mon, 03 Feb 2025 10:19:47 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-2166360285dso74395555ad.1 for <75966@debbugs.gnu.org>; Mon, 03 Feb 2025 07:19:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738595981; x=1739200781; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pj1L5JhZJHPmZ45xOs6LCxp9oPBPWXOlUBDm+rjlpKg=; b=ctzLEIEdlWHwCocx7B33X3qdfqPnM8e/NMxKQazH51PjRtEblM3qI0MqSUo6NWwq31 oUuHCC0mSZ6l4dSZt9Gy4AFQrYsr9dPktJZbCJERp3YyOKWM0GLiaIQEIuiWg4Y//65Q 7wl+3qSx0MId3gSqJc5Rh89sDmwpeDEq9BWUQCdbmydiSpJxyb6/h6izVT7PWuNNOkOU jtjSehbR8saceyjLpEx/Xz27fd5qqWRh+cjv8+OFTIS2CNTo/rm47EAlbamigDOy6rfM JMdqBK1GHjjaioaQA/p2AAGgPL4RMV2XoxJQQHgT05KCHQg1A0LB5TQkzefxcczyVPwl nBwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738595981; x=1739200781; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pj1L5JhZJHPmZ45xOs6LCxp9oPBPWXOlUBDm+rjlpKg=; b=cJLR9M7tdwW0ITbJ/a5RE1IoduNMDDtSHeG5eUqNTh+jTACUUahow3Qwlfat0q5uhJ KLwMOBDyVKV/Ojc3SWbfjHeFpDQqpq7KKpaPyN4bQioF24E9O2ODUBtXIyV5CWxm6ICZ CCX+cGDzaat12RX4IZdLuFwAy4bA44Zc8KlSqIp5Qa+Y4Fs2HXK8wgBTKQjznvscTALJ 44uIxEdsPDQMf86ZHnWKl+hD5dSKu58ywEOHPgS1uV8B8HqCoTVGEJXnApVmCpCnQaKx ScEkcyyeG4/ZdW7gifWNAAjDP02prWRCgcnZOFJLEjJ6/orOayhzsHrSVdyIOAy4RpLB AtDQ== X-Gm-Message-State: AOJu0YwiR2P8IbCaamoGB9HaBfFdmRMXRSPdFMDBulQnfP2Uj6u2/9wv 5wIzXoRYr+ZnjHRrZDzl5D8HXWAup0Zaonzup1swXEAcL08b+Toq X-Gm-Gg: ASbGncsOz6YE4+C+WchtOeM3vNffjkDBEFte2ttQ/qY4+O27u4xGmPQihs/LiAKyZSL FBnnyG29gAB0QbtElZzfIeXjFDz+mebThN3Hm5hy1JQDC+0D1nd+LWDKzOf5zjEdTNcZ+/c72Ap yJXGiKHhF1dTeRMgbrsKiCeVu7iBC6EysnJADYF90VUuvk7NXNS8Fm9FGC7chGp196QRDibH09l uqebUkLNpM5gqr6fQndNNBVmiUJw0/c1Xmyxq1pZlO7KtSHR8jXmTMkuRQCgylntO772n4DYPxB 02v/UXsUgtbp X-Google-Smtp-Source: AGHT+IGl0Hx6D9ZL0ALWS9w/Prbad1zTqrqAgshoyj31pekd1PrVV7KppVy9thCldzZaoxNY/l1ciQ== X-Received: by 2002:a05:6300:6f8c:b0:1ed:a72f:bed2 with SMTP id adf61e73a8af0-1eda72fc05dmr10298836637.5.1738595980649; Mon, 03 Feb 2025 07:19:40 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-acec0a65716sm6752892a12.68.2025.02.03.07.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 07:19:40 -0800 (PST) From: Maxim Cournoyer To: iyzsong@envs.net Subject: Re: [bug#75966] [PATCH v3 10/10] gnu: qutebrowser: Do not wrap with QTWEBENGINEPROCESS_PATH. In-Reply-To: <01b9a27f0667f70e1370265f28045136460edc1a.1738470835.git.iyzsong@member.fsf.org> (iyzsong@envs.net's message of "Sun, 2 Feb 2025 12:34:59 +0800") References: <01b9a27f0667f70e1370265f28045136460edc1a.1738470835.git.iyzsong@member.fsf.org> Date: Tue, 04 Feb 2025 00:19:27 +0900 Message-ID: <871pwfcayo.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, iyzsong@envs.net writes: > From: =E5=AE=8B=E6=96=87=E6=AD=A6 > > * gnu/packages/web-browsers.scm (qutebrowser): [arguments]: Remove > QTWEBENGINEPROCESS_PATH from the 'wrap-qt-process-path phase. > [...] This one and the other before LGTM, with the same nitpicks about the GNU change log style.=20 --8<---------------cut here---------------start------------->8--- Reviewed-by: Maxim Cournoyer --8<---------------cut here---------------end--------------->8--- By the way, I notice that sending the cover letter on each submission is useful, as I could then put my reviewed-by trailer on the 0/N commit (the cover letter) to mean 'whole series LGTM', at least per 'b4 shazam' semantic, which will add the trailer for you if you use it to apply the patches. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 02:10:17 2025 Received: (at 75966) by debbugs.gnu.org; 4 Feb 2025 07:10:17 +0000 Received: from localhost ([127.0.0.1]:42384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tfD4b-0003CN-5U for submit@debbugs.gnu.org; Tue, 04 Feb 2025 02:10:17 -0500 Received: from mail.envs.net ([5.199.136.28]:48002) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tfD4Y-0003CD-5r for 75966@debbugs.gnu.org; Tue, 04 Feb 2025 02:10:14 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 3634238A3E58; Tue, 4 Feb 2025 07:10:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gxWvf5kCl5MV; Tue, 4 Feb 2025 07:10:07 +0000 (UTC) Received: from localhost (unknown [112.44.101.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Tue, 4 Feb 2025 07:10:07 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 0fe604b5; Tue, 4 Feb 2025 07:13:42 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Maxim Cournoyer Subject: Re: [bug#75966] [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: <87ed0fdrhe.fsf_-_@gmail.com> (Maxim Cournoyer's message of "Mon, 03 Feb 2025 23:37:17 +0900") References: <87ed0fdrhe.fsf_-_@gmail.com> Date: Tue, 04 Feb 2025 15:13:42 +0800 Message-ID: <87ldumqj15.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Maxim Cournoyer writes: > [...] > > Reviewed-by: Maxim Cournoyer > > I note that given then change to qt-utils, that's a Qt world rebuild > change, and should go to a qt-team branch. Perhaps we could bunch a qt > upgrade on top if time permits; we have a manifest that makes this > rather simple (unless there are new test failures...). See > etc/teams/qt-team/qt-manifest.scm for example, and the comment inside. I have adjust the change logs and push them into qt-team branch. Also with 'guix refresh' for 'qt-manifest.scm', update qt to 6.8.2. qtbase now require a newer version of freetype, so update it first. I haven't build them locally, so consider the 'qt-team' branch WIP. I'll test them and update python-pyqt later. Thank you! From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 04 21:00:16 2025 Received: (at 75966) by debbugs.gnu.org; 5 Feb 2025 02:00:16 +0000 Received: from localhost ([127.0.0.1]:47389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tfUi7-000896-W2 for submit@debbugs.gnu.org; Tue, 04 Feb 2025 21:00:16 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]:42036) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tfUi5-00085D-Iu for 75966@debbugs.gnu.org; Tue, 04 Feb 2025 21:00:14 -0500 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-21f0b5d6c6eso5157315ad.0 for <75966@debbugs.gnu.org>; Tue, 04 Feb 2025 18:00:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738720807; x=1739325607; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1+pczPyIWGfSCFEi8upqWGxZa/AVlQXdUFFT9MRqeOM=; b=IPLHEig+oa5YQDTpuuOXtUPJUrMYLCctvwxx8ZAjGMXNrs+fz3M3F7wMjyvqB5g1zQ SLmjDFR+3qqLMZ+M3n2OXNomHT2xVOz4+m1BXXjpw2v9xIhPyoL01gqMfUKd0hItsMzS rbwlnCQX9gFiBZvVgPPasuuVtQlaCDUOzElSZrNwSOUif42FkJTZ+2aw94fmtbm3Mgl8 KLiDoCpMIsi+Te+PIQDfsFENsq3DxaSZQa+fH0/dGKc00z6oIUq+j1GvXivlI2ct5OpA zF+xKHWJyOpYEY9ujlLP7vANiF78M35mifL67oN9bSBIazzCnCCpIuQufNixEOSMJggJ wV0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738720807; x=1739325607; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1+pczPyIWGfSCFEi8upqWGxZa/AVlQXdUFFT9MRqeOM=; b=Tf0rELBx1ezD2/cL37vQTy/TmBl5QS9EXxK6S4KjAQk/Fu0lAJmuSrtJk1LTPPYs4o iQHTDNQaG6sZc2oGHORMqzl6WGDwYPOSW8//GQBAayZ0TEoWH4xAN+QA3T1IgY60mVIa 2PF/Znc2IjE+tW8VVDx3ibIPuk4h8dMUQCZJ2e+mP2Fi5AxUkzpwuLS6SK2/2QFbPiQY T+us3Aa9G0jsMEl6vgPDn6jb4BBMPVFxF4cMUo9AKOrE1el4Iduzx7kh+RntIiEG0QUe pprydlw9wMFuUoNjv91TS6YSaI+h1W8JSmGkOZ54Bf5+dMtIdZ63O8HjO9uf+kvQziJG 5kvA== X-Forwarded-Encrypted: i=1; AJvYcCVADHG7/M2GaTcw70SOVfgnzQP7mwlGAX2qTDC3RLahadMaUeNdnZ5wwxe7OGZnX7jzlK5PCg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxflACI6bMRHb8rkMtrb8U30r4vWGka9ubHNXyMJpFLStaRs3OS 2fE/HC5prGhi29id+ifZOoXqmaQbW8ojPs0AH8y1A4Awd514OtROvCwv1ZNR X-Gm-Gg: ASbGncue/AmS8nZEFSzlVoT57afywWDuEhVscEjk4p+VPOp8n4CnLkS57BVvviA6/Tr 7TOgaOxVPWxA42HfvBYktIb5B4CFsrLvgg8BlMjjaiFEVfTnyb+fQAaTZIcRJSWhMnbSID2RSmz YBxM0syrfOOeubGW9jzkDl0y/8NfO1Wh/4yvtV01v4g1mc7CXUzlOLyzGa0BBtSrfTGJpuaB46u 8inmtDIYdGmyVE7UySc3eYt9+IUkMxk7wAItFrAjPjA+BolDZZCwIvZE+sPKuGA0UWTz8sZfJMr 3jOuzUwhVsGz X-Google-Smtp-Source: AGHT+IEaJ9h2gROsnYL2KDpe2+ZyEl2A+JPONfFcHLN3cvNThIs8nAsXUYEDLp+sfl7aYBO0Btr2EQ== X-Received: by 2002:a17:902:da84:b0:216:3f6e:fabd with SMTP id d9443c01a7336-21f01c17563mr79624795ad.7.1738720806961; Tue, 04 Feb 2025 18:00:06 -0800 (PST) Received: from terra ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21de32ecad9sm103837565ad.157.2025.02.04.18.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 18:00:06 -0800 (PST) From: Maxim Cournoyer To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [bug#75966] [PATCH] gnu: qtwebengine: Set default path for QtWebEngineProcess. In-Reply-To: <87ldumqj15.fsf@envs.net> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Tue, 04 Feb 2025 15:13:42 +0800") References: <87ed0fdrhe.fsf_-_@gmail.com> <87ldumqj15.fsf@envs.net> Date: Wed, 05 Feb 2025 10:59:54 +0900 Message-ID: <87bjvh9mn9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75966 Cc: =?utf-8?B?5a6L5paH5q2m?= , 75966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, =E5=AE=8B=E6=96=87=E6=AD=A6 writes: > Maxim Cournoyer writes: > >> [...] >> >> Reviewed-by: Maxim Cournoyer >> >> I note that given then change to qt-utils, that's a Qt world rebuild >> change, and should go to a qt-team branch. Perhaps we could bunch a qt >> upgrade on top if time permits; we have a manifest that makes this >> rather simple (unless there are new test failures...). See >> etc/teams/qt-team/qt-manifest.scm for example, and the comment inside. > > I have adjust the change logs and push them into qt-team branch. Also > with 'guix refresh' for 'qt-manifest.scm', update qt to 6.8.2. qtbase > now require a newer version of freetype, so update it first. > > I haven't build them locally, so consider the 'qt-team' branch WIP. > I'll test them and update python-pyqt later. Thank you! Awesome, thank you. --=20 Thanks, Maxim