From unknown Tue Aug 19 13:14:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7596: 23.2.90; fill-flowed with DELETE-SPACE option does not work Resent-From: Kazuhiro Ito Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2010 23:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7596 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7596@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12918517436001 (code B ref -1); Wed, 08 Dec 2010 23:43:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Dec 2010 23:42:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQTeR-0001Yj-Dt for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:42:23 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQTeO-0001YU-U5 for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:42:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQTkB-0001ul-09 for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:48:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:44737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQTkA-0001uh-UL for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:48:18 -0500 Received: from [140.186.70.92] (port=33165 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQTk9-0004UC-Li for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 18:48:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQTk7-0001uJ-La for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 18:48:17 -0500 Received: from msa103.auone-net.jp ([61.117.18.163]:58266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQTk7-0001s3-Dh for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 18:48:15 -0500 Received: from MJOLNIR.med.osaka-cu.ac.jp (dhcp-sch-f7-211-148.med.osaka-cu.ac.jp [160.193.211.148]) by msa103.auone-net.jp (au one net msa) with ESMTP id 46B5834803A; Thu, 9 Dec 2010 08:48:03 +0900 (JST) Date: Thu, 09 Dec 2010 08:48:00 +0900 Message-ID: <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp> From: Kazuhiro Ito User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/23.2.90 (i386-mingw-nt5.1.2600) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Thu_Dec_09_08:48:00_2010-1" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.5 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) --Multipart_Thu_Dec_09_08:48:00_2010-1 Content-Type: text/plain; charset=US-ASCII When I start emacs (emacs-23 branch) with -Q and evaluate below code, I receive unexpected result. (with-temp-buffer (insert "ABC \nDEF") (fill-flowed nil t) (buffer-string)) It returns "ABC DEF" But I expect "ABCDEF" I expect DELETE-SPACE option corresponds to "DelSp" parameter in RFC3676 and works so. Plesse see attached patch. -- Kazuhiro Ito --Multipart_Thu_Dec_09_08:48:00_2010-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="flow-fill.el.diff" Content-Transfer-Encoding: 7bit === modified file 'lisp/gnus/flow-fill.el' --- lisp/gnus/flow-fill.el 2010-01-13 08:35:10 +0000 +++ lisp/gnus/flow-fill.el 2010-12-08 10:14:13 +0000 @@ -106,8 +106,6 @@ (forward-line 1)) (goto-char (point-min)) (while (re-search-forward " $" nil t) - (when delete-space - (delete-char -1)) (when (save-excursion (beginning-of-line) (looking-at "^\\(>*\\)\\( ?\\)")) @@ -135,6 +133,8 @@ (replace-match (if (string= (match-string 2) " ") "" "\\2"))) (backward-delete-char -1) + (when delete-space + (delete-char -1)) (end-of-line)) (unless sig (condition-case nil --Multipart_Thu_Dec_09_08:48:00_2010-1-- From unknown Tue Aug 19 13:14:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7596: 23.2.90; fill-flowed with DELETE-SPACE option does not work Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jan 2011 19:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7596 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: ding@gnus.org Cc: Kazuhiro Ito , 7596@debbugs.gnu.org Received: via spool by 7596-submit@debbugs.gnu.org id=B7596.129572424431527 (code B ref 7596); Sat, 22 Jan 2011 19:25:01 +0000 Received: (at 7596) by debbugs.gnu.org; 22 Jan 2011 19:24:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pgj48-0008CR-94 for submit@debbugs.gnu.org; Sat, 22 Jan 2011 14:24:04 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pgj46-0008Bx-K9 for 7596@debbugs.gnu.org; Sat, 22 Jan 2011 14:24:03 -0500 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p0MJVq2M030217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 22 Jan 2011 14:31:53 -0500 Received: by furball (Postfix, from userid 1000) id 5FE681611FB; Sat, 22 Jan 2011 14:31:52 -0500 (EST) From: Chong Yidong References: <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp> Date: Sat, 22 Jan 2011 14:31:52 -0500 In-Reply-To: <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp> (Kazuhiro Ito's message of "Thu, 09 Dec 2010 08:48:00 +0900") Message-ID: <877hdwzqdz.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Kazuhiro Ito writes: > (with-temp-buffer > (insert "ABC \nDEF") > (fill-flowed nil t) > (buffer-string)) > It returns > "ABC > DEF" > But I expect > "ABCDEF" > I expect DELETE-SPACE option corresponds to "DelSp" parameter in > RFC3676 and works so. Plesse see attached patch. Could a Gnus developer please review Kazuhiro Ito's patch? Thanks. --- lisp/gnus/flow-fill.el 2010-01-13 08:35:10 +0000 +++ lisp/gnus/flow-fill.el 2010-12-08 10:14:13 +0000 @@ -106,8 +106,6 @@ (forward-line 1)) (goto-char (point-min)) (while (re-search-forward " $" nil t) - (when delete-space - (delete-char -1)) (when (save-excursion (beginning-of-line) (looking-at "^\\(>*\\)\\( ?\\)")) @@ -135,6 +133,8 @@ (replace-match (if (string= (match-string 2) " ") "" "\\2"))) (backward-delete-char -1) + (when delete-space + (delete-char -1)) (end-of-line)) (unless sig (condition-case nil From unknown Tue Aug 19 13:14:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kazuhiro Ito Subject: bug#7596: closed (Re: bug#7596: 23.2.90; fill-flowed with DELETE-SPACE option does not work) Message-ID: References: <878vycra72.fsf@gnus.org> <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp> X-Gnu-PR-Message: they-closed 7596 X-Gnu-PR-Package: emacs Reply-To: 7596@debbugs.gnu.org Date: Sat, 22 Jan 2011 19:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1295725322-3503-1" This is a multi-part message in MIME format... ------------=_1295725322-3503-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #7596: 23.2.90; fill-flowed with DELETE-SPACE option does not work which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 7596@debbugs.gnu.org. --=20 7596: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D7596 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1295725322-3503-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 7596-close) by debbugs.gnu.org; 22 Jan 2011 19:41:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PgjKk-0000tK-5x for submit@debbugs.gnu.org; Sat, 22 Jan 2011 14:41:14 -0500 Received: from baybryj.net ([198.144.208.130] helo=vaio) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PgjKi-0000t7-AU for 7596-close@debbugs.gnu.org; Sat, 22 Jan 2011 14:41:12 -0500 Received: from larsi by vaio with local (Exim 4.69) (envelope-from ) id 1PgjSK-0004OO-JB; Sat, 22 Jan 2011 20:49:04 +0100 From: Lars Ingebrigtsen To: Chong Yidong Subject: Re: bug#7596: 23.2.90; fill-flowed with DELETE-SPACE option does not work In-Reply-To: <877hdwzqdz.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 22 Jan 2011 14:31:52 -0500") Date: Sat, 22 Jan 2011 20:48:49 +0100 Message-ID: <878vycra72.fsf@gnus.org> References: <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp> <877hdwzqdz.fsf@stupidchicken.com> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7596-close Cc: Kazuhiro Ito , 7596-close@debbugs.gnu.org, ding@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Chong Yidong writes: >> I expect DELETE-SPACE option corresponds to "DelSp" parameter in >> RFC3676 and works so. Plesse see attached patch. > > Could a Gnus developer please review Kazuhiro Ito's patch? Thanks. It looks reasonable to me. I've applied the patch. -- (domestic pets only, the antidote for overdose, milk.) larsi@gnus.org * Lars Magne Ingebrigtsen ------------=_1295725322-3503-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Dec 2010 23:42:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQTeR-0001Yj-Dt for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:42:23 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQTeO-0001YU-U5 for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:42:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQTkB-0001ul-09 for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:48:19 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:44737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQTkA-0001uh-UL for submit@debbugs.gnu.org; Wed, 08 Dec 2010 18:48:18 -0500 Received: from [140.186.70.92] (port=33165 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQTk9-0004UC-Li for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 18:48:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQTk7-0001uJ-La for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 18:48:17 -0500 Received: from msa103.auone-net.jp ([61.117.18.163]:58266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQTk7-0001s3-Dh for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 18:48:15 -0500 Received: from MJOLNIR.med.osaka-cu.ac.jp (dhcp-sch-f7-211-148.med.osaka-cu.ac.jp [160.193.211.148]) by msa103.auone-net.jp (au one net msa) with ESMTP id 46B5834803A; Thu, 9 Dec 2010 08:48:03 +0900 (JST) Date: Thu, 09 Dec 2010 08:48:00 +0900 Message-ID: <82bp4vn7wv.wl%kzhr@d1.dion.ne.jp> From: Kazuhiro Ito To: bug-gnu-emacs@gnu.org Subject: 23.2.90; fill-flowed with DELETE-SPACE option does not work User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/23.2.90 (i386-mingw-nt5.1.2600) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Thu_Dec_09_08:48:00_2010-1" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) --Multipart_Thu_Dec_09_08:48:00_2010-1 Content-Type: text/plain; charset=US-ASCII When I start emacs (emacs-23 branch) with -Q and evaluate below code, I receive unexpected result. (with-temp-buffer (insert "ABC \nDEF") (fill-flowed nil t) (buffer-string)) It returns "ABC DEF" But I expect "ABCDEF" I expect DELETE-SPACE option corresponds to "DelSp" parameter in RFC3676 and works so. Plesse see attached patch. -- Kazuhiro Ito --Multipart_Thu_Dec_09_08:48:00_2010-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="flow-fill.el.diff" Content-Transfer-Encoding: 7bit === modified file 'lisp/gnus/flow-fill.el' --- lisp/gnus/flow-fill.el 2010-01-13 08:35:10 +0000 +++ lisp/gnus/flow-fill.el 2010-12-08 10:14:13 +0000 @@ -106,8 +106,6 @@ (forward-line 1)) (goto-char (point-min)) (while (re-search-forward " $" nil t) - (when delete-space - (delete-char -1)) (when (save-excursion (beginning-of-line) (looking-at "^\\(>*\\)\\( ?\\)")) @@ -135,6 +133,8 @@ (replace-match (if (string= (match-string 2) " ") "" "\\2"))) (backward-delete-char -1) + (when delete-space + (delete-char -1)) (end-of-line)) (unless sig (condition-case nil --Multipart_Thu_Dec_09_08:48:00_2010-1-- ------------=_1295725322-3503-1--