Subject: [bug#75959] [PATCH v5] services: syncthing: Added support for config file serialization.

From: Bruno Victal <[email-masked]>
Date: Sat, 8 Feb 2025 12:14:36 +0000

On 2025-02-07 22:44, Leo Famulari wrote:
>> +;; It is useful to be able to view the xml output by Guix, and to be able to
>> +;; diff it with a user's previous config, especially when migrating one's
>> +;; config to Guix.  This function adds whitespace that matches the whitespace
>> +;; of config files managed by Syncthing for easy diffing.
>> +(define (indent-sxml sxml indent-increment current-indent)
> 
> Nice. Hopefully this doesn't go stale anytime soon.
> 
> Overall, it's looking good. Thanks a lot for this contribution! Let me
> know what you think about the feedback I've given here.

I think this addition is unnecessary since there's a well-known command
to pretty-print any XML file:
  xmllint --format <the-file>

Admittedly to my untrained eyes, this indent-sxml looks complex at a
superficial glance and just adds maintenance burden without necessity
in light of xmllint existence IMO.

My 2¢,

-- 
Bruno.