Subject: bug#75954: closed (Re: bug#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp")

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 01 Feb 2025 02:30:02 +0000

Your bug report

#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp"

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
75954: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=75954
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp"
From: Stefan Kangas <[email-masked]>
To: Damien Cassou <[email-masked]>, [email-masked]
Date: Sat, 1 Feb 2025 03:29:40 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 30.1

Damien Cassou <[email-masked]> writes:

> Hi Stefan,
>
> Stefan Kangas <[email-masked]> writes:
>> Damien Cassou <[email-masked]> writes:
>>
>>> some packages provide a binary "OmniSharp" instead of "omnisharp". In
>>> a case-sensitive file-systems this means eglot will not find the binary
>>> file and won't work.
>>
>> Is this on MS-Windows?  Isn't that supposed to be case-insensitive?
>
>
> nixpkgs for example provides "OmniSharp"
>
> https://search.nixos.org/packages?channel=unstable&show=omnisharp-roslyn&from=0&size=50&sort=relevance&type=packages&query=omnisharp-roslyn

OK, thanks.  I installed the patch on emacs-30 as 87be3aa1491.  Closing.

Subject: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp"
From: Damien Cassou <[email-masked]>
To: [email-masked]
Date: Thu, 30 Jan 2025 22:15:21 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Tags: patch

Hi,

some packages provide a binary "OmniSharp" instead of "omnisharp". In
a case-sensitive file-systems this means eglot will not find the binary
file and won't work.

Best

-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
>From 3bb0ea1968880fa4572b139a9b284ec187eae9a9 Mon Sep 17 00:00:00 2001
From: Damien Cassou <[email-masked]>
Date: Thu, 30 Jan 2025 21:44:31 +0100
Subject: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp"

Some packages provide a binary "OmniSharp" instead of "omnisharp" which
breaks in case-sensitive file-systems.

* lisp/progmodes/eglot.el (eglot-server-programs): Add "OmniSharp" as
valid binary name to search for.
---
 lisp/progmodes/eglot.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index c2a8562eb97..38ab44bae69 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -325,6 +325,7 @@ eglot-server-programs
     ((csharp-mode csharp-ts-mode)
      . ,(eglot-alternatives
          '(("omnisharp" "-lsp")
+           ("OmniSharp" "-lsp")
            ("csharp-ls"))))
     (purescript-mode . ("purescript-language-server" "--stdio"))
     ((perl-mode cperl-mode)
-- 
2.47.1