From unknown Tue Aug 19 12:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2025 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 75954@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173827176120262 (code B ref -1); Thu, 30 Jan 2025 21:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jan 2025 21:16:01 +0000 Received: from localhost ([127.0.0.1]:48180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdbtI-0005Gk-S3 for submit@debbugs.gnu.org; Thu, 30 Jan 2025 16:16:01 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50202) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdbtE-0005GL-QS for submit@debbugs.gnu.org; Thu, 30 Jan 2025 16:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdbsn-0002qp-LF for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2025 16:15:30 -0500 Received: from mail.reprendre.net ([193.23.30.35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdbsl-0007H6-DF for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2025 16:15:29 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3B7F02CAC32 for ; Thu, 30 Jan 2025 22:15:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=dkim; t=1738271722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=HmzjHhzvJGDBaI4l+szsh4iz9mEtiOMwJ1WnRclqM2w=; b=OdBHQKi522e9a9ZBaFccL4DTsqsrvh3pzyjFKwCokQPGSNb9/yVRqB4BR4NzQ/FOC9batn CXAaJVL92amUFM9vS2+TmZlM085GCfbTySXqvS5kObf7Q7j8f8AA7iwfoPsJ+zRHTAyhFH D9qq/y/CGzri/NVHnGap56Alm7tgmetwCJ2DTh4Z7rDM0Zzp8hYzpxnFjOY/p5BH39mW2Q 9YZGW5Ywezfgm9ZMfhb6kwh8ezMpKVT3Kt5Vmxn3t2kYfNHe6iBZfAv/hBONrB2gKoQSLj VaxtK6Vf0dQmtBQ6op8nkeWA8bSBNZXEXA6aKwtDqAUA7pxOtx0E0QTvulKvSQ== From: Damien Cassou Date: Thu, 30 Jan 2025 22:15:21 +0100 Message-ID: <87y0ysm2ae.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Last-TLS-Session-Version: TLSv1.3 Received-SPF: pass client-ip=193.23.30.35; envelope-from=damien@cassou.me; helo=mail.reprendre.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch Hi, some packages provide a binary "OmniSharp" instead of "omnisharp". In a case-sensitive file-systems this means eglot will not find the binary file and won't work. Best -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-eglot-Allow-omnisharp-binary-to-be-capitalized-OmniS.patch >From 3bb0ea1968880fa4572b139a9b284ec187eae9a9 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Thu, 30 Jan 2025 21:44:31 +0100 Subject: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" Some packages provide a binary "OmniSharp" instead of "omnisharp" which breaks in case-sensitive file-systems. * lisp/progmodes/eglot.el (eglot-server-programs): Add "OmniSharp" as valid binary name to search for. --- lisp/progmodes/eglot.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index c2a8562eb97..38ab44bae69 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -325,6 +325,7 @@ eglot-server-programs ((csharp-mode csharp-ts-mode) . ,(eglot-alternatives '(("omnisharp" "-lsp") + ("OmniSharp" "-lsp") ("csharp-ls")))) (purescript-mode . ("purescript-language-server" "--stdio")) ((perl-mode cperl-mode) -- 2.47.1 --=-=-=-- From unknown Tue Aug 19 12:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2025 02:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Damien Cassou , 75954@debbugs.gnu.org Received: via spool by 75954-submit@debbugs.gnu.org id=B75954.17382904248865 (code B ref 75954); Fri, 31 Jan 2025 02:28:02 +0000 Received: (at 75954) by debbugs.gnu.org; 31 Jan 2025 02:27:04 +0000 Received: from localhost ([127.0.0.1]:48718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdgkK-0002Iv-G7 for submit@debbugs.gnu.org; Thu, 30 Jan 2025 21:27:04 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:61514) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tdgkH-0002II-1a for 75954@debbugs.gnu.org; Thu, 30 Jan 2025 21:27:01 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5d3f28a4fccso2113216a12.2 for <75954@debbugs.gnu.org>; Thu, 30 Jan 2025 18:27:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738290414; x=1738895214; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=Ep07NZwEji8tn/u+bewaxy5CPqvFGYs0A4ySZem5A8E=; b=Ir2At5qF+Np1NC8D3PdDS9PvBtxm9aGLfIDItc2ey4MRWIYYcMJoAtwTadQanA0Nea VGLm4KqumhhXJyyppNYNIQdw6dHd/cMzFCsrcPpcoOdIDvTB/KqtFjzKV9kHbwS33M1M za4T895gyEYMWYnhZzKLBrJEMRDzjW7rvz6E0lX/D9O6YHn1YqDTWOD6xrwcmT6J41dL 5WTU8gStCXaBNQQ3Nhc4ntTUAkvoGA53RI7DYqLMfvLcOX6RQt7ssPEwPNEjq2IjWE3N W9sMw3VUfxug4nLs/7t279A5BbRav2QPw8/AYCNo+B208IU1DAYR7i4FHRLV4EsAMJYf Id0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738290414; x=1738895214; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ep07NZwEji8tn/u+bewaxy5CPqvFGYs0A4ySZem5A8E=; b=kH/Kp6477TXPPNYk7GV9aU0NOaxhRBpiT1Rmgnv7c2JYUHgdQu+dHRxUbpldatz4rU i31dvY5U1WATAO2zx3jAMgip9EtkDSIKkSxBkW73/d5/wfDZ4G0jgNB9XDUZwXis2UUF NhoNVGOzPsXJfs8isF5hnSR3k9o+HsUR/yH3Y/Crw+GvJHXEDz+FLFM42njUtt6000XL 9F++9P537Irr5qvqh2ZCU9JxJRU8S3VZTVjwHRgh/lw97v8qoG7iHq97fPOyLSw0mjV3 tt1VyWQp7YYOMCtvjDoUVpyrG6DCmZoZHpspGK94/zbGKMiiBKdica2oTcZd1Aik6E+r QfAw== X-Forwarded-Encrypted: i=1; AJvYcCUSJ1wr2RP0CLmk8j1NAIBqV0gVpU38o4AYVWzQ0BWOUFGe175cBwbv3yE4JUhvPOvGNUY5xg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzUwemRt/hhEHIJ8fYlQkiv3/8aMABJ68FDh3Pot778sy0SKb20 dnN+T5f7hGr/CmnJqi2U4v+04X/VP93f4fqFTRR411rANOC2+B/rG6B/GZlJzsPW4R4C/fZivl6 nUvd9ynbAYv3qvTV8gOI962s5Qn8= X-Gm-Gg: ASbGncsHPmPVJMtEnNvAfX2IXeNAzaX5XTJZ0h+qxsRbCb6gpXRlzoWYqhmXmkJ6vrw 5V+IAu7nMIJclDohsbr3JMs4qOVi3GKqfG6i/Azk/qB/A6V8/+u8GZtevro2/1+4qhaNHPgDptF A= X-Google-Smtp-Source: AGHT+IHK5sJF14BwsAcTT8ivy+9qH7zq1WSXimDwRytcqPtXToATMYgJNsLJzcdRUygW49QIrxQNGGOrXHCWk/6v6go= X-Received: by 2002:a05:6402:1d4c:b0:5dc:5bfe:189e with SMTP id 4fb4d7f45d1cf-5dc5efb8c86mr10758235a12.6.1738290414341; Thu, 30 Jan 2025 18:26:54 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 30 Jan 2025 21:26:53 -0500 From: Stefan Kangas In-Reply-To: <87y0ysm2ae.fsf@cassou.me> References: <87y0ysm2ae.fsf@cassou.me> MIME-Version: 1.0 Date: Thu, 30 Jan 2025 21:26:53 -0500 X-Gm-Features: AWEUYZmt227fdDdIrj7bZhmsYVrjzW0fQdoBiWnUKmfWnWMEIbPBjgVxmOiwS4k Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Damien Cassou writes: > some packages provide a binary "OmniSharp" instead of "omnisharp". In > a case-sensitive file-systems this means eglot will not find the binary > file and won't work. Thanks. Is this on MS-Windows? Isn't that supposed to be case-insensitive? I think we should document in this bug report at least, what are the "some packages" above, and which systems are affected. If the workaround is only helpful for MS-Windows, I think we should add a comment to that effect. From unknown Tue Aug 19 12:50:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2025 13:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas , 75954@debbugs.gnu.org Received: via spool by 75954-submit@debbugs.gnu.org id=B75954.173833004418323 (code B ref 75954); Fri, 31 Jan 2025 13:28:01 +0000 Received: (at 75954) by debbugs.gnu.org; 31 Jan 2025 13:27:24 +0000 Received: from localhost ([127.0.0.1]:50513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdr3L-0004lT-Tk for submit@debbugs.gnu.org; Fri, 31 Jan 2025 08:27:24 -0500 Received: from mail.reprendre.net ([193.23.30.35]:50624) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdr3J-0004lF-2A for 75954@debbugs.gnu.org; Fri, 31 Jan 2025 08:27:22 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 2011F2CAC19; Fri, 31 Jan 2025 14:27:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=dkim; t=1738330038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UF8TTN+hl0pWd9FB/2qZ264nnWGfYErBYK8tBtWnnOk=; b=YpaOjbxIbUUDbfe5TDRSfx9zcp/SNI1ApgqRgCj0etOHJpSdXBP21p3QCnUijBlPOfqo/U Tnd9nVzKIG7fJO/0PFUNEXAjyKzNsFcsDSehaZZNhEOU2srg/kyFErhJOpGDUb/9sQLfQz oovMY4JMIlfpQTCoGJQmwb9ZIuLhXo1NbwNzhPfPo7CAg2jLWh1yxTNBQ4gq1Gi2gGpgXd DwDPhTCQldH1obBT+HKcaXxkYIHUbDOM3wWCUkygD8TyWjiFUgAb9roj1N0DLjUgcjLqUJ VLhDjZcUCc63Vre9CqNnSMGt8ZviqnOcUwRrY4eUyOoQMZqXy2qOMBD4l80bSw== From: Damien Cassou In-Reply-To: References: <87y0ysm2ae.fsf@cassou.me> Date: Fri, 31 Jan 2025 14:26:56 +0100 Message-ID: <87v7tvm7vj.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan, Stefan Kangas writes: > Damien Cassou writes: > >> some packages provide a binary "OmniSharp" instead of "omnisharp". In >> a case-sensitive file-systems this means eglot will not find the binary >> file and won't work. > > Is this on MS-Windows? Isn't that supposed to be case-insensitive? nixpkgs for example provides "OmniSharp" https://search.nixos.org/packages?channel=unstable&show=omnisharp-roslyn&from=0&size=50&sort=relevance&type=packages&query=omnisharp-roslyn -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From unknown Tue Aug 19 12:50:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Damien Cassou Subject: bug#75954: closed (Re: bug#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp") Message-ID: References: <87y0ysm2ae.fsf@cassou.me> X-Gnu-PR-Message: they-closed 75954 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 75954@debbugs.gnu.org Date: Sat, 01 Feb 2025 02:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1738377002-10835-1" This is a multi-part message in MIME format... ------------=_1738377002-10835-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75954@debbugs.gnu.org. --=20 75954: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75954 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1738377002-10835-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75954-done) by debbugs.gnu.org; 1 Feb 2025 02:29:52 +0000 Received: from localhost ([127.0.0.1]:55660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1te3GZ-0002o5-Np for submit@debbugs.gnu.org; Fri, 31 Jan 2025 21:29:52 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:60916) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1te3GW-0002nc-G2 for 75954-done@debbugs.gnu.org; Fri, 31 Jan 2025 21:29:50 -0500 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-5d90a5581fcso4548824a12.1 for <75954-done@debbugs.gnu.org>; Fri, 31 Jan 2025 18:29:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738376981; x=1738981781; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=Cf49ijIpLWrRxsH7i8K1oHg7n54Rn4v/8ldk9M6ZufM=; b=Gqofz8h6diZYIk+22PdeXkyQAQ9qrebLyS+zC91Yt4nNlmVLOzUWsysdwA6zMosixq t2VIMp51p2HXFnTDaKfdSNZTK+vFXmG6It4iYrwLyKx1T0l+So3V6duFfT+xrjQXH8yF B14/Xmr35gr5gUacSAXEAZUfGZ7t8s09jsEjB1aJq/0y+bTUxmD3/nWskA1M8Y0QZfRz YCnRqm6jGrNS+WLxFY4gZmKmMLaMxDoKI9rMq7CclJr8T+GjQcXke/YchtVVhvhJ54C1 UwDFmMHuIgMNJ1d2eaqNZmJJHB8Q5MQvn9rltAeN8mryx2ItOsgpNLIIEvACUz31zzRc bKNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738376981; x=1738981781; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cf49ijIpLWrRxsH7i8K1oHg7n54Rn4v/8ldk9M6ZufM=; b=lIOk68otqSYGHbfprtY5cva4R6UmkBxOuouOgxKaZY7OAC8Jtdco9HrhzAsJbRPuOA 1qTTXOWLJzYaYNYmb4cGWClRGzI1E31Utk3Y1U0V6r5GYo14DzBBkC0sfBcEp3PXLS94 SVm1uoTH69h0UAcfM9miQK4woinYCNLNlcmwk4RgFMxyxvAnl1d3mBPIp2CygEFN8AJ0 caVCngMxaKB/+K8fOzGMiigLhGYD/+6QYSHS3X48acyv4Cj8Mcd9gA/VGT1k4a+JX+l3 5RcapqUXhhh+vk5qpyMDuWvP5gKu7sTuzgt05DzTajuXoWTeSYApQgzF7nEw7qRx3Y8m sw5Q== X-Forwarded-Encrypted: i=1; AJvYcCXjAWjJK8oInwfZZNXHS4zTSdf5Opz5GPAiT/OEWuMe8W1uayCBU3gwOfhido2uqCkNhVjHwrxcjepD@debbugs.gnu.org X-Gm-Message-State: AOJu0YzKiQzxf9+x39OxPN3nJG4bBFpREarYXC+5G8WIQwQu/2Lvgkio a6KEQbsZ8+iX8RQm6xg+8koMYvxM4oN+RCFt2N4Biw2WpOweXgYhhXcgXWkPXfgH34NP6HkPHrG ED4RYLmlYMFhjAxAqLVU02RhhBYkswa6O X-Gm-Gg: ASbGncsZx5BBNASmOFwVX+FzQd1EJ3Z0dz1Vb2rWPa5aKLs40Ylzmq9n58/JDyg9uus +wpJ5vPRX/f4nzI6veG1JdcFa5eZN3qW6q9WMUyyBlhhe9NPyE8INvgSyY56FS8D3UaWBT+0A X-Google-Smtp-Source: AGHT+IGScPMZq98sA/c/QB/xVQ9cjDnCeumFHT/k2jwZCnT93mpOC4k7X8B/8ubJdFZkF+vbfqqxY71CHYRGlEmGiN8= X-Received: by 2002:a05:6402:42ce:b0:5d0:b925:a8a with SMTP id 4fb4d7f45d1cf-5dc5efc7231mr15519646a12.16.1738376981324; Fri, 31 Jan 2025 18:29:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 1 Feb 2025 03:29:40 +0100 From: Stefan Kangas In-Reply-To: <87v7tvm7vj.fsf@cassou.me> References: <87y0ysm2ae.fsf@cassou.me> <87v7tvm7vj.fsf@cassou.me> MIME-Version: 1.0 Date: Sat, 1 Feb 2025 03:29:40 +0100 X-Gm-Features: AWEUYZnoqJ6gQCZQNaVvvtGLLShlBw9AtotcGOT93aFDgWOfheQDYfpJu-uZV8U Message-ID: Subject: Re: bug#75954: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" To: Damien Cassou , 75954-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 75954-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 30.1 Damien Cassou writes: > Hi Stefan, > > Stefan Kangas writes: >> Damien Cassou writes: >> >>> some packages provide a binary "OmniSharp" instead of "omnisharp". In >>> a case-sensitive file-systems this means eglot will not find the binary >>> file and won't work. >> >> Is this on MS-Windows? Isn't that supposed to be case-insensitive? > > > nixpkgs for example provides "OmniSharp" > > https://search.nixos.org/packages?channel=unstable&show=omnisharp-roslyn&from=0&size=50&sort=relevance&type=packages&query=omnisharp-roslyn OK, thanks. I installed the patch on emacs-30 as 87be3aa1491. Closing. ------------=_1738377002-10835-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Jan 2025 21:16:01 +0000 Received: from localhost ([127.0.0.1]:48180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdbtI-0005Gk-S3 for submit@debbugs.gnu.org; Thu, 30 Jan 2025 16:16:01 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50202) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdbtE-0005GL-QS for submit@debbugs.gnu.org; Thu, 30 Jan 2025 16:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdbsn-0002qp-LF for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2025 16:15:30 -0500 Received: from mail.reprendre.net ([193.23.30.35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdbsl-0007H6-DF for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2025 16:15:29 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3B7F02CAC32 for ; Thu, 30 Jan 2025 22:15:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=dkim; t=1738271722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=HmzjHhzvJGDBaI4l+szsh4iz9mEtiOMwJ1WnRclqM2w=; b=OdBHQKi522e9a9ZBaFccL4DTsqsrvh3pzyjFKwCokQPGSNb9/yVRqB4BR4NzQ/FOC9batn CXAaJVL92amUFM9vS2+TmZlM085GCfbTySXqvS5kObf7Q7j8f8AA7iwfoPsJ+zRHTAyhFH D9qq/y/CGzri/NVHnGap56Alm7tgmetwCJ2DTh4Z7rDM0Zzp8hYzpxnFjOY/p5BH39mW2Q 9YZGW5Ywezfgm9ZMfhb6kwh8ezMpKVT3Kt5Vmxn3t2kYfNHe6iBZfAv/hBONrB2gKoQSLj VaxtK6Vf0dQmtBQ6op8nkeWA8bSBNZXEXA6aKwtDqAUA7pxOtx0E0QTvulKvSQ== From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" Date: Thu, 30 Jan 2025 22:15:21 +0100 Message-ID: <87y0ysm2ae.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Last-TLS-Session-Version: TLSv1.3 Received-SPF: pass client-ip=193.23.30.35; envelope-from=damien@cassou.me; helo=mail.reprendre.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch Hi, some packages provide a binary "OmniSharp" instead of "omnisharp". In a case-sensitive file-systems this means eglot will not find the binary file and won't work. Best -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-eglot-Allow-omnisharp-binary-to-be-capitalized-OmniS.patch >From 3bb0ea1968880fa4572b139a9b284ec187eae9a9 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Thu, 30 Jan 2025 21:44:31 +0100 Subject: [PATCH] eglot: Allow omnisharp binary to be capitalized "OmniSharp" Some packages provide a binary "OmniSharp" instead of "omnisharp" which breaks in case-sensitive file-systems. * lisp/progmodes/eglot.el (eglot-server-programs): Add "OmniSharp" as valid binary name to search for. --- lisp/progmodes/eglot.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index c2a8562eb97..38ab44bae69 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -325,6 +325,7 @@ eglot-server-programs ((csharp-mode csharp-ts-mode) . ,(eglot-alternatives '(("omnisharp" "-lsp") + ("OmniSharp" "-lsp") ("csharp-ls")))) (purescript-mode . ("purescript-language-server" "--stdio")) ((perl-mode cperl-mode) -- 2.47.1 --=-=-=-- ------------=_1738377002-10835-1--