GNU bug report logs - #75928
31.0.50; `dom-print' often fails to print an SVG DOM

Previous Next

Full log

Message #21 received at 75928-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: David Ponce <da_vid <at> orange.fr>
Cc: 75928-done <at> debbugs.gnu.org
Subject: Re: bug#75928: 31.0.50; `dom-print' often fails to print an SVG DOM
Date: Sat, 15 Feb 2025 13:50:45 +0200

> Date: Sat, 8 Feb 2025 13:55:16 +0100
> Cc: 75928 <at> debbugs.gnu.org
> From: David Ponce <da_vid <at> orange.fr>
> 
> On 2025-02-08 10:41, Eli Zaretskii wrote:
> >> Date: Wed, 5 Feb 2025 13:01:04 +0100
> >> From:  David Ponce via "Bug reports for GNU Emacs,
> >>   the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >>
> >> I attached a new patch that also avoid printing attributes without a
> >> value (value is nil in the DOM).
> >>
> >> I also refreshed the list of HTML boolean attributes from the current
> >> standard, and put checking for a boolean attribute in a separate
> >> inline function for clarity.
> >>
> >> The patch also slightly improve the code by computing the indentation
> >> column outside of loop and delegating indentation to `indent-line-to'.
> > 
> > Thanks.
> > 
> > Using indent-line-to requires binding indent-tabs-mode to nil, to make
> > sure we produce spaces and not TABs, right?
> > 
> > Also, please make sure the dom.el test suite still passes after this
> > change, if you haven't already.  Bonus points for providing a new test
> > for this feature.
> 
> Hello Eli,
> 
> Thank you very much for your feedback.
> 
> Please, find attached a new patch to force indent with spaces and to add
> two new tests to dom-tests.el.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.