From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jan 2025 15:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 75926@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173816367231921 (code B ref -1); Wed, 29 Jan 2025 15:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jan 2025 15:14:32 +0000 Received: from localhost ([127.0.0.1]:42553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1td9lv-0008In-JG for submit@debbugs.gnu.org; Wed, 29 Jan 2025 10:14:31 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35434) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1td9ls-0008IO-DZ for submit@debbugs.gnu.org; Wed, 29 Jan 2025 10:14:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1td9lm-0001oj-2I for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2025 10:14:22 -0500 Received: from mta-snd-e01.auone-net.jp ([111.86.247.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1td9lg-0005FF-B8 for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2025 10:14:21 -0500 Received: from kzhr.d1.dion.ne.jp by mta-snd-e01.auone-net.jp with ESMTP id <20250129151408185.PWJL.22508.kzhr.d1.dion.ne.jp@mta-snd-e01.auone-net.jp>; Thu, 30 Jan 2025 00:14:08 +0900 Date: Thu, 30 Jan 2025 00:14:07 +0900 Message-ID: <85sep1odog.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito X-Hashcash: 1:20:250129:bug-gnu-emacs@gnu.org::VGFYIjOqMA3FHcCv:0Q/Q User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d1.dion.ne.jp; s=default-1; t=1738163648; bh=xdc2C4aZ83TZ81x2cW/I6CNQBAzlMC4d9Xm0N8qUZRM=; h=Date:From:To:Subject; b=HPCukuZEFDwWZVpSLJ7Mp0AU5FrIMrQuUrS5ZGeb7Tkkag85F19m9gACKFIG3jGfsgtREvc2 4l8qnET+sbrL+U3ycZT7NoxCiRvG6L/NLsKX2HYL5RCLLDksQI+qBabaUeXsK3ErKmQ7eoOtC/ 2K2fCMw5N5puJzzNQ6wAFtf9fsAG2YFV0x50d6gheSnyKbg5JJesYnLqSZZXrycJAcF79dyaHS lThw1XggLr9ouJRRYEKKuvvita8BFUJXkzNQ0xK8i9xi/LK4w1NJzUx2JNFBF+vwYhgp73r9JD eJ2IahngJcBchWbnI4BzN14+XENfUBN1xb5CJ2UqynbX3TAw== Received-SPF: pass client-ip=111.86.247.1; envelope-from=kzhr@d1.dion.ne.jp; helo=mta-snd-e01.auone-net.jp X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Cygw32 build fails on master. $ make (snip) Loading term/w32-win... Error: void-variable (tree-sitter--library-abi) (snip) tree-sitter--library-abi is defined in src/treesit.c only when native Windows build. -- Kazuhiro Ito From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jan 2025 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kazuhiro Ito Cc: 75926@debbugs.gnu.org Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.17381663937460 (code B ref 75926); Wed, 29 Jan 2025 16:00:02 +0000 Received: (at 75926) by debbugs.gnu.org; 29 Jan 2025 15:59:53 +0000 Received: from localhost ([127.0.0.1]:42647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdATo-0001wG-Ou for submit@debbugs.gnu.org; Wed, 29 Jan 2025 10:59:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37906) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdATl-0001vw-Js for 75926@debbugs.gnu.org; Wed, 29 Jan 2025 10:59:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdATe-0004ie-6d; Wed, 29 Jan 2025 10:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g6jrrNMp4WG7MKW4lDuWjWFuERpnlo6+EoCQ6cfaFUs=; b=TcJY0x6Xk1Ih 9JH5Cgipz38mpyzHNklSptrmmplk4TeTo392GRomCGxCvA1v2acZMrHKvm0lLsaDWp61ABtsCKXGo 57y3xti5bC8BFRt99VUiPJRfn255Qe9nEhGZuyZZeKoheg3E5CAAJVKfy8UV19Feb9PX4XZeZ8AxF Hxl8sW2i/Bf//jgKRMgx4wMo7QhadlGXp3bJhVrmVjqMIyQZ3f9snNVHgv31J5ey/H2iwlHAeuY/x j1QOz+4AFUdMk8mubqFwUEKztT4rW1NNb4CPBTjsn2vK6hdpoSC8ukcLDrgtJeAHSUt4eTWg96MtA xSyL+ereqP2mAkFhLNH2Rw==; Date: Wed, 29 Jan 2025 17:59:38 +0200 Message-Id: <86cyg5mx05.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <85sep1odog.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Thu, 30 Jan 2025 00:14:07 +0900) References: <85sep1odog.wl--xmue@d1.dion.ne.jp> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 30 Jan 2025 00:14:07 +0900 > From: Kazuhiro Ito > > Cygw32 build fails on master. > > $ make > (snip) > Loading term/w32-win... > > Error: void-variable (tree-sitter--library-abi) > (snip) > > tree-sitter--library-abi is defined in src/treesit.c only when native > Windows build. Thanks, should be fixed now. From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2025 10:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 75926@debbugs.gnu.org Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.173823203729683 (code B ref 75926); Thu, 30 Jan 2025 10:14:02 +0000 Received: (at 75926) by debbugs.gnu.org; 30 Jan 2025 10:13:57 +0000 Received: from localhost ([127.0.0.1]:44519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdRYb-0007ie-2o for submit@debbugs.gnu.org; Thu, 30 Jan 2025 05:13:57 -0500 Received: from mta-snd-e01.auone-net.jp ([111.86.247.1]:2401) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdRYX-0007iR-KV for 75926@debbugs.gnu.org; Thu, 30 Jan 2025 05:13:55 -0500 Received: from kzhr.d1.dion.ne.jp by mta-snd-e01.auone-net.jp with ESMTP id <20250130101349395.QXTR.22508.kzhr.d1.dion.ne.jp@mta-snd-e01.auone-net.jp>; Thu, 30 Jan 2025 19:13:49 +0900 Date: Thu, 30 Jan 2025 19:13:49 +0900 Message-ID: <85plk4obhe.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito In-Reply-To: <86cyg5mx05.fsf@gnu.org> References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d1.dion.ne.jp; s=default-1; t=1738232029; bh=ZiwbLoBOrX/N+7DDZ3Mxl3ILrweFnieCa3lQUCJVz+g=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=A8bqq26YyNdOF73nAoC5Dui0t7O7d7dMg8DQ+q8fyLHYdo1QGIKpckVrJfA4PwoH2vrxPqKf YL/zOMsdmLjpz4wCUMvUnGedMEDibiFP0EzYFN6GX7Tv4OXVEGgEW7picuyYiw2A665OGlq4aZ R1Cz3YKNcDTutx75zEf13gIQRSHS6tWLwZsp3xEoUaKl44lxgThA9hpoaml8w4FZCPGCHoebaf 9U60y3FCIvNM/eX4gqou289iSycn6pn2hg0we0ZMHfCn2Zu0D8nEe2dtyBn17Liw9aP4eoLb6o 5tkpTMrMhFTZ1b3yKlI9tFcsoY7J96XM9C9cX60ZldY4MEeg== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > Cygw32 build fails on master. > > > > $ make > > (snip) > > Loading term/w32-win... > > > > Error: void-variable (tree-sitter--library-abi) > > (snip) > > > > tree-sitter--library-abi is defined in src/treesit.c only when native > > Windows build. > > Thanks, should be fixed now. Thank you for the quick fix, though I wonder cygw32 build needs tree-sitter--library-abi. The variable is used to adjust dynamic-library-alist's value, whcih doesn't seem to be used on cygw32 build. -- Kazuhiro Ito From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2025 10:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kazuhiro Ito , Ken Brown Cc: 75926@debbugs.gnu.org Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.17382338882949 (code B ref 75926); Thu, 30 Jan 2025 10:45:01 +0000 Received: (at 75926) by debbugs.gnu.org; 30 Jan 2025 10:44:48 +0000 Received: from localhost ([127.0.0.1]:44583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdS2S-0000lV-9O for submit@debbugs.gnu.org; Thu, 30 Jan 2025 05:44:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44396) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdS2P-0000lH-Qr for 75926@debbugs.gnu.org; Thu, 30 Jan 2025 05:44:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tdS2I-0003sZ-5c; Thu, 30 Jan 2025 05:44:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=smOHdoTiD4AoXSy54OXChidyNQW2yy/jLyvswB4Q1Gw=; b=qI+thBZ49KmW C32ZEwJBFa/fsMC3af7durcZw7nM1qYJpkIs9XoPPXCgWqFSSsyVnNSHZIjSiWzf3jj+IE4Y3Jeek OOEGvL3GmOUsEBBURcWuZH0KZxB9LPUDqFbOXeoK77j+3pjg6V7Zw+W+bZnsVpLSjeaP0EcKY5M65 7rOh9DfFSr7wdmGia0FvDtNkFKRYCTKKTHEQ6W1AuhLWhJKCHMFNzhm2+jdj8CP6iTp8MRPiDu1V7 s2RulkEjxQmFDG8KHOjnJ/OtsTU49qGGMsTYFLL3kcn+w+YXPKayCDo6snLv9JwQt9b5ocJhL59xT yCH6WkgJSAsW8m6uCddxRg==; Date: Thu, 30 Jan 2025 12:44:33 +0200 Message-Id: <867c6clgxa.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <85plk4obhe.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Thu, 30 Jan 2025 19:13:49 +0900) References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> <85plk4obhe.wl--xmue@d1.dion.ne.jp> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 30 Jan 2025 19:13:49 +0900 > From: Kazuhiro Ito > Cc: 75926@debbugs.gnu.org > > > > Cygw32 build fails on master. > > > > > > $ make > > > (snip) > > > Loading term/w32-win... > > > > > > Error: void-variable (tree-sitter--library-abi) > > > (snip) > > > > > > tree-sitter--library-abi is defined in src/treesit.c only when native > > > Windows build. > > > > Thanks, should be fixed now. > > Thank you for the quick fix, though I wonder cygw32 build needs > tree-sitter--library-abi. The variable is used to adjust > dynamic-library-alist's value, whcih doesn't seem to be used on cygw32 > build. I know, but the problem is the Cygw32 build loads w32-win.el, where this data structure is defined. And all the other variables and functions used in that structure's value are defined using HAVE_NTGUI as the condition, so I just did the same for this case. We should probably split w32-win.el into two parts, one loaded by both the native Windows and Cygw32 builds, the other only by the former. But I don't know enough about the Cygw32 build and it needs, and don't have Cygwin installed to build it in the first place, so I'm not the best person for doing that job. Maybe Ken (CC'ed) has comments or suggestions on this. From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2025 19:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Kazuhiro Ito Cc: 75926@debbugs.gnu.org Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.17382658922538 (code B ref 75926); Thu, 30 Jan 2025 19:39:01 +0000 Received: (at 75926) by debbugs.gnu.org; 30 Jan 2025 19:38:12 +0000 Received: from localhost ([127.0.0.1]:47979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tdaMd-0000er-BS for submit@debbugs.gnu.org; Thu, 30 Jan 2025 14:38:12 -0500 Received: from mail-dm6nam10on2070f.outbound.protection.outlook.com ([2a01:111:f403:2413::70f]:19297 helo=NAM10-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tdaMM-0000do-IS for 75926@debbugs.gnu.org; Thu, 30 Jan 2025 14:37:55 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HM0QOuJUYXlFBiVz+nbRNkvVzv6B4YsxE4yiVMohy2ozILpOEcmpubWeGWE4JkJkU3td7tat7GafChgPJbi22Fhrlq5nBCJ5KxeMiFHl03vr/p+y4n0hanWWrGnzuejydnLMkQhDv+jfY+FciIu7JyZmIlahdWFy8xXx16xhvHmrfQsSmrkjb/s5xGw3h3OevnBWH3YUxLx5zFnsmjazM05no8OKG+YZoAbGAPnnMLcR7qHi3Y+asILH+V13oDA2LC9WVItV9dLOXUKX6KCuSfj4/jQ4tJEdy8NJmODb7B/fXVZbpxQph3r4DI2OvyYW1zcBC7aGd+0feiNSVW+CfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VMhH6jHwX9MoZ///Jx9KgsnrFgPQvAlNMQHzU9dPTw8=; b=oc/3T7T4pe1vD0brV1GWXL4UxGgqTJDi870ZRUG2Cc0Ty7FK1UFvYn1y/iowf3pSvCAqMRBDJPZtNAhDvag/Ge4WXTg6yUyQBrnSVGg+Ww1r6m5kmTFR5jq1q4SgpHxZJyHGcUAOoNUxpwL1VqcNM9VKiK5gOUJaIVd5uckD0OVkg4B312lEravq3tKbp71ZSk1o1GU5sxVqnQdcsl7119cQuztHhTpUf8jhouWN7ygqB/GEOrwCUdMKCl24aOeAGFcjQ6zDFACMr53BOVnn0YgmkzM9X/5LVg08Xit66Xu6Tc5pIAeTkb1JBb8yAIG+R004pbgUbSuLLh1poTiNmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VMhH6jHwX9MoZ///Jx9KgsnrFgPQvAlNMQHzU9dPTw8=; b=Il1Op/3THScmiGvKAkCI+9KcqPCsmX/bFTRAad6gpD1nUtx1MVfLq3oM3SlM6q94yK6GcECiC8xdnj1pCQOvKZDtsqewRQURbgWeDsZ+ltoqyzKZL0+/SK4lv4yV1RqbCjimDOY5bJwCwHVLqyhhEHYbHz3XCZ9yGm6MXAByyqM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Received: from SN6PR04MB5151.namprd04.prod.outlook.com (2603:10b6:805:90::25) by BL3PR04MB8203.namprd04.prod.outlook.com (2603:10b6:208:34a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.18; Thu, 30 Jan 2025 19:37:47 +0000 Received: from SN6PR04MB5151.namprd04.prod.outlook.com ([fe80::5ff0:555f:8712:42dd]) by SN6PR04MB5151.namprd04.prod.outlook.com ([fe80::5ff0:555f:8712:42dd%5]) with mapi id 15.20.8398.017; Thu, 30 Jan 2025 19:37:47 +0000 Message-ID: Date: Thu, 30 Jan 2025 14:37:45 -0500 User-Agent: Mozilla Thunderbird References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> <85plk4obhe.wl--xmue@d1.dion.ne.jp> <867c6clgxa.fsf@gnu.org> Content-Language: en-US From: Ken Brown In-Reply-To: <867c6clgxa.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN1PR12CA0019.namprd12.prod.outlook.com (2603:10b6:408:e1::24) To SN6PR04MB5151.namprd04.prod.outlook.com (2603:10b6:805:90::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR04MB5151:EE_|BL3PR04MB8203:EE_ X-MS-Office365-Filtering-Correlation-Id: bb9c817d-3d2e-4be9-17d8-08dd4165931e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: PJfyw/5NOEDSLkXKYPXr9ENIlsgzERVdox5d3OjwJA5NOEIKnrvzpyuSgZ0vcvjenVUlU0ZW04mKGbaXrimIy4Xr5PhfrAAhHfM85AL0ZHyEx7/gXw2P6/yEaHCOtH8/ZroeRGC4gvX9M/6ADdhwnpfTK17gdY7L5vYmQvb0/i5X9OVTYIn3vJf90konimLY6tnq884n+vaqrBtDEYhQBthmI9p6t+Z7BGaGVFb3tVlIEClQuS3sMlAskPFI94k5r/7VJQkT0ef8f1vLzrS9mKJOF7xfkxXeHuh5hi1ZjQzM8BVZS9j75SbqaRHx6uE5AqROk39fGJsbCVbSBIoEMV7riV3mr/BGEiWPo9mIivstkXTeCOFw+DLa4jOtsDHH/GFL9zRk8zOhajH/CCAf9qhfNjvy/gIJdnjOpqFQAkASJ1BcqfcgQJ10F1AOx9IqFbbaXp7HAZISxeH6h74jWeYfva2F0cXDyzBDiYPlYD7bHsdC1twyh0w+CzsV2tuHYfRiaINpkZchwGXXiUr/vsrDahXlk75Iq/Z80AJhlFWdvJElJU9mbRkYAXWOMSsQueA19tD2/IIi8z7vcnh44et8MmO2YZyjhJaO9BMGhqLcnK1nLfo683KemboUv5G/yhGyD/wysLpLR6R7Yuj8xCvkONKIrf5sjM3ovI+iWIAi7cGGv33d5+Vt8BecNOqnsjLeelsZ+vngD9bvpOd7MWFu8Ljgc77c7VTwIHxfker8nK+Xye+lTmNakFbp0GT97UL4J1G3BQnkDnT2bsoDCKnniskRZeKhJ65wrh23EvD0BqaChWzLj7/9cW+5fA4A+2IvY+jx8otLKKkIC+Bj2RlvuJP4lfFm+1ptHm1RmPt4QKY6OHDMlero7sG4n1Wpoh7I30MrrEpQfHLOwpGuTueA7priD+zhQ6z0aTDe7aDjqnq66m67cyBeDf7L2JE2gLsbij9d9eq3AAL8nR8HqpOQEF7yimY7NZCRLUcDP4n63HGFW3IZx+qdbJQNKwBe4sHv5G5ouSOE49VsBymjL+lvDA1cT3oZPRjLvnQYsyXY+auo4im+1+Xr6/PQVa6Y72SLr+QTafK8UmE+EAUgWPF6+WHQRp2148j4coJQz0aIx7HJTp0LtWBB6f5hDtQzZyHotc1ru95TeMcgAo9EizfuXrhsTxwR1aO4LKlLpLq2ByrOjxwIRGco2G1y+Ro+wjVsqQej8DUTufy5QTOi4TBDakNc1nzojA/TYPILYOGsFfEVHCJh15dgsOGhFDyQG3TH6jO38PiemQ6OExiEU5EXyAU15BpnP+xgHs1WPCqC58eFSw6mbKTw11UPXma36DrWV9+eX0VdovXOXHAmDE/EysOxlFwa0LFyXYBXM1J05lA0jXSzyac8R5Xx0XoM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR04MB5151.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dm366awg2dCvNDK0zm6/+S4lwoS5+3r8+nS5Usqa8I9h6oUgCFChKZfw3DFbSI5xgGwv/mB8QeXgqINghXpSb0qIwf6hvYbdkiU+4bbnzBaZgqoMNcvi43bjGLmZjo/9NT38NOvovA7UYN526ozTnNX+gKIDu7Luss7k9xw19qKrCThkD59vEAU2DBG20QWjGBtiU2BjmjnayIsUj9ZtDeuG1mvjWWA4scrL8kZ+FLfVvWvAGtCA7pYkKmwYbpLdxk/w/687th3hNRxBcVlUpBV+6SyqGrJDaLc4I0KV1nYNPyECYwqUes3H7Sy9gDRcPAABqdMSRNg14sV+ZBe/J3QsI9153NhTFHQmCjNoWSLjIe5fvEp6jj4pIT/uELzcYYO4Bzn95/9TPd5haxgU17pyFBkB1fGQLX0RSCMUZZ9a/9kVMMaHXRkQEFGfcUvAzEe4WjGRtHADsUTBIeIJAdSUtYoS1eNxD6GMXVyZfCwm47XSUDY9jeOsFrmm8Hb4Bqq1OQGo/trKEpmXrxQ2DSPgFjHIDTXLBzmE0HyDduufdT7agheKeLXYJR7ZoXZ5JFqo/wVyBKZHeSGMLlo/R5NXxz4E42mAH4BcCGMCwe290H8CNpRV+DtdsfpsUODbfc/1Zr62ng7+IPptA/8Jx5HpVvWlXS85e+sfvLSi3LvUJn5HfbnT2FsGYtzk9FGzPB/Z/iQa6tvQFaVRMT8d1m+DT/nDSk6cncjaR2BzRsI9kZ4jfzPmyVVM/hbSd2o6LXAIpbo/qK1VQNjPGs27OGfQErdLWVdDy55ixVlKl+FMkmk1cXCSspTWakBozCIjX6upJWnsKVYSixCgFbsDVRKEdACe8Ae40nB3ZjuH137II7fTyoHv5+7hq3iW9oHqV5qWqunW8uBHvbS+kSafdmizPXKuIb3bnvKLtciQ1dfIoI4oMZCxhJ9GD2xIxLZkpIdEYrUfiK5npiJeEnZaihALRZOs37e5gvZjNLKSAkfLmo+ZU6NhkZnBVdasfWrSVNw0Qv+5C45cLPBo2FJ+vLwcDRRZukM/Lqx8MX2fqlsvNrRjCvhBe5lC4iySsa1g6hEuAPOF0xNKU1OdBIwfhSq/KX6414ivXgUFeSUyGSVYTe20q+R5ZwTQs47z2LNhnjMw/ciFQR12uakSqKcGrD8A390826jzvl/mV/3OjDjdAL8uKC59PsTgzFg00p9hWAKSCO5VY9KCv6MdNFL0uPdaN0gS2rI+B2BhmN9d2nLcX97gRaEDXhS1CXkyy7V+fPZvK6EACatbxc6uZvhNHps5kMgs4KdX1RdHfw+8zefiMtNYPGE0Geer4r43vR33Jp7PauHoUxIzMbgbW5/K1cfKvcaii7tOWZ9aT6Xqaj0xfP/rRzvTXZTNaTXf74iKBhhLgG5J19SMqjXKEPNHAKRZerB7yjjqdo2HZC2JKwtaCdO9/6C90mYcg2PNqd25dE2FbIQZkTZIp0kr8+yYtgoFL/za0zogzcaUl8/v6WbMbfepHcUCl6X3csjisXVjzS+jiDerPzwidQddW/wQc84Hb7kuP7l2rTmanpdX/XeJUgFtsOGL2Epc9yBQqxeL X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: bb9c817d-3d2e-4be9-17d8-08dd4165931e X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB5151.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2025 19:37:47.3407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gPXt912fwqKcppAz0Z9bPWsvvqHXj5osvGhCXPQyuRRrlQ0i3lLzxfqdr90+F7yLPmlPoLnjZvdAATSA3WNUKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR04MB8203 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 1/30/2025 5:44 AM, Eli Zaretskii wrote: >> Date: Thu, 30 Jan 2025 19:13:49 +0900 >> From: Kazuhiro Ito >> Thank you for the quick fix, though I wonder cygw32 build needs >> tree-sitter--library-abi. The variable is used to adjust >> dynamic-library-alist's value, whcih doesn't seem to be used on cygw32 >> build. > > I know, but the problem is the Cygw32 build loads w32-win.el, where > this data structure is defined. And all the other variables and > functions used in that structure's value are defined using HAVE_NTGUI > as the condition, so I just did the same for this case. > > We should probably split w32-win.el into two parts, one loaded by both > the native Windows and Cygw32 builds, the other only by the former. > But I don't know enough about the Cygw32 build and it needs, and don't > have Cygwin installed to build it in the first place, so I'm not the > best person for doing that job. Maybe Ken (CC'ed) has comments or > suggestions on this. That sounds like a reasonable approach, but I don't have time to dig into it right now. I don't actually know the innards of the Cygw32 build very well. I never use that build myself, and I only build it when someone asks me to test something. Kazuhiro, are you interested in giving Eli's suggestion a try? I have a feeling that you're more familiar with that part of the code than I am. Ken From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Feb 2025 10:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: kzhr@d1.dion.ne.jp, Ken Brown Cc: 75926@debbugs.gnu.org Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.17396149169980 (code B ref 75926); Sat, 15 Feb 2025 10:22:02 +0000 Received: (at 75926) by debbugs.gnu.org; 15 Feb 2025 10:21:56 +0000 Received: from localhost ([127.0.0.1]:53472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tjFJ6-0002au-AN for submit@debbugs.gnu.org; Sat, 15 Feb 2025 05:21:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49836) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tjFJ3-0002ae-70 for 75926@debbugs.gnu.org; Sat, 15 Feb 2025 05:21:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tjFIv-0000Xv-W6; Sat, 15 Feb 2025 05:21:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FeBR9Rckyg6F+pK6MqMKBKEKd4dgs2F+dIZwNrlK29w=; b=kfJqhziMn/0T nafbnY5Dfk/r+s+YJDuwjvaZDh01y7ZmnWB4JYno3N3Au9AwfUPy9CvO3oVFaf/oqLaH5eFd3FZhl gZq1i8vBWxfyaSjYhr63cqz4muJfZLIFik2s0OcI2CqY0vxF6U+RcrhM8xtxs+QxjQ2EodiAtaKOc CQkzrcveFMYV1Co1fteBvTaGQESdWIhBRL/G+yD0PDwx8J0Ot7gI/4rPEFhPXGB6nwk1Ad/f6dfvz +sWVQXxodwHTckrP2kl/m1ReEBq1pazooCBQYEXKFE6lJbrmEaPIVQlRSYXCbvagyOfuPXx2OzhWP 5GUxA5QYI9JJJUBvrvB8pw==; Date: Sat, 15 Feb 2025 12:21:43 +0200 Message-Id: <86zfineceg.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Ken Brown on Thu, 30 Jan 2025 14:37:45 -0500) References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> <85plk4obhe.wl--xmue@d1.dion.ne.jp> <867c6clgxa.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Kazuhiro, do you intend on giving this a try?| > Date: Thu, 30 Jan 2025 14:37:45 -0500 > Cc: 75926@debbugs.gnu.org > From: Ken Brown > > On 1/30/2025 5:44 AM, Eli Zaretskii wrote: > >> Date: Thu, 30 Jan 2025 19:13:49 +0900 > >> From: Kazuhiro Ito > >> Thank you for the quick fix, though I wonder cygw32 build needs > >> tree-sitter--library-abi. The variable is used to adjust > >> dynamic-library-alist's value, whcih doesn't seem to be used on cygw32 > >> build. > > > > I know, but the problem is the Cygw32 build loads w32-win.el, where > > this data structure is defined. And all the other variables and > > functions used in that structure's value are defined using HAVE_NTGUI > > as the condition, so I just did the same for this case. > > > > We should probably split w32-win.el into two parts, one loaded by both > > the native Windows and Cygw32 builds, the other only by the former. > > But I don't know enough about the Cygw32 build and it needs, and don't > > have Cygwin installed to build it in the first place, so I'm not the > > best person for doing that job. Maybe Ken (CC'ed) has comments or > > suggestions on this. > > That sounds like a reasonable approach, but I don't have time to dig > into it right now. I don't actually know the innards of the Cygw32 > build very well. I never use that build myself, and I only build it > when someone asks me to test something. Kazuhiro, are you interested in > giving Eli's suggestion a try? I have a feeling that you're more > familiar with that part of the code than I am. > > Ken > From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Feb 2025 02:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 75926@debbugs.gnu.org, Ken Brown Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.174036331730182 (code B ref 75926); Mon, 24 Feb 2025 02:16:01 +0000 Received: (at 75926) by debbugs.gnu.org; 24 Feb 2025 02:15:17 +0000 Received: from localhost ([127.0.0.1]:37650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmO03-0007qj-RP for submit@debbugs.gnu.org; Sun, 23 Feb 2025 21:15:16 -0500 Received: from mta-snd-e06.auone-net.jp ([111.86.247.6]:28320) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tmNzx-0007nr-Qg for 75926@debbugs.gnu.org; Sun, 23 Feb 2025 21:15:14 -0500 Received: from kzhr.d1.dion.ne.jp by mta-snd-e06.auone-net.jp with ESMTP id <20250224021505916.YGQE.9150.kzhr.d1.dion.ne.jp@mta-snd-e06.auone-net.jp>; Mon, 24 Feb 2025 11:15:05 +0900 Date: Mon, 24 Feb 2025 11:15:05 +0900 Message-ID: <857c5gf5qu.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito In-Reply-To: <86zfineceg.fsf@gnu.org> References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> <85plk4obhe.wl--xmue@d1.dion.ne.jp> <867c6clgxa.fsf@gnu.org> <86zfineceg.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Mon_Feb_24_11:15:05_2025-1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d1.dion.ne.jp; s=default-1; t=1740363306; bh=E+4S0QXQk3fnSrB6udBGFvd1D6K0r6yRqjvUsFPwhNo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=lzlHEqpJN8fSuH+CAEfVh0fTbaTc9MrDWDtKDA0DfygZZVLUcA5Lfi0IrafDCAViZjSEW4ZA 0mydUViX5+r3yVgmk43bI/06k7odSdHGqd+Ar37zNN0Ts/Ee3MvTb26KPO1MR1D4m3HlvRGGz2 a9M5xWSvII/2+Tby7CEmRXLkx3w7Vclu/fda+rO2VX0Ltm4+HOQY/9WSkjmXH+NW/Qm0I2HdTP WRtH9Kk1lthzZU+J9oCHsvd7LMMs116VfDa0s1EnibM8bQBO0/QQ6Y/9Sj1AG1b1UnzizfMNc6 NeKFYxB+NiuwwAHNwzDRYC8Hkk4QOgRUKMDPz4G6qF3MBIuw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Multipart_Mon_Feb_24_11:15:05_2025-1 Content-Type: text/plain; charset=US-ASCII > > > We should probably split w32-win.el into two parts, one loaded by both > > > the native Windows and Cygw32 builds, the other only by the former. > > > But I don't know enough about the Cygw32 build and it needs, and don't > > > have Cygwin installed to build it in the first place, so I'm not the > > > best person for doing that job. Maybe Ken (CC'ed) has comments or > > > suggestions on this. > > > > That sounds like a reasonable approach, but I don't have time to dig > > into it right now. I don't actually know the innards of the Cygw32 > > build very well. I never use that build myself, and I only build it > > when someone asks me to test something. Kazuhiro, are you interested in > > giving Eli's suggestion a try? I have a feeling that you're more > > familiar with that part of the code than I am. > > Ping! Kazuhiro, do you intend on giving this a try?| Sorry for the late response. I didn't have enough time and actually I don't know Emacs internals well in any area. I simply build Emacs for testing elisp packages I maintain. But I tried on it. Please review. -- Kazuhiro Ito --Multipart_Mon_Feb_24_11:15:05_2025-1 Content-Type: text/x-patch; type=patch; name="0001-Avoid-defining-unneeded-variables-on-Cygw32.patch"; charset=US-ASCII Content-Disposition: attachment; filename="0001-Avoid-defining-unneeded-variables-on-Cygw32.patch" Content-Transfer-Encoding: 7bit >From d17b4eceb8c0c638b993703f9684fef9324eca2e Mon Sep 17 00:00:00 2001 From: Kazuhiro Ito Date: Sun, 23 Feb 2025 22:47:00 +0900 Subject: [PATCH] Avoid defining unneeded variables on Cygw32. lisp/term/w32-win.el contained definitions of variables which were not used on Cygw32. It is now to split into two files, common part and Windows native build specific part. The latter is new file, lisp/term/w32-win.el. * src/image.c (Qlibpng_version, Qlibgif_version) (Qlibjpeg_version): Don't define on Cygw32 build. * src/treesit.c (Qtree_sitter__library_abi): Ditto. * lisp/term/w32-win.el (dynamic-library-alist, libpng-version) (libgif-version, libjpeg-version, libgnutls-version) (tree-sitter--library-abi, gui-backend-set-selection) (gui-backend-get-selection, gui-backend-selection-owner-p) (gui-selection-exists-p): Moved to lisp/term/w32-nt.el. * lisp/term/w32-nt.el: New file, separated Windows native build specific part from lisp/term/w32-win.el. * lisp/loadup.el: Load term/w32-nt.el on Windows native build. --- lisp/loadup.el | 1 + lisp/term/w32-nt.el | 153 +++++++++++++++++++++++++++++++++++++++++++ lisp/term/w32-win.el | 108 ------------------------------ src/image.c | 2 +- src/treesit.c | 2 +- 5 files changed, 156 insertions(+), 110 deletions(-) create mode 100644 lisp/term/w32-nt.el diff --git a/lisp/loadup.el b/lisp/loadup.el index 9089da9a988..3e87f4811df 100644 --- a/lisp/loadup.el +++ b/lisp/loadup.el @@ -332,6 +332,7 @@ (load "term/w32-win") (load "disp-table") (when (eq system-type 'windows-nt) + (load "term/w32-nt") (load "w32-fns") (load "ls-lisp") (load "dos-w32")) diff --git a/lisp/term/w32-nt.el b/lisp/term/w32-nt.el new file mode 100644 index 00000000000..7ff9472839d --- /dev/null +++ b/lisp/term/w32-nt.el @@ -0,0 +1,153 @@ +;;; w32-nt.el --- MS-Windows native build specific definitions -*- lexical-binding: t -*- + +;; Copyright (C) 1993-1994, 2001-2025 Free Software Foundation, Inc. + +;; Author: FSF +;; Keywords: terminals + +;; This file is part of GNU Emacs. + +;; GNU Emacs is free software: you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; GNU Emacs is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with GNU Emacs. If not, see . + +;;; Commentary: + +;; w32-nt.el: this file contains MS-Windows native build specific +;; definitions formerly included in w32-win.el. + +;;; Code: + + +(eval-when-compile (require 'cl-lib)) + + +(defvar dynamic-library-alist) +(defvar libpng-version) ; image.c #ifdef HAVE_NTGUI +(defvar libgif-version) +(defvar libjpeg-version) + +(defvar libgnutls-version) ; gnutls.c + +(defvar tree-sitter--library-abi) ; treesit.c + +;;; Set default known names for external libraries +(setq dynamic-library-alist + (list + '(gdiplus "gdiplus.dll") + '(shlwapi "shlwapi.dll") + '(xpm "libxpm.dll" "xpm4.dll" "libXpm-nox4.dll") + ;; Versions of libpng 1.4.x and later are incompatible with + ;; earlier versions. Set up the list of libraries according to + ;; the version we were compiled against. (If we were compiled + ;; without PNG support, libpng-version's value is -1.) + (if (>= libpng-version 10400) + (let ((major (/ libpng-version 10000)) + (minor (mod (/ libpng-version 100) 10))) + (list 'png + ;; libpngXY.dll is the default name when building + ;; with CMake or from a lpngXYY tarball on w32, + ;; libpngXY-XY.dll is the DLL name when building + ;; with libtool / autotools + (format "libpng%d%d.dll" major minor) + (format "libpng%d%d-%d%d.dll" major minor major minor))) + '(png "libpng12d.dll" "libpng12.dll" "libpng3.dll" "libpng.dll" + ;; these are libpng 1.2.8 from GTK+ + "libpng13d.dll" "libpng13.dll")) + '(tiff "libtiff-5.dll" "libtiff3.dll" "libtiff.dll") + (if (> libjpeg-version 62) + ;; Versions of libjpeg after 6b are incompatible with + ;; earlier versions, and each of versions 7, 8, and 9 is + ;; also incompatible with the preceding ones (the core data + ;; structures used for communications with the library + ;; gained additional members with each new version). So we + ;; must use only the version of the library which Emacs was + ;; compiled against. + (list 'jpeg (format "libjpeg-%d.dll" (/ libjpeg-version 10))) + '(jpeg "jpeg62.dll" "libjpeg.dll" "jpeg-62.dll" "jpeg.dll")) + ;; Versions of giflib 5.0.0 and later changed signatures of + ;; several functions used by Emacs, which makes those versions + ;; incompatible with previous ones. We select the correct + ;; libraries according to the version of giflib we were + ;; compiled against. (If we were compiled without GIF support, + ;; libgif-version's value is -1.) + (if (>= libgif-version 50100) + ;; Yes, giflib 5.0 uses 6 as the major version of the API, + ;; and giflib 5.1 uses 7, thus "libgif-7.dll" and + ;; "libgif-6.dll" below (giflib 4.x used 5 as the major API + ;; version). giflib5.dll is from the lua-files project, + ;; and gif.dll is from luapower. + '(gif "libgif-7.dll") + (if (>= libgif-version 50000) + '(gif "libgif-6.dll" "giflib5.dll" "gif.dll") + '(gif "libgif-5.dll" "giflib4.dll" "libungif4.dll" "libungif.dll"))) + '(svg "librsvg-2-2.dll") + '(webp "libwebp-7.dll" "libwebp.dll") + '(webpdemux "libwebpdemux-2.dll" "libwebpdemux.dll") + '(sqlite3 "libsqlite3-0.dll") + '(gdk-pixbuf "libgdk_pixbuf-2.0-0.dll") + '(glib "libglib-2.0-0.dll") + '(gio "libgio-2.0-0.dll") + '(gobject "libgobject-2.0-0.dll") + (if (>= libgnutls-version 30400) + '(gnutls "libgnutls-30.dll") + '(gnutls "libgnutls-28.dll" "libgnutls-26.dll")) + '(libxml2 "libxml2-2.dll" "libxml2.dll") + '(zlib "zlib1.dll" "libz-1.dll") + '(lcms2 "liblcms2-2.dll") + '(gccjit "libgccjit-0.dll") + ;; MSYS2 distributes libtree-sitter.dll, without API version + ;; number, upto and including version 0.24.3-2; later versions + ;; come with libtree-sitter-major.minor.dll (as in + ;; libtree-sitter-0.24.dll). Sadly, the header files don't have + ;; any symbols for library version, so we can only use the + ;; library-language ABI version; according to + ;; https://github.com/tree-sitter/tree-sitter/issues/3925, the + ;; language ABI must change when the library's ABI is modified. + (if (<= tree-sitter--library-abi 14) + '(tree-sitter "libtree-sitter-0.24.dll" + "libtree-sitter.dll" + "libtree-sitter-0.dll") + '(tree-sitter "libtree-sitter-0.25.dll")))) + + +;;;; Selections + +(declare-function w32--set-selection "w32-win.el") + +(declare-function w32--get-selection "w32-win.el") + +(declare-function w32--selection-owner-p "w32-win.el") + +(declare-function w32-selection-exists-p "w32select.c" + (&optional selection terminal)) + +;; Make copy&pasting in w32's console interact with the system's clipboard! +(cl-defmethod gui-backend-set-selection (type value + &context (window-system nil)) + (w32--set-selection type value)) + +(cl-defmethod gui-backend-get-selection (type data-type + &context (window-system nil)) + (w32--get-selection type data-type)) + +(cl-defmethod gui-backend-selection-owner-p (selection + &context (window-system nil)) + (w32--selection-owner-p selection)) + +(cl-defmethod gui-selection-exists-p (selection + &context (window-system nil)) + (w32-selection-exists-p selection)) + +(provide 'term/w32-nt) + +;;; w32-nt.el ends here diff --git a/lisp/term/w32-win.el b/lisp/term/w32-win.el index af53345a377..fa7862d9bff 100644 --- a/lisp/term/w32-win.el +++ b/lisp/term/w32-win.el @@ -240,94 +240,6 @@ w32-win-suspend-error "Report an error when a suspend is attempted." (error "Suspending an Emacs running under W32 makes no sense")) -(defvar dynamic-library-alist) -(defvar libpng-version) ; image.c #ifdef HAVE_NTGUI -(defvar libgif-version) -(defvar libjpeg-version) - -(defvar libgnutls-version) ; gnutls.c - -(defvar tree-sitter--library-abi) ; treesit.c - -;;; Set default known names for external libraries -(setq dynamic-library-alist - (list - '(gdiplus "gdiplus.dll") - '(shlwapi "shlwapi.dll") - '(xpm "libxpm.dll" "xpm4.dll" "libXpm-nox4.dll") - ;; Versions of libpng 1.4.x and later are incompatible with - ;; earlier versions. Set up the list of libraries according to - ;; the version we were compiled against. (If we were compiled - ;; without PNG support, libpng-version's value is -1.) - (if (>= libpng-version 10400) - (let ((major (/ libpng-version 10000)) - (minor (mod (/ libpng-version 100) 10))) - (list 'png - ;; libpngXY.dll is the default name when building - ;; with CMake or from a lpngXYY tarball on w32, - ;; libpngXY-XY.dll is the DLL name when building - ;; with libtool / autotools - (format "libpng%d%d.dll" major minor) - (format "libpng%d%d-%d%d.dll" major minor major minor))) - '(png "libpng12d.dll" "libpng12.dll" "libpng3.dll" "libpng.dll" - ;; these are libpng 1.2.8 from GTK+ - "libpng13d.dll" "libpng13.dll")) - '(tiff "libtiff-5.dll" "libtiff3.dll" "libtiff.dll") - (if (> libjpeg-version 62) - ;; Versions of libjpeg after 6b are incompatible with - ;; earlier versions, and each of versions 7, 8, and 9 is - ;; also incompatible with the preceding ones (the core data - ;; structures used for communications with the library - ;; gained additional members with each new version). So we - ;; must use only the version of the library which Emacs was - ;; compiled against. - (list 'jpeg (format "libjpeg-%d.dll" (/ libjpeg-version 10))) - '(jpeg "jpeg62.dll" "libjpeg.dll" "jpeg-62.dll" "jpeg.dll")) - ;; Versions of giflib 5.0.0 and later changed signatures of - ;; several functions used by Emacs, which makes those versions - ;; incompatible with previous ones. We select the correct - ;; libraries according to the version of giflib we were - ;; compiled against. (If we were compiled without GIF support, - ;; libgif-version's value is -1.) - (if (>= libgif-version 50100) - ;; Yes, giflib 5.0 uses 6 as the major version of the API, - ;; and giflib 5.1 uses 7, thus "libgif-7.dll" and - ;; "libgif-6.dll" below (giflib 4.x used 5 as the major API - ;; version). giflib5.dll is from the lua-files project, - ;; and gif.dll is from luapower. - '(gif "libgif-7.dll") - (if (>= libgif-version 50000) - '(gif "libgif-6.dll" "giflib5.dll" "gif.dll") - '(gif "libgif-5.dll" "giflib4.dll" "libungif4.dll" "libungif.dll"))) - '(svg "librsvg-2-2.dll") - '(webp "libwebp-7.dll" "libwebp.dll") - '(webpdemux "libwebpdemux-2.dll" "libwebpdemux.dll") - '(sqlite3 "libsqlite3-0.dll") - '(gdk-pixbuf "libgdk_pixbuf-2.0-0.dll") - '(glib "libglib-2.0-0.dll") - '(gio "libgio-2.0-0.dll") - '(gobject "libgobject-2.0-0.dll") - (if (>= libgnutls-version 30400) - '(gnutls "libgnutls-30.dll") - '(gnutls "libgnutls-28.dll" "libgnutls-26.dll")) - '(libxml2 "libxml2-2.dll" "libxml2.dll") - '(zlib "zlib1.dll" "libz-1.dll") - '(lcms2 "liblcms2-2.dll") - '(gccjit "libgccjit-0.dll") - ;; MSYS2 distributes libtree-sitter.dll, without API version - ;; number, upto and including version 0.24.3-2; later versions - ;; come with libtree-sitter-major.minor.dll (as in - ;; libtree-sitter-0.24.dll). Sadly, the header files don't have - ;; any symbols for library version, so we can only use the - ;; library-language ABI version; according to - ;; https://github.com/tree-sitter/tree-sitter/issues/3925, the - ;; language ABI must change when the library's ABI is modified. - (if (<= tree-sitter--library-abi 14) - '(tree-sitter "libtree-sitter-0.24.dll" - "libtree-sitter.dll" - "libtree-sitter-0.dll") - '(tree-sitter "libtree-sitter-0.25.dll")))) - ;;; multi-tty support (defvar w32-initialized nil "Non-nil if the w32 window system has been initialized.") @@ -554,26 +466,6 @@ gui-backend-selection-exists-p &context (window-system w32)) (w32-selection-exists-p selection)) -(when (eq system-type 'windows-nt) - ;; Make copy&pasting in w32's console interact with the system's clipboard! - ;; We could move those cl-defmethods outside of the `when' and use - ;; "&context (system-type (eql windows-nt))" instead! - (cl-defmethod gui-backend-set-selection (type value - &context (window-system nil)) - (w32--set-selection type value)) - - (cl-defmethod gui-backend-get-selection (type data-type - &context (window-system nil)) - (w32--get-selection type data-type)) - - (cl-defmethod gui-backend-selection-owner-p (selection - &context (window-system nil)) - (w32--selection-owner-p selection)) - - (cl-defmethod gui-selection-exists-p (selection - &context (window-system nil)) - (w32-selection-exists-p selection))) - ;; The "Windows" keys on newer keyboards bring up the Start menu ;; whether you want it or not - make Emacs ignore these keystrokes ;; rather than beep. diff --git a/src/image.c b/src/image.c index b051e4ca796..65d8db24adc 100644 --- a/src/image.c +++ b/src/image.c @@ -13003,7 +13003,7 @@ syms_of_image (void) DEFSYM (Qgs_load_image, "gs-load-image"); #endif /* HAVE_GHOSTSCRIPT */ -#ifdef HAVE_NTGUI +#ifdef WINDOWSNT /* Versions of libpng, libgif, and libjpeg that we were compiled with, or -1 if no PNG/GIF support was compiled in. This is tested by w32-win.el to correctly set up the alist used to search for the diff --git a/src/treesit.c b/src/treesit.c index 62606d99749..fa7fe95b7dc 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -4577,7 +4577,7 @@ or (not PRED), meaning not satisfying the inner PRED qualifies the node. defsubr (&Streesit_subtree_stat); #endif /* HAVE_TREE_SITTER */ defsubr (&Streesit_available_p); -#ifdef HAVE_NTGUI +#ifdef WINDOWSNT DEFSYM (Qtree_sitter__library_abi, "tree-sitter--library-abi"); Fset (Qtree_sitter__library_abi, #if HAVE_TREE_SITTER -- 2.45.1 --Multipart_Mon_Feb_24_11:15:05_2025-1-- From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Feb 2025 12:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kazuhiro Ito Cc: 75926@debbugs.gnu.org, kbrown@cornell.edu Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.174040052013436 (code B ref 75926); Mon, 24 Feb 2025 12:36:01 +0000 Received: (at 75926) by debbugs.gnu.org; 24 Feb 2025 12:35:20 +0000 Received: from localhost ([127.0.0.1]:38811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmXg8-0003Ud-Bs for submit@debbugs.gnu.org; Mon, 24 Feb 2025 07:35:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46462) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tmXg6-0003PN-5n for 75926@debbugs.gnu.org; Mon, 24 Feb 2025 07:35:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tmXfz-00082G-Qc; Mon, 24 Feb 2025 07:35:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GdhxbkHcWZAny1r6IJw+uAMtsYXM7O2GcS+1O4Oa03g=; b=j1foIfrYPCax zbOJZ+4VJtAGtEKhnFqSCFNx0xIhvDGuyMmYWUqW04+rPFCsaVHsDt5aYN7pD1Ovx7Zb+uvx+eVvB t9LvewVxL95LXaTTZVQGJEA8gnlVXL9TkRdCiLmNtnrYqEpk36l6acW6dyPbZraia2dw2UO9K6d2H Bh11viqVV1WnoKitrILrl2EwEqSpy9FIrUx90vXt09lR/EHByGO/T6EiAGMzrlzbl4e+c2bESJlZw XmVPUgrPCFv4CAn4AHRvdjSGpEdXuHx7h7ENolOIYmfdRNr7eWpA7ZBYZp5EET/dlsjDVpq4c+99W VpXCmlFb10mwUN2AfZ0aPQ==; Date: Mon, 24 Feb 2025 14:35:09 +0200 Message-Id: <86ecznzfk2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <857c5gf5qu.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Mon, 24 Feb 2025 11:15:05 +0900) References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> <85plk4obhe.wl--xmue@d1.dion.ne.jp> <867c6clgxa.fsf@gnu.org> <86zfineceg.fsf@gnu.org> <857c5gf5qu.wl--xmue@d1.dion.ne.jp> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 24 Feb 2025 11:15:05 +0900 > From: Kazuhiro Ito > Cc: Ken Brown , > 75926@debbugs.gnu.org > > > > > We should probably split w32-win.el into two parts, one loaded by both > > > > the native Windows and Cygw32 builds, the other only by the former. > > > > But I don't know enough about the Cygw32 build and it needs, and don't > > > > have Cygwin installed to build it in the first place, so I'm not the > > > > best person for doing that job. Maybe Ken (CC'ed) has comments or > > > > suggestions on this. > > > > > > That sounds like a reasonable approach, but I don't have time to dig > > > into it right now. I don't actually know the innards of the Cygw32 > > > build very well. I never use that build myself, and I only build it > > > when someone asks me to test something. Kazuhiro, are you interested in > > > giving Eli's suggestion a try? I have a feeling that you're more > > > familiar with that part of the code than I am. > > > > Ping! Kazuhiro, do you intend on giving this a try?| > > Sorry for the late response. I didn't have enough time and actually I > don't know Emacs internals well in any area. I simply build Emacs for > testing elisp packages I maintain. But I tried on it. > Please review. Thanks. Ken, any comments? From unknown Fri Aug 15 20:55:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#75926: 31.0.50; Cygw32 build break Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Feb 2025 22:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75926 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Kazuhiro Ito Cc: 75926@debbugs.gnu.org Received: via spool by 75926-submit@debbugs.gnu.org id=B75926.174043487324657 (code B ref 75926); Mon, 24 Feb 2025 22:08:01 +0000 Received: (at 75926) by debbugs.gnu.org; 24 Feb 2025 22:07:53 +0000 Received: from localhost ([127.0.0.1]:43208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tmgcC-0006Pa-Rp for submit@debbugs.gnu.org; Mon, 24 Feb 2025 17:07:53 -0500 Received: from mail-dm6nam10on2070d.outbound.protection.outlook.com ([2a01:111:f403:2413::70d]:3040 helo=NAM10-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tmgc9-0006PH-S5 for 75926@debbugs.gnu.org; Mon, 24 Feb 2025 17:07:51 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=idIRIMBjlabFNjzLIJ4BL1+tRJUTaVHg+TpajOHQOlHIMlZYgFKFRwZFxFG1m/swotMI79+Ik670VnzSC+8TK4QRPjusRlel9y8qYPmnuxnnPzNk+UrgmLuJELNylxYxXJ8bSD4BPd7p8p+eBdk5Y/hHpPpVoZGqjW+lVAQ0eCtMeKW8EQpCocj1FM+l/oKLwEV5n6Mf7TWczMgSjxeGQGQRgLG4sLbFv46CUiX6GMmg+4UpClALcL+SEg0DmyZAXnTwG3o6HmxgvA1SnyirI3Jj8whbiua/xFKPolhJvOOegf3Yk1vvXI4xVkLrRCtw9WdAYrbshP5LjnuuTVCaig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9+x/9p0YdA4wEDczSMI4PBpmGkYj09tHPjpQ9fP7QgQ=; b=IO3QldKUS4Jy9iAvgrXg9JjN/iGMQjtYQ4P5uI77h6Urcd0IhwbzNSKXMQ8ofz0w6E87PgCSm+NbDBfofiEFwyqwo1l/yCmE4x+QJKFCLoE059DEKpoRBO0S9oNB0HDFS/IOuSGpZHeM6RP4FnV5k3JthkBJIk0MBZa+YR/T2THIlFXfTd3C13F/0BlVSuLQ3nU73BsiZIVtPfSIrUCZbUYrfZ8j1mP9GpNbDN4xHbhBj2sZlc8CxwE+76BYA5D6YW/ErhjutE2qof8KZ+ezSfzetp6ZyMcFE79un9vMLdI5Y95VK/jWTEEZv5g4P1Aj3lSD2Lb7v8Zf64pZfl0HiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9+x/9p0YdA4wEDczSMI4PBpmGkYj09tHPjpQ9fP7QgQ=; b=JvBT2H8idKyoKXiXLUJ6DyPuVv27PqcCZxL6syvwHFs606F4QBCDKvnBosPiBs/Ag4dRYMFW5T1FzFEols5BvoWQmi7nNiZeLIrTkqZjmt9hPGRt3y92SzjgIURNrllrvp/h/yUIeRSFJwm4qMPlh/p0Ff3Ku+uioI29o8AuL4M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Received: from SN6PR04MB5151.namprd04.prod.outlook.com (2603:10b6:805:90::25) by BY5PR04MB6392.namprd04.prod.outlook.com (2603:10b6:a03:1ed::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Mon, 24 Feb 2025 22:07:36 +0000 Received: from SN6PR04MB5151.namprd04.prod.outlook.com ([fe80::5ff0:555f:8712:42dd]) by SN6PR04MB5151.namprd04.prod.outlook.com ([fe80::5ff0:555f:8712:42dd%5]) with mapi id 15.20.8466.016; Mon, 24 Feb 2025 22:07:36 +0000 Message-ID: Date: Mon, 24 Feb 2025 17:07:34 -0500 User-Agent: Mozilla Thunderbird References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> <85plk4obhe.wl--xmue@d1.dion.ne.jp> <867c6clgxa.fsf@gnu.org> <86zfineceg.fsf@gnu.org> <857c5gf5qu.wl--xmue@d1.dion.ne.jp> <86ecznzfk2.fsf@gnu.org> Content-Language: en-US From: Ken Brown In-Reply-To: <86ecznzfk2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN9PR03CA0888.namprd03.prod.outlook.com (2603:10b6:408:13c::23) To SN6PR04MB5151.namprd04.prod.outlook.com (2603:10b6:805:90::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR04MB5151:EE_|BY5PR04MB6392:EE_ X-MS-Office365-Filtering-Correlation-Id: ee082597-5816-4a76-4f2b-08dd551fa540 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: rx/dIk8w8OxMnn/yDgN2tkY+gumlRc8pfKfq6YTDf4CocSSmr3Qa+bOffZZkgOnPSregc5StIwJ6u1tah+S/29jTHDjVuXawqLBrYmm4ciK6LAumO2VyCXaSrsqvK+Py2QQDyKJzrQoNTvj2ew36V0Qg3mS8heVfjtIuuGv7AyOaAYlrg+cvkwYbw8G1xSVCRq8uTvE1zfJpkmMdIZclwEk741uXDZloaBhOyjty1+2Po1TAIzCbiw0DVdYVueu4zBoKMQBBaFwSYiJcbkog8Q9nbE4dy8ACbBs7PPt8OfcU515QnkGSvyBnh+LKSGvIo4ETgbA4ayPJtK1iVBfa5ZUfWcxj9d7zwIvlHnk21bqQQuvONRwpoP+K7Sdso6fziNz8+xInskDAA9MIeR10HDocPqtUZ5hVoaoccMD4RGy7tP0uaBEOhJlxr5Ouqb4nmqwN2LeMieiLiRyuSP32b45fg7LvK2+/CONefrNj6s29trNtHbgyUD3X7gnaQUsxGUb25VUV+a/FyZvm4eSOaS8wMUeksuVr/LODL09IQ3NwpG65EhVlPU6Gwkd91c6c/x5QQ/mtQJTH41qysrXCg6TdphRW/adRmCNr8p42TLSzCE0Up0ZxPf8nJxQST1BTMqDgGUEMuX/j4XlF3mDSncg1fEoJdcgnqDPrsCDbktvn0M3VjfhQu79PTeegUOx1NNJxECx9nITHXGgqRY44F2/87c8K68kn1nccz873vDqA20HWUoF5mE2LU/IIliwKgYuYcxXziedIiAi5FMv+8hj9AybWrQSETH8whtLV7FB8ufcV6K9lRuoPS35hbTv2vhhNK8qPg9IjIUyG9MIPGFn/U+iaoGjdE57B16n/XujfuN5aRWjuRty4HbEy7kJXgCmYsXYzbfzOV5n6Z/sqvcVSCm2sgGCmV1eW7H3sqqAlSwYxKKJTZxCAlw6GUcjYtSB26nbPuAy7qfMedsoIu9FSK2m5QTv+pFEBhQvAs2r7FjxLA8vKSIL3AmahQKDKrnkHdp/sbLJnGovfvmBmNV/QA0Y1fXNxj/oMQY2FJWS+L0Ep4xLz8X15JtKcEz73p4qpYba4fngn+H1rrImibD4iqkDWspmDW6tfiWz71nKXba2szSijGy5tEEJG0LU9Lz9vkHv+RXbVUeWlVmeydhEnCwG4iMiem5Fdrkng4rjbwlzMGCKT/tHjJi6Xt3nc7Q5aZnMUTKYuY1MQ6PMf61bOmgLFDoJi+raoADAR/cpghBFWzYmwVbIFYM6HK8TbXKKrTmuKDnMFBmgUdHXUQOFrhNG4LoGhaENGAuHbSXFYRI/hhAFgijh9rHmhq1KIrhPrkfZBtirNJu7jCn0h21OGnBp/HsarSBNcgMCfnySrnF53SqquWQowMmCy2Szs X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR04MB5151.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: BN7LXGba7pHmObVWoiJVA2S17u3QzK3uAl2BpnHo5UuRlhEvThRgKWajpzET759vVrpTGrWeIsqGxVHvx7iha+uDBp/NV6jFi3ttitU02JbtqO8VRrgjgxpkp/SRkw8d8CN7dTpLaKVA3Mc9acj4LEdO3D2V74IzHDlrRxd5V6dus2zzy/+f0zvyp82JQhVANlha4ZfU+uQE1Kn+6rYLlbRgdq1zYITbZNhJxFrxLDRz+bGTAW9d+HrSyS3ce0K38SlZSIqdd5rYlJP/Dvmrgl35k4kUmrrzFJfshjK52ZNPuJLW9uBE0OGO+K40WMRrcG6sk7SlBXYBFRW52CU4qzOkINV30WJb9i9b9utanWUEIXstVswA5vndXi5falwhr7MiK4qIYzCDMlRZ+xlKjvIXhV6Y5lIPdSZ9dkm2xQikx+HDmWTrB81zlOIhTGGqPm5U73YXVKf3OOUsLhbSu7eyWfEfHNbc0bC34qJFE/lOkNH03pvSZe2bvnqG235aGTyq4uzXVMyPkkAlPN6Afvm1LXOyW9Q5tDTri05DPfER1qPbDbxRZqdi9p8MNfVmzzyimOpwkObUOHOZUdi8N8qUX7CArKMbDr05zLWfV8wDXjEe1dlBSID7l7gmyjmeJJ66D9wh0ExPl/3xTE2sFjth30ZGmHeJCGLKJI1VrOnq+cInaTorgHE8U8crUiDZjrgMT2ckte/x2xmuLxRctCNVj9qzkuk4JrBcbEE+ei9Lf6HPlSKk08fXIY4TXh3wWIyTInCi+q3t1tpFTOqoFxQvauKpfJbf4a05tI2BVZbDhT5Efev2XYZIazHW6kPyG5Ln7tXBezj9xd8YP0WMGDoUdV1DiAHmSi4QGJRibV2UWoWvfeUBT1x/CUZ9E5Ion2GgL+Ynhcuj5DF35vbZwF7gwdoT6tH67WsRWvenQH1tySKVsT5XwLmoYGBcBFTmDYfMUjZHljI33r3g2Zn6z7y05iM2C9VgnFWfgnaEdFrf/SXzieQlwkfboAx7ND3eg8WJo3AqsEdDWYJFmv97/+P4mvuzbIn48kCVT6x4TCku3c6zvS2MQnf91H9FFSSGOhgOiP+ImPTjQsrE/cD/8wBwioMxrwxhyDsJRBLt7s/4PrgkIzQhsNoSXXucbQx4ymsgVwtTibQynlc0c/e38vXRbu76mGl8xC91TLrib5mQHaLahsg5i8543qTZuk2Zgw2kOQJVgqT/TILGCgTaannFegqJsUNYZqMrDSfEI1eOT45T9h/ynNqCRqkIjNmtj5UyT9c7FwJm7nSgWRO/z18QfpQc2f36M6JfFqf5p0TA3kPqS633PykfSb0cnoYe6i4Zu0q6iagqV38xTS93kvDNHcVxx+xGwZDB3PCFIKg+zpNoRf6oB4D4ezCSIyyANX7Xo6Dxu6dApTNX8Z1eadBp1O6m+6G0fWia3diX6u6O6tzHahRZJgU/8/ei6K7PG6uNRewDYyMvz8nIF3aIMsv4OvTdMGGsfnXxV6nA4DmjsOghWm9fMMLZ2PEPFrkVzdQNEUP07m4nwCJ4xLMpcsP/zdA7uU6pkeVnJy0Dh/HmYsDTX/1lRhbQbeeEFDSW X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: ee082597-5816-4a76-4f2b-08dd551fa540 X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB5151.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2025 22:07:36.2424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v5rsRbYLm4FM9V8dnkeQJdfhQELHf5T9o1h/xz0jGnyR4c5kdgdQM5vyZnFHKKPT3Xjk4i+iwV7zh2uEZ+Siig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6392 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/24/2025 7:35 AM, Eli Zaretskii wrote: >> Date: Mon, 24 Feb 2025 11:15:05 +0900 >> From: Kazuhiro Ito >> Cc: Ken Brown , >> 75926@debbugs.gnu.org >> >>>>> We should probably split w32-win.el into two parts, one loaded by both >>>>> the native Windows and Cygw32 builds, the other only by the former. >>>>> But I don't know enough about the Cygw32 build and it needs, and don't >>>>> have Cygwin installed to build it in the first place, so I'm not the >>>>> best person for doing that job. Maybe Ken (CC'ed) has comments or >>>>> suggestions on this. >>>> >>>> That sounds like a reasonable approach, but I don't have time to dig >>>> into it right now. I don't actually know the innards of the Cygw32 >>>> build very well. I never use that build myself, and I only build it >>>> when someone asks me to test something. Kazuhiro, are you interested in >>>> giving Eli's suggestion a try? I have a feeling that you're more >>>> familiar with that part of the code than I am. >>> >>> Ping! Kazuhiro, do you intend on giving this a try?| >> >> Sorry for the late response. I didn't have enough time and actually I >> don't know Emacs internals well in any area. I simply build Emacs for >> testing elisp packages I maintain. But I tried on it. >> Please review. > > Thanks. Ken, any comments? LGTM, though I haven't checked every detail. It obviously needs lots of testing. I only have some small comments about the commit message: > Subject: [PATCH] Avoid defining unneeded variables on Cygw32. No period at the end of the summary line. > lisp/term/w32-win.el contained definitions of variables which were > not used on Cygw32. It is now to split into two files, common > part and Windows native build specific part. The latter is new > file, lisp/term/w32-win.el. w32-nt.el > * src/image.c (Qlibpng_version, Qlibgif_version) > (Qlibjpeg_version): Don't define on Cygw32 build. > > * src/treesit.c (Qtree_sitter__library_abi): Ditto. > > * lisp/term/w32-win.el (dynamic-library-alist, libpng-version) > (libgif-version, libjpeg-version, libgnutls-version) > (tree-sitter--library-abi, gui-backend-set-selection) > (gui-backend-get-selection, gui-backend-selection-owner-p) > (gui-selection-exists-p): Moved to lisp/term/w32-nt.el. > > * lisp/term/w32-nt.el: New file, separated Windows native build > specific part from lisp/term/w32-win.el. > > * lisp/loadup.el: Load term/w32-nt.el on Windows native build. The bug number should be mentioned somewhere. Kazuhiro, thanks very much for doing this! Ken From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 03 21:55:21 2025 Received: (at control) by debbugs.gnu.org; 4 Mar 2025 02:55:21 +0000 Received: from localhost ([127.0.0.1]:53781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tpIRF-0000rW-1E for submit@debbugs.gnu.org; Mon, 03 Mar 2025 21:55:21 -0500 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]:46500) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tpIRD-0000rD-1J for control@debbugs.gnu.org; Mon, 03 Mar 2025 21:55:19 -0500 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-abf45d8db04so455183266b.1 for ; Mon, 03 Mar 2025 18:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741056913; x=1741661713; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=3owjzL4f5+5O+GJ/k+p9e8HG8jJnCjVyTCeT1wGhtZ8=; b=Bqyi+oWrICU83fplMxGBMKxfcytPdqzPQCP++wDlNJxwfJAp21agrqnGVGq5WdXMrd VaVyT1+st3JondIK/KhCW2kiDIHcQmUo7WtDVnTZjbt3doJy1DjjQKvMc5poLmSqDrZN 3eQJoc2VfnxyRci8jzN+oSCJQTDHwP4cGnzR+Jhma72G8Zpqu7SFRg8Yy/VqCTeXaZ0J 9xs7k6YKgY2qHeCtrUYH2gHsoKXCP83f/+dGEM/c23EonpxPFvRjzNsM12DYl6mviKbT UomBDKMfhvZXeC65rgp6zgvP6M+Z27LpBttp4mFEHOMgYIBA4vq4YzlLS+N5mIyKgYV4 8bIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741056913; x=1741661713; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3owjzL4f5+5O+GJ/k+p9e8HG8jJnCjVyTCeT1wGhtZ8=; b=Q9AWOaOvWlymBRLP3BaYPYt6/Wct1i3+WFcXyo9P5+NGN+MhspSCq67fLyY6bXkj87 FgDWj9swGckm1uK3myTeZEperzeMyFtSlKDoFH43TbDLoL2y6D3L9De8btTbLzOsRpca 1ski1dC+9abGzB6G6oniIbomd/+nc9VStgM1pmOhWLUuE8zIlGZhK7lTn4Aov/5hwIkF zJXg/fVbfccmkjxU61wmtlUqSV60rUf7US3aZZmtnUo1NKI3OVruZzLFDQuZo+jNoRtU QPWSTOXOod3AISlVSJpnuRxcTO2w7GlTfm7vFzHXSOG4L72oCWTVrMWqeF9Z8tXPAYSM criQ== X-Gm-Message-State: AOJu0Yz/HMt4hLj8+YNlaNLQ34oGH4uPS8VGrXn4iE6Q1hqseuITzmYw 4Rtlu0SWVX053wl+MlNyxymRCnR0JorIAM3+s9CB7agn8gp2dd86Namh1hU4bJrSPOeo7aLHyqZ EzHk5HejnEpIMjamL2MOD3dWVGBzdPrM5zU+QRg== X-Gm-Gg: ASbGncvbSEuR3lacfoPOyg+PMxSjB/+Luq31tFKea7vxDwf/TTozPRsvUSaXJn6Ixwx YBNrHGgalUr4cThigRdmZWwnCZ629wjl9RuVlOsNbbAiWy99gAt2f1rpMFiod8oHqmLhei+SaTr YqEiVvgtDCE+PQhIJLdVBrT2iCHKk= X-Google-Smtp-Source: AGHT+IEoPoMiG9SxrqdZ+etj94R//3CeviUME6AaCtAM6Y/rDrvhKRC0IdFNms4oQ0Ifq4fg1z4Jon/x9yfLv1aGVCM= X-Received: by 2002:a17:906:40d1:b0:abf:44bd:8326 with SMTP id a640c23a62f3a-abf44bd85demr1177787666b.17.1741056912427; Mon, 03 Mar 2025 18:55:12 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Mar 2025 18:55:12 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 3 Mar 2025 18:55:12 -0800 X-Gm-Features: AQ5f1JpIAnTpF-Ny_QoMVvoBoof50FQPtaop33T-764d0IiykyUQ1E1vhcyX1kM Message-ID: Subject: control message for bug #75926 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 75926 + patch quit From unknown Fri Aug 15 20:55:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kazuhiro Ito Subject: bug#75926: closed (Re: bug#75926: 31.0.50; Cygw32 build break) Message-ID: References: <86jz92mewm.fsf@gnu.org> <85sep1odog.wl--xmue@d1.dion.ne.jp> X-Gnu-PR-Message: they-closed 75926 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 75926@debbugs.gnu.org Date: Thu, 06 Mar 2025 14:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1741270082-18686-1" This is a multi-part message in MIME format... ------------=_1741270082-18686-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #75926: 31.0.50; Cygw32 build break which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 75926@debbugs.gnu.org. --=20 75926: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75926 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1741270082-18686-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 75926-done) by debbugs.gnu.org; 6 Mar 2025 14:07:19 +0000 Received: from localhost ([127.0.0.1]:42023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tqBsd-0004q6-AX for submit@debbugs.gnu.org; Thu, 06 Mar 2025 09:07:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34306) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tqBsa-0004ps-Ht for 75926-done@debbugs.gnu.org; Thu, 06 Mar 2025 09:07:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tqBsT-0000ad-MF; Thu, 06 Mar 2025 09:07:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VnkAGcCTfd/uhvJ4r/0zJE3kTATl1CGaD51kVhDtVaU=; b=l2M13JnWbN04 dOm/wGODTBiJq3FpprFlBzxElOgzOeSQzO0v6kOpDyss0zJw8zB+8Y85uo01LkS9odMxTd/bURO3y aQStaY9ShNMFP8PLYcdM2lOiI7R3ZbuMc/H0LG0+TG2ClQCzOA5ZIE4b2K/gpgV/gdr9wNxuhTYGW coPn7YyHAPLtpyFWpwTJ82sDY9Eo5QZeaSqjOMrj5zEnn1Pp7uR9oPs2skrihpnVZW31451iaKo+z YsqyYiMN+/ka+ADQgZMNV0G+wFcvzF/RWMJ+SAieFgX5bUIoRqvIM8WCWFaRIgnfUUmcZ6yWPhVWG FUO+1LiiKMoCwLjD4TUyjQ==; Date: Thu, 06 Mar 2025 16:07:05 +0200 Message-Id: <86jz92mewm.fsf@gnu.org> From: Eli Zaretskii To: Ken Brown In-Reply-To: (message from Ken Brown on Mon, 24 Feb 2025 17:07:34 -0500) Subject: Re: bug#75926: 31.0.50; Cygw32 build break References: <85sep1odog.wl--xmue@d1.dion.ne.jp> <86cyg5mx05.fsf@gnu.org> <85plk4obhe.wl--xmue@d1.dion.ne.jp> <867c6clgxa.fsf@gnu.org> <86zfineceg.fsf@gnu.org> <857c5gf5qu.wl--xmue@d1.dion.ne.jp> <86ecznzfk2.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75926-done Cc: 75926-done@debbugs.gnu.org, kzhr@d1.dion.ne.jp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 24 Feb 2025 17:07:34 -0500 > Cc: 75926@debbugs.gnu.org > From: Ken Brown > > On 2/24/2025 7:35 AM, Eli Zaretskii wrote: > >> Date: Mon, 24 Feb 2025 11:15:05 +0900 > >> From: Kazuhiro Ito > >> Cc: Ken Brown , > >> 75926@debbugs.gnu.org > >> > >>>>> We should probably split w32-win.el into two parts, one loaded by both > >>>>> the native Windows and Cygw32 builds, the other only by the former. > >>>>> But I don't know enough about the Cygw32 build and it needs, and don't > >>>>> have Cygwin installed to build it in the first place, so I'm not the > >>>>> best person for doing that job. Maybe Ken (CC'ed) has comments or > >>>>> suggestions on this. > >>>> > >>>> That sounds like a reasonable approach, but I don't have time to dig > >>>> into it right now. I don't actually know the innards of the Cygw32 > >>>> build very well. I never use that build myself, and I only build it > >>>> when someone asks me to test something. Kazuhiro, are you interested in > >>>> giving Eli's suggestion a try? I have a feeling that you're more > >>>> familiar with that part of the code than I am. > >>> > >>> Ping! Kazuhiro, do you intend on giving this a try?| > >> > >> Sorry for the late response. I didn't have enough time and actually I > >> don't know Emacs internals well in any area. I simply build Emacs for > >> testing elisp packages I maintain. But I tried on it. > >> Please review. > > > > Thanks. Ken, any comments? > > LGTM, though I haven't checked every detail. It obviously needs lots of > testing. I only have some small comments about the commit message: > > > Subject: [PATCH] Avoid defining unneeded variables on Cygw32. > > No period at the end of the summary line. > > > lisp/term/w32-win.el contained definitions of variables which were > > not used on Cygw32. It is now to split into two files, common > > part and Windows native build specific part. The latter is new > > file, lisp/term/w32-win.el. > > w32-nt.el > > > * src/image.c (Qlibpng_version, Qlibgif_version) > > (Qlibjpeg_version): Don't define on Cygw32 build. > > > > * src/treesit.c (Qtree_sitter__library_abi): Ditto. > > > > * lisp/term/w32-win.el (dynamic-library-alist, libpng-version) > > (libgif-version, libjpeg-version, libgnutls-version) > > (tree-sitter--library-abi, gui-backend-set-selection) > > (gui-backend-get-selection, gui-backend-selection-owner-p) > > (gui-selection-exists-p): Moved to lisp/term/w32-nt.el. > > > > * lisp/term/w32-nt.el: New file, separated Windows native build > > specific part from lisp/term/w32-win.el. > > > > * lisp/loadup.el: Load term/w32-nt.el on Windows native build. > > The bug number should be mentioned somewhere. Thanks, I've fixed these minor nits, and boldly installed the changes on the master branch. > Kazuhiro, thanks very much for doing this! Seconded. Closing the bug. ------------=_1741270082-18686-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Jan 2025 15:14:32 +0000 Received: from localhost ([127.0.0.1]:42553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1td9lv-0008In-JG for submit@debbugs.gnu.org; Wed, 29 Jan 2025 10:14:31 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35434) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1td9ls-0008IO-DZ for submit@debbugs.gnu.org; Wed, 29 Jan 2025 10:14:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1td9lm-0001oj-2I for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2025 10:14:22 -0500 Received: from mta-snd-e01.auone-net.jp ([111.86.247.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1td9lg-0005FF-B8 for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2025 10:14:21 -0500 Received: from kzhr.d1.dion.ne.jp by mta-snd-e01.auone-net.jp with ESMTP id <20250129151408185.PWJL.22508.kzhr.d1.dion.ne.jp@mta-snd-e01.auone-net.jp>; Thu, 30 Jan 2025 00:14:08 +0900 Date: Thu, 30 Jan 2025 00:14:07 +0900 Message-ID: <85sep1odog.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Cygw32 build break X-Hashcash: 1:20:250129:bug-gnu-emacs@gnu.org::VGFYIjOqMA3FHcCv:0Q/Q User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d1.dion.ne.jp; s=default-1; t=1738163648; bh=xdc2C4aZ83TZ81x2cW/I6CNQBAzlMC4d9Xm0N8qUZRM=; h=Date:From:To:Subject; b=HPCukuZEFDwWZVpSLJ7Mp0AU5FrIMrQuUrS5ZGeb7Tkkag85F19m9gACKFIG3jGfsgtREvc2 4l8qnET+sbrL+U3ycZT7NoxCiRvG6L/NLsKX2HYL5RCLLDksQI+qBabaUeXsK3ErKmQ7eoOtC/ 2K2fCMw5N5puJzzNQ6wAFtf9fsAG2YFV0x50d6gheSnyKbg5JJesYnLqSZZXrycJAcF79dyaHS lThw1XggLr9ouJRRYEKKuvvita8BFUJXkzNQ0xK8i9xi/LK4w1NJzUx2JNFBF+vwYhgp73r9JD eJ2IahngJcBchWbnI4BzN14+XENfUBN1xb5CJ2UqynbX3TAw== Received-SPF: pass client-ip=111.86.247.1; envelope-from=kzhr@d1.dion.ne.jp; helo=mta-snd-e01.auone-net.jp X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Cygw32 build fails on master. $ make (snip) Loading term/w32-win... Error: void-variable (tree-sitter--library-abi) (snip) tree-sitter--library-abi is defined in src/treesit.c only when native Windows build. -- Kazuhiro Ito ------------=_1741270082-18686-1--