GNU bug report logs -
#75926
31.0.50; Cygw32 build break
Previous Next
Reported by: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Date: Wed, 29 Jan 2025 15:15:02 UTC
Severity: normal
Tags: patch
Found in version 31.0.50
Done: Eli Zaretskii <eliz <at> gnu.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 75926 in the body.
You can then email your comments to 75926 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Wed, 29 Jan 2025 15:15:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Wed, 29 Jan 2025 15:15:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Cygw32 build fails on master.
$ make
(snip)
Loading term/w32-win...
Error: void-variable (tree-sitter--library-abi)
(snip)
tree-sitter--library-abi is defined in src/treesit.c only when native
Windows build.
--
Kazuhiro Ito
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Wed, 29 Jan 2025 16:00:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 75926 <at> debbugs.gnu.org (full text, mbox):
> Date: Thu, 30 Jan 2025 00:14:07 +0900
> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
>
> Cygw32 build fails on master.
>
> $ make
> (snip)
> Loading term/w32-win...
>
> Error: void-variable (tree-sitter--library-abi)
> (snip)
>
> tree-sitter--library-abi is defined in src/treesit.c only when native
> Windows build.
Thanks, should be fixed now.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Thu, 30 Jan 2025 10:14:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 75926 <at> debbugs.gnu.org (full text, mbox):
> > Cygw32 build fails on master.
> >
> > $ make
> > (snip)
> > Loading term/w32-win...
> >
> > Error: void-variable (tree-sitter--library-abi)
> > (snip)
> >
> > tree-sitter--library-abi is defined in src/treesit.c only when native
> > Windows build.
>
> Thanks, should be fixed now.
Thank you for the quick fix, though I wonder cygw32 build needs
tree-sitter--library-abi. The variable is used to adjust
dynamic-library-alist's value, whcih doesn't seem to be used on cygw32
build.
--
Kazuhiro Ito
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Thu, 30 Jan 2025 10:45:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 75926 <at> debbugs.gnu.org (full text, mbox):
> Date: Thu, 30 Jan 2025 19:13:49 +0900
> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
> Cc: 75926 <at> debbugs.gnu.org
>
> > > Cygw32 build fails on master.
> > >
> > > $ make
> > > (snip)
> > > Loading term/w32-win...
> > >
> > > Error: void-variable (tree-sitter--library-abi)
> > > (snip)
> > >
> > > tree-sitter--library-abi is defined in src/treesit.c only when native
> > > Windows build.
> >
> > Thanks, should be fixed now.
>
> Thank you for the quick fix, though I wonder cygw32 build needs
> tree-sitter--library-abi. The variable is used to adjust
> dynamic-library-alist's value, whcih doesn't seem to be used on cygw32
> build.
I know, but the problem is the Cygw32 build loads w32-win.el, where
this data structure is defined. And all the other variables and
functions used in that structure's value are defined using HAVE_NTGUI
as the condition, so I just did the same for this case.
We should probably split w32-win.el into two parts, one loaded by both
the native Windows and Cygw32 builds, the other only by the former.
But I don't know enough about the Cygw32 build and it needs, and don't
have Cygwin installed to build it in the first place, so I'm not the
best person for doing that job. Maybe Ken (CC'ed) has comments or
suggestions on this.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Thu, 30 Jan 2025 19:39:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 75926 <at> debbugs.gnu.org (full text, mbox):
On 1/30/2025 5:44 AM, Eli Zaretskii wrote:
>> Date: Thu, 30 Jan 2025 19:13:49 +0900
>> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
>> Thank you for the quick fix, though I wonder cygw32 build needs
>> tree-sitter--library-abi. The variable is used to adjust
>> dynamic-library-alist's value, whcih doesn't seem to be used on cygw32
>> build.
>
> I know, but the problem is the Cygw32 build loads w32-win.el, where
> this data structure is defined. And all the other variables and
> functions used in that structure's value are defined using HAVE_NTGUI
> as the condition, so I just did the same for this case.
>
> We should probably split w32-win.el into two parts, one loaded by both
> the native Windows and Cygw32 builds, the other only by the former.
> But I don't know enough about the Cygw32 build and it needs, and don't
> have Cygwin installed to build it in the first place, so I'm not the
> best person for doing that job. Maybe Ken (CC'ed) has comments or
> suggestions on this.
That sounds like a reasonable approach, but I don't have time to dig
into it right now. I don't actually know the innards of the Cygw32
build very well. I never use that build myself, and I only build it
when someone asks me to test something. Kazuhiro, are you interested in
giving Eli's suggestion a try? I have a feeling that you're more
familiar with that part of the code than I am.
Ken
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Sat, 15 Feb 2025 10:22:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 75926 <at> debbugs.gnu.org (full text, mbox):
Ping! Kazuhiro, do you intend on giving this a try?|
> Date: Thu, 30 Jan 2025 14:37:45 -0500
> Cc: 75926 <at> debbugs.gnu.org
> From: Ken Brown <kbrown <at> cornell.edu>
>
> On 1/30/2025 5:44 AM, Eli Zaretskii wrote:
> >> Date: Thu, 30 Jan 2025 19:13:49 +0900
> >> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
> >> Thank you for the quick fix, though I wonder cygw32 build needs
> >> tree-sitter--library-abi. The variable is used to adjust
> >> dynamic-library-alist's value, whcih doesn't seem to be used on cygw32
> >> build.
> >
> > I know, but the problem is the Cygw32 build loads w32-win.el, where
> > this data structure is defined. And all the other variables and
> > functions used in that structure's value are defined using HAVE_NTGUI
> > as the condition, so I just did the same for this case.
> >
> > We should probably split w32-win.el into two parts, one loaded by both
> > the native Windows and Cygw32 builds, the other only by the former.
> > But I don't know enough about the Cygw32 build and it needs, and don't
> > have Cygwin installed to build it in the first place, so I'm not the
> > best person for doing that job. Maybe Ken (CC'ed) has comments or
> > suggestions on this.
>
> That sounds like a reasonable approach, but I don't have time to dig
> into it right now. I don't actually know the innards of the Cygw32
> build very well. I never use that build myself, and I only build it
> when someone asks me to test something. Kazuhiro, are you interested in
> giving Eli's suggestion a try? I have a feeling that you're more
> familiar with that part of the code than I am.
>
> Ken
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Mon, 24 Feb 2025 02:16:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 75926 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
> > > We should probably split w32-win.el into two parts, one loaded by both
> > > the native Windows and Cygw32 builds, the other only by the former.
> > > But I don't know enough about the Cygw32 build and it needs, and don't
> > > have Cygwin installed to build it in the first place, so I'm not the
> > > best person for doing that job. Maybe Ken (CC'ed) has comments or
> > > suggestions on this.
> >
> > That sounds like a reasonable approach, but I don't have time to dig
> > into it right now. I don't actually know the innards of the Cygw32
> > build very well. I never use that build myself, and I only build it
> > when someone asks me to test something. Kazuhiro, are you interested in
> > giving Eli's suggestion a try? I have a feeling that you're more
> > familiar with that part of the code than I am.
>
> Ping! Kazuhiro, do you intend on giving this a try?|
Sorry for the late response. I didn't have enough time and actually I
don't know Emacs internals well in any area. I simply build Emacs for
testing elisp packages I maintain. But I tried on it.
Please review.
--
Kazuhiro Ito
[0001-Avoid-defining-unneeded-variables-on-Cygw32.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Mon, 24 Feb 2025 12:36:01 GMT)
Full text and
rfc822 format available.
Message #26 received at 75926 <at> debbugs.gnu.org (full text, mbox):
> Date: Mon, 24 Feb 2025 11:15:05 +0900
> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
> Cc: Ken Brown <kbrown <at> cornell.edu>,
> 75926 <at> debbugs.gnu.org
>
> > > > We should probably split w32-win.el into two parts, one loaded by both
> > > > the native Windows and Cygw32 builds, the other only by the former.
> > > > But I don't know enough about the Cygw32 build and it needs, and don't
> > > > have Cygwin installed to build it in the first place, so I'm not the
> > > > best person for doing that job. Maybe Ken (CC'ed) has comments or
> > > > suggestions on this.
> > >
> > > That sounds like a reasonable approach, but I don't have time to dig
> > > into it right now. I don't actually know the innards of the Cygw32
> > > build very well. I never use that build myself, and I only build it
> > > when someone asks me to test something. Kazuhiro, are you interested in
> > > giving Eli's suggestion a try? I have a feeling that you're more
> > > familiar with that part of the code than I am.
> >
> > Ping! Kazuhiro, do you intend on giving this a try?|
>
> Sorry for the late response. I didn't have enough time and actually I
> don't know Emacs internals well in any area. I simply build Emacs for
> testing elisp packages I maintain. But I tried on it.
> Please review.
Thanks. Ken, any comments?
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#75926; Package
emacs.
(Mon, 24 Feb 2025 22:08:01 GMT)
Full text and
rfc822 format available.
Message #29 received at 75926 <at> debbugs.gnu.org (full text, mbox):
On 2/24/2025 7:35 AM, Eli Zaretskii wrote:
>> Date: Mon, 24 Feb 2025 11:15:05 +0900
>> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
>> Cc: Ken Brown <kbrown <at> cornell.edu>,
>> 75926 <at> debbugs.gnu.org
>>
>>>>> We should probably split w32-win.el into two parts, one loaded by both
>>>>> the native Windows and Cygw32 builds, the other only by the former.
>>>>> But I don't know enough about the Cygw32 build and it needs, and don't
>>>>> have Cygwin installed to build it in the first place, so I'm not the
>>>>> best person for doing that job. Maybe Ken (CC'ed) has comments or
>>>>> suggestions on this.
>>>>
>>>> That sounds like a reasonable approach, but I don't have time to dig
>>>> into it right now. I don't actually know the innards of the Cygw32
>>>> build very well. I never use that build myself, and I only build it
>>>> when someone asks me to test something. Kazuhiro, are you interested in
>>>> giving Eli's suggestion a try? I have a feeling that you're more
>>>> familiar with that part of the code than I am.
>>>
>>> Ping! Kazuhiro, do you intend on giving this a try?|
>>
>> Sorry for the late response. I didn't have enough time and actually I
>> don't know Emacs internals well in any area. I simply build Emacs for
>> testing elisp packages I maintain. But I tried on it.
>> Please review.
>
> Thanks. Ken, any comments?
LGTM, though I haven't checked every detail. It obviously needs lots of
testing. I only have some small comments about the commit message:
> Subject: [PATCH] Avoid defining unneeded variables on Cygw32.
No period at the end of the summary line.
> lisp/term/w32-win.el contained definitions of variables which were
> not used on Cygw32. It is now to split into two files, common
> part and Windows native build specific part. The latter is new
> file, lisp/term/w32-win.el.
w32-nt.el
> * src/image.c (Qlibpng_version, Qlibgif_version)
> (Qlibjpeg_version): Don't define on Cygw32 build.
>
> * src/treesit.c (Qtree_sitter__library_abi): Ditto.
>
> * lisp/term/w32-win.el (dynamic-library-alist, libpng-version)
> (libgif-version, libjpeg-version, libgnutls-version)
> (tree-sitter--library-abi, gui-backend-set-selection)
> (gui-backend-get-selection, gui-backend-selection-owner-p)
> (gui-selection-exists-p): Moved to lisp/term/w32-nt.el.
>
> * lisp/term/w32-nt.el: New file, separated Windows native build
> specific part from lisp/term/w32-win.el.
>
> * lisp/loadup.el: Load term/w32-nt.el on Windows native build.
The bug number should be mentioned somewhere.
Kazuhiro, thanks very much for doing this!
Ken
Added tag(s) patch.
Request was from
Stefan Kangas <stefankangas <at> gmail.com>
to
control <at> debbugs.gnu.org.
(Tue, 04 Mar 2025 02:56:02 GMT)
Full text and
rfc822 format available.
Reply sent
to
Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility.
(Thu, 06 Mar 2025 14:08:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>:
bug acknowledged by developer.
(Thu, 06 Mar 2025 14:08:02 GMT)
Full text and
rfc822 format available.
Message #36 received at 75926-done <at> debbugs.gnu.org (full text, mbox):
> Date: Mon, 24 Feb 2025 17:07:34 -0500
> Cc: 75926 <at> debbugs.gnu.org
> From: Ken Brown <kbrown <at> cornell.edu>
>
> On 2/24/2025 7:35 AM, Eli Zaretskii wrote:
> >> Date: Mon, 24 Feb 2025 11:15:05 +0900
> >> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
> >> Cc: Ken Brown <kbrown <at> cornell.edu>,
> >> 75926 <at> debbugs.gnu.org
> >>
> >>>>> We should probably split w32-win.el into two parts, one loaded by both
> >>>>> the native Windows and Cygw32 builds, the other only by the former.
> >>>>> But I don't know enough about the Cygw32 build and it needs, and don't
> >>>>> have Cygwin installed to build it in the first place, so I'm not the
> >>>>> best person for doing that job. Maybe Ken (CC'ed) has comments or
> >>>>> suggestions on this.
> >>>>
> >>>> That sounds like a reasonable approach, but I don't have time to dig
> >>>> into it right now. I don't actually know the innards of the Cygw32
> >>>> build very well. I never use that build myself, and I only build it
> >>>> when someone asks me to test something. Kazuhiro, are you interested in
> >>>> giving Eli's suggestion a try? I have a feeling that you're more
> >>>> familiar with that part of the code than I am.
> >>>
> >>> Ping! Kazuhiro, do you intend on giving this a try?|
> >>
> >> Sorry for the late response. I didn't have enough time and actually I
> >> don't know Emacs internals well in any area. I simply build Emacs for
> >> testing elisp packages I maintain. But I tried on it.
> >> Please review.
> >
> > Thanks. Ken, any comments?
>
> LGTM, though I haven't checked every detail. It obviously needs lots of
> testing. I only have some small comments about the commit message:
>
> > Subject: [PATCH] Avoid defining unneeded variables on Cygw32.
>
> No period at the end of the summary line.
>
> > lisp/term/w32-win.el contained definitions of variables which were
> > not used on Cygw32. It is now to split into two files, common
> > part and Windows native build specific part. The latter is new
> > file, lisp/term/w32-win.el.
>
> w32-nt.el
>
> > * src/image.c (Qlibpng_version, Qlibgif_version)
> > (Qlibjpeg_version): Don't define on Cygw32 build.
> >
> > * src/treesit.c (Qtree_sitter__library_abi): Ditto.
> >
> > * lisp/term/w32-win.el (dynamic-library-alist, libpng-version)
> > (libgif-version, libjpeg-version, libgnutls-version)
> > (tree-sitter--library-abi, gui-backend-set-selection)
> > (gui-backend-get-selection, gui-backend-selection-owner-p)
> > (gui-selection-exists-p): Moved to lisp/term/w32-nt.el.
> >
> > * lisp/term/w32-nt.el: New file, separated Windows native build
> > specific part from lisp/term/w32-win.el.
> >
> > * lisp/loadup.el: Load term/w32-nt.el on Windows native build.
>
> The bug number should be mentioned somewhere.
Thanks, I've fixed these minor nits, and boldly installed the changes
on the master branch.
> Kazuhiro, thanks very much for doing this!
Seconded.
Closing the bug.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Fri, 04 Apr 2025 11:24:07 GMT)
Full text and
rfc822 format available.
This bug report was last modified 130 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.