GNU bug report logs - #75918
[PATCH] Add new user option tab-bar-define-keys

Previous Next

Full log

View this message in rfc822 format

From: Ship Mints <shipmints <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 75918 <at> debbugs.gnu.org
Subject: bug#75918: [PATCH] Add new user option tab-bar-define-keys
Date: Wed, 29 Jan 2025 14:28:29 -0500

[Message part 1 (text/plain, inline)]

This one should adequately address that backward compatibility issue.
Thanks for pointing it out.

On Wed, Jan 29, 2025 at 1:58 PM Juri Linkov <juri <at> linkov.net> wrote:

> > +  (when (memq tab-bar-define-keys '(t tab))
> > +    (define-key tab-bar-mode-map [(control tab)] #'tab-next)
> > +    (define-key tab-bar-mode-map [(control shift tab)] #'tab-previous)
> > +    (define-key tab-bar-mode-map [(control shift iso-lefttab)]
> #'tab-previous))
>
> But we still need to check with global-key-binding here
> before binding TAB keys.  This will ensure backwards-compatibility.
>
> > -(defun tab-bar-mode--tab-key-bind (map key binding)
> > -  ;; Don't override user customized global key bindings
> > -  (define-key map key
> > -    `(menu-item "" ,binding
> > -      :filter ,(lambda (cmd) (unless (global-key-binding key) cmd)))))
>

[Message part 2 (text/html, inline)]

[0001-Add-new-user-option-tab-bar-define-keys.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.