GNU bug report logs - #75918
[PATCH] Add new user option tab-bar-define-keys

Previous Next

Full log

Message #29 received at 75918 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Ship Mints <shipmints <at> gmail.com>
Cc: 75918 <at> debbugs.gnu.org
Subject: Re: bug#75918: [PATCH] Add new user option tab-bar-define-keys
Date: Wed, 29 Jan 2025 20:58:09 +0200

> +  (when (memq tab-bar-define-keys '(t tab))
> +    (define-key tab-bar-mode-map [(control tab)] #'tab-next)
> +    (define-key tab-bar-mode-map [(control shift tab)] #'tab-previous)
> +    (define-key tab-bar-mode-map [(control shift iso-lefttab)] #'tab-previous))

But we still need to check with global-key-binding here
before binding TAB keys.  This will ensure backwards-compatibility.

> -(defun tab-bar-mode--tab-key-bind (map key binding)
> -  ;; Don't override user customized global key bindings
> -  (define-key map key
> -    `(menu-item "" ,binding
> -      :filter ,(lambda (cmd) (unless (global-key-binding key) cmd)))))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.