GNU bug report logs - #75910
31; Deprecate minibuffer-completing-file-name

Previous Next

Full log

Message #11 received at 75910 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: "75910 <at> debbugs.gnu.org" <75910 <at> debbugs.gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: [External] : bug#75910: 31; Deprecate
 minibuffer-completing-file-name
Date: Tue, 28 Jan 2025 18:19:41 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

>> I propose to deprecate `minibuffer-completing-file-name', since the
>> completion category as part of the completion metadata acts as
>> generalization for this variable. Similarly `minibuffer-completing-
>> symbols' has been deprecated and removed a while ago.
>> 
>> Instead of checking `minibuffer-completing-file-name' one can use
>> (minibuffer-category-p 'file) given the following predicate function:
>> 
>> (defun minibuffer-category-p (cat)
>>   (eq (completion-metadata-get
>>        (completion-metadata
>>         (buffer-substring-no-properties
>>          (minibuffer-prompt-end) (point))
>>         minibuffer-completion-table
>>         minibuffer-completion-predicate)
>>        'category)
>>       cat))
>
> That you don't use something isn't evidence
> that it isn't used.

The variable is not widely used. You can grep the Emacs code base. Also
the completion category metadata has been designed as a general
replacement. I think it should be removed like
`minibuffer-completing-symbol' which has already been removed.

Daniel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.