From unknown Sun Jun 22 00:09:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7591: 24.0.50; incorrect `make-obsolete' for `mouse-major-mode-menu' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Dec 2010 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7591 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7591@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.129182471418188 (code B ref -1); Wed, 08 Dec 2010 16:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Dec 2010 16:11:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQMcU-0004jJ-Kz for submit@debbugs.gnu.org; Wed, 08 Dec 2010 11:11:54 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQMcT-0004j5-Ip for submit@debbugs.gnu.org; Wed, 08 Dec 2010 11:11:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQMiE-0004dc-Rj for submit@debbugs.gnu.org; Wed, 08 Dec 2010 11:17:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:56926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQMiE-0004dX-Pg for submit@debbugs.gnu.org; Wed, 08 Dec 2010 11:17:50 -0500 Received: from [140.186.70.92] (port=40805 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQMiD-00008T-LI for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 11:17:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQMiC-0004d0-96 for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 11:17:49 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:27220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQMiB-0004cl-Sq for bug-gnu-emacs@gnu.org; Wed, 08 Dec 2010 11:17:48 -0500 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oB8GHj6R016711 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 8 Dec 2010 16:17:46 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oB8GHi70017426 for ; Wed, 8 Dec 2010 16:17:44 GMT Received: from abhmt014.oracle.com by acsmt355.oracle.com with ESMTP id 856592611291825059; Wed, 08 Dec 2010 08:17:39 -0800 Received: from dradamslap1 (/10.159.245.200) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 08 Dec 2010 08:17:39 -0800 From: "Drew Adams" Date: Wed, 8 Dec 2010 08:17:37 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuW823I6OLNQq61Q4mxGZsPn2Gq7w== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) In mouse.el: (make-obsolete 'mouse-major-mode-menu 'mouse-menu-major-mode-map "23.1") That is incorrect. `mouse-major-mode-menu' is a _command_ (and can thus be bound to a key). `mouse-menu-major-mode-map' is not a command. Try, for instance, each of these: (define-key global-map [remap mouse-save-then-kill] 'mouse-major-mode-menu) (define-key global-map [remap mouse-save-then-kill] ''mouse-menu-major-mode-map) Try `mouse-3' after each of those. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-12-06 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' From unknown Sun Jun 22 00:09:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7591: 24.0.50; incorrect `make-obsolete' for `mouse-major-mode-menu' Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Dec 2010 22:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7591 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 7591@debbugs.gnu.org Received: via spool by 7591-submit@debbugs.gnu.org id=B7591.12919347776917 (code B ref 7591); Thu, 09 Dec 2010 22:47:02 +0000 Received: (at 7591) by debbugs.gnu.org; 9 Dec 2010 22:46:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQpFh-0001nV-5R for submit@debbugs.gnu.org; Thu, 09 Dec 2010 17:46:17 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PQpFg-0001nF-1O for 7591@debbugs.gnu.org; Thu, 09 Dec 2010 17:46:16 -0500 Received: from alfajor.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oB9MqFQ3014176; Thu, 9 Dec 2010 17:52:16 -0500 Received: by alfajor.home (Postfix, from userid 20848) id 6D41F64096; Thu, 9 Dec 2010 17:52:15 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Thu, 09 Dec 2010 17:52:15 -0500 In-Reply-To: (Drew Adams's message of "Wed, 8 Dec 2010 08:17:37 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3704=0 X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > (make-obsolete 'mouse-major-mode-menu 'mouse-menu-major-mode-map "23.1") > That is incorrect. The argument to make-obsolete is not intended to say "foobar is a drop-in-replacement for barbaz", just that "barbaz has been found undesirable, its successor is foobar". Often one needs to adjust things if one wants to switch to the new non-obsolete alternative. Stefan From unknown Sun Jun 22 00:09:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7591: 24.0.50; incorrect `make-obsolete' for `mouse-major-mode-menu' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Dec 2010 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7591 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Stefan Monnier'" Cc: 7591@debbugs.gnu.org Received: via spool by 7591-submit@debbugs.gnu.org id=B7591.129199924310286 (code B ref 7591); Fri, 10 Dec 2010 16:41:01 +0000 Received: (at 7591) by debbugs.gnu.org; 10 Dec 2010 16:40:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR61S-0002fq-OU for submit@debbugs.gnu.org; Fri, 10 Dec 2010 11:40:43 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PR61Q-0002fd-6k for 7591@debbugs.gnu.org; Fri, 10 Dec 2010 11:40:40 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBAGkfCQ031741 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Dec 2010 16:46:42 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBAGkXKU008734; Fri, 10 Dec 2010 16:46:39 GMT Received: from abhmt018.oracle.com by acsmt354.oracle.com with ESMTP id 864308841291999570; Fri, 10 Dec 2010 08:46:10 -0800 Received: from dradamslap1 (/10.159.225.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 10 Dec 2010 08:46:10 -0800 From: "Drew Adams" References: Date: Fri, 10 Dec 2010 08:46:09 -0800 Message-ID: <612738B99E514F4084A6029D9CD79436@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 Thread-Index: AcuX89EHmFnbEYQuTSSqutnu1kS8bQAAO9lQ X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) > > (make-obsolete 'mouse-major-mode-menu > > 'mouse-menu-major-mode-map "23.1") > > > > That is incorrect. `mouse-major-mode-menu' is a > > _command_ (and can thus be bound to a key). > > `mouse-menu-major-mode-map' is not a command. > > The argument to make-obsolete is not intended to say "foobar is > a drop-in-replacement for barbaz", just that "barbaz has been found > undesirable, its successor is foobar". Often one needs to > adjust things if one wants to switch to the new non-obsolete > alternative. Even if that is the case it is not helpful here. The best command to use for this is the _only_ command that exists (so far): `mouse-major-mode-menu'. Consider this user's request: http://lists.gnu.org/archive/html/help-gnu-emacs/2010-12/msg02016.html My suggestion to him was this: >> If you don't care about modes that might bind `C-mouse-3' >> specially, then just remap its command: >> >> (define-key global-map [remap mouse-save-then-kill] >> 'mouse-major-mode-menu) Unless there is a _command_ that does what `mouse-major-mode-menu' does, you cannot do something like that. Or you need to roll your own command. Emacs should offer a command for this, as it has in the past. What is wrong with the existing `mouse-major-mode-menu' that it should be removed? If you have in mind a better definition, then please add it. But Emacs should have a command for this, whatever the name and whatever the exact definition. From unknown Sun Jun 22 00:09:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7591: 24.0.50; incorrect `make-obsolete' for `mouse-major-mode-menu' Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Dec 2010 20:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7591 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 7591@debbugs.gnu.org Received: via spool by 7591-submit@debbugs.gnu.org id=B7591.12920145474820 (code B ref 7591); Fri, 10 Dec 2010 20:56:02 +0000 Received: (at 7591) by debbugs.gnu.org; 10 Dec 2010 20:55:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PRA0J-0001Fg-Cp for submit@debbugs.gnu.org; Fri, 10 Dec 2010 15:55:47 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PRA0G-0001FR-FE for 7591@debbugs.gnu.org; Fri, 10 Dec 2010 15:55:45 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aj8LAFMkAk3O+KIs/2dsb2JhbACic4Eaeb9VhUoEhGSOBQ X-IronPort-AV: E=Sophos;i="4.59,326,1288584000"; d="scan'208";a="85137130" Received: from 206-248-162-44.dsl.teksavvy.com (HELO ceviche.home) ([206.248.162.44]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 10 Dec 2010 16:01:48 -0500 Received: by ceviche.home (Postfix, from userid 20848) id BBCA26616B; Fri, 10 Dec 2010 16:01:47 -0500 (EST) From: Stefan Monnier Message-ID: References: <612738B99E514F4084A6029D9CD79436@us.oracle.com> Date: Fri, 10 Dec 2010 16:01:47 -0500 In-Reply-To: <612738B99E514F4084A6029D9CD79436@us.oracle.com> (Drew Adams's message of "Fri, 10 Dec 2010 08:46:09 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >> The argument to make-obsolete is not intended to say "foobar is >> a drop-in-replacement for barbaz", just that "barbaz has been found >> undesirable, its successor is foobar". Often one needs to >> adjust things if one wants to switch to the new non-obsolete >> alternative. > Even if that is the case it is not helpful here. The best command to use for > this is the _only_ command that exists (so far): `mouse-major-mode-menu'. Right, so you "need to adjust things". This case really doesn't seem to be any different. > Unless there is a _command_ that does what `mouse-major-mode-menu' does, you > cannot do something like that. No part of Emacs needs such a command, and very few users (or external packages) would use it. So I'm far from convinced it is warranted. > Or you need to roll your own command. Exactly. Something along lines of (defun my-command () (x-popup-menu nil mouse-menu-major-mode-map)) should do the trick. > Emacs should offer a command for this, as it has in the past. What is wrong > with the existing `mouse-major-mode-menu' that it should be removed? mouse-menu-major-mode-map works as well or better (better because C-h k can be used to find the name of a function bound to a particular menu entry) for all uses we care about. So we don't need mouse-major-mode-menu any more. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 21:43:31 2011 Received: (at control) by debbugs.gnu.org; 25 Feb 2011 02:43:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsneV-0001rh-Cj for submit@debbugs.gnu.org; Thu, 24 Feb 2011 21:43:31 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsneS-0001rU-O0 for control@debbugs.gnu.org; Thu, 24 Feb 2011 21:43:28 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1PsneN-0000j0-Gw for control@debbugs.gnu.org; Thu, 24 Feb 2011 21:43:23 -0500 Date: Thu, 24 Feb 2011 21:43:23 -0500 Message-Id: Subject: control message for bug 7591 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) close 7591