From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 28 03:29:12 2025 Received: (at submit) by debbugs.gnu.org; 28 Jan 2025 08:29:12 +0000 Received: from localhost ([127.0.0.1]:35472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tcgy8-00035p-Jp for submit@debbugs.gnu.org; Tue, 28 Jan 2025 03:29:12 -0500 Received: from lists.gnu.org ([2001:470:142::17]:50696) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tcgy6-00035S-7t for submit@debbugs.gnu.org; Tue, 28 Jan 2025 03:29:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tcgxu-0000c3-E0 for bug-gnu-emacs@gnu.org; Tue, 28 Jan 2025 03:29:01 -0500 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tcgxo-0000at-SF for bug-gnu-emacs@gnu.org; Tue, 28 Jan 2025 03:28:58 -0500 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2ee8aa26415so9159065a91.1 for ; Tue, 28 Jan 2025 00:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738052931; x=1738657731; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=vrY1pkjnNQXmXEV7pOVKXkxAzmO2yEjH9BghCQjiFGA=; b=A+FuWj4yeu2XiQO8z0acWJc1UaOpfHvrElAMZHYRoEBNjMh71qaruvhTO1MoWBSSpe GFSJKyYvxYmVgKRo7wM2i2Nb66tY6TDQkoHvv0PrQ+tpH+0ln9UW0EKcneAMuXVAbkjm QEzzLKgjaZrZSTUWu4r6hHw3Umwqw+9wr9ALyC1NRDX9dnG+UE/H2EcjdReLJOKmyxLq HxwbDuW4Tlv/spC5kRHZbXPBsZQcnkxt3YVb4TnbEdbpZOJJ4KvqUUzAGt3Ka5shdSdS Gt8qbpfmM0jE2b1JnHGZ5JOXXya8s8TaXUcqQ0icT3eo2w3vtfBV2XQkBrOaa1JcaQJ0 ruAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738052931; x=1738657731; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vrY1pkjnNQXmXEV7pOVKXkxAzmO2yEjH9BghCQjiFGA=; b=CPF1neIZRpICQ45iavEvMhpYd0YptAexaQqU6B3zBf7o1+gRR+gebCI/xVOIyRdxuS y5IcVowm9hsGVKKOdU7t6/7Q3+osCeHjgmWqxzuV0mFu/XvaqW7zUsefWt/FIB5lsjr/ gJE+m0/32AgZ8+AutcgnoO3tHmIMuNK1csdZ9LoeHpsoqHcx3QVdV2NlBpDFjEqXAOZu DbbpQyCUgSMeioX3TnBZFRVQZJrdl6+KWUiEk/kBevVSMr5gnHqhLj4DLDsjWkGCtHgz hbnZdgN3j0ltMQPdn6gW/2X1mZpgL8+kAI+N/oV8+sKTeq/GyWZPcOIM937S97+f2m76 zrUA== X-Gm-Message-State: AOJu0YzwOG8jDCPC+sYEFCugyqyr50LU0J66E9cBzDDpYEiNwsDg5jjB rUM8Qd0L1fY2p1zDNEyN/BJuW4D359PiWXxBeB5AkqxxlVpVwxE3nidJEQ== X-Gm-Gg: ASbGncug5YVmiOdBIBoDHGElpq3B4fFbhSjrNC1c5GzJiRUAEz2Ezi4sv67vUO+Dgrd Qt2NRcBYFFocQf2zQmhaO0JO9mAXfbrRiQOzuGcgqEPy0N50r8BV3Oc9L3eNo3A9tKIjPIaAGmX DdomU9ga6TSlxz/Uj3jjz89dXyuFnGXdDYi+g0m657jxb+iHQ8EFTJEG0EJxb5ZcVoLdHWKo2Pt VpLrv51+lM2EVOZuAQKL3RZUamEioKKnGOG2MZFvubGnD3sA7/yGwbWzRqhnPhWUqhd9qToiXXm HASK3dV0yvaYYj5OGF6aqop/X21kEyxvUD3lNgjiHS2myK7pLg== X-Google-Smtp-Source: AGHT+IEeRau4Quyd2CAKPke64oosuR4Wqi6HlKJtIVEpuam3Uf2psaH7Fs4QN8PkiYYrlr7+9KZLKg== X-Received: by 2002:a17:90a:c106:b0:2ee:c9b6:c267 with SMTP id 98e67ed59e1d1-2f782c8fd22mr67859436a91.9.1738052929794; Tue, 28 Jan 2025 00:28:49 -0800 (PST) Received: from debian-qemu (syn-076-094-249-045.res.spectrum.com. [76.94.249.45]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7ffa5ab06sm8666073a91.18.2025.01.28.00.28.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 00:28:49 -0800 (PST) From: Xiyue Deng To: bug-gnu-emacs@gnu.org Subject: 30.0.93; track-changes-tests--random failure Date: Tue, 28 Jan 2025 00:28:46 -0800 Message-ID: <87v7tznxz5.fsf@debian-qemu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::102b; envelope-from=manphiz@gmail.com; helo=mail-pj1-x102b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" When trying to build Emacs candidate 30.0.93 under a Debian unstable sbuild environment (which comes with GCC-14), the track-changes-tests--random test fails with the following error: ,---- | ... | Random seed =3D "814217" | Running 1 tests (2025-01-28 08:03:59+0000, selector =E2=80=98(not (or (ta= g :expensive-test) (tag :unstable)))=E2=80=99) | seeding with: "814217" | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Test track-changes-tests--random backtrace: | cl--assertion-failed((not (memq id track-changes--clean-trackers))) | track-changes-fetch(#s(track-changes--tracker :signal #f(compiled-fu | #f(compiled-function (id buf n) #)(#s(tr | #f(compiled-function () #)() | #f(compiled-function () #)() | handler-bind-1(#f(compiled-function () #) id 1tclTb-0002K0-3m for submit@debbugs.gnu.org; Tue, 28 Jan 2025 08:17:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55854) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tclTZ-0002Jg-8J for 75906@debbugs.gnu.org; Tue, 28 Jan 2025 08:17:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tclTT-0001Ie-9n; Tue, 28 Jan 2025 08:17:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ch9l3YymT0enVOUK42y+abwMF9eZ6AVoo3rZKHsmcFM=; b=NEF1Zmu3g6wi1tnuF99U cfVKBT4F4B8u1iRuWkQ0/v2eNQKnV4DNsgGLOMIid3TtX6hAi9L9dkwFEYAqaavbdLaIdV1XDLwAZ sn/rr0w5AN55uxdjFIkednibF1N0Gkft0sKexXF3zaBdxO25Js8XMn54C8VzEHFvWOh52IidV+ut6 gBpRIpgbhNTzdYLa+cUgpY6cr5xdLO01qae9dKyrZV5wdGvZcgOx7ZWRpvsm4r2j9QHzeoj1aBJmJ ZPp1avXv01aXtbvEubHL4BpeYJpRUezNv3q1CtqdOp+Z3heA9kl0uhxOs9RvFa4oWdejNqlBmCcV5 QNDO33xRBYpeag==; Date: Tue, 28 Jan 2025 15:17:48 +0200 Message-Id: <86a5bbnklf.fsf@gnu.org> From: Eli Zaretskii To: Xiyue Deng , Stefan Monnier In-Reply-To: <87v7tznxz5.fsf@debian-qemu> (message from Xiyue Deng on Tue, 28 Jan 2025 00:28:46 -0800) Subject: Re: bug#75906: 30.0.93; track-changes-tests--random failure References: <87v7tznxz5.fsf@debian-qemu> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75906 Cc: 75906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Xiyue Deng > Date: Tue, 28 Jan 2025 00:28:46 -0800 > > > When trying to build Emacs candidate 30.0.93 under a Debian unstable > sbuild environment (which comes with GCC-14), the > track-changes-tests--random test fails with the following error: > > ,---- > | ... > | Random seed = "814217" > | Running 1 tests (2025-01-28 08:03:59+0000, selector ‘(not (or (tag :expensive-test) (tag :unstable)))’) > | seeding with: "814217" > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Warning (emacs): Missing/incorrect calls to ‘before/after-change-functions’!! > | Details logged to ‘track-changes--error-log’ > | Test track-changes-tests--random backtrace: > | cl--assertion-failed((not (memq id track-changes--clean-trackers))) > | track-changes-fetch(#s(track-changes--tracker :signal #f(compiled-fu > | #f(compiled-function (id buf n) #)(#s(tr > | #f(compiled-function () #)() > | #f(compiled-function () #)() > | handler-bind-1(#f(compiled-function () # | ert--run-test-internal(#s(ert--test-execution-info :test ... :result > | ert-run-test(#s(ert-test :name track-changes-tests--random :document > | ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m > | ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co > | ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) > | ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un > | eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( > | command-line-1(("-L" ":/build/reproducible-path/emacs-30.0.93+1/debi > | command-line() > | normal-top-level() > | Test track-changes-tests--random condition: > | (cl-assertion-failed (not (memq id track-changes--clean-trackers))) > | FAILED 1/1 track-changes-tests--random (0.078891 sec) at ../../build-src/test/lisp/emacs-lisp/track-changes-tests.el:44 > | > | Ran 1 tests, 0 results as expected, 1 unexpected (2025-01-28 08:03:59+0000, 0.120839 sec) > | > | 1 unexpected results: > | FAILED track-changes-tests--random > | > | make[5]: *** [Makefile:185: lisp/emacs-lisp/track-changes-tests.log] Error 1 > `---- > > I haven't tried the latest in the origin/emacs-30, though skimming over > the changelog it doesn't seem to be any commit related to this test. > > Please advice on how to fix this. TIA! Adding Stefan to the discussion. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 29 04:31:11 2025 Received: (at 75906) by debbugs.gnu.org; 29 Jan 2025 09:31:11 +0000 Received: from localhost ([127.0.0.1]:39958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1td4Pf-0002Gf-1Z for submit@debbugs.gnu.org; Wed, 29 Jan 2025 04:31:11 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1td4Pd-0002GN-3i for 75906@debbugs.gnu.org; Wed, 29 Jan 2025 04:31:09 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 986E380A75; Wed, 29 Jan 2025 04:31:02 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1738143061; bh=8J4oqxXz86I5dpJiQEgt5YscZr39EkgMKckixlBD91I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OpJ9zj81z1xp5LNNb9mP8aVpz51sXdnm7F8AI1Y/aKDIp0Xf8meChkpseezG72Jqf 1eaW6hNM1dp0MfiZJdFfakxstZ3UVlVY4kRB5uYnI2ZuOjDF245vLj4c44rlvnEOnl eQF2HMPMOCMK1nH1IbVyNxyY5UP2y+KNWrWnq0Ov575rhJ8BS7H6CYHkfMo5BqfSzE yb1C7+FZXgAd6jR+Fa+D/O10NOhJS0/Ih6TfaVbPRAqx2HElnqvivvE7gKZegg2Q09 F1bMu8OBlUb1mysiYfwpVKFrcogWc2HUOid67W83Da3seUi43aupT5mHIfpkVW8sO7 mP+3KRb345Kuw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1E147800CB; Wed, 29 Jan 2025 04:31:01 -0500 (EST) Received: from asado (unknown [185.252.130.169]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 913AE1208A6; Wed, 29 Jan 2025 04:30:59 -0500 (EST) From: Stefan Monnier To: Xiyue Deng Subject: Re: bug#75906: 30.0.93; track-changes-tests--random failure In-Reply-To: <87v7tznxz5.fsf@debian-qemu> (Xiyue Deng's message of "Tue, 28 Jan 2025 00:28:46 -0800") Message-ID: References: <87v7tznxz5.fsf@debian-qemu> Date: Wed, 29 Jan 2025 04:30:56 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75906 Cc: 75906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > | Random seed =3D "814217" > | Running 1 tests (2025-01-28 08:03:59+0000, selector =E2=80=98(not (or (= tag :expensive-test) (tag :unstable)))=E2=80=99) > | seeding with: "814217" > | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-chang= e-functions=E2=80=99!! > | Details logged to =E2=80=98track-changes--error-log=E2=80=99 Hmm... that's weird. I tried: src/emacs --batch -Q \ --eval '(setq track-changes-tests--random-seed 814217)' \ -l test/lisp/emacs-lisp/track-changes-tests.elc \ --eval '(ert-run-tests-batch-and-exit t)' but that sadly did not reproduce the problem for me. Does it reproduce the problem for you? If so, can you try src/emacs --batch -Q \ --eval '(setq track-changes-tests--random-verbose t)' \ --eval '(setq track-changes-tests--random-seed 814217)' \ -l test/lisp/emacs-lisp/track-changes-tests.elc \ --eval '(ert-run-tests-batch-and-exit t)' to hopefully get more details of what's going on? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 29 06:06:02 2025 Received: (at 75906) by debbugs.gnu.org; 29 Jan 2025 11:06:02 +0000 Received: from localhost ([127.0.0.1]:40109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1td5tR-0006pr-Nd for submit@debbugs.gnu.org; Wed, 29 Jan 2025 06:06:02 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:42390) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1td5tO-0006pT-0t for 75906@debbugs.gnu.org; Wed, 29 Jan 2025 06:05:59 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-2167141dfa1so10083835ad.1 for <75906@debbugs.gnu.org>; Wed, 29 Jan 2025 03:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738148752; x=1738753552; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xeZ2ArEVy0gd1QPAaiS1XuVhk+08VmUMhQqwD1ju1wo=; b=mEVWG9SGxeU2qUpcqdABIgUFZt5pt69aQTP6gkspuT1L3/nxfk4ZqvVfgpXlJdssKX 9+dfEwmE6HVLnpdfVrqaNmtKn91LEHlG/hmsE0YOisQOmwWniqUTOz5PRGF1dMr74KZE H66yHMdSDCyoQT/MRTo1hwUhfOirm0OjHAfYP0JGyOLjATyAyOqU67LpKLYachos7y4t 9lBPAnEDMNxh/PNzPQgTFmvgLEDGMgkBPErytSVItc8DklFTTDbbbDyp3mbufqsTnd3f E82dLegMIMwudvx6hxtIe7oBH3YzxFyrFdmP18Sxsivi2Q+OIYlht13pP0eup3xqrN07 ubqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738148752; x=1738753552; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xeZ2ArEVy0gd1QPAaiS1XuVhk+08VmUMhQqwD1ju1wo=; b=EZ/QCS2NUQv+YccL8GJV/jxGy7lg2ey+8qVFgEGx3vBbmJYSDl3+tj9sOrpx8XDq0P mxuaBI0uFgbVAUNHrqwxlgFSb1IxKsZGaf+wp0PH4Y/YAEHnAAP3DmFEtbTSVxlZDoeQ oUP0W5mKzrEwJLfyFdvK21xKpBAV/gwTsFWNXG9s+BYtjSgipoz8jzL7gVgS+5jj4X0u ck9s6cr9SasfLCd3EMq2BcCQn+86OhS8vYDsaNCbf2m1Sbc5SL6p9BU11zzBjRUpCuML CEB3lyFW/rthKwCf/9CNCkN70NwbXRbhVEKTH/f1sV0mRaAzeuA/RmqZBE89I2K69FjS QYkA== X-Gm-Message-State: AOJu0Ywg5yeu904hmokhHiL89j5+jP/h/wj0v7/rw4f6/UAgGyuRBBNe IPFIa1LVWiVddtncnjCIK6A4UAC3E2W83XT+2L4H+tPyKZkS0CeO62Belw== X-Gm-Gg: ASbGncvxI/ci76tXxOqKeTBmk8yXfI0FDaC+9ng3eJuXbBzw8Flo6m0kMlDjabUDvMP 8XrKrz29k7KYoqT8CxAOY59bnedJ4+UdgKPiSfjHVwewk/HvBW7cD9WQu7S4PZkP4uFj/kL1A+d d2dduv3AveJ8JU57TxFKP16GQtsRcp8ZSC0iqP8KDaPXvlAUKCnamHgdHRDN3B+60y2lZs8PSxt OSZd/5G+0rNZPudS2+8HTWPUJ5t5PyXtyIKnURv70Cz5YqZ5qeGqvOjWMdXlndMMSzF6WZsMj/X 5PAuzQVPt9/eU10ksbxQrsEDGcMN/RpWBjwHWBFH/2H8jzOFcg== X-Google-Smtp-Source: AGHT+IF4o8T+CePnqnadwab/TV6M5QaBnsJDJ2X4ULVCH8d+PQgc691n/UXLMnleFgFoKxR/UcfwuQ== X-Received: by 2002:a17:902:cccf:b0:215:ae61:27ca with SMTP id d9443c01a7336-21dd78296f1mr40677685ad.26.1738148751314; Wed, 29 Jan 2025 03:05:51 -0800 (PST) Received: from debian-qemu (syn-076-094-249-045.res.spectrum.com. [76.94.249.45]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da414ed3bsm97247725ad.193.2025.01.29.03.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2025 03:05:50 -0800 (PST) From: Xiyue Deng To: Stefan Monnier Subject: Re: bug#75906: 30.0.93; track-changes-tests--random failure In-Reply-To: (Stefan Monnier's message of "Wed, 29 Jan 2025 04:30:56 -0500") References: <87v7tznxz5.fsf@debian-qemu> Date: Wed, 29 Jan 2025 03:05:47 -0800 Message-ID: <87msf9op6c.fsf@debian-qemu> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 75906 Cc: 75906@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan, Stefan Monnier writes: >> | Random seed =3D "814217" >> | Running 1 tests (2025-01-28 08:03:59+0000, selector =E2=80=98(not (or = (tag :expensive-test) (tag :unstable)))=E2=80=99) >> | seeding with: "814217" >> | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-chan= ge-functions=E2=80=99!! >> | Details logged to =E2=80=98track-changes--error-log=E2=80=99 > > Hmm... that's weird. I tried: > > src/emacs --batch -Q \ > --eval '(setq track-changes-tests--random-seed 814217)' \ > -l test/lisp/emacs-lisp/track-changes-tests.elc \ > --eval '(ert-run-tests-batch-and-exit t)' > > but that sadly did not reproduce the problem for me. > Does it reproduce the problem for you? > If so, can you try > > src/emacs --batch -Q \ > --eval '(setq track-changes-tests--random-verbose t)' \ > --eval '(setq track-changes-tests--random-seed 814217)' \ > -l test/lisp/emacs-lisp/track-changes-tests.elc \ > --eval '(ert-run-tests-batch-and-exit t)' > > to hopefully get more details of what's going on? > > > Stefan > It looks like this test may be flaky. When building on a newer commit in origin/emacs-30 (a9cde24), it sometimes fails with a different seed, but not all the time. Please see below: ,---- | Random seed =3D "12012242" | Running 1 tests (2025-01-28 22:28:55+0000, selector =E2=80=98(not (or (ta= g :expensive-test) (tag :unstable)))=E2=80=99) | seeding with: "12012242" | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Warning (emacs): Missing/incorrect calls to =E2=80=98before/after-change-= functions=E2=80=99!! | Details logged to =E2=80=98track-changes--error-log=E2=80=99 | Test track-changes-tests--random backtrace: | cl--assertion-failed((not (memq id track-changes--clean-trackers))) | track-changes-fetch(#s(track-changes--tracker :signal #f(compiled-fu | #f(compiled-function (id buf n) #)(#s(t | #f(compiled-function () #)() | #f(compiled-function () #)() | handler-bind-1(#f(compiled-function () # | ert--run-test-internal(#s(ert--test-execution-info :test ... :result | ert-run-test(#s(ert-test :name track-changes-tests--random :document | ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m | ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co | ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable))) | ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un | eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( | command-line-1(("-L" ":/build/reproducible-path/emacs-30.0.93+git202 | command-line() | normal-top-level() | Test track-changes-tests--random condition: | (cl-assertion-failed (not (memq id track-changes--clean-trackers))) | FAILED 1/1 track-changes-tests--random (0.158094 sec) at ../../build= -src/test/lisp/emacs-lisp/track-changes-tests.el:44 |=20 | Ran 1 tests, 0 results as expected, 1 unexpected (2025-01-28 22:28:55+000= 0, 0.195262 sec) |=20 | 1 unexpected results: | FAILED track-changes-tests--random |=20 | make[5]: *** [Makefile:185: lisp/emacs-lisp/track-changes-tests.log] Erro= r 1 `---- --=20 Xiyue Deng From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 02 18:14:00 2025 Received: (at 75906) by debbugs.gnu.org; 2 Feb 2025 23:14:00 +0000 Received: from localhost ([127.0.0.1]:36664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tejA8-0004C7-Ak for submit@debbugs.gnu.org; Sun, 02 Feb 2025 18:14:00 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25055) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tejA5-0004Bi-5f; Sun, 02 Feb 2025 18:13:58 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 14654100182; Sun, 2 Feb 2025 18:13:50 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1738538029; bh=BnM9oD07K9WXcLGik+Ahj+FlIwqfcXeaqQqjmNzuZp4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Zd7oq9ww3VZ8mBje8MKzE2MCs03Lu6/gq/N3jz9SDR74jQ43UW/pV6kEOeQnAsVTx eoYZz9+vk+mejrBEhZHPM2YAVM1UYX/V18OSMUToyKGVlV/AVNZKHhT3jTUHiEoNyW qsMqMp+y6dU470EYKJdfKDMTngLfzU1nqOrccbAPjJiVjCaFiuQ9/3dxFATPLMq6mv I47iZdheIs9S3d57EceklDjTemOKQzRp6Jh0R3prkjMGZOIBuyM3Q58S/0fn+ab9lG AJR4/4ShWk46CM3ZxZr5Pdt/tcQDwX3yUyN4ztr2xppCPrVMCjO7YXv26N4Mpua0VR QANLXXX3i8iOA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 51452100128; Sun, 2 Feb 2025 18:13:49 -0500 (EST) Received: from alfajor (104-195-232-86.cpe.teksavvy.com [104.195.232.86]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 052EC120478; Sun, 2 Feb 2025 18:13:48 -0500 (EST) From: Stefan Monnier To: Xiyue Deng Subject: Re: bug#75906: 30.0.93; track-changes-tests--random failure In-Reply-To: <87msf9op6c.fsf@debian-qemu> (Xiyue Deng's message of "Wed, 29 Jan 2025 03:05:47 -0800") Message-ID: References: <87v7tznxz5.fsf@debian-qemu> <87msf9op6c.fsf@debian-qemu> Date: Sun, 02 Feb 2025 18:13:47 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75906 Cc: 75906@debbugs.gnu.org, Morgan Willcock X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) forcemerge 75906 73041 thanks Hi, It looks like those two bugs are one and the same. > > Hmm... that's weird. I tried: > > > > src/emacs --batch -Q \ > > --eval '(setq track-changes-tests--random-seed 814217)' \ > > -l test/lisp/emacs-lisp/track-changes-tests.elc \ > > --eval '(ert-run-tests-batch-and-exit t)' Duh! It was just a pilot error on my end: the seed needs to be a string. After fixing the above to use (setq track-changes-tests--random-seed "814217") I was able to reproduce the problem locally. > It looks like this test may be flaky. It's randomized (which is why it prints the seed it used, so you can try and reproduce it reliably once it hits a problem). > | Test track-changes-tests--random backtrace: > | cl--assertion-failed((not (memq id track-changes--clean-trackers))) > | track-changes-fetch(#s(track-changes--tracker :signal #f(compiled-fu After finding the origin of the problem, I think that the better fix is to adjust the assertion. The better short term fix for `emacs-30` is to simply comment out this assertion. Any objection to pushing the patch below to `emacs-30`? Stefan diff --git a/lisp/emacs-lisp/track-changes.el b/lisp/emacs-lisp/track-changes.el index 3f3b8d7bed9..1aac53b5f33 100644 --- a/lisp/emacs-lisp/track-changes.el +++ b/lisp/emacs-lisp/track-changes.el @@ -364,7 +364,9 @@ track-changes-fetch track-changes--state)) ;; Nothing to do. nil) - (cl-assert (not (memq id track-changes--clean-trackers))) + ;; ID may still be in `track-changes--clean-trackers' if + ;; `after-change-functions' was skipped. + ;;(cl-assert (not (memq id track-changes--clean-trackers))) (cl-assert (<= (point-min) beg end (point-max))) ;; Update the tracker's state *before* running `func' so we don't risk ;; mistakenly replaying the changes in case `func' exits non-locally. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 07:11:44 2025 Received: (at 75906) by debbugs.gnu.org; 3 Feb 2025 12:11:44 +0000 Received: from localhost ([127.0.0.1]:38147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tevIm-00030j-Dk for submit@debbugs.gnu.org; Mon, 03 Feb 2025 07:11:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53682) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tevIj-00030P-Up for 75906@debbugs.gnu.org; Mon, 03 Feb 2025 07:11:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tevIc-0002bk-UB; Mon, 03 Feb 2025 07:11:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oKb1EFFao0QdNM6gOxwTji7Y+vCfajO9439JK8XFghc=; b=og0wXV7ZQ2T7 QQzHqVi/lzbEE9FYckQN4efyxRcZhwbdeVvZ/UovfUNtNJZTJrgpJWL4lVcozHyzvpMMJgN1X/sEJ dkROwcgdOoq3l4mzBE1afZPVkURS5q7U2VWmRi7dnCgvjAw/kyLJE/ty6VAfXqkYHwVHYSQQz2f4T QLGMp/NHaxjTYeHrWmtjv62vJhq9WNLqrI3KQZN/oMs3Qs7zG4HO/p0umCpc69oPNCERhfnN4qDNI yb/NyBc2BxuD4R7KkwWyYalBuL0PfCfeurK5yhursxZ0ravbblmATfxlPT7MsWhfSxft4bopjW4c1 ozeewGatbuQ7yq5VfsXTyQ==; Date: Mon, 03 Feb 2025 14:11:22 +0200 Message-Id: <865xlrcjo5.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#75906: 30.0.93; track-changes-tests--random failure References: <87v7tznxz5.fsf@debian-qemu> <87msf9op6c.fsf@debian-qemu> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75906 Cc: 75906@debbugs.gnu.org, morgan@ice9.digital, manphiz@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 75906@debbugs.gnu.org, Morgan Willcock > Date: Sun, 02 Feb 2025 18:13:47 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > forcemerge 75906 73041 > thanks > > Hi, > > It looks like those two bugs are one and the same. > > > > Hmm... that's weird. I tried: > > > > > > src/emacs --batch -Q \ > > > --eval '(setq track-changes-tests--random-seed 814217)' \ > > > -l test/lisp/emacs-lisp/track-changes-tests.elc \ > > > --eval '(ert-run-tests-batch-and-exit t)' > > Duh! It was just a pilot error on my end: the seed needs to be > a string. After fixing the above to use > > (setq track-changes-tests--random-seed "814217") > > I was able to reproduce the problem locally. > > > It looks like this test may be flaky. > > It's randomized (which is why it prints the seed it used, so you can > try and reproduce it reliably once it hits a problem). > > > | Test track-changes-tests--random backtrace: > > | cl--assertion-failed((not (memq id track-changes--clean-trackers))) > > | track-changes-fetch(#s(track-changes--tracker :signal #f(compiled-fu > > After finding the origin of the problem, I think that the better fix is > to adjust the assertion. The better short term fix for `emacs-30` is to > simply comment out this assertion. > > Any objection to pushing the patch below to `emacs-30`? No objection, please go ahead, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 03 15:51:33 2025 Received: (at 75906-done) by debbugs.gnu.org; 3 Feb 2025 20:51:33 +0000 Received: from localhost ([127.0.0.1]:41498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tf3Pp-0007pk-Hq for submit@debbugs.gnu.org; Mon, 03 Feb 2025 15:51:33 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34027) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tf3Po-0007pV-0R for 75906-done@debbugs.gnu.org; Mon, 03 Feb 2025 15:51:32 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6A85480919; Mon, 3 Feb 2025 15:51:26 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1738615885; bh=9iWphijshjayIi4UyZlMbT9ZVCDBLhHCDPKCCTEo06A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=objuJWVkbSkWXahecxc2CaOVlQT3166pMFo8dw1usAy+iTie+jLBIgDOHHz7dD7UB C988zRWL0jtKUg2JOr7fmFHeNsRnQGZr7jo77bgkDMW74ZJkYJYwWQi2LzSml3aRNN WUVWkinDLEaODs6TOPgNc0pyLnPQnMNsT2/LF9MRNJvDMHzuwFW09mUO2SxR8+DdqW wA8O6foqXEsQsmPKses/vSSN4RlIJUOzrBC7NFPhyuyfy29XSDK5exDTybvjn3Cm0n i4K3Peu/9aBEXSQ8LZaS7uILCOzRlZjIMzbsGum3TUdQSL+tUuCGyBlSwK/QRDc5BZ FHPv+CfY45i/g== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 14FD680878; Mon, 3 Feb 2025 15:51:25 -0500 (EST) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 05CBF1209D0; Mon, 3 Feb 2025 15:51:25 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#75906: 30.0.93; track-changes-tests--random failure In-Reply-To: <865xlrcjo5.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Feb 2025 14:11:22 +0200") Message-ID: References: <87v7tznxz5.fsf@debian-qemu> <87msf9op6c.fsf@debian-qemu> <865xlrcjo5.fsf@gnu.org> Date: Mon, 03 Feb 2025 15:51:24 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.218 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 75906-done Cc: 75906-done@debbugs.gnu.org, manphiz@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > No objection, please go ahead, and thanks. Done, thanks, closing, Stefan From unknown Sat Aug 16 21:23:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 04 Mar 2025 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator